[INFO] fetching crate libquilt 0.1.1... [INFO] checking libquilt-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate libquilt 0.1.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate libquilt 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate libquilt 0.1.1 [INFO] finished tweaking crates.io crate libquilt 0.1.1 [INFO] tweaked toml for crates.io crate libquilt 0.1.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 88 packages to latest compatible versions [INFO] [stderr] Adding ansi_term v0.11.0 (latest: v0.12.1) [INFO] [stderr] Adding base64 v0.9.3 (latest: v0.22.1) [INFO] [stderr] Adding bit-set v0.5.3 (latest: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding block-buffer v0.3.3 (latest: v0.10.4) [INFO] [stderr] Adding byte-tools v0.2.0 (latest: v0.3.1) [INFO] [stderr] Adding cloudabi v0.0.3 (latest: v0.1.0) [INFO] [stderr] Adding digest v0.7.6 (latest: v0.10.7) [INFO] [stderr] Adding dtoa v0.4.8 (latest: v1.0.9) [INFO] [stderr] Adding generic-array v0.9.1 (latest: v1.1.0) [INFO] [stderr] Adding itertools v0.8.2 (latest: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding pretty_assertions v0.5.1 (latest: v1.4.0) [INFO] [stderr] Adding proptest v0.8.7 (latest: v1.5.0) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding rand v0.5.6 (latest: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding regex-syntax v0.6.29 (latest: v0.8.4) [INFO] [stderr] Adding rusty-fork v0.2.2 (latest: v0.3.0) [INFO] [stderr] Adding serde_yaml v0.7.5 (latest: v0.9.34+deprecated) [INFO] [stderr] Adding sha2 v0.7.1 (latest: v0.10.8) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e823550e2886ee23a90bda88b35f9dd0c2cfbfa5692f46ce03ef0d003461ba55 [INFO] running `Command { std: "docker" "start" "-a" "e823550e2886ee23a90bda88b35f9dd0c2cfbfa5692f46ce03ef0d003461ba55", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e823550e2886ee23a90bda88b35f9dd0c2cfbfa5692f46ce03ef0d003461ba55", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e823550e2886ee23a90bda88b35f9dd0c2cfbfa5692f46ce03ef0d003461ba55", kill_on_drop: false }` [INFO] [stdout] e823550e2886ee23a90bda88b35f9dd0c2cfbfa5692f46ce03ef0d003461ba55 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 234cd42f6d21fa161a14aa2039ac4c904bd8f35c929481a601bee8a475e977c6 [INFO] running `Command { std: "docker" "start" "-a" "234cd42f6d21fa161a14aa2039ac4c904bd8f35c929481a601bee8a475e977c6", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking byte-tools v0.2.0 [INFO] [stderr] Checking arrayref v0.3.8 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking fake-simd v0.1.2 [INFO] [stderr] Checking safemem v0.3.3 [INFO] [stderr] Checking dtoa v0.4.8 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking quilt_graph v0.1.1 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking generic-array v0.9.1 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking quilt_diff v0.1.1 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking difference v2.0.0 [INFO] [stderr] Checking block-buffer v0.3.3 [INFO] [stderr] Checking base64 v0.9.3 [INFO] [stderr] Checking pretty_assertions v0.5.1 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking digest v0.7.6 [INFO] [stderr] Checking sha2 v0.7.1 [INFO] [stderr] Checking serde_yaml v0.7.5 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking rand v0.5.6 [INFO] [stderr] Checking rusty-fork v0.2.2 [INFO] [stderr] Checking proptest v0.8.7 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking quilt_multimap v0.1.1 [INFO] [stderr] Checking quilt_partition v0.1.1 [INFO] [stderr] Checking libquilt v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: methods `is_live`, `pseudo_edges`, and `assert_consistent` are never used [INFO] [stdout] --> src/storage/graggle.rs:523:8 [INFO] [stdout] | [INFO] [stdout] 147 | impl GraggleData { [INFO] [stdout] | ---------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 523 | fn is_live(&self, node: &NodeId) -> bool { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 528 | fn pseudo_edges(&self, u: &NodeId) -> HashSet { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 555 | pub fn assert_consistent(&self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:230:20 [INFO] [stdout] | [INFO] [stdout] 230 | .ok_or(Error::NotOrdered) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/patch.rs:233:19 [INFO] [stdout] | [INFO] [stdout] 205 | let mut deps = HashSet::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | deps: deps.into_iter().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resolver.rs:126:19 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn into_order_resolver(self) -> OrderResolver<'a> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | seen: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resolver.rs:114:26 [INFO] [stdout] | [INFO] [stdout] 114 | .map(|u| (u, self.sccs.in_edges(&u).count())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libquilt` (lib) due to 5 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `has_pseudoedge` is never used [INFO] [stdout] --> src/storage/graggle/tests.rs:96:8 [INFO] [stdout] | [INFO] [stdout] 95 | trait GraggleExt { [INFO] [stdout] | ---------- method in this trait [INFO] [stdout] 96 | fn has_pseudoedge(&self, i: u64, j: u64) -> bool; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:230:20 [INFO] [stdout] | [INFO] [stdout] 230 | .ok_or(Error::NotOrdered) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/graggle/tests.rs:537:5 [INFO] [stdout] | [INFO] [stdout] 528 | let changes = num_to_add.prop_flat_map(move |n| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 537 | / changes [INFO] [stdout] 538 | | .prop_map(move |(del, n, nn, no, on)| make_changes(old_ids.clone(), del, n, nn, no, on)) [INFO] [stdout] | |________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/graggle/tests.rs:548:5 [INFO] [stdout] | [INFO] [stdout] 547 | let graggle = arb_live_graggle(initial_size); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 548 | / graggle [INFO] [stdout] 549 | | .prop_flat_map(move |d| { [INFO] [stdout] 550 | | let ch = arb_changes(&d, change_size); [INFO] [stdout] 551 | | (Just(d), ch) [INFO] [stdout] 552 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/graggle/tests.rs:640:5 [INFO] [stdout] | [INFO] [stdout] 638 | let graggle = arb_live_graggle(initial_size); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 639 | let num_changes = 1..(num_changes + 1); [INFO] [stdout] 640 | / (graggle, num_changes) [INFO] [stdout] 641 | | .prop_flat_map(move |(d, n)| recurse(d.clone(), change_size, n, d, vec![])) [INFO] [stdout] | |___________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/patch.rs:233:19 [INFO] [stdout] | [INFO] [stdout] 205 | let mut deps = HashSet::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | deps: deps.into_iter().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resolver.rs:126:19 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn into_order_resolver(self) -> OrderResolver<'a> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | seen: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resolver.rs:114:26 [INFO] [stdout] | [INFO] [stdout] 114 | .map(|u| (u, self.sccs.in_edges(&u).count())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libquilt` (lib test) due to 8 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "234cd42f6d21fa161a14aa2039ac4c904bd8f35c929481a601bee8a475e977c6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "234cd42f6d21fa161a14aa2039ac4c904bd8f35c929481a601bee8a475e977c6", kill_on_drop: false }` [INFO] [stdout] 234cd42f6d21fa161a14aa2039ac4c904bd8f35c929481a601bee8a475e977c6