[INFO] fetching crate libpacket-derive 0.1.1... [INFO] checking libpacket-derive-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate libpacket-derive 0.1.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate libpacket-derive 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate libpacket-derive 0.1.1 [INFO] finished tweaking crates.io crate libpacket-derive 0.1.1 [INFO] tweaked toml for crates.io crate libpacket-derive 0.1.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 38 packages to latest compatible versions [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0530208e857774d5f86b1c8fe4f31bfd198c87158ecd8afe9068f1881abd047b [INFO] running `Command { std: "docker" "start" "-a" "0530208e857774d5f86b1c8fe4f31bfd198c87158ecd8afe9068f1881abd047b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0530208e857774d5f86b1c8fe4f31bfd198c87158ecd8afe9068f1881abd047b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0530208e857774d5f86b1c8fe4f31bfd198c87158ecd8afe9068f1881abd047b", kill_on_drop: false }` [INFO] [stdout] 0530208e857774d5f86b1c8fe4f31bfd198c87158ecd8afe9068f1881abd047b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 90bffd9e4549c0b7dad091255aa19c94c25f8288e46d42cd5620916eea0f790f [INFO] running `Command { std: "docker" "start" "-a" "90bffd9e4549c0b7dad091255aa19c94c25f8288e46d42cd5620916eea0f790f", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling trybuild v1.0.99 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking libpacket-derive v0.1.1 (/opt/rustwide/workdir) [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gen.rs:60:8 [INFO] [stdout] | [INFO] [stdout] 53 | let (p, bounds, size) = packet_impl(packet, false)?; [INFO] [stdout] | - ------ ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let (p_mut, _, _) = packet_impl(packet, true)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | let tokens = quote! { [INFO] [stdout] | _________------___- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | | #p [INFO] [stdout] 57 | | [INFO] [stdout] 58 | | #p_mut [INFO] [stdout] 59 | | }; [INFO] [stdout] | |_____- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | Ok((tokens, bounds, size)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gen.rs:468:8 [INFO] [stdout] | [INFO] [stdout] 85 | let mut offset_fns_packet = Vec::new(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | let mut offset_fns_struct = Vec::new(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | let mut accessors = vec![]; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | let mut mutators = vec![]; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | let mut populate = vec![]; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | let mut payload_bounds = PayloadBounds { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | lower: quote!(0), [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | upper: quote!(0), [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | }; [INFO] [stdout] 94 | let name = if mutable { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 375 | let populate = if mutable { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 376 | let base_name = format_ident!("{}", &packet.base_name); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 377 | / quote! { [INFO] [stdout] 378 | | /// Populates a {name}Packet using a {name} structure [INFO] [stdout] 379 | | #[inline] [INFO] [stdout] 380 | | #[cfg_attr(feature = "clippy", allow(used_underscore_binding))] [INFO] [stdout] ... | [INFO] [stdout] 383 | | } [INFO] [stdout] 384 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 389 | | let base_name = format_ident!("{}", &packet.base_name); [INFO] [stdout] | | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 390 | | let struct_size = current_offset(bit_offset, &offset_fns_struct[..]); [INFO] [stdout] | | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 396 | | let imm_name = format_ident!("{}", packet.packet_name()); [INFO] [stdout] | | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 397 | | let mut_ = if mutable { quote!(mut) } else { quote!() }; [INFO] [stdout] | | ---- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 398 | | let packet_data = if mutable { [INFO] [stdout] | | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 403 | | let mutators = if mutable { mutators } else { vec![] }; [INFO] [stdout] | | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 404 | | [INFO] [stdout] 405 | let tokens = quote! { [INFO] [stdout] | _________------___- [INFO] [stdout] | |_________|________| [INFO] [stdout] | |_________|________| [INFO] [stdout] | |_________|________| [INFO] [stdout] | |_________|________| [INFO] [stdout] | |_________|________| [INFO] [stdout] | |_________|________| [INFO] [stdout] | |_________|________| [INFO] [stdout] | |_________|________| [INFO] [stdout] | |_________|________| [INFO] [stdout] | |_________|________| [INFO] [stdout] | |_________|________| [INFO] [stdout] | |_________|________| [INFO] [stdout] | |_________|________| [INFO] [stdout] | |_________|________| [INFO] [stdout] | |_________|________| [INFO] [stdout] | |_________|________| [INFO] [stdout] | |_________|________| [INFO] [stdout] | |_________|________| [INFO] [stdout] | |_________|________| [INFO] [stdout] | |_________|________| [INFO] [stdout] | |_________|________| [INFO] [stdout] | |_________|________| [INFO] [stdout] | |_________|________| [INFO] [stdout] | |_________|________| [INFO] [stdout] | |_________|________| [INFO] [stdout] | |_________|________| [INFO] [stdout] | |_________|________| [INFO] [stdout] | |_________|________| [INFO] [stdout] | |_________|________| [INFO] [stdout] | |_________|________| [INFO] [stdout] | |_________|________| [INFO] [stdout] | |_________|________| [INFO] [stdout] | |_________|________| [INFO] [stdout] | |_________|________| [INFO] [stdout] | |_________|________| [INFO] [stdout] | |_________|________| [INFO] [stdout] | |_________|________| [INFO] [stdout] | |_________|________| [INFO] [stdout] | |_________|________| [INFO] [stdout] | |_________|________| [INFO] [stdout] | |_________|________| [INFO] [stdout] | |_________|________| [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 406 | | impl<'a> #name<'a> { [INFO] [stdout] 407 | | /// Constructs a new #name. If the provided buffer is less than the minimum required [INFO] [stdout] 408 | | /// packet size, this will return None. [INFO] [stdout] ... | [INFO] [stdout] 465 | | } [INFO] [stdout] 466 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_____| [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 467 | [INFO] [stdout] 468 | Ok(( [INFO] [stdout] | ________^ [INFO] [stdout] 469 | tokens, [INFO] [stdout] 470 | payload_bounds, [INFO] [stdout] 471 | current_offset(bit_offset, &offset_fns_packet[..]), [INFO] [stdout] 472 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:217:8 [INFO] [stdout] | [INFO] [stdout] 51 | let mut fields = Vec::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | Ok(Packet { [INFO] [stdout] | ________^ [INFO] [stdout] 218 | | base_name: name, [INFO] [stdout] 219 | | fields, [INFO] [stdout] 220 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libpacket-derive` (lib) due to 4 previous errors [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "90bffd9e4549c0b7dad091255aa19c94c25f8288e46d42cd5620916eea0f790f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "90bffd9e4549c0b7dad091255aa19c94c25f8288e46d42cd5620916eea0f790f", kill_on_drop: false }` [INFO] [stdout] 90bffd9e4549c0b7dad091255aa19c94c25f8288e46d42cd5620916eea0f790f