[INFO] fetching crate libosdp 0.1.9... [INFO] checking libosdp-0.1.9 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate libosdp 0.1.9 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate libosdp 0.1.9 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate libosdp 0.1.9 [INFO] finished tweaking crates.io crate libosdp 0.1.9 [INFO] tweaked toml for crates.io crate libosdp 0.1.9 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate libosdp 0.1.9 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2b7e64a73639f621c4246f3f87f74cae9eeca23cb6f5d56067fbbd07bd855365 [INFO] running `Command { std: "docker" "start" "-a" "2b7e64a73639f621c4246f3f87f74cae9eeca23cb6f5d56067fbbd07bd855365", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2b7e64a73639f621c4246f3f87f74cae9eeca23cb6f5d56067fbbd07bd855365", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2b7e64a73639f621c4246f3f87f74cae9eeca23cb6f5d56067fbbd07bd855365", kill_on_drop: false }` [INFO] [stdout] 2b7e64a73639f621c4246f3f87f74cae9eeca23cb6f5d56067fbbd07bd855365 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 86ed4a2e6ae9478ff81b918fd6070872fb64bea9543be302f1a232253cc8361f [INFO] running `Command { std: "docker" "start" "-a" "86ed4a2e6ae9478ff81b918fd6070872fb64bea9543be302f1a232253cc8361f", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Compiling prettyplease v0.2.16 [INFO] [stderr] Compiling linux-raw-sys v0.4.13 [INFO] [stderr] Compiling bitflags v2.4.2 [INFO] [stderr] Compiling either v1.10.0 [INFO] [stderr] Compiling memchr v2.7.1 [INFO] [stderr] Compiling regex-syntax v0.8.2 [INFO] [stderr] Compiling minimal-lexical v0.2.1 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling libloading v0.8.3 [INFO] [stderr] Compiling home v0.5.9 [INFO] [stderr] Compiling bindgen v0.69.4 [INFO] [stderr] Compiling anyhow v1.0.81 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling itertools v0.12.1 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling log v0.4.21 [INFO] [stderr] Compiling lazycell v1.3.0 [INFO] [stderr] Compiling rustc-hash v1.1.0 [INFO] [stderr] Compiling build-target v0.4.0 [INFO] [stderr] Compiling clang-sys v1.7.0 [INFO] [stderr] Compiling cc v1.0.90 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking smallvec v0.6.14 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Compiling async-trait v0.1.77 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking thread-id v3.3.0 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking owning_ref v0.2.4 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking smallvec v0.3.4 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Checking crossbeam v0.2.12 [INFO] [stderr] Checking parking_lot v0.3.8 [INFO] [stderr] Checking futures v0.1.31 [INFO] [stderr] Checking ringbuf v0.3.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling which v4.4.2 [INFO] [stderr] Compiling cexpr v0.6.0 [INFO] [stderr] Checking multiqueue v0.3.2 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking env_logger v0.11.3 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Checking sha256 v1.5.0 [INFO] [stderr] Compiling libosdp-sys v3.0.3 [INFO] [stderr] Checking libosdp v0.1.9 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cp.rs:84:12 [INFO] [stdout] | [INFO] [stdout] 77 | pub fn new(mut pd_info: Vec) -> Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 85 | | ctx: cp_setup(info)?, [INFO] [stdout] 86 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pd.rs:82:12 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn new(info: PdInfo) -> Result { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | unsafe { libosdp_sys::osdp_set_log_callback(Some(log_handler)) }; [INFO] [stdout] 82 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 83 | | ctx: pd_setup(info)?, [INFO] [stdout] 84 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pdinfo.rs:112:32 [INFO] [stdout] | [INFO] [stdout] 112 | .unwrap_or_else(|| CString::new(format!("PD-{}", self.address)).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cp.rs:84:12 [INFO] [stdout] | [INFO] [stdout] 77 | pub fn new(mut pd_info: Vec) -> Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 85 | | ctx: cp_setup(info)?, [INFO] [stdout] 86 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pd.rs:82:12 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn new(info: PdInfo) -> Result { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | unsafe { libosdp_sys::osdp_set_log_callback(Some(log_handler)) }; [INFO] [stdout] 82 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 83 | | ctx: pd_setup(info)?, [INFO] [stdout] 84 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pdinfo.rs:112:32 [INFO] [stdout] | [INFO] [stdout] 112 | .unwrap_or_else(|| CString::new(format!("PD-{}", self.address)).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libosdp` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `libosdp` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "86ed4a2e6ae9478ff81b918fd6070872fb64bea9543be302f1a232253cc8361f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "86ed4a2e6ae9478ff81b918fd6070872fb64bea9543be302f1a232253cc8361f", kill_on_drop: false }` [INFO] [stdout] 86ed4a2e6ae9478ff81b918fd6070872fb64bea9543be302f1a232253cc8361f