[INFO] crate libmpv2 4.0.0 is already in cache [INFO] checking libmpv2-4.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate libmpv2 4.0.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate libmpv2 4.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate libmpv2 4.0.0 [INFO] finished tweaking crates.io crate libmpv2 4.0.0 [INFO] tweaked toml for crates.io crate libmpv2 4.0.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate libmpv2 4.0.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ad00790c04dca6eff86e2b155378be4ef5fb0e9fb709e3ecfbc5ae57c9c4e40d [INFO] running `Command { std: "docker" "start" "-a" "ad00790c04dca6eff86e2b155378be4ef5fb0e9fb709e3ecfbc5ae57c9c4e40d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ad00790c04dca6eff86e2b155378be4ef5fb0e9fb709e3ecfbc5ae57c9c4e40d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ad00790c04dca6eff86e2b155378be4ef5fb0e9fb709e3ecfbc5ae57c9c4e40d", kill_on_drop: false }` [INFO] [stdout] ad00790c04dca6eff86e2b155378be4ef5fb0e9fb709e3ecfbc5ae57c9c4e40d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a387560c2924031d34ed4edecb32a1383d8ab99dfffbeb69683a6dd2491dfd64 [INFO] running `Command { std: "docker" "start" "-a" "a387560c2924031d34ed4edecb32a1383d8ab99dfffbeb69683a6dd2491dfd64", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling version-compare v0.1.1 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling libmpv2-sys v4.0.0 [INFO] [stderr] Compiling sdl2 v0.36.0 [INFO] [stderr] Compiling libmpv2 v4.0.0 (/opt/rustwide/workdir) [INFO] [stderr] Compiling sdl2-sys v0.36.0 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling memoffset v0.5.6 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mpv.rs:46:12 [INFO] [stdout] | [INFO] [stdout] 43 | fn get_from_c_void Result>(mut fun: F) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | Ok(unsafe { val.assume_init() }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mpv.rs:383:12 [INFO] [stdout] | [INFO] [stdout] 378 | mut fun: F, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 383 | Ok(MpvStr(unsafe { mpv_cstr_to_str!(*ptr) }?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mpv.rs:506:12 [INFO] [stdout] | [INFO] [stdout] 483 | initializer: F, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 506 | Ok(Mpv { [INFO] [stdout] | ____________^ [INFO] [stdout] 507 | | ctx, [INFO] [stdout] 508 | | event_context: EventContext::new(ctx), [INFO] [stdout] 509 | | #[cfg(feature = "protocols")] [INFO] [stdout] 510 | | protocols_guard: AtomicBool::new(false), [INFO] [stdout] 511 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mpv/events.rs:240:24 [INFO] [stdout] | [INFO] [stdout] 238 | let result = unsafe { PropertyData::from_raw(property.format, property.data) }?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 239 | [INFO] [stdout] 240 | Ok(Event::GetPropertyReply { [INFO] [stdout] | ________________________^ [INFO] [stdout] 241 | | name, [INFO] [stdout] 242 | | result, [INFO] [stdout] 243 | | reply_userdata: event.reply_userdata, [INFO] [stdout] 244 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mpv/events.rs:298:28 [INFO] [stdout] | [INFO] [stdout] 295 | let change = [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 298 | Ok(Event::PropertyChange { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 299 | | name, [INFO] [stdout] 300 | | change, [INFO] [stdout] 301 | | reply_userdata: event.reply_userdata, [INFO] [stdout] 302 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mpv/protocol.rs:148:47 [INFO] [stdout] | [INFO] [stdout] 148 | panic::catch_unwind(|| ((*data).close_fn)(Box::from_raw((*data).cookie))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mpv/render.rs:144:49 [INFO] [stdout] | [INFO] [stdout] 141 | fn from(val: OpenGLInitParams) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | get_proc_address_ctx: Box::into_raw(Box::new(val)) as *mut c_void, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libmpv2` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "a387560c2924031d34ed4edecb32a1383d8ab99dfffbeb69683a6dd2491dfd64", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a387560c2924031d34ed4edecb32a1383d8ab99dfffbeb69683a6dd2491dfd64", kill_on_drop: false }` [INFO] [stdout] a387560c2924031d34ed4edecb32a1383d8ab99dfffbeb69683a6dd2491dfd64