[INFO] fetching crate libharu 0.1.5... [INFO] checking libharu-0.1.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate libharu 0.1.5 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate libharu 0.1.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate libharu 0.1.5 [INFO] finished tweaking crates.io crate libharu 0.1.5 [INFO] tweaked toml for crates.io crate libharu 0.1.5 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate libharu 0.1.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5980e0cd47a08594c869afa810c20f126e384e9b52b721550abb99ee9a1c1571 [INFO] running `Command { std: "docker" "start" "-a" "5980e0cd47a08594c869afa810c20f126e384e9b52b721550abb99ee9a1c1571", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5980e0cd47a08594c869afa810c20f126e384e9b52b721550abb99ee9a1c1571", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5980e0cd47a08594c869afa810c20f126e384e9b52b721550abb99ee9a1c1571", kill_on_drop: false }` [INFO] [stdout] 5980e0cd47a08594c869afa810c20f126e384e9b52b721550abb99ee9a1c1571 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b69aab8a7dad66f0e9e3583c9e9e658ce48fb3d45275b046ec51f2e566164dbd [INFO] running `Command { std: "docker" "start" "-a" "b69aab8a7dad66f0e9e3583c9e9e658ce48fb3d45275b046ec51f2e566164dbd", kill_on_drop: false }` [INFO] [stderr] Compiling pkg-config v0.3.20 [INFO] [stderr] Compiling libc v0.2.103 [INFO] [stderr] Compiling anyhow v1.0.44 [INFO] [stderr] Compiling encoding_rs v0.8.28 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Compiling libharu-sys v0.0.1 [INFO] [stderr] Checking libharu v0.1.5 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/document.rs:123:12 [INFO] [stdout] | [INFO] [stdout] 107 | pub fn new(onerror: impl Fn(Error) + 'static) -> anyhow::Result [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | { [INFO] [stdout] 109 | let onerror = Box::new(onerror); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | let mut inner = Box::new(DocumentInner{onerror, last_errno: 0, last_detailno: 0}); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | Ok(Self { doc, inner }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/page.rs:254:29 [INFO] [stdout] | [INFO] [stdout] 254 | let orig_text = text.clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/document.rs:123:12 [INFO] [stdout] | [INFO] [stdout] 107 | pub fn new(onerror: impl Fn(Error) + 'static) -> anyhow::Result [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | { [INFO] [stdout] 109 | let onerror = Box::new(onerror); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | let mut inner = Box::new(DocumentInner{onerror, last_errno: 0, last_detailno: 0}); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | Ok(Self { doc, inner }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/page.rs:254:29 [INFO] [stdout] | [INFO] [stdout] 254 | let orig_text = text.clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libharu` (lib) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libharu` (lib test) due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "b69aab8a7dad66f0e9e3583c9e9e658ce48fb3d45275b046ec51f2e566164dbd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b69aab8a7dad66f0e9e3583c9e9e658ce48fb3d45275b046ec51f2e566164dbd", kill_on_drop: false }` [INFO] [stdout] b69aab8a7dad66f0e9e3583c9e9e658ce48fb3d45275b046ec51f2e566164dbd