[INFO] fetching crate libgtp 0.1.2... [INFO] checking libgtp-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate libgtp 0.1.2 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate libgtp 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate libgtp 0.1.2 [INFO] finished tweaking crates.io crate libgtp 0.1.2 [INFO] tweaked toml for crates.io crate libgtp 0.1.2 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 30 packages to latest compatible versions [INFO] [stderr] Adding env_logger v0.7.1 (latest: v0.11.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding humantime v1.3.0 (latest: v2.1.0) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2bd4ee66fa53d72199c1cecef1e338f60356af10c9ab97a3144c9c273291c1f2 [INFO] running `Command { std: "docker" "start" "-a" "2bd4ee66fa53d72199c1cecef1e338f60356af10c9ab97a3144c9c273291c1f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2bd4ee66fa53d72199c1cecef1e338f60356af10c9ab97a3144c9c273291c1f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2bd4ee66fa53d72199c1cecef1e338f60356af10c9ab97a3144c9c273291c1f2", kill_on_drop: false }` [INFO] [stdout] 2bd4ee66fa53d72199c1cecef1e338f60356af10c9ab97a3144c9c273291c1f2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 65d384dfd3c6a54ca822bfb7bb85bcc4271ca2a86c249102c2c6c938f64f2285 [INFO] running `Command { std: "docker" "start" "-a" "65d384dfd3c6a54ca822bfb7bb85bcc4271ca2a86c249102c2c6c938f64f2285", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking scrub_log v0.2.1 [INFO] [stderr] Checking libgtp v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `serde` [INFO] [stdout] --> src/model/mod.rs:9:7 [INFO] [stdout] | [INFO] [stdout] 9 | #[cfg(feature = "serde")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `controller` and `default` [INFO] [stdout] = help: consider adding `serde` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `serde` [INFO] [stdout] --> src/model/mod.rs:19:12 [INFO] [stdout] | [INFO] [stdout] 19 | #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `controller` and `default` [INFO] [stdout] = help: consider adding `serde` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `serde` [INFO] [stdout] --> src/model/mod.rs:9:7 [INFO] [stdout] | [INFO] [stdout] 9 | #[cfg(feature = "serde")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `controller` and `default` [INFO] [stdout] = help: consider adding `serde` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `serde` [INFO] [stdout] --> src/model/command.rs:12:7 [INFO] [stdout] | [INFO] [stdout] 12 | #[cfg(feature = "serde")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `controller` and `default` [INFO] [stdout] = help: consider adding `serde` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `serde` [INFO] [stdout] --> src/model/mod.rs:19:12 [INFO] [stdout] | [INFO] [stdout] 19 | #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `controller` and `default` [INFO] [stdout] = help: consider adding `serde` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `serde` [INFO] [stdout] --> src/model/command.rs:12:7 [INFO] [stdout] | [INFO] [stdout] 12 | #[cfg(feature = "serde")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `controller` and `default` [INFO] [stdout] = help: consider adding `serde` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `serde` [INFO] [stdout] --> src/model/command.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 15 | #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `controller` and `default` [INFO] [stdout] = help: consider adding `serde` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `serde` [INFO] [stdout] --> src/model/command.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 15 | #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `controller` and `default` [INFO] [stdout] = help: consider adding `serde` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `serde` [INFO] [stdout] --> src/model/command.rs:209:12 [INFO] [stdout] | [INFO] [stdout] 209 | #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `controller` and `default` [INFO] [stdout] = help: consider adding `serde` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `serde` [INFO] [stdout] --> src/model/command.rs:209:12 [INFO] [stdout] | [INFO] [stdout] 209 | #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `controller` and `default` [INFO] [stdout] = help: consider adding `serde` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `serde` [INFO] [stdout] --> src/model/command.rs:236:12 [INFO] [stdout] | [INFO] [stdout] 236 | #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `controller` and `default` [INFO] [stdout] = help: consider adding `serde` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `serde` [INFO] [stdout] --> src/model/command.rs:236:12 [INFO] [stdout] | [INFO] [stdout] 236 | #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `controller` and `default` [INFO] [stdout] = help: consider adding `serde` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `serde` [INFO] [stdout] --> src/model/command.rs:444:12 [INFO] [stdout] | [INFO] [stdout] 444 | #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `controller` and `default` [INFO] [stdout] = help: consider adding `serde` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `serde` [INFO] [stdout] --> src/model/command.rs:444:12 [INFO] [stdout] | [INFO] [stdout] 444 | #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `controller` and `default` [INFO] [stdout] = help: consider adding `serde` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `serde` [INFO] [stdout] --> src/model/failure.rs:7:7 [INFO] [stdout] | [INFO] [stdout] 7 | #[cfg(feature = "serde")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `controller` and `default` [INFO] [stdout] = help: consider adding `serde` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `serde` [INFO] [stdout] --> src/model/failure.rs:7:7 [INFO] [stdout] | [INFO] [stdout] 7 | #[cfg(feature = "serde")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `controller` and `default` [INFO] [stdout] = help: consider adding `serde` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `serde` [INFO] [stdout] --> src/model/failure.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 11 | #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `controller` and `default` [INFO] [stdout] = help: consider adding `serde` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `serde` [INFO] [stdout] --> src/model/response.rs:10:7 [INFO] [stdout] | [INFO] [stdout] 10 | #[cfg(feature = "serde")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `controller` and `default` [INFO] [stdout] = help: consider adding `serde` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `serde` [INFO] [stdout] --> src/model/failure.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 11 | #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `controller` and `default` [INFO] [stdout] = help: consider adding `serde` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `serde` [INFO] [stdout] --> src/model/response.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 14 | #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `controller` and `default` [INFO] [stdout] = help: consider adding `serde` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `serde` [INFO] [stdout] --> src/model/response.rs:252:12 [INFO] [stdout] | [INFO] [stdout] 252 | #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `controller` and `default` [INFO] [stdout] = help: consider adding `serde` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `serde` [INFO] [stdout] --> src/model/response.rs:10:7 [INFO] [stdout] | [INFO] [stdout] 10 | #[cfg(feature = "serde")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `controller` and `default` [INFO] [stdout] = help: consider adding `serde` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `serde` [INFO] [stdout] --> src/model/response.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 14 | #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `controller` and `default` [INFO] [stdout] = help: consider adding `serde` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `serde` [INFO] [stdout] --> src/model/response.rs:252:12 [INFO] [stdout] | [INFO] [stdout] 252 | #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `controller` and `default` [INFO] [stdout] = help: consider adding `serde` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/types.rs:434:14 [INFO] [stdout] | [INFO] [stdout] 433 | fn from_iter>(it: I) -> Self { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 434 | Self(it.into_iter().collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/types.rs:541:12 [INFO] [stdout] | [INFO] [stdout] 533 | let elems : Vec = str.split_ascii_whitespace() [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 541 | Ok(Self(elems)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/model/types.rs:534:30 [INFO] [stdout] | [INFO] [stdout] 534 | .take_while(|e| e.clone() != "".to_string()) [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/types.rs:575:14 [INFO] [stdout] | [INFO] [stdout] 574 | fn from_iter>(it: I) -> Self { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 575 | Self(it.into_iter().collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 18 | let mut child = std::process::Command::new(name) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | let stdin = BufWriter::new(child.stdin.take().unwrap()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 27 | | child, [INFO] [stdout] 28 | | stdin, [INFO] [stdout] 29 | | incoming_lines: Arc::new(Mutex::new(VecDeque::new())), [INFO] [stdout] 30 | | analyze_line: Arc::new(Mutex::new("".to_string())), [INFO] [stdout] 31 | | is_ready: Arc::new(Mutex::new(false)), [INFO] [stdout] 32 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libgtp` (lib) due to 5 previous errors; 13 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/types.rs:434:14 [INFO] [stdout] | [INFO] [stdout] 433 | fn from_iter>(it: I) -> Self { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 434 | Self(it.into_iter().collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/types.rs:541:12 [INFO] [stdout] | [INFO] [stdout] 533 | let elems : Vec = str.split_ascii_whitespace() [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 541 | Ok(Self(elems)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/model/types.rs:534:30 [INFO] [stdout] | [INFO] [stdout] 534 | .take_while(|e| e.clone() != "".to_string()) [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/types.rs:575:14 [INFO] [stdout] | [INFO] [stdout] 574 | fn from_iter>(it: I) -> Self { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 575 | Self(it.into_iter().collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 18 | let mut child = std::process::Command::new(name) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | let stdin = BufWriter::new(child.stdin.take().unwrap()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 27 | | child, [INFO] [stdout] 28 | | stdin, [INFO] [stdout] 29 | | incoming_lines: Arc::new(Mutex::new(VecDeque::new())), [INFO] [stdout] 30 | | analyze_line: Arc::new(Mutex::new("".to_string())), [INFO] [stdout] 31 | | is_ready: Arc::new(Mutex::new(false)), [INFO] [stdout] 32 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libgtp` (lib test) due to 5 previous errors; 13 warnings emitted [INFO] running `Command { std: "docker" "inspect" "65d384dfd3c6a54ca822bfb7bb85bcc4271ca2a86c249102c2c6c938f64f2285", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "65d384dfd3c6a54ca822bfb7bb85bcc4271ca2a86c249102c2c6c938f64f2285", kill_on_drop: false }` [INFO] [stdout] 65d384dfd3c6a54ca822bfb7bb85bcc4271ca2a86c249102c2c6c938f64f2285