[INFO] fetching crate libgfold 0.1.3... [INFO] checking libgfold-0.1.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate libgfold 0.1.3 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate libgfold 0.1.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate libgfold 0.1.3 [INFO] finished tweaking crates.io crate libgfold 0.1.3 [INFO] tweaked toml for crates.io crate libgfold 0.1.3 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 68 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding git2 v0.18.3 (latest: v0.19.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding libgit2-sys v0.16.2+1.7.2 (latest: v0.17.0+1.8.1) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding yansi v0.5.1 (latest: v1.0.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `git2` dependency) [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `env_logger` dependency) [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b79aa0bca51e9ed93e2f38c0e9892e7caa017627f4b9f59bba5ae073bb132b65 [INFO] running `Command { std: "docker" "start" "-a" "b79aa0bca51e9ed93e2f38c0e9892e7caa017627f4b9f59bba5ae073bb132b65", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b79aa0bca51e9ed93e2f38c0e9892e7caa017627f4b9f59bba5ae073bb132b65", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b79aa0bca51e9ed93e2f38c0e9892e7caa017627f4b9f59bba5ae073bb132b65", kill_on_drop: false }` [INFO] [stdout] b79aa0bca51e9ed93e2f38c0e9892e7caa017627f4b9f59bba5ae073bb132b65 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9bf2af42d6096468a87c55dc9cd2dacc1b98c528760bcf10278aa41019643694 [INFO] running `Command { std: "docker" "start" "-a" "9bf2af42d6096468a87c55dc9cd2dacc1b98c528760bcf10278aa41019643694", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `git2` dependency) [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `env_logger` dependency) [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Compiling remain v0.2.14 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Compiling libz-sys v1.1.20 [INFO] [stderr] Compiling libgit2-sys v0.16.2+1.7.2 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Checking git2 v0.18.3 [INFO] [stderr] Checking libgfold v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/status.rs:91:12 [INFO] [stdout] | [INFO] [stdout] 52 | let head = match repo.head() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | Ok(head) => Some(head), [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | let (remote, remote_name) = match repo.find_remote("origin") { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | Ok(origin) => (Some(origin), Some("origin".to_string())), [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | let mut opts = StatusOptions::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | Ok(v) if v.is_empty() => match &head { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | Ok((status, head, remote)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/status.rs:128:12 [INFO] [stdout] | [INFO] [stdout] 127 | let remotes = repository.remotes()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | Ok(match remotes.get(0) { [INFO] [stdout] | ____________^ [INFO] [stdout] 129 | | Some(remote_name) => ( [INFO] [stdout] 130 | | Some(repository.find_remote(remote_name)?), [INFO] [stdout] 131 | | Some(remote_name.to_string()), [INFO] [stdout] 132 | | ), [INFO] [stdout] 133 | | None => (None, None), [INFO] [stdout] 134 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libgfold` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/status.rs:91:12 [INFO] [stdout] | [INFO] [stdout] 52 | let head = match repo.head() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | Ok(head) => Some(head), [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | let (remote, remote_name) = match repo.find_remote("origin") { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | Ok(origin) => (Some(origin), Some("origin".to_string())), [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | let mut opts = StatusOptions::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | Ok(v) if v.is_empty() => match &head { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | Ok((status, head, remote)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/status.rs:128:12 [INFO] [stdout] | [INFO] [stdout] 127 | let remotes = repository.remotes()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | Ok(match remotes.get(0) { [INFO] [stdout] | ____________^ [INFO] [stdout] 129 | | Some(remote_name) => ( [INFO] [stdout] 130 | | Some(repository.find_remote(remote_name)?), [INFO] [stdout] 131 | | Some(remote_name.to_string()), [INFO] [stdout] 132 | | ), [INFO] [stdout] 133 | | None => (None, None), [INFO] [stdout] 134 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libgfold` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "9bf2af42d6096468a87c55dc9cd2dacc1b98c528760bcf10278aa41019643694", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9bf2af42d6096468a87c55dc9cd2dacc1b98c528760bcf10278aa41019643694", kill_on_drop: false }` [INFO] [stdout] 9bf2af42d6096468a87c55dc9cd2dacc1b98c528760bcf10278aa41019643694