[INFO] fetching crate libeko 0.1.5... [INFO] checking libeko-0.1.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate libeko 0.1.5 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate libeko 0.1.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate libeko 0.1.5 [INFO] finished tweaking crates.io crate libeko 0.1.5 [INFO] tweaked toml for crates.io crate libeko 0.1.5 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 50 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding uuid v0.8.2 (latest: v1.10.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 52ccfe6d07aaa17d7b2ffd2bf9bd61c9b9073c44c894ac7305fa77b3a0b81c3a [INFO] running `Command { std: "docker" "start" "-a" "52ccfe6d07aaa17d7b2ffd2bf9bd61c9b9073c44c894ac7305fa77b3a0b81c3a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "52ccfe6d07aaa17d7b2ffd2bf9bd61c9b9073c44c894ac7305fa77b3a0b81c3a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "52ccfe6d07aaa17d7b2ffd2bf9bd61c9b9073c44c894ac7305fa77b3a0b81c3a", kill_on_drop: false }` [INFO] [stdout] 52ccfe6d07aaa17d7b2ffd2bf9bd61c9b9073c44c894ac7305fa77b3a0b81c3a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5cd897aefff809dc7b5a04b138680df2a95cecc0be3fcd27fae2d770c4e47aa9 [INFO] running `Command { std: "docker" "start" "-a" "5cd897aefff809dc7b5a04b138680df2a95cecc0be3fcd27fae2d770c4e47aa9", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Compiling curl v0.4.46 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Compiling libz-sys v1.1.20 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling curl-sys v0.4.74+curl-8.9.0 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Compiling error-chain v0.12.4 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking openssl-sys v0.9.103 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Compiling getset v0.1.2 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking libeko v0.1.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:48:32 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn send_event(sender: &mut EchoEventClient, messages: &[Message]) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 48 | pub fn send_event(sender: &mut dyn EchoEventClient, messages: &[Message]) -> Result<()> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:53:28 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn search(sender: &mut EchoSearchClient, search: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 53 | pub fn search(sender: &mut dyn EchoSearchClient, search: &str) -> Result { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:58:28 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn scroll(sender: &mut EchoSearchClient, scroll: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 58 | pub fn scroll(sender: &mut dyn EchoSearchClient, scroll: &str) -> Result { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:48:32 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn send_event(sender: &mut EchoEventClient, messages: &[Message]) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 48 | pub fn send_event(sender: &mut dyn EchoEventClient, messages: &[Message]) -> Result<()> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:53:28 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn search(sender: &mut EchoSearchClient, search: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 53 | pub fn search(sender: &mut dyn EchoSearchClient, search: &str) -> Result { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:58:28 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn scroll(sender: &mut EchoSearchClient, scroll: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 58 | pub fn scroll(sender: &mut dyn EchoSearchClient, scroll: &str) -> Result { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `url` is never read [INFO] [stdout] --> src/sender/curl.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct Client { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 15 | url: String, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Client` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/echo/event.rs:153:36 [INFO] [stdout] | [INFO] [stdout] 153 | .map(|(k, v)| ((*k).clone().into(), (*v).clone().into())) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/echo/event.rs:153:57 [INFO] [stdout] | [INFO] [stdout] 153 | .map(|(k, v)| ((*k).clone().into(), (*v).clone().into())) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sender/curl.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 21 | let mut list = List::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | let mut easy = Easy::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 35 | | easy, [INFO] [stdout] 36 | | url: Default::default(), [INFO] [stdout] 37 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sender/curl.rs:72:46 [INFO] [stdout] | [INFO] [stdout] 72 | transfer.read_function(|into| Ok(messages_vec.read(into).unwrap_or(0)))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sender/curl.rs:93:46 [INFO] [stdout] | [INFO] [stdout] 93 | transfer.read_function(|into| Ok(search_bytes.read(into).unwrap_or(0)))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sender/curl.rs:112:46 [INFO] [stdout] | [INFO] [stdout] 112 | transfer.read_function(|into| Ok(scroll_bytes.read(into).unwrap_or(0)))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `url` is never read [INFO] [stdout] --> src/sender/curl.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct Client { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 15 | url: String, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Client` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/echo/event.rs:153:36 [INFO] [stdout] | [INFO] [stdout] 153 | .map(|(k, v)| ((*k).clone().into(), (*v).clone().into())) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/echo/event.rs:153:57 [INFO] [stdout] | [INFO] [stdout] 153 | .map(|(k, v)| ((*k).clone().into(), (*v).clone().into())) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sender/curl.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 21 | let mut list = List::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | let mut easy = Easy::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 35 | | easy, [INFO] [stdout] 36 | | url: Default::default(), [INFO] [stdout] 37 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sender/curl.rs:72:46 [INFO] [stdout] | [INFO] [stdout] 72 | transfer.read_function(|into| Ok(messages_vec.read(into).unwrap_or(0)))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sender/curl.rs:93:46 [INFO] [stdout] | [INFO] [stdout] 93 | transfer.read_function(|into| Ok(search_bytes.read(into).unwrap_or(0)))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sender/curl.rs:112:46 [INFO] [stdout] | [INFO] [stdout] 112 | transfer.read_function(|into| Ok(scroll_bytes.read(into).unwrap_or(0)))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libeko` (lib test) due to 7 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `libeko` (lib) due to 7 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "5cd897aefff809dc7b5a04b138680df2a95cecc0be3fcd27fae2d770c4e47aa9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5cd897aefff809dc7b5a04b138680df2a95cecc0be3fcd27fae2d770c4e47aa9", kill_on_drop: false }` [INFO] [stdout] 5cd897aefff809dc7b5a04b138680df2a95cecc0be3fcd27fae2d770c4e47aa9