[INFO] fetching crate libdrm_amdgpu_sys 0.7.5... [INFO] checking libdrm_amdgpu_sys-0.7.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate libdrm_amdgpu_sys 0.7.5 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate libdrm_amdgpu_sys 0.7.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate libdrm_amdgpu_sys 0.7.5 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate libdrm_amdgpu_sys 0.7.5 [INFO] tweaked toml for crates.io crate libdrm_amdgpu_sys 0.7.5 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate libdrm_amdgpu_sys 0.7.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d0fa26d0c7cbfaefd610491a53eb9e22f1bb2845a3ffe50eac4901fa9e49eb6b [INFO] running `Command { std: "docker" "start" "-a" "d0fa26d0c7cbfaefd610491a53eb9e22f1bb2845a3ffe50eac4901fa9e49eb6b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d0fa26d0c7cbfaefd610491a53eb9e22f1bb2845a3ffe50eac4901fa9e49eb6b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d0fa26d0c7cbfaefd610491a53eb9e22f1bb2845a3ffe50eac4901fa9e49eb6b", kill_on_drop: false }` [INFO] [stdout] d0fa26d0c7cbfaefd610491a53eb9e22f1bb2845a3ffe50eac4901fa9e49eb6b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d43d1a10dc659c696292205a3dab823c30fa2fcedc91016bd036130e8277b0d6 [INFO] running `Command { std: "docker" "start" "-a" "d43d1a10dc659c696292205a3dab823c30fa2fcedc91016bd036130e8277b0d6", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling libdrm_amdgpu_sys v0.7.5 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> amdgpu/mod.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 81 | pub(crate) fn parse_hwmon>(path: P) -> Option { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | std::fs::read_to_string(path.into()).ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> amdgpu/mod.rs:83:26 [INFO] [stdout] | [INFO] [stdout] 83 | .and_then(|file| file.trim_end().parse::().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> amdgpu/mod.rs:159:5 [INFO] [stdout] | [INFO] [stdout] 157 | let Ok(amdgpu_devices) = std::fs::read_dir("/sys/bus/pci/drivers/amdgpu") else { return Vec::new() }; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | [INFO] [stdout] 159 | / amdgpu_devices.flat_map(|v| { [INFO] [stdout] 160 | | let name = v.ok()?.file_name(); [INFO] [stdout] 161 | | [INFO] [stdout] 162 | | /* 0000:00:00.0 */ [INFO] [stdout] ... | [INFO] [stdout] 165 | | name.into_string().ok()?.parse::().ok() [INFO] [stdout] 166 | | }).collect() [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> amdgpu/throttle_status.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 38 | let mut set: HashSet = HashSet::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | set.into_iter().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> amdgpu/ip_discovery.rs:139:13 [INFO] [stdout] | [INFO] [stdout] 138 | let mut ip_hw: Vec = die.filter_map(|ip_hw| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | ip_hw.ok()?.file_name().to_str()?.parse().ok() [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pci/bus_info.rs:62:13 [INFO] [stdout] | [INFO] [stdout] 61 | pci_by_path.or_else(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | std::fs::read_dir(self.get_sysfs_path().join("drm"))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pci/bus_info.rs:93:38 [INFO] [stdout] | [INFO] [stdout] 93 | .filter_map(|entry| Some(entry.ok()?.path())) [INFO] [stdout] | ----- ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> drm_mode/object_property.rs:60:18 [INFO] [stdout] | [INFO] [stdout] 58 | let prop = drmModeProperty::get(fd, *prop_id)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | [INFO] [stdout] 60 | Some((prop, *value)) [INFO] [stdout] | ^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libdrm_amdgpu_sys` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> amdgpu/mod.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 81 | pub(crate) fn parse_hwmon>(path: P) -> Option { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | std::fs::read_to_string(path.into()).ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> amdgpu/mod.rs:83:26 [INFO] [stdout] | [INFO] [stdout] 83 | .and_then(|file| file.trim_end().parse::().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> amdgpu/mod.rs:159:5 [INFO] [stdout] | [INFO] [stdout] 157 | let Ok(amdgpu_devices) = std::fs::read_dir("/sys/bus/pci/drivers/amdgpu") else { return Vec::new() }; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | [INFO] [stdout] 159 | / amdgpu_devices.flat_map(|v| { [INFO] [stdout] 160 | | let name = v.ok()?.file_name(); [INFO] [stdout] 161 | | [INFO] [stdout] 162 | | /* 0000:00:00.0 */ [INFO] [stdout] ... | [INFO] [stdout] 165 | | name.into_string().ok()?.parse::().ok() [INFO] [stdout] 166 | | }).collect() [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> amdgpu/throttle_status.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 38 | let mut set: HashSet = HashSet::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | set.into_iter().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> amdgpu/ip_discovery.rs:139:13 [INFO] [stdout] | [INFO] [stdout] 138 | let mut ip_hw: Vec = die.filter_map(|ip_hw| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | ip_hw.ok()?.file_name().to_str()?.parse().ok() [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pci/bus_info.rs:62:13 [INFO] [stdout] | [INFO] [stdout] 61 | pci_by_path.or_else(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | std::fs::read_dir(self.get_sysfs_path().join("drm"))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pci/bus_info.rs:93:38 [INFO] [stdout] | [INFO] [stdout] 93 | .filter_map(|entry| Some(entry.ok()?.path())) [INFO] [stdout] | ----- ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> drm_mode/object_property.rs:60:18 [INFO] [stdout] | [INFO] [stdout] 58 | let prop = drmModeProperty::get(fd, *prop_id)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | [INFO] [stdout] 60 | Some((prop, *value)) [INFO] [stdout] | ^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libdrm_amdgpu_sys` (lib test) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "d43d1a10dc659c696292205a3dab823c30fa2fcedc91016bd036130e8277b0d6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d43d1a10dc659c696292205a3dab823c30fa2fcedc91016bd036130e8277b0d6", kill_on_drop: false }` [INFO] [stdout] d43d1a10dc659c696292205a3dab823c30fa2fcedc91016bd036130e8277b0d6