[INFO] fetching crate libcnb-package 0.23.0... [INFO] checking libcnb-package-0.23.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate libcnb-package 0.23.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate libcnb-package 0.23.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate libcnb-package 0.23.0 [INFO] finished tweaking crates.io crate libcnb-package 0.23.0 [INFO] tweaked toml for crates.io crate libcnb-package 0.23.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 70 packages to latest compatible versions [INFO] [stderr] Adding bit-set v0.5.3 (latest: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding fixedbitset v0.4.2 (latest: v0.5.7) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding winsafe v0.0.19 (latest: v0.0.22) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f2240e49b46df2cb935ca3cf6119e60f9c841007ae973a4b41c26b575484466d [INFO] running `Command { std: "docker" "start" "-a" "f2240e49b46df2cb935ca3cf6119e60f9c841007ae973a4b41c26b575484466d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f2240e49b46df2cb935ca3cf6119e60f9c841007ae973a4b41c26b575484466d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f2240e49b46df2cb935ca3cf6119e60f9c841007ae973a4b41c26b575484466d", kill_on_drop: false }` [INFO] [stdout] f2240e49b46df2cb935ca3cf6119e60f9c841007ae973a4b41c26b575484466d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5c51d45c2e35eaa90c9f801e4319d7c2b26579b6d5316f5b2510e40b715251f9 [INFO] running `Command { std: "docker" "start" "-a" "5c51d45c2e35eaa90c9f801e4319d7c2b26579b6d5316f5b2510e40b715251f9", kill_on_drop: false }` [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling bit-vec v0.6.3 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking uriparse v0.6.4 [INFO] [stderr] Checking fixedbitset v0.4.2 [INFO] [stderr] Compiling indoc v2.0.5 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking which v6.0.3 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking camino v1.1.9 [INFO] [stderr] Checking cargo-platform v0.1.8 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking semver v1.0.23 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling bit-set v0.5.3 [INFO] [stderr] Checking petgraph v0.6.5 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking cargo_metadata v0.18.1 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking libcnb-common v0.23.0 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Checking fancy-regex v0.13.0 [INFO] [stderr] Checking ignore v0.4.22 [INFO] [stderr] Compiling libcnb-proc-macros v0.23.0 [INFO] [stderr] Checking libcnb-data v0.23.0 [INFO] [stderr] Checking libcnb-package v0.23.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:148:5 [INFO] [stdout] | [INFO] [stdout] 148 | / output [INFO] [stdout] 149 | | .status [INFO] [stdout] 150 | | .success() [INFO] [stdout] 151 | | .then_some(output) [INFO] [stdout] 152 | | .ok_or(FindCargoWorkspaceRootError::CommandFailure(status)) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dependency_graph.rs:50:29 [INFO] [stdout] | [INFO] [stdout] 50 | .find(|idx| graph[*idx].id() == dependency) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dependency_graph.rs:89:25 [INFO] [stdout] | [INFO] [stdout] 89 | .find(|idx| graph[*idx].id() == root_node.id()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dependency_graph.rs:89:45 [INFO] [stdout] | [INFO] [stdout] 89 | .find(|idx| graph[*idx].id() == root_node.id()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/package.rs:87:5 [INFO] [stdout] | [INFO] [stdout] 66 | let cargo_metadata = MetadataCommand::new() [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | / fs::write( [INFO] [stdout] 88 | | destination.join("package.toml"), [INFO] [stdout] 89 | | "[buildpack]\nuri = \".\"\n", [INFO] [stdout] 90 | | ) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/package.rs:144:5 [INFO] [stdout] | [INFO] [stdout] 144 | / write_toml_file( [INFO] [stdout] 145 | | &normalized_package_descriptor, [INFO] [stdout] 146 | | destination.join("package.toml"), [INFO] [stdout] 147 | | ) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libcnb-package` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:148:5 [INFO] [stdout] | [INFO] [stdout] 148 | / output [INFO] [stdout] 149 | | .status [INFO] [stdout] 150 | | .success() [INFO] [stdout] 151 | | .then_some(output) [INFO] [stdout] 152 | | .ok_or(FindCargoWorkspaceRootError::CommandFailure(status)) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dependency_graph.rs:50:29 [INFO] [stdout] | [INFO] [stdout] 50 | .find(|idx| graph[*idx].id() == dependency) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dependency_graph.rs:89:25 [INFO] [stdout] | [INFO] [stdout] 89 | .find(|idx| graph[*idx].id() == root_node.id()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dependency_graph.rs:89:45 [INFO] [stdout] | [INFO] [stdout] 89 | .find(|idx| graph[*idx].id() == root_node.id()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/package.rs:87:5 [INFO] [stdout] | [INFO] [stdout] 66 | let cargo_metadata = MetadataCommand::new() [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | / fs::write( [INFO] [stdout] 88 | | destination.join("package.toml"), [INFO] [stdout] 89 | | "[buildpack]\nuri = \".\"\n", [INFO] [stdout] 90 | | ) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/package.rs:144:5 [INFO] [stdout] | [INFO] [stdout] 144 | / write_toml_file( [INFO] [stdout] 145 | | &normalized_package_descriptor, [INFO] [stdout] 146 | | destination.join("package.toml"), [INFO] [stdout] 147 | | ) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libcnb-package` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "5c51d45c2e35eaa90c9f801e4319d7c2b26579b6d5316f5b2510e40b715251f9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5c51d45c2e35eaa90c9f801e4319d7c2b26579b6d5316f5b2510e40b715251f9", kill_on_drop: false }` [INFO] [stdout] 5c51d45c2e35eaa90c9f801e4319d7c2b26579b6d5316f5b2510e40b715251f9