[INFO] fetching crate libbruteforce 4.0.1... [INFO] checking libbruteforce-4.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate libbruteforce 4.0.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate libbruteforce 4.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-2-tc2/source/.cargo/config.toml [INFO] started tweaking crates.io crate libbruteforce 4.0.1 [INFO] finished tweaking crates.io crate libbruteforce 4.0.1 [INFO] tweaked toml for crates.io crate libbruteforce 4.0.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate libbruteforce 4.0.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8c221d82836e847e68d17a91b7167a6727f418ab88f137b104e8a19574b90406 [INFO] running `Command { std: "docker" "start" "-a" "8c221d82836e847e68d17a91b7167a6727f418ab88f137b104e8a19574b90406", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8c221d82836e847e68d17a91b7167a6727f418ab88f137b104e8a19574b90406", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8c221d82836e847e68d17a91b7167a6727f418ab88f137b104e8a19574b90406", kill_on_drop: false }` [INFO] [stdout] 8c221d82836e847e68d17a91b7167a6727f418ab88f137b104e8a19574b90406 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8148e863c29575279ca031d6b099f68fc9e0c6856358c09774400d7bca8e26b8 [INFO] running `Command { std: "docker" "start" "-a" "8148e863c29575279ca031d6b099f68fc9e0c6856358c09774400d7bca8e26b8", kill_on_drop: false }` [INFO] [stderr] Compiling typenum v1.15.0 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling libc v0.2.116 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking cpufeatures v0.2.1 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Compiling time-macros v0.2.3 [INFO] [stderr] Checking num_threads v0.1.3 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Compiling generic-array v0.14.5 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking time v0.3.7 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking colored v2.0.0 [INFO] [stderr] Checking crypto-common v0.1.1 [INFO] [stderr] Checking block-buffer v0.10.0 [INFO] [stderr] Checking simple_logger v2.1.0 [INFO] [stderr] Checking digest v0.10.1 [INFO] [stderr] Checking sha2 v0.10.1 [INFO] [stderr] Checking md-5 v0.10.0 [INFO] [stderr] Checking sha-1 v0.10.0 [INFO] [stderr] Checking libbruteforce v4.0.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:126:18 [INFO] [stdout] | [INFO] [stdout] 126 | .map(|h| h.join().unwrap()) // result of the Option from the threads [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crack/worker_threads.rs:74:19 [INFO] [stdout] | [INFO] [stdout] 66 | params: Arc>, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | done: Arc, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | mut indices: Box<[isize]>, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 75 | | // reserve a string buffer with the maximum needed size; in the worst case it can contain [INFO] [stdout] 76 | | // indices.len() * 4 bytes, because UTF-8 chars can be at most 4 byte long. Because [INFO] [stdout] 77 | | // I prevent the allocation for a string in every iteration and do this only once, [INFO] [stdout] ... | [INFO] [stdout] 152 | | result [INFO] [stdout] 153 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libbruteforce` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:126:18 [INFO] [stdout] | [INFO] [stdout] 126 | .map(|h| h.join().unwrap()) // result of the Option from the threads [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crack/worker_threads.rs:74:19 [INFO] [stdout] | [INFO] [stdout] 66 | params: Arc>, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | done: Arc, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | mut indices: Box<[isize]>, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 75 | | // reserve a string buffer with the maximum needed size; in the worst case it can contain [INFO] [stdout] 76 | | // indices.len() * 4 bytes, because UTF-8 chars can be at most 4 byte long. Because [INFO] [stdout] 77 | | // I prevent the allocation for a string in every iteration and do this only once, [INFO] [stdout] ... | [INFO] [stdout] 152 | | result [INFO] [stdout] 153 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/testutil/mod.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 38 | let alphabet = Builder::new().full().build(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | BasicCrackParameter::new(alphabet, max_len, min_len, false), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/testutil/mod.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 49 | let alphabet = Builder::new().full().build(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | BasicCrackParameter::new(alphabet, max_len, min_len, false), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/testutil/mod.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 62 | let alphabet = Builder::new().full().build(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | BasicCrackParameter::new(alphabet, max_len, min_len, true), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libbruteforce` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "8148e863c29575279ca031d6b099f68fc9e0c6856358c09774400d7bca8e26b8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8148e863c29575279ca031d6b099f68fc9e0c6856358c09774400d7bca8e26b8", kill_on_drop: false }` [INFO] [stdout] 8148e863c29575279ca031d6b099f68fc9e0c6856358c09774400d7bca8e26b8