[INFO] fetching crate libblobd-direct 0.5.4... [INFO] checking libblobd-direct-0.5.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate libblobd-direct 0.5.4 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate libblobd-direct 0.5.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate libblobd-direct 0.5.4 [INFO] finished tweaking crates.io crate libblobd-direct 0.5.4 [INFO] tweaked toml for crates.io crate libblobd-direct 0.5.4 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 144 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding croaring v0.8.1 (latest: v2.0.3) [INFO] [stderr] Adding croaring-sys v0.8.1 (latest: v4.1.1) [INFO] [stderr] Adding dashmap v5.5.3 (latest: v6.0.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding matchers v0.1.0 (latest: v0.2.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (latest: v0.50.1) [INFO] [stderr] Adding num-derive v0.3.3 (latest: v0.4.2) [INFO] [stderr] Adding regex-automata v0.1.10 (latest: v0.4.7) [INFO] [stderr] Adding regex-syntax v0.6.29 (latest: v0.8.4) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding strum v0.24.1 (latest: v0.26.3) [INFO] [stderr] Adding strum_macros v0.24.3 (latest: v0.26.4) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c4d6bb2312158a7d7efd4de94c16b528630a27a46bee59517add6760b142c50b [INFO] running `Command { std: "docker" "start" "-a" "c4d6bb2312158a7d7efd4de94c16b528630a27a46bee59517add6760b142c50b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c4d6bb2312158a7d7efd4de94c16b528630a27a46bee59517add6760b142c50b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c4d6bb2312158a7d7efd4de94c16b528630a27a46bee59517add6760b142c50b", kill_on_drop: false }` [INFO] [stdout] c4d6bb2312158a7d7efd4de94c16b528630a27a46bee59517add6760b142c50b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 111d47ea44f4179595265c628d4b1071e8b1604331f3aa9ce2bc34916c4c9353 [INFO] running `Command { std: "docker" "start" "-a" "111d47ea44f4179595265c628d4b1071e8b1604331f3aa9ce2bc34916c4c9353", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling croaring-sys v0.8.1 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Compiling blake3 v1.5.4 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling io-uring v0.6.4 [INFO] [stderr] Checking rmp v0.8.14 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Compiling struct-name v0.0.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking roaring v0.10.6 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking signal-future v0.1.1 [INFO] [stderr] Checking bufpool v0.2.4 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Compiling tracing-test-macro v0.2.5 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Checking stochastic-queue v0.2.0 [INFO] [stderr] Checking croaring v0.8.1 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking rmp-serde v1.3.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Compiling strum_macros v0.24.3 [INFO] [stderr] Compiling num-derive v0.3.3 [INFO] [stderr] Compiling struct-name-macro v0.0.2 [INFO] [stderr] Checking off64 v0.6.0 [INFO] [stderr] Checking tinybuf v0.3.0 [INFO] [stderr] Checking tracing-test v0.2.5 [INFO] [stderr] Checking strum v0.24.1 [INFO] [stderr] Checking libblobd-direct v0.5.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:213:47 [INFO] [stdout] | [INFO] [stdout] 211 | let partitions = join_all(self.partitions.into_iter().map(|p| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 212 | let progress = progress.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 213 | async move { p.load_and_start(progress).await } [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:304:16 [INFO] [stdout] | [INFO] [stdout] 301 | .map(|o| BlobdListObjectsOutputObject { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 304 | key: o.key.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/allocator/mod.rs:62:13 [INFO] [stdout] | [INFO] [stdout] 53 | pages: Pages, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | dir: AllocDir, [INFO] [stdout] 55 | metrics: BlobdMetrics, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | free: (pages.spage_size_pow2..=pages.lpage_size_pow2) [INFO] [stdout] | _____________^ [INFO] [stdout] 63 | | .map(|sz| { [INFO] [stdout] 64 | | let page_count = u32!(div_pow2(heap_size, sz)); [INFO] [stdout] 65 | | let mut map = RoaringBitmap::new(); [INFO] [stdout] ... | [INFO] [stdout] 70 | | }) [INFO] [stdout] 71 | | .collect(), [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backing_store/file.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn new(file: File, pages: Pages) -> Self { [INFO] [stdout] | ---------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | Self { [INFO] [stdout] 21 | file: Arc::new(file), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backing_store/file.rs:43:59 [INFO] [stdout] | [INFO] [stdout] 43 | async fn write_at(&self, offset: u64, data: Buf) -> Buf { [INFO] [stdout] | _________________________________________---------_________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | | spawn_blocking({ [INFO] [stdout] 45 | | let file = self.file.clone(); [INFO] [stdout] 46 | | move || { [INFO] [stdout] ... | [INFO] [stdout] 53 | | .unwrap() [INFO] [stdout] 54 | | } [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backing_store/uring.rs:266:59 [INFO] [stdout] | [INFO] [stdout] 266 | async fn write_at(&self, offset: u64, data: Buf) -> Buf { [INFO] [stdout] | _________________________________________---------_________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 267 | | let (fut, fut_ctl) = SignalFuture::new(); [INFO] [stdout] 268 | | self [INFO] [stdout] 269 | | .sender [INFO] [stdout] ... | [INFO] [stdout] 275 | | fut.await [INFO] [stdout] 276 | | } [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object/mod.rs:125:14 [INFO] [stdout] | [INFO] [stdout] 123 | pub fn new(id: u64, state: ObjectState, metadata: ObjectMetadata, metadata_size: u64) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | Self { [INFO] [stdout] 125 | inner: Arc::new(ObjectInner { [INFO] [stdout] | ______________^ [INFO] [stdout] 126 | | id, [INFO] [stdout] 127 | | lock: RwLock::new(()), [INFO] [stdout] 128 | | metadata, [INFO] [stdout] 129 | | metadata_size, [INFO] [stdout] 130 | | state: AtomicU8::new(state as u8), [INFO] [stdout] 131 | | }), [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object/mod.rs:139:7 [INFO] [stdout] | [INFO] [stdout] 135 | pub fn with_new_id(self, new_id: u64) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | self.inner.metadata.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/op/write_object.rs:109:51 [INFO] [stdout] | [INFO] [stdout] 109 | .map_err(|err| OpError::DataStreamError(Box::from(err)))? [INFO] [stdout] | --- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/partition/mod.rs:106:68 [INFO] [stdout] | [INFO] [stdout] 80 | tuples, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | let dev = dev.bounded(0, self.heap_dev_offset); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | let pages = pages.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | async move { tuples.start_background_commit_loop(dev, pages).await } [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tuples.rs:68:14 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn new(pages: Pages, bundles_with_initial_data: Vec>) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | let mut state = TuplesState::default(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | state: Arc::new(Mutex::new(state)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:213:47 [INFO] [stdout] | [INFO] [stdout] 211 | let partitions = join_all(self.partitions.into_iter().map(|p| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 212 | let progress = progress.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 213 | async move { p.load_and_start(progress).await } [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:304:16 [INFO] [stdout] | [INFO] [stdout] 301 | .map(|o| BlobdListObjectsOutputObject { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 304 | key: o.key.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/allocator/mod.rs:62:13 [INFO] [stdout] | [INFO] [stdout] 53 | pages: Pages, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | dir: AllocDir, [INFO] [stdout] 55 | metrics: BlobdMetrics, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | free: (pages.spage_size_pow2..=pages.lpage_size_pow2) [INFO] [stdout] | _____________^ [INFO] [stdout] 63 | | .map(|sz| { [INFO] [stdout] 64 | | let page_count = u32!(div_pow2(heap_size, sz)); [INFO] [stdout] 65 | | let mut map = RoaringBitmap::new(); [INFO] [stdout] ... | [INFO] [stdout] 70 | | }) [INFO] [stdout] 71 | | .collect(), [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backing_store/file.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn new(file: File, pages: Pages) -> Self { [INFO] [stdout] | ---------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | Self { [INFO] [stdout] 21 | file: Arc::new(file), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libblobd-direct` (lib) due to 12 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backing_store/file.rs:43:59 [INFO] [stdout] | [INFO] [stdout] 43 | async fn write_at(&self, offset: u64, data: Buf) -> Buf { [INFO] [stdout] | _________________________________________---------_________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | | spawn_blocking({ [INFO] [stdout] 45 | | let file = self.file.clone(); [INFO] [stdout] 46 | | move || { [INFO] [stdout] ... | [INFO] [stdout] 53 | | .unwrap() [INFO] [stdout] 54 | | } [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backing_store/uring.rs:266:59 [INFO] [stdout] | [INFO] [stdout] 266 | async fn write_at(&self, offset: u64, data: Buf) -> Buf { [INFO] [stdout] | _________________________________________---------_________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 267 | | let (fut, fut_ctl) = SignalFuture::new(); [INFO] [stdout] 268 | | self [INFO] [stdout] 269 | | .sender [INFO] [stdout] ... | [INFO] [stdout] 275 | | fut.await [INFO] [stdout] 276 | | } [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object/mod.rs:125:14 [INFO] [stdout] | [INFO] [stdout] 123 | pub fn new(id: u64, state: ObjectState, metadata: ObjectMetadata, metadata_size: u64) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | Self { [INFO] [stdout] 125 | inner: Arc::new(ObjectInner { [INFO] [stdout] | ______________^ [INFO] [stdout] 126 | | id, [INFO] [stdout] 127 | | lock: RwLock::new(()), [INFO] [stdout] 128 | | metadata, [INFO] [stdout] 129 | | metadata_size, [INFO] [stdout] 130 | | state: AtomicU8::new(state as u8), [INFO] [stdout] 131 | | }), [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object/mod.rs:139:7 [INFO] [stdout] | [INFO] [stdout] 135 | pub fn with_new_id(self, new_id: u64) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | self.inner.metadata.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/op/write_object.rs:109:51 [INFO] [stdout] | [INFO] [stdout] 109 | .map_err(|err| OpError::DataStreamError(Box::from(err)))? [INFO] [stdout] | --- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/partition/mod.rs:106:68 [INFO] [stdout] | [INFO] [stdout] 80 | tuples, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | let dev = dev.bounded(0, self.heap_dev_offset); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | let pages = pages.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | async move { tuples.start_background_commit_loop(dev, pages).await } [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tuples.rs:68:14 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn new(pages: Pages, bundles_with_initial_data: Vec>) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | let mut state = TuplesState::default(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | state: Arc::new(Mutex::new(state)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libblobd-direct` (lib test) due to 12 previous errors [INFO] running `Command { std: "docker" "inspect" "111d47ea44f4179595265c628d4b1071e8b1604331f3aa9ce2bc34916c4c9353", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "111d47ea44f4179595265c628d4b1071e8b1604331f3aa9ce2bc34916c4c9353", kill_on_drop: false }` [INFO] [stdout] 111d47ea44f4179595265c628d4b1071e8b1604331f3aa9ce2bc34916c4c9353