[INFO] fetching crate lib_game_detector 0.0.8... [INFO] checking lib_game_detector-0.0.8 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate lib_game_detector 0.0.8 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate lib_game_detector 0.0.8 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate lib_game_detector 0.0.8 [INFO] finished tweaking crates.io crate lib_game_detector 0.0.8 [INFO] tweaked toml for crates.io crate lib_game_detector 0.0.8 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate lib_game_detector 0.0.8 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 83ef82ab7ce1759ea3643ec7ae70e5a5a62eb5d7c9ed7d81cdd568533b3f41e8 [INFO] running `Command { std: "docker" "start" "-a" "83ef82ab7ce1759ea3643ec7ae70e5a5a62eb5d7c9ed7d81cdd568533b3f41e8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "83ef82ab7ce1759ea3643ec7ae70e5a5a62eb5d7c9ed7d81cdd568533b3f41e8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "83ef82ab7ce1759ea3643ec7ae70e5a5a62eb5d7c9ed7d81cdd568533b3f41e8", kill_on_drop: false }` [INFO] [stdout] 83ef82ab7ce1759ea3643ec7ae70e5a5a62eb5d7c9ed7d81cdd568533b3f41e8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 69ea02800dfc3b74275af0ca76f467b7378cb8c6d04d962d536dc598631026f1 [INFO] running `Command { std: "docker" "start" "-a" "69ea02800dfc3b74275af0ca76f467b7378cb8c6d04d962d536dc598631026f1", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.83 [INFO] [stderr] Compiling rustix v0.38.28 [INFO] [stderr] Checking linux-raw-sys v0.4.12 [INFO] [stderr] Compiling crossbeam-utils v0.8.17 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Compiling serde v1.0.193 [INFO] [stderr] Compiling libc v0.2.150 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Compiling serde_json v1.0.108 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Compiling rayon-core v1.12.0 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Checking ciborium-io v0.2.1 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking plotters-backend v0.3.5 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking bytecount v0.6.8 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking plotters-svg v0.3.5 [INFO] [stderr] Checking ascii v1.1.0 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking ciborium-ll v0.2.1 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking condtype v1.3.0 [INFO] [stderr] Checking regex-lite v0.1.5 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.16 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking crossbeam-deque v0.8.4 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.65 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking rayon v1.8.0 [INFO] [stderr] Checking directories v5.0.1 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking plotters v0.3.5 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking clap_builder v4.4.11 [INFO] [stderr] Checking nom_locate v4.2.0 [INFO] [stderr] Checking steam_shortcuts_util v1.1.8 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking clap v4.4.11 [INFO] [stderr] Compiling test-case-core v3.3.1 [INFO] [stderr] Compiling serde_derive v1.0.193 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling divan-macros v0.1.14 [INFO] [stderr] Compiling test-case-macros v3.3.1 [INFO] [stderr] Checking test-case v3.3.1 [INFO] [stderr] Checking divan v0.1.14 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking lib_game_detector v0.0.8 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:22:14 [INFO] [stdout] | [INFO] [stdout] 16 | args: impl IntoIterator, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | env_vars: impl IntoIterator, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | ) -> Arc> { [INFO] [stdout] 19 | let mut command = Command::new(command); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | Arc::new(Mutex::new(command)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux/mod.rs:65:29 [INFO] [stdout] | [INFO] [stdout] 65 | .filter_map(|l| l.get_detected_games().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux/mod.rs:82:35 [INFO] [stdout] | [INFO] [stdout] 82 | .filter_map(|l| match l.get_detected_games() { [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux/mod.rs:100:17 [INFO] [stdout] | [INFO] [stdout] 99 | .and_then(|l| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | / l.get_detected_games() [INFO] [stdout] 101 | | .map_err(|_| { [INFO] [stdout] 102 | | error!( [INFO] [stdout] 103 | | "Launcher detected but there was an error with getting detected games for the launcher: {:?}", [INFO] [stdout] 104 | | l.get_launcher_type() [INFO] [stdout] 105 | | ) [INFO] [stdout] 106 | | }) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux/launchers/bottles.rs:333:21 [INFO] [stdout] | [INFO] [stdout] 306 | let launch_command = { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 333 | / Game { [INFO] [stdout] 334 | | title: clean_game_title(title), [INFO] [stdout] 335 | | launch_command, [INFO] [stdout] 336 | | path_box_art, [INFO] [stdout] 337 | | path_game_dir, [INFO] [stdout] 338 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux/launchers/heroic/heroic_amazon.rs:98:17 [INFO] [stdout] | [INFO] [stdout] 89 | let launch_command = get_launch_command_for_heroic_source("nile", &app_id, self.is_using_flatpak); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | / Game { [INFO] [stdout] 99 | | title, [INFO] [stdout] 100 | | launch_command, [INFO] [stdout] 101 | | path_box_art, [INFO] [stdout] 102 | | path_game_dir, [INFO] [stdout] 103 | | }.into() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux/launchers/heroic/heroic_epic.rs:98:17 [INFO] [stdout] | [INFO] [stdout] 89 | let launch_command = get_launch_command_for_heroic_source("legendary", &app_id, self.is_using_flatpak); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | / Game { [INFO] [stdout] 99 | | title, [INFO] [stdout] 100 | | launch_command, [INFO] [stdout] 101 | | path_box_art, [INFO] [stdout] 102 | | path_game_dir, [INFO] [stdout] 103 | | }.into() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux/launchers/heroic/heroic_gog.rs:153:17 [INFO] [stdout] | [INFO] [stdout] 141 | let launch_command = [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | / Game { [INFO] [stdout] 154 | | title, [INFO] [stdout] 155 | | launch_command, [INFO] [stdout] 156 | | path_box_art, [INFO] [stdout] 157 | | path_game_dir, [INFO] [stdout] 158 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux/launchers/lutris.rs:349:21 [INFO] [stdout] | [INFO] [stdout] 321 | let launch_command = { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 349 | / Game { [INFO] [stdout] 350 | | title: clean_game_title(title), [INFO] [stdout] 351 | | launch_command, [INFO] [stdout] 352 | | path_box_art, [INFO] [stdout] 353 | | path_game_dir, [INFO] [stdout] 354 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux/launchers/minecraft/at.rs:102:17 [INFO] [stdout] | [INFO] [stdout] 84 | let launch_command = { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | / Game { [INFO] [stdout] 103 | | title: get_minecraft_title(&title), [INFO] [stdout] 104 | | launch_command, [INFO] [stdout] 105 | | path_box_art, [INFO] [stdout] 106 | | path_game_dir, [INFO] [stdout] 107 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux/launchers/minecraft/prism.rs:124:17 [INFO] [stdout] | [INFO] [stdout] 107 | let launch_command = { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | / Game { [INFO] [stdout] 125 | | title: get_minecraft_title(&title), [INFO] [stdout] 126 | | launch_command, [INFO] [stdout] 127 | | path_box_art, [INFO] [stdout] 128 | | path_game_dir, [INFO] [stdout] 129 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux/launchers/steam/steam_shortcuts.rs:292:21 [INFO] [stdout] | [INFO] [stdout] 283 | let launch_command = get_steam_launch_command(app_id, self.is_using_flatpak); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 292 | / Game { [INFO] [stdout] 293 | | title: clean_game_title(&title), [INFO] [stdout] 294 | | launch_command, [INFO] [stdout] 295 | | path_box_art, [INFO] [stdout] 296 | | path_game_dir, [INFO] [stdout] 297 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lib_game_detector` (lib) due to 13 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "69ea02800dfc3b74275af0ca76f467b7378cb8c6d04d962d536dc598631026f1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "69ea02800dfc3b74275af0ca76f467b7378cb8c6d04d962d536dc598631026f1", kill_on_drop: false }` [INFO] [stdout] 69ea02800dfc3b74275af0ca76f467b7378cb8c6d04d962d536dc598631026f1