[INFO] fetching crate lhef 0.6.0... [INFO] checking lhef-0.6.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate lhef 0.6.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate lhef 0.6.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate lhef 0.6.0 [INFO] finished tweaking crates.io crate lhef 0.6.0 [INFO] tweaked toml for crates.io crate lhef 0.6.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 80 packages to latest compatible versions [INFO] [stderr] Adding anes v0.1.6 (latest: v0.2.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding itertools v0.11.0 (latest: v0.13.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding xmltree v0.9.0 (latest: v0.11.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fb93aa9981b1ba6490cd72f56113dfb164032a5235f6ac839b482a95690b9584 [INFO] running `Command { std: "docker" "start" "-a" "fb93aa9981b1ba6490cd72f56113dfb164032a5235f6ac839b482a95690b9584", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fb93aa9981b1ba6490cd72f56113dfb164032a5235f6ac839b482a95690b9584", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fb93aa9981b1ba6490cd72f56113dfb164032a5235f6ac839b482a95690b9584", kill_on_drop: false }` [INFO] [stdout] fb93aa9981b1ba6490cd72f56113dfb164032a5235f6ac839b482a95690b9584 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4b09f16490f70e5a34ff926d64e23898ad7a88b6fa153fed188ee932e47fc9eb [INFO] running `Command { std: "docker" "start" "-a" "4b09f16490f70e5a34ff926d64e23898ad7a88b6fa153fed188ee932e47fc9eb", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking xml-rs v0.8.21 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking xmltree v0.9.0 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking fast-float v0.2.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking lhef v0.6.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 44 | pub fn new(mut stream: T) -> Result, ReadError> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | Ok(Reader { [INFO] [stdout] | ____________^ [INFO] [stdout] 49 | | stream, [INFO] [stdout] 50 | | version, [INFO] [stdout] 51 | | header, [INFO] [stdout] 52 | | xml_header, [INFO] [stdout] 53 | | heprup, [INFO] [stdout] 54 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:221:11 [INFO] [stdout] | [INFO] [stdout] 213 | fn parse(name: F, text: Option<&str>) -> Result [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 221 | match text.parse::() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:220:54 [INFO] [stdout] | [INFO] [stdout] 213 | fn parse(name: F, text: Option<&str>) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 220 | let text: &str = text.ok_or_else(|| MissingEntry(name().into()))?; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:233:54 [INFO] [stdout] | [INFO] [stdout] 227 | fn parse_f64(name: F, text: Option<&str>) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | let text: &str = text.ok_or_else(|| MissingEntry(name().into()))?; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer.rs:106:12 [INFO] [stdout] | [INFO] [stdout] 103 | pub fn new(mut stream: T, version: &str) -> Result, WriteError> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | Ok(Writer { [INFO] [stdout] | ____________^ [INFO] [stdout] 107 | | stream, [INFO] [stdout] 108 | | state: WriterState::ExpectingHeaderOrInit, [INFO] [stdout] 109 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lhef` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "4b09f16490f70e5a34ff926d64e23898ad7a88b6fa153fed188ee932e47fc9eb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4b09f16490f70e5a34ff926d64e23898ad7a88b6fa153fed188ee932e47fc9eb", kill_on_drop: false }` [INFO] [stdout] 4b09f16490f70e5a34ff926d64e23898ad7a88b6fa153fed188ee932e47fc9eb