[INFO] fetching crate lethe 0.8.0... [INFO] checking lethe-0.8.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate lethe 0.8.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate lethe 0.8.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate lethe 0.8.0 [INFO] finished tweaking crates.io crate lethe 0.8.0 [INFO] tweaked toml for crates.io crate lethe 0.8.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate lethe 0.8.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bd26ac396031e533f5faf905cc0be8ee2a680448cc2bc5110cff718a4dbcc4f4 [INFO] running `Command { std: "docker" "start" "-a" "bd26ac396031e533f5faf905cc0be8ee2a680448cc2bc5110cff718a4dbcc4f4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bd26ac396031e533f5faf905cc0be8ee2a680448cc2bc5110cff718a4dbcc4f4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bd26ac396031e533f5faf905cc0be8ee2a680448cc2bc5110cff718a4dbcc4f4", kill_on_drop: false }` [INFO] [stdout] bd26ac396031e533f5faf905cc0be8ee2a680448cc2bc5110cff718a4dbcc4f4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b024427785330a0f46e454a0278981c7e3d923ef62eb7fbf2fb0ab8965f4ae16 [INFO] running `Command { std: "docker" "start" "-a" "b024427785330a0f46e454a0278981c7e3d923ef62eb7fbf2fb0ab8965f4ae16", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.133 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Compiling unicode-ident v1.0.4 [INFO] [stderr] Compiling serde v1.0.145 [INFO] [stderr] Compiling syn v1.0.100 [INFO] [stderr] Compiling indexmap v1.9.1 [INFO] [stderr] Checking miniz_oxide v0.5.4 [INFO] [stderr] Compiling backtrace v0.3.66 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking gimli v0.26.2 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking unicode-width v0.1.10 [INFO] [stderr] Compiling serde_derive v1.0.145 [INFO] [stderr] Compiling thiserror v1.0.35 [INFO] [stderr] Checking object v0.29.0 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Checking once_cell v1.15.0 [INFO] [stderr] Compiling anyhow v1.0.65 [INFO] [stderr] Checking ryu v1.0.11 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking safemem v0.3.3 [INFO] [stderr] Checking os_str_bytes v6.3.0 [INFO] [stderr] Checking itoa v1.0.3 [INFO] [stderr] Checking num_threads v0.1.6 [INFO] [stderr] Checking rustc-demangle v0.1.21 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking line-wrap v0.1.1 [INFO] [stderr] Checking aho-corasick v0.7.19 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking retain_mut v0.1.7 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking getrandom v0.2.7 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking terminal_size v0.1.17 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking console v0.15.1 [INFO] [stderr] Checking term v0.7.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking time v0.3.14 [INFO] [stderr] Checking numtoa v0.2.4 [INFO] [stderr] Checking xml-rs v0.8.4 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking addr2line v0.17.0 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking textwrap v0.15.1 [INFO] [stderr] Checking bytemuck v1.12.1 [INFO] [stderr] Checking nix v0.25.0 [INFO] [stderr] Checking clap v3.2.22 [INFO] [stderr] Checking roaring v0.10.1 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Checking sysfs-class v0.1.3 [INFO] [stderr] Compiling thiserror-impl v1.0.35 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking plist v1.3.1 [INFO] [stderr] Checking indicatif v0.17.1 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking prettytable-rs v0.9.0 [INFO] [stderr] Checking streaming-iterator v0.1.7 [INFO] [stderr] Checking flate2 v1.0.24 [INFO] [stderr] Checking assert_matches v1.5.0 [INFO] [stderr] Checking lethe v0.8.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `crate::storage::nix::*` [INFO] [stdout] --> src/storage/mod.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub use crate::storage::nix::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `linux` [INFO] [stdout] --> src/main.rs:115:17 [INFO] [stdout] | [INFO] [stdout] 115 | if cfg!(linux) { [INFO] [stdout] | ^^^^^ help: found config with similar value: `target_os = "linux"` [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(linux)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(linux)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::storage::nix::*` [INFO] [stdout] --> src/storage/mod.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub use crate::storage::nix::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `linux` [INFO] [stdout] --> src/main.rs:115:17 [INFO] [stdout] | [INFO] [stdout] 115 | if cfg!(linux) { [INFO] [stdout] | ^^^^^ help: found config with similar value: `target_os = "linux"` [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(linux)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(linux)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `position` is never used [INFO] [stdout] --> src/storage/mod.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 33 | pub trait StorageAccess { [INFO] [stdout] | ------------- method in this trait [INFO] [stdout] 34 | fn position(&mut self) -> Result; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `block_size` is never read [INFO] [stdout] --> src/storage/mod.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 62 | pub struct StorageDetails { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 63 | pub size: u64, [INFO] [stdout] 64 | pub block_size: usize, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `StorageDetails` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:213:19 [INFO] [stdout] | [INFO] [stdout] 170 | let device_id = cmd.value_of("device").ok_or(anyhow!("Invalid device ID"))?; [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | let mut state = WipeState::default(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | let mut session = frontend.wipe_session(&device.id, cmd.is_present("yes")); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | match device.access() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/nix/mod.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn new>(file_path: P) -> Result { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let file = os::open_file_direct(file_path, true)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | Ok(FileAccess { file }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/nix/mod.rs:95:43 [INFO] [stdout] | [INFO] [stdout] 95 | FileAccess::new(&self.id).map(|a| Box::new(a) as Box) [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/nix/linux.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn open_file_direct>(file_path: P, write_access: bool) -> Result { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | use std::os::unix::fs::OpenOptionsExt; [INFO] [stdout] 32 | / OpenOptions::new() [INFO] [stdout] 33 | | .create(false) [INFO] [stdout] 34 | | .append(false) [INFO] [stdout] 35 | | .write(write_access) [INFO] [stdout] ... | [INFO] [stdout] 38 | | .custom_flags(libc::O_DIRECT /* | libc::O_DSYNC*/) // should be enough in linux 2.6+ [INFO] [stdout] 39 | | .open(file_path.as_ref()) [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/idshortcuts.rs:58:41 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn from(ids: HashSet<&str>) -> IdShortcuts { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | IdShortcuts { [INFO] [stdout] 58 | inner: Self::build_map_from(ids.into_iter().collect()), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/storage_repo.rs:26:37 [INFO] [stdout] | [INFO] [stdout] 12 | let flat_id_set: HashSet = source [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | refs: IdShortcuts::from(flat_id_set.to_owned().iter().map(|x| x.as_str()).collect()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lethe` (bin "lethe") due to 7 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `position` is never used [INFO] [stdout] --> src/storage/mod.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 33 | pub trait StorageAccess { [INFO] [stdout] | ------------- method in this trait [INFO] [stdout] 34 | fn position(&mut self) -> Result; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `block_size` is never read [INFO] [stdout] --> src/storage/mod.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 62 | pub struct StorageDetails { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 63 | pub size: u64, [INFO] [stdout] 64 | pub block_size: usize, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `StorageDetails` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:213:19 [INFO] [stdout] | [INFO] [stdout] 170 | let device_id = cmd.value_of("device").ok_or(anyhow!("Invalid device ID"))?; [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | let mut state = WipeState::default(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | let mut session = frontend.wipe_session(&device.id, cmd.is_present("yes")); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | match device.access() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/nix/mod.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn new>(file_path: P) -> Result { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let file = os::open_file_direct(file_path, true)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | Ok(FileAccess { file }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/nix/mod.rs:95:43 [INFO] [stdout] | [INFO] [stdout] 95 | FileAccess::new(&self.id).map(|a| Box::new(a) as Box) [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/nix/linux.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn open_file_direct>(file_path: P, write_access: bool) -> Result { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | use std::os::unix::fs::OpenOptionsExt; [INFO] [stdout] 32 | / OpenOptions::new() [INFO] [stdout] 33 | | .create(false) [INFO] [stdout] 34 | | .append(false) [INFO] [stdout] 35 | | .write(write_access) [INFO] [stdout] ... | [INFO] [stdout] 38 | | .custom_flags(libc::O_DIRECT /* | libc::O_DSYNC*/) // should be enough in linux 2.6+ [INFO] [stdout] 39 | | .open(file_path.as_ref()) [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/idshortcuts.rs:58:41 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn from(ids: HashSet<&str>) -> IdShortcuts { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | IdShortcuts { [INFO] [stdout] 58 | inner: Self::build_map_from(ids.into_iter().collect()), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/storage_repo.rs:26:37 [INFO] [stdout] | [INFO] [stdout] 12 | let flat_id_set: HashSet = source [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | refs: IdShortcuts::from(flat_id_set.to_owned().iter().map(|x| x.as_str()).collect()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lethe` (bin "lethe" test) due to 7 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b024427785330a0f46e454a0278981c7e3d923ef62eb7fbf2fb0ab8965f4ae16", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b024427785330a0f46e454a0278981c7e3d923ef62eb7fbf2fb0ab8965f4ae16", kill_on_drop: false }` [INFO] [stdout] b024427785330a0f46e454a0278981c7e3d923ef62eb7fbf2fb0ab8965f4ae16