[INFO] fetching crate legion_codegen 0.4.0... [INFO] checking legion_codegen-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate legion_codegen 0.4.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate legion_codegen 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate legion_codegen 0.4.0 [INFO] finished tweaking crates.io crate legion_codegen 0.4.0 [INFO] tweaked toml for crates.io crate legion_codegen 0.4.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 8 packages to latest compatible versions [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9840515c11d7ed23cdd2662bc3ed6273b241c2ceca5c66de613c4bce803e2c1a [INFO] running `Command { std: "docker" "start" "-a" "9840515c11d7ed23cdd2662bc3ed6273b241c2ceca5c66de613c4bce803e2c1a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9840515c11d7ed23cdd2662bc3ed6273b241c2ceca5c66de613c4bce803e2c1a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9840515c11d7ed23cdd2662bc3ed6273b241c2ceca5c66de613c4bce803e2c1a", kill_on_drop: false }` [INFO] [stdout] 9840515c11d7ed23cdd2662bc3ed6273b241c2ceca5c66de613c4bce803e2c1a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 656e090b7c8a6a662ef1e5eb8965aa0c4ca2b64f16538ac178b46201292f275f [INFO] running `Command { std: "docker" "start" "-a" "656e090b7c8a6a662ef1e5eb8965aa0c4ca2b64f16538ac178b46201292f275f", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking legion_codegen v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:456:12 [INFO] [stdout] | [INFO] [stdout] 317 | let mut parameters = Vec::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 318 | let mut query = Vec::::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 319 | let mut read_resources = Vec::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 320 | let mut write_resources = Vec::new(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 321 | let mut state_args = Vec::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 456 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 457 | | ident: item.ident.clone(), [INFO] [stdout] 458 | | generics: item.generics.clone(), [INFO] [stdout] 459 | | parameters, [INFO] [stdout] ... | [INFO] [stdout] 463 | | state_args, [INFO] [stdout] 464 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:591:12 [INFO] [stdout] | [INFO] [stdout] 551 | fn parse(attr: SystemAttr, item: &mut ItemFn) -> Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 554 | let mut read_components = Vec::new(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 555 | let mut write_components = Vec::new(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 556 | let mut filters = Vec::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 589 | let signature = Sig::parse(&mut item.sig)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 590 | [INFO] [stdout] 591 | Ok(Config { [INFO] [stdout] | ____________^ [INFO] [stdout] 592 | | attr, [INFO] [stdout] 593 | | visibility: item.vis.clone(), [INFO] [stdout] 594 | | read_components, [INFO] [stdout] ... | [INFO] [stdout] 597 | | signature, [INFO] [stdout] 598 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:456:12 [INFO] [stdout] | [INFO] [stdout] 317 | let mut parameters = Vec::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 318 | let mut query = Vec::::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 319 | let mut read_resources = Vec::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 320 | let mut write_resources = Vec::new(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 321 | let mut state_args = Vec::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 456 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 457 | | ident: item.ident.clone(), [INFO] [stdout] 458 | | generics: item.generics.clone(), [INFO] [stdout] 459 | | parameters, [INFO] [stdout] ... | [INFO] [stdout] 463 | | state_args, [INFO] [stdout] 464 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `legion_codegen` (lib test) due to 3 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:591:12 [INFO] [stdout] | [INFO] [stdout] 551 | fn parse(attr: SystemAttr, item: &mut ItemFn) -> Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 554 | let mut read_components = Vec::new(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 555 | let mut write_components = Vec::new(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 556 | let mut filters = Vec::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 589 | let signature = Sig::parse(&mut item.sig)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 590 | [INFO] [stdout] 591 | Ok(Config { [INFO] [stdout] | ____________^ [INFO] [stdout] 592 | | attr, [INFO] [stdout] 593 | | visibility: item.vis.clone(), [INFO] [stdout] 594 | | read_components, [INFO] [stdout] ... | [INFO] [stdout] 597 | | signature, [INFO] [stdout] 598 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `legion_codegen` (lib) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "656e090b7c8a6a662ef1e5eb8965aa0c4ca2b64f16538ac178b46201292f275f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "656e090b7c8a6a662ef1e5eb8965aa0c4ca2b64f16538ac178b46201292f275f", kill_on_drop: false }` [INFO] [stdout] 656e090b7c8a6a662ef1e5eb8965aa0c4ca2b64f16538ac178b46201292f275f