[INFO] fetching crate learn_rust_bugs 0.1.0... [INFO] checking learn_rust_bugs-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate learn_rust_bugs 0.1.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate learn_rust_bugs 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate learn_rust_bugs 0.1.0 [INFO] finished tweaking crates.io crate learn_rust_bugs 0.1.0 [INFO] tweaked toml for crates.io crate learn_rust_bugs 0.1.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate learn_rust_bugs 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a3e7e9d51c9983449b045d91e984c61e76c872f2e1d907efc0776ae071e80066 [INFO] running `Command { std: "docker" "start" "-a" "a3e7e9d51c9983449b045d91e984c61e76c872f2e1d907efc0776ae071e80066", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a3e7e9d51c9983449b045d91e984c61e76c872f2e1d907efc0776ae071e80066", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a3e7e9d51c9983449b045d91e984c61e76c872f2e1d907efc0776ae071e80066", kill_on_drop: false }` [INFO] [stdout] a3e7e9d51c9983449b045d91e984c61e76c872f2e1d907efc0776ae071e80066 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] deed7d206d5027cf56d196b7c4e831ad848acf81694113add3f7ce13374ee2d3 [INFO] running `Command { std: "docker" "start" "-a" "deed7d206d5027cf56d196b7c4e831ad848acf81694113add3f7ce13374ee2d3", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling libc v0.2.139 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking regex-syntax v0.6.28 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking termcolor v1.2.0 [INFO] [stderr] Checking aho-corasick v0.7.20 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking regex v1.7.1 [INFO] [stderr] Checking env_logger v0.9.3 [INFO] [stderr] Checking learn_rust_bugs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::rc::Rc` [INFO] [stdout] --> src/locks.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::rc::Rc; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::rc::Rc` [INFO] [stdout] --> src/locks.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::rc::Rc; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `post` [INFO] [stdout] --> src/state_pattern/states.rs:6:27 [INFO] [stdout] | [INFO] [stdout] 6 | fn content<'a>(&self, post: &'a Post) -> &'a str { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_post` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `post` [INFO] [stdout] --> src/state_pattern/states.rs:6:27 [INFO] [stdout] | [INFO] [stdout] 6 | fn content<'a>(&self, post: &'a Post) -> &'a str { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_post` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `MyBox` is never constructed [INFO] [stdout] --> src/boxs/deref.rs:3:8 [INFO] [stdout] | [INFO] [stdout] 3 | struct MyBox(T); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/boxs/deref.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 5 | impl MyBox { [INFO] [stdout] | ---------------- associated function in this implementation [INFO] [stdout] 6 | fn new(x: T) -> MyBox { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `mybox_test` is never used [INFO] [stdout] --> src/boxs/deref.rs:18:4 [INFO] [stdout] | [INFO] [stdout] 18 | fn mybox_test() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `0` and `1` are never read [INFO] [stdout] --> src/boxs/linked_list.rs:8:10 [INFO] [stdout] | [INFO] [stdout] 8 | Cons(Rc>, Rc), [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | fields in this variant [INFO] [stdout] | [INFO] [stdout] = note: `List` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the fields to be of unit type to suppress this warning while preserving the field numbering, or remove the fields [INFO] [stdout] | [INFO] [stdout] 8 | Cons((), ()), [INFO] [stdout] | ~~ ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `MessageSender` is never used [INFO] [stdout] --> src/boxs/refcells.rs:4:7 [INFO] [stdout] | [INFO] [stdout] 4 | trait MessageSender { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `LimitChecker` is never constructed [INFO] [stdout] --> src/boxs/refcells.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 8 | struct LimitChecker<'a, T> [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `set_value` are never used [INFO] [stdout] --> src/boxs/refcells.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 17 | / impl<'a, T> LimitChecker<'a, T> [INFO] [stdout] 18 | | where [INFO] [stdout] 19 | | T: MessageSender, [INFO] [stdout] | |_____________________- associated items in this implementation [INFO] [stdout] 20 | { [INFO] [stdout] 21 | pub fn new(message_sender: &'a T, max: usize) -> LimitChecker<'a, T> { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 29 | pub fn set_value(&mut self, value: usize) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `value`, `parent`, and `children` are never read [INFO] [stdout] --> src/boxs/trees.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct Node { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 6 | value: i32, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 7 | parent: RefCell>, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 8 | children: RefCell>>, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Node` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `tree_test` is never used [INFO] [stdout] --> src/boxs/trees.rs:11:4 [INFO] [stdout] | [INFO] [stdout] 11 | fn tree_test() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `state` is never read [INFO] [stdout] --> src/state_pattern.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 3 | struct Post { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 4 | state: Option>, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `add_text`, `request_review`, `approve`, and `content` are never used [INFO] [stdout] --> src/state_pattern.rs:9:12 [INFO] [stdout] | [INFO] [stdout] 8 | impl Post { [INFO] [stdout] | --------- associated items in this implementation [INFO] [stdout] 9 | pub fn new() -> Post { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 15 | pub fn add_text(&mut self, msg: &str) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 18 | pub fn request_review(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 21 | pub fn approve(&mut self) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 24 | pub fn content(&self) -> &str { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `request_review`, `approve`, and `content` are never used [INFO] [stdout] --> src/state_pattern/states.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 3 | pub trait State { [INFO] [stdout] | ----- methods in this trait [INFO] [stdout] 4 | fn request_review(self: Box) -> Box; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 5 | fn approve(self: Box) -> Box; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 6 | fn content<'a>(&self, post: &'a Post) -> &'a str { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static `COUNT` is never used [INFO] [stdout] --> src/unsafes.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 47 | static mut COUNT: u32 = 0; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/locks.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | Err("lock test error".into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/threads.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 35 | let (tx0, rx) = mpsc::channel(); [INFO] [stdout] | --- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let tx1 = tx0.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | [INFO] [stdout] 38 | let h0 = thread::spawn(move || -> Result<(), SendError<&str>> { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let h1 = thread::spawn(move || -> Result<(), SendError<&str>> { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | Err("mpsc test err".into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 15 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `MyBox` is never constructed [INFO] [stdout] --> src/boxs/deref.rs:3:8 [INFO] [stdout] | [INFO] [stdout] 3 | struct MyBox(T); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/boxs/deref.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 5 | impl MyBox { [INFO] [stdout] | ---------------- associated function in this implementation [INFO] [stdout] 6 | fn new(x: T) -> MyBox { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `mybox_test` is never used [INFO] [stdout] --> src/boxs/deref.rs:18:4 [INFO] [stdout] | [INFO] [stdout] 18 | fn mybox_test() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `0` and `1` are never read [INFO] [stdout] --> src/boxs/linked_list.rs:8:10 [INFO] [stdout] | [INFO] [stdout] 8 | Cons(Rc>, Rc), [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | fields in this variant [INFO] [stdout] | [INFO] [stdout] = note: `List` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the fields to be of unit type to suppress this warning while preserving the field numbering, or remove the fields [INFO] [stdout] | [INFO] [stdout] 8 | Cons((), ()), [INFO] [stdout] | ~~ ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `value`, `parent`, and `children` are never read [INFO] [stdout] --> src/boxs/trees.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct Node { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 6 | value: i32, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 7 | parent: RefCell>, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 8 | children: RefCell>>, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Node` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `tree_test` is never used [INFO] [stdout] --> src/boxs/trees.rs:11:4 [INFO] [stdout] | [INFO] [stdout] 11 | fn tree_test() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static `COUNT` is never used [INFO] [stdout] --> src/unsafes.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 47 | static mut COUNT: u32 = 0; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `learn_rust_bugs` (lib) due to 3 previous errors; 15 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/locks.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | Err("lock test error".into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/threads.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 35 | let (tx0, rx) = mpsc::channel(); [INFO] [stdout] | --- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let tx1 = tx0.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | [INFO] [stdout] 38 | let h0 = thread::spawn(move || -> Result<(), SendError<&str>> { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let h1 = thread::spawn(move || -> Result<(), SendError<&str>> { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | Err("mpsc test err".into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `learn_rust_bugs` (lib test) due to 3 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "deed7d206d5027cf56d196b7c4e831ad848acf81694113add3f7ce13374ee2d3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "deed7d206d5027cf56d196b7c4e831ad848acf81694113add3f7ce13374ee2d3", kill_on_drop: false }` [INFO] [stdout] deed7d206d5027cf56d196b7c4e831ad848acf81694113add3f7ce13374ee2d3