[INFO] fetching crate lc-render 0.2.3... [INFO] checking lc-render-0.2.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate lc-render 0.2.3 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate lc-render 0.2.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate lc-render 0.2.3 [INFO] finished tweaking crates.io crate lc-render 0.2.3 [INFO] tweaked toml for crates.io crate lc-render 0.2.3 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate lc-render 0.2.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 64294da1b981b65ea74afa8d82d09dc30793dbdbab7173986d7504d59d4d5013 [INFO] running `Command { std: "docker" "start" "-a" "64294da1b981b65ea74afa8d82d09dc30793dbdbab7173986d7504d59d4d5013", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "64294da1b981b65ea74afa8d82d09dc30793dbdbab7173986d7504d59d4d5013", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "64294da1b981b65ea74afa8d82d09dc30793dbdbab7173986d7504d59d4d5013", kill_on_drop: false }` [INFO] [stdout] 64294da1b981b65ea74afa8d82d09dc30793dbdbab7173986d7504d59d4d5013 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 261538bbbec8efffbcafbf29332180a65253bef0207f0e9a5f7d4a5654457320 [INFO] running `Command { std: "docker" "start" "-a" "261538bbbec8efffbcafbf29332180a65253bef0207f0e9a5f7d4a5654457320", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling serde v1.0.126 [INFO] [stderr] Compiling libc v0.2.94 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Compiling proc-macro2 v1.0.26 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Compiling rayon-core v1.9.0 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling serde_json v1.0.64 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Compiling syn v1.0.72 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking plotters-backend v0.3.0 [INFO] [stderr] Compiling serde_derive v1.0.126 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking itertools v0.10.0 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Compiling crossbeam-utils v0.8.4 [INFO] [stderr] Compiling memoffset v0.6.3 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Compiling rayon v1.5.0 [INFO] [stderr] Checking plotters-svg v0.3.0 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking half v1.7.1 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking svg v0.9.1 [INFO] [stderr] Compiling cast v0.2.5 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking crossbeam-epoch v0.9.4 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Checking criterion-plot v0.4.3 [INFO] [stderr] Checking crossbeam-deque v0.8.0 [INFO] [stderr] Checking plotters v0.3.0 [INFO] [stderr] Checking lc-render v0.2.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/shape/bar.rs:163:40 [INFO] [stdout] | [INFO] [stdout] 163 | Orientation::Horizontal => (X_ATTR), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 163 - Orientation::Horizontal => (X_ATTR), [INFO] [stdout] 163 + Orientation::Horizontal => X_ATTR, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/shape/bar.rs:164:38 [INFO] [stdout] | [INFO] [stdout] 164 | Orientation::Vertical => (Y_ATTR), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 164 - Orientation::Vertical => (Y_ATTR), [INFO] [stdout] 164 + Orientation::Vertical => Y_ATTR, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/shape/bar.rs:167:40 [INFO] [stdout] | [INFO] [stdout] 167 | Orientation::Horizontal => (Y_ATTR), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 167 - Orientation::Horizontal => (Y_ATTR), [INFO] [stdout] 167 + Orientation::Horizontal => Y_ATTR, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/shape/bar.rs:168:38 [INFO] [stdout] | [INFO] [stdout] 168 | Orientation::Vertical => (X_ATTR), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 168 - Orientation::Vertical => (X_ATTR), [INFO] [stdout] 168 + Orientation::Vertical => X_ATTR, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/shape/bar.rs:171:40 [INFO] [stdout] | [INFO] [stdout] 171 | Orientation::Horizontal => (WIDTH_ATTR), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 171 - Orientation::Horizontal => (WIDTH_ATTR), [INFO] [stdout] 171 + Orientation::Horizontal => WIDTH_ATTR, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/shape/bar.rs:172:38 [INFO] [stdout] | [INFO] [stdout] 172 | Orientation::Vertical => (HEIGHT_ATTR), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 172 - Orientation::Vertical => (HEIGHT_ATTR), [INFO] [stdout] 172 + Orientation::Vertical => HEIGHT_ATTR, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/shape/bar.rs:175:40 [INFO] [stdout] | [INFO] [stdout] 175 | Orientation::Horizontal => (HEIGHT_ATTR), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 175 - Orientation::Horizontal => (HEIGHT_ATTR), [INFO] [stdout] 175 + Orientation::Horizontal => HEIGHT_ATTR, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/shape/bar.rs:176:38 [INFO] [stdout] | [INFO] [stdout] 176 | Orientation::Vertical => (WIDTH_ATTR), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 176 - Orientation::Vertical => (WIDTH_ATTR), [INFO] [stdout] 176 + Orientation::Vertical => WIDTH_ATTR, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chart.rs:310:9 [INFO] [stdout] | [INFO] [stdout] 240 | let mut res = svg::node::element::Group::new().set(CLASS_ATTR, CLASS_CHART); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 277 | let mut views_group = svg::node::element::Group::new() [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 310 | / svg::Document::new() [INFO] [stdout] 311 | | .set(WIDTH_ATTR, self.width) [INFO] [stdout] 312 | | .set(HEIGHT_ATTR, self.height) [INFO] [stdout] 313 | | .set(VIEW_BOX_ATTR, (START, START, self.width, self.height)) [INFO] [stdout] | |________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lc-render` (lib) due to 2 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "261538bbbec8efffbcafbf29332180a65253bef0207f0e9a5f7d4a5654457320", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "261538bbbec8efffbcafbf29332180a65253bef0207f0e9a5f7d4a5654457320", kill_on_drop: false }` [INFO] [stdout] 261538bbbec8efffbcafbf29332180a65253bef0207f0e9a5f7d4a5654457320