[INFO] fetching crate lazyjj 0.3.1... [INFO] checking lazyjj-0.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate lazyjj 0.3.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate lazyjj 0.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate lazyjj 0.3.1 [INFO] finished tweaking crates.io crate lazyjj 0.3.1 [INFO] tweaked toml for crates.io crate lazyjj 0.3.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate lazyjj 0.3.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 06c70a56ead691cd3c528e73ea2592fe1ab366afab42d898922b7698a117e294 [INFO] running `Command { std: "docker" "start" "-a" "06c70a56ead691cd3c528e73ea2592fe1ab366afab42d898922b7698a117e294", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "06c70a56ead691cd3c528e73ea2592fe1ab366afab42d898922b7698a117e294", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "06c70a56ead691cd3c528e73ea2592fe1ab366afab42d898922b7698a117e294", kill_on_drop: false }` [INFO] [stdout] 06c70a56ead691cd3c528e73ea2592fe1ab366afab42d898922b7698a117e294 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c635217562c572194e83a37ea7f1fe54ffaafd036495f54e215535ea5b204e07 [INFO] running `Command { std: "docker" "start" "-a" "c635217562c572194e83a37ea7f1fe54ffaafd036495f54e215535ea5b204e07", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Checking zerocopy v0.7.34 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Checking castaway v0.2.2 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking winnow v0.6.13 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking similar v2.5.0 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking simdutf8 v0.1.4 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking clap_builder v4.5.7 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Checking lru v0.12.3 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking unicode-truncate v1.0.0 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking insta v1.39.0 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling stability v0.2.0 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling clap_derive v4.5.5 [INFO] [stderr] Checking thiserror v1.0.61 [INFO] [stderr] Checking clap v4.5.7 [INFO] [stderr] Checking strum v0.26.2 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking compact_str v0.7.1 [INFO] [stderr] Checking serde_spanned v0.6.6 [INFO] [stderr] Checking toml_datetime v0.6.6 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking toml_edit v0.22.14 [INFO] [stderr] Checking ratatui v0.26.3 [INFO] [stderr] Checking toml v0.8.14 [INFO] [stderr] Checking tui-textarea v0.4.0 [INFO] [stderr] Checking ansi-to-tui v4.0.1 [INFO] [stderr] Checking tui_confirm_dialog v0.2.1 [INFO] [stderr] Checking lazyjj v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: variant `Multiple` is never constructed [INFO] [stdout] --> src/ui/mod.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 26 | pub enum ComponentAction { [INFO] [stdout] | --------------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 31 | Multiple(Vec), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:97:27 [INFO] [stdout] | [INFO] [stdout] 97 | terminal.draw(|f| ui(f, app).unwrap())?; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 51 | Ok(App { [INFO] [stdout] | ____________^ [INFO] [stdout] 52 | | env, [INFO] [stdout] 53 | | current_tab: Tab::Log, [INFO] [stdout] 54 | | log: LogTab::new(commander)?, [INFO] [stdout] ... | [INFO] [stdout] 58 | | popup: None, [INFO] [stdout] 59 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commander/log.rs:56:17 [INFO] [stdout] | [INFO] [stdout] 53 | let captured = HEAD_TEMPLATE_REGEX.captures(text); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | .map_or(Err(anyhow!(HeadParseError(text.to_owned()))), |captured| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commander/log.rs:113:25 [INFO] [stdout] | [INFO] [stdout] 113 | .map(|line| parse_head(line).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/branches_tab.rs:129:12 [INFO] [stdout] | [INFO] [stdout] 110 | let branches_output = commander.get_branches(show_all); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | let branch_output = branch.as_ref().and_then(|branch| match branch { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | let (popup_tx, popup_rx) = std::sync::mpsc::channel(); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | [INFO] [stdout] 129 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 130 | | branches_output, [INFO] [stdout] 131 | | branch, [INFO] [stdout] 132 | | branches_list_state, [INFO] [stdout] ... | [INFO] [stdout] 155 | | config: commander.env.config.clone(), [INFO] [stdout] 156 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/command_log_tab.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 30 | let command_history = commander.command_history.clone(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 35 | | commands_height: 0, [INFO] [stdout] 36 | | commands_list_state, [INFO] [stdout] 37 | | command_history, [INFO] [stdout] 38 | | output_panel: DetailsPanel::new(), [INFO] [stdout] 39 | | config: commander.env.config.clone(), [INFO] [stdout] 40 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/files_tab.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 58 | let files_output = commander.get_files(&head); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | let diff_output = current_file [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 75 | | head, [INFO] [stdout] 76 | | is_current_head, [INFO] [stdout] ... | [INFO] [stdout] 89 | | config: commander.env.config.clone(), [INFO] [stdout] 90 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/log_tab.rs:90:12 [INFO] [stdout] | [INFO] [stdout] 80 | let log_output = commander.get_log(&log_revset); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | let head_output = commander.get_commit_show(&head.commit_id, &diff_format); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | [INFO] [stdout] 87 | let (popup_tx, popup_rx) = std::sync::mpsc::channel(); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | let (branch_set_popup_tx, branch_set_popup_rx) = std::sync::mpsc::channel(); [INFO] [stdout] | ------------------- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | [INFO] [stdout] 90 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 91 | | log_output_text: match log_output.as_ref() { [INFO] [stdout] 92 | | Ok(log_output) => log_output [INFO] [stdout] 93 | | .graph [INFO] [stdout] ... | [INFO] [stdout] 121 | | config: commander.env.config.clone(), [INFO] [stdout] 122 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/log_tab.rs:236:12 [INFO] [stdout] | [INFO] [stdout] 236 | Ok(None) [INFO] [stdout] | ^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Multiple` is never constructed [INFO] [stdout] --> src/ui/mod.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 26 | pub enum ComponentAction { [INFO] [stdout] | --------------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 31 | Multiple(Vec), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:97:27 [INFO] [stdout] | [INFO] [stdout] 97 | terminal.draw(|f| ui(f, app).unwrap())?; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 51 | Ok(App { [INFO] [stdout] | ____________^ [INFO] [stdout] 52 | | env, [INFO] [stdout] 53 | | current_tab: Tab::Log, [INFO] [stdout] 54 | | log: LogTab::new(commander)?, [INFO] [stdout] ... | [INFO] [stdout] 58 | | popup: None, [INFO] [stdout] 59 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commander/log.rs:56:17 [INFO] [stdout] | [INFO] [stdout] 53 | let captured = HEAD_TEMPLATE_REGEX.captures(text); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | .map_or(Err(anyhow!(HeadParseError(text.to_owned()))), |captured| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commander/log.rs:113:25 [INFO] [stdout] | [INFO] [stdout] 113 | .map(|line| parse_head(line).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commander/mod.rs:253:16 [INFO] [stdout] | [INFO] [stdout] 225 | let directory = TempDir::new("lazyjj")?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 248 | let mut commander = Commander::new(&env); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 253 | Ok(Self { [INFO] [stdout] | ________________^ [INFO] [stdout] 254 | | directory, [INFO] [stdout] 255 | | commander, [INFO] [stdout] 256 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/branches_tab.rs:129:12 [INFO] [stdout] | [INFO] [stdout] 110 | let branches_output = commander.get_branches(show_all); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | let branch_output = branch.as_ref().and_then(|branch| match branch { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | let (popup_tx, popup_rx) = std::sync::mpsc::channel(); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | [INFO] [stdout] 129 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 130 | | branches_output, [INFO] [stdout] 131 | | branch, [INFO] [stdout] 132 | | branches_list_state, [INFO] [stdout] ... | [INFO] [stdout] 155 | | config: commander.env.config.clone(), [INFO] [stdout] 156 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/command_log_tab.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 30 | let command_history = commander.command_history.clone(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 35 | | commands_height: 0, [INFO] [stdout] 36 | | commands_list_state, [INFO] [stdout] 37 | | command_history, [INFO] [stdout] 38 | | output_panel: DetailsPanel::new(), [INFO] [stdout] 39 | | config: commander.env.config.clone(), [INFO] [stdout] 40 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/files_tab.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 58 | let files_output = commander.get_files(&head); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | let diff_output = current_file [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 75 | | head, [INFO] [stdout] 76 | | is_current_head, [INFO] [stdout] ... | [INFO] [stdout] 89 | | config: commander.env.config.clone(), [INFO] [stdout] 90 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/log_tab.rs:90:12 [INFO] [stdout] | [INFO] [stdout] 80 | let log_output = commander.get_log(&log_revset); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | let head_output = commander.get_commit_show(&head.commit_id, &diff_format); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | [INFO] [stdout] 87 | let (popup_tx, popup_rx) = std::sync::mpsc::channel(); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | let (branch_set_popup_tx, branch_set_popup_rx) = std::sync::mpsc::channel(); [INFO] [stdout] | ------------------- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | [INFO] [stdout] 90 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 91 | | log_output_text: match log_output.as_ref() { [INFO] [stdout] 92 | | Ok(log_output) => log_output [INFO] [stdout] 93 | | .graph [INFO] [stdout] ... | [INFO] [stdout] 121 | | config: commander.env.config.clone(), [INFO] [stdout] 122 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/log_tab.rs:236:12 [INFO] [stdout] | [INFO] [stdout] 236 | Ok(None) [INFO] [stdout] | ^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lazyjj` (bin "lazyjj") due to 10 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 10 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lazyjj` (bin "lazyjj" test) due to 11 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "c635217562c572194e83a37ea7f1fe54ffaafd036495f54e215535ea5b204e07", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c635217562c572194e83a37ea7f1fe54ffaafd036495f54e215535ea5b204e07", kill_on_drop: false }` [INFO] [stdout] c635217562c572194e83a37ea7f1fe54ffaafd036495f54e215535ea5b204e07