[INFO] fetching crate lazy-pregen 0.1.4... [INFO] checking lazy-pregen-0.1.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate lazy-pregen 0.1.4 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate lazy-pregen 0.1.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate lazy-pregen 0.1.4 [INFO] finished tweaking crates.io crate lazy-pregen 0.1.4 [INFO] tweaked toml for crates.io crate lazy-pregen 0.1.4 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 75 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding fern v0.5.9 (latest: v0.6.2) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding strsim v0.8.0 (latest: v0.11.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding synstructure v0.12.6 (latest: v0.13.1) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding toml v0.4.10 (latest: v0.8.19) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 62beee03585e45838478f172c5482642febe6658bf04d1f7a6e87961b87bafdc [INFO] running `Command { std: "docker" "start" "-a" "62beee03585e45838478f172c5482642febe6658bf04d1f7a6e87961b87bafdc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "62beee03585e45838478f172c5482642febe6658bf04d1f7a6e87961b87bafdc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "62beee03585e45838478f172c5482642febe6658bf04d1f7a6e87961b87bafdc", kill_on_drop: false }` [INFO] [stdout] 62beee03585e45838478f172c5482642febe6658bf04d1f7a6e87961b87bafdc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f1174d12900a0f04d183597a23feb9be3aa2f382033ab761ac77a6261a015302 [INFO] running `Command { std: "docker" "start" "-a" "f1174d12900a0f04d183597a23feb9be3aa2f382033ab761ac77a6261a015302", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Compiling unicode-xid v0.2.5 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking toml v0.4.10 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking fern v0.5.9 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Checking ctrlc v3.4.5 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking lazy-pregen v0.1.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `stdout_join` and `stderr_join` are never read [INFO] [stdout] --> src/main.rs:122:5 [INFO] [stdout] | [INFO] [stdout] 120 | struct TextStream { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 121 | receiver: Receiver, [INFO] [stdout] 122 | stdout_join: JoinHandle<()>, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 123 | stderr_join: JoinHandle<()>, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TextStream` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/main.rs:198:12 [INFO] [stdout] | [INFO] [stdout] 198 | Stderr(String), [INFO] [stdout] | ------ ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Text` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 198 | Stderr(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:139:12 [INFO] [stdout] | [INFO] [stdout] 130 | pub fn new(stdout_source: Receiver, stderr_source: Receiver) -> IoResult { [INFO] [stdout] | ------------------------------------ ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | // Create a receiver so each line can be received, then a sender for each thread. [INFO] [stdout] 132 | let (stdout_sender, receiver) = mpsc::channel(); [INFO] [stdout] | ------------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | let stderr_sender = stdout_sender.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | let stdout_join = ThreadBuilder::new().spawn(Self::remote_reader(stdout_source, Text::Stdout, stdout_sender))?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | let stderr_join = ThreadBuilder::new().spawn(Self::remote_reader(stderr_source, Text::Stderr, stderr_sender))?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | [INFO] [stdout] 139 | Ok(TextStream { [INFO] [stdout] | ____________^ [INFO] [stdout] 140 | | receiver, [INFO] [stdout] 141 | | stdout_join, [INFO] [stdout] 142 | | stderr_join [INFO] [stdout] 143 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `stdout_join` and `stderr_join` are never read [INFO] [stdout] --> src/main.rs:122:5 [INFO] [stdout] | [INFO] [stdout] 120 | struct TextStream { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 121 | receiver: Receiver, [INFO] [stdout] 122 | stdout_join: JoinHandle<()>, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 123 | stderr_join: JoinHandle<()>, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TextStream` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/main.rs:198:12 [INFO] [stdout] | [INFO] [stdout] 198 | Stderr(String), [INFO] [stdout] | ------ ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Text` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 198 | Stderr(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:139:12 [INFO] [stdout] | [INFO] [stdout] 130 | pub fn new(stdout_source: Receiver, stderr_source: Receiver) -> IoResult { [INFO] [stdout] | ------------------------------------ ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | // Create a receiver so each line can be received, then a sender for each thread. [INFO] [stdout] 132 | let (stdout_sender, receiver) = mpsc::channel(); [INFO] [stdout] | ------------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | let stderr_sender = stdout_sender.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | let stdout_join = ThreadBuilder::new().spawn(Self::remote_reader(stdout_source, Text::Stdout, stdout_sender))?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | let stderr_join = ThreadBuilder::new().spawn(Self::remote_reader(stderr_source, Text::Stderr, stderr_sender))?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | [INFO] [stdout] 139 | Ok(TextStream { [INFO] [stdout] | ____________^ [INFO] [stdout] 140 | | receiver, [INFO] [stdout] 141 | | stdout_join, [INFO] [stdout] 142 | | stderr_join [INFO] [stdout] 143 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:155:19 [INFO] [stdout] | [INFO] [stdout] 149 | fn remote_reader(reader_source: Receiver, mut make_text: F, text_output: Sender) -> impl FnOnce() -> () [INFO] [stdout] | ------------- --------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | match reader_source.recv() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method call resolves to `<&[T; N] as IntoIterator>::into_iter` (due to backwards compatibility), but will resolve to `<[T; N] as IntoIterator>::into_iter` in Rust 2021 [INFO] [stdout] --> src/main.rs:802:77 [INFO] [stdout] | [INFO] [stdout] 802 | .args([&xmx_arg, "-jar", &config.resources.server, "nogui"].into_iter()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(array_into_iter)]` on by default [INFO] [stdout] help: use `.iter()` instead of `.into_iter()` to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 802 | .args([&xmx_arg, "-jar", &config.resources.server, "nogui"].iter()) [INFO] [stdout] | ~~~~ [INFO] [stdout] help: or use `IntoIterator::into_iter(..)` instead of `.into_iter()` to explicitly iterate by value [INFO] [stdout] | [INFO] [stdout] 802 | .args(IntoIterator::into_iter([&xmx_arg, "-jar", &config.resources.server, "nogui"])) [INFO] [stdout] | ++++++++++++++++++++++++ ~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:155:19 [INFO] [stdout] | [INFO] [stdout] 149 | fn remote_reader(reader_source: Receiver, mut make_text: F, text_output: Sender) -> impl FnOnce() -> () [INFO] [stdout] | ------------- --------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | match reader_source.recv() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method call resolves to `<&[T; N] as IntoIterator>::into_iter` (due to backwards compatibility), but will resolve to `<[T; N] as IntoIterator>::into_iter` in Rust 2021 [INFO] [stdout] --> src/main.rs:802:77 [INFO] [stdout] | [INFO] [stdout] 802 | .args([&xmx_arg, "-jar", &config.resources.server, "nogui"].into_iter()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(array_into_iter)]` on by default [INFO] [stdout] help: use `.iter()` instead of `.into_iter()` to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 802 | .args([&xmx_arg, "-jar", &config.resources.server, "nogui"].iter()) [INFO] [stdout] | ~~~~ [INFO] [stdout] help: or use `IntoIterator::into_iter(..)` instead of `.into_iter()` to explicitly iterate by value [INFO] [stdout] | [INFO] [stdout] 802 | .args(IntoIterator::into_iter([&xmx_arg, "-jar", &config.resources.server, "nogui"])) [INFO] [stdout] | ++++++++++++++++++++++++ ~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lazy-pregen` (bin "lazy-pregen") due to 3 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `lazy-pregen` (bin "lazy-pregen" test) due to 3 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "f1174d12900a0f04d183597a23feb9be3aa2f382033ab761ac77a6261a015302", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f1174d12900a0f04d183597a23feb9be3aa2f382033ab761ac77a6261a015302", kill_on_drop: false }` [INFO] [stdout] f1174d12900a0f04d183597a23feb9be3aa2f382033ab761ac77a6261a015302