[INFO] fetching crate las 0.9.1... [INFO] checking las-0.9.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate las 0.9.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate las 0.9.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate las 0.9.1 [INFO] removed 0 missing examples [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate las 0.9.1 [INFO] tweaked toml for crates.io crate las 0.9.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate las 0.9.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 16346d3c34b4f07fd8efc5fe7f6ff9498a2cc7206b029048120a12401975a608 [INFO] running `Command { std: "docker" "start" "-a" "16346d3c34b4f07fd8efc5fe7f6ff9498a2cc7206b029048120a12401975a608", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "16346d3c34b4f07fd8efc5fe7f6ff9498a2cc7206b029048120a12401975a608", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "16346d3c34b4f07fd8efc5fe7f6ff9498a2cc7206b029048120a12401975a608", kill_on_drop: false }` [INFO] [stdout] 16346d3c34b4f07fd8efc5fe7f6ff9498a2cc7206b029048120a12401975a608 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bb88270ad6f44ce2ee55e4d9deeda4785e90ca7253d03ba3be90576d22d5a438 [INFO] running `Command { std: "docker" "start" "-a" "bb88270ad6f44ce2ee55e4d9deeda4785e90ca7253d03ba3be90576d22d5a438", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.74 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling serde v1.0.208 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling serde_json v1.0.125 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking clap v4.5.15 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Compiling serde_derive v1.0.208 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking las v0.9.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/header/mod.rs:705:9 [INFO] [stdout] | [INFO] [stdout] 704 | fn from(version: V) -> Header { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 705 | / Builder::from(version) [INFO] [stdout] 706 | | .into_header() [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader/mod.rs:285:9 [INFO] [stdout] | [INFO] [stdout] 284 | pub fn from_path>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 285 | / File::open(path) [INFO] [stdout] 286 | | .map_err(Error::from) [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader/mod.rs:287:42 [INFO] [stdout] | [INFO] [stdout] 287 | .and_then(|file| Reader::new(BufReader::new(file))) [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader/las.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 13 | pub(crate) fn new(mut read: R, header: Header) -> Result> { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | Ok(PointReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 15 | | start: read.stream_position()?, [INFO] [stdout] 16 | | read, [INFO] [stdout] 17 | | header, [INFO] [stdout] 18 | | index: 0, [INFO] [stdout] 19 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer/mod.rs:339:9 [INFO] [stdout] | [INFO] [stdout] 323 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 339 | / File::create(path) [INFO] [stdout] 340 | | .map_err(Error::from) [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer/mod.rs:341:42 [INFO] [stdout] | [INFO] [stdout] 341 | .and_then(|file| Writer::new(BufWriter::new(file), header)) [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `las` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "bb88270ad6f44ce2ee55e4d9deeda4785e90ca7253d03ba3be90576d22d5a438", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bb88270ad6f44ce2ee55e4d9deeda4785e90ca7253d03ba3be90576d22d5a438", kill_on_drop: false }` [INFO] [stdout] bb88270ad6f44ce2ee55e4d9deeda4785e90ca7253d03ba3be90576d22d5a438