[INFO] fetching crate landmass 0.6.0... [INFO] checking landmass-0.6.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate landmass 0.6.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate landmass 0.6.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate landmass 0.6.0 [INFO] finished tweaking crates.io crate landmass 0.6.0 [INFO] tweaked toml for crates.io crate landmass 0.6.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 50 packages to latest compatible versions [INFO] [stderr] Adding glam v0.28.0 (latest: v0.29.0) [INFO] [stderr] Adding itertools v0.11.0 (latest: v0.13.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3c654c38973b2605c3af69d8ae7d1d6cf48d5c215677434417b029ceb761b437 [INFO] running `Command { std: "docker" "start" "-a" "3c654c38973b2605c3af69d8ae7d1d6cf48d5c215677434417b029ceb761b437", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3c654c38973b2605c3af69d8ae7d1d6cf48d5c215677434417b029ceb761b437", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3c654c38973b2605c3af69d8ae7d1d6cf48d5c215677434417b029ceb761b437", kill_on_drop: false }` [INFO] [stdout] 3c654c38973b2605c3af69d8ae7d1d6cf48d5c215677434417b029ceb761b437 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b25604c0ac925cea27f1f6d3a924e9df4b4b368ee9e5188fe86b1cd58e093f26 [INFO] running `Command { std: "docker" "start" "-a" "b25604c0ac925cea27f1f6d3a924e9df4b4b368ee9e5188fe86b1cd58e093f26", kill_on_drop: false }` [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling heapless v0.8.0 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking robust v1.1.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling slotmap v1.0.7 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking glam v0.28.0 [INFO] [stderr] Checking float_next_after v1.0.0 [INFO] [stderr] Checking disjoint v0.8.0 [INFO] [stderr] Checking ord_subset v3.1.1 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking hash32 v0.3.1 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking geographiclib-rs v0.2.4 [INFO] [stderr] Checking rstar v0.12.0 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking earcutr v0.4.3 [INFO] [stderr] Checking geo-types v0.7.13 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking kdtree v0.7.0 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking spade v2.12.0 [INFO] [stderr] Checking dodgy_2d v0.5.2 [INFO] [stderr] Checking geo v0.28.0 [INFO] [stderr] Checking landmass v0.6.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/agent.rs:118:23 [INFO] [stdout] | [INFO] [stdout] 106 | position: CS::Coordinate, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | velocity: CS::Coordinate, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | current_target: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/agent.rs:122:29 [INFO] [stdout] | [INFO] [stdout] 106 | position: CS::Coordinate, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | velocity: CS::Coordinate, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | current_desired_move: CS::from_landmass(&Vec3::ZERO), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/astar.rs:205:29 [INFO] [stdout] | [INFO] [stdout] 131 | let mut best_estimates = HashMap::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | [INFO] [stdout] 133 | let mut all_nodes = Vec::>::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | let initial_node = [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 205 | PathResult { stats, path: None } [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/avoidance.rs:405:3 [INFO] [stdout] | [INFO] [stdout] 195 | let mut explored_nodes = HashSet::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 405 | / finished_loops [INFO] [stdout] 406 | | .drain(..) [INFO] [stdout] 407 | | .map(|looop| dodgy_2d::Obstacle::Closed { [INFO] [stdout] 408 | | vertices: looop [INFO] [stdout] ... | [INFO] [stdout] 423 | | } [INFO] [stdout] 424 | | })) [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nav_mesh.rs:256:8 [INFO] [stdout] | [INFO] [stdout] 76 | mut self, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 192 | let mut used_type_indices = HashSet::new(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 256 | Ok(ValidNavigationMesh { [INFO] [stdout] | ________^ [INFO] [stdout] 257 | | mesh_bounds, [INFO] [stdout] 258 | | polygons, [INFO] [stdout] 259 | | vertices, [INFO] [stdout] ... | [INFO] [stdout] 262 | | marker: Default::default(), [INFO] [stdout] 263 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/query.rs:84:6 [INFO] [stdout] | [INFO] [stdout] 68 | point: CS::Coordinate, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | Ok(SampledPoint { [INFO] [stdout] | ______^ [INFO] [stdout] 85 | | point: CS::from_landmass(&point), [INFO] [stdout] 86 | | node_ref, [INFO] [stdout] 87 | | node_type: island.type_index_to_node_type.get(&type_index).copied(), [INFO] [stdout] 88 | | marker: PhantomData, [INFO] [stdout] 89 | | }) [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `landmass` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/agent.rs:118:23 [INFO] [stdout] | [INFO] [stdout] 106 | position: CS::Coordinate, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | velocity: CS::Coordinate, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | current_target: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/agent.rs:122:29 [INFO] [stdout] | [INFO] [stdout] 106 | position: CS::Coordinate, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | velocity: CS::Coordinate, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | current_desired_move: CS::from_landmass(&Vec3::ZERO), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/astar.rs:205:29 [INFO] [stdout] | [INFO] [stdout] 131 | let mut best_estimates = HashMap::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | [INFO] [stdout] 133 | let mut all_nodes = Vec::>::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | let initial_node = [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 205 | PathResult { stats, path: None } [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/avoidance.rs:405:3 [INFO] [stdout] | [INFO] [stdout] 195 | let mut explored_nodes = HashSet::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 405 | / finished_loops [INFO] [stdout] 406 | | .drain(..) [INFO] [stdout] 407 | | .map(|looop| dodgy_2d::Obstacle::Closed { [INFO] [stdout] 408 | | vertices: looop [INFO] [stdout] ... | [INFO] [stdout] 423 | | } [INFO] [stdout] 424 | | })) [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nav_mesh.rs:256:8 [INFO] [stdout] | [INFO] [stdout] 76 | mut self, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 192 | let mut used_type_indices = HashSet::new(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 256 | Ok(ValidNavigationMesh { [INFO] [stdout] | ________^ [INFO] [stdout] 257 | | mesh_bounds, [INFO] [stdout] 258 | | polygons, [INFO] [stdout] 259 | | vertices, [INFO] [stdout] ... | [INFO] [stdout] 262 | | marker: Default::default(), [INFO] [stdout] 263 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/query.rs:84:6 [INFO] [stdout] | [INFO] [stdout] 68 | point: CS::Coordinate, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | Ok(SampledPoint { [INFO] [stdout] | ______^ [INFO] [stdout] 85 | | point: CS::from_landmass(&point), [INFO] [stdout] 86 | | node_ref, [INFO] [stdout] 87 | | node_type: island.type_index_to_node_type.get(&type_index).copied(), [INFO] [stdout] 88 | | marker: PhantomData, [INFO] [stdout] 89 | | }) [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `landmass` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "b25604c0ac925cea27f1f6d3a924e9df4b4b368ee9e5188fe86b1cd58e093f26", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b25604c0ac925cea27f1f6d3a924e9df4b4b368ee9e5188fe86b1cd58e093f26", kill_on_drop: false }` [INFO] [stdout] b25604c0ac925cea27f1f6d3a924e9df4b4b368ee9e5188fe86b1cd58e093f26