[INFO] fetching crate lance-core 0.16.1... [INFO] checking lance-core-0.16.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate lance-core 0.16.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate lance-core 0.16.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate lance-core 0.16.1 [INFO] finished tweaking crates.io crate lance-core 0.16.1 [INFO] tweaked toml for crates.io crate lance-core 0.16.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 258 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding async-io v1.13.0 (latest: v2.3.4) [INFO] [stderr] Adding async-lock v2.8.0 (latest: v3.4.0) [INFO] [stderr] Adding bit-set v0.5.3 (latest: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cargo_metadata v0.14.2 (latest: v0.18.1) [INFO] [stderr] Adding datafusion-common v40.0.0 (latest: v41.0.0) [INFO] [stderr] Adding datafusion-expr v40.0.0 (latest: v41.0.0) [INFO] [stderr] Adding datafusion-sql v40.0.0 (latest: v41.0.0) [INFO] [stderr] Adding event-listener v2.5.3 (latest: v5.3.1) [INFO] [stderr] Adding fastrand v1.9.0 (latest: v2.1.1) [INFO] [stderr] Adding futures-lite v1.13.0 (latest: v2.3.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding io-lifetimes v1.0.11 (latest: v2.0.3) [INFO] [stderr] Adding itertools v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.3.8 (latest: v0.6.5) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding mock_instant v0.3.2 (latest: v0.5.1) [INFO] [stderr] Adding moka v0.11.3 (latest: v0.12.8) [INFO] [stderr] Adding object_store v0.10.2 (latest: v0.11.0) [INFO] [stderr] Adding polling v2.8.0 (latest: v3.7.3) [INFO] [stderr] Adding prost v0.12.6 (latest: v0.13.2) [INFO] [stderr] Adding prost-derive v0.12.6 (latest: v0.13.2) [INFO] [stderr] Adding pulldown-cmark v0.9.6 (latest: v0.12.0) [INFO] [stderr] Adding quanta v0.11.1 (latest: v0.12.3) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding raw-cpuid v10.7.0 (latest: v11.1.0) [INFO] [stderr] Adding rustix v0.37.27 (latest: v0.38.35) [INFO] [stderr] Adding siphasher v0.3.11 (latest: v1.0.1) [INFO] [stderr] Adding snafu v0.7.5 (latest: v0.8.4) [INFO] [stderr] Adding snafu-derive v0.7.5 (latest: v0.8.4) [INFO] [stderr] Adding socket2 v0.4.10 (latest: v0.5.7) [INFO] [stderr] Adding sqlparser v0.47.0 (latest: v0.50.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c2ed2eb8463821486e4f2072b3123eb2f1d5bcfd8a2e0f1259e9f8290296125b [INFO] running `Command { std: "docker" "start" "-a" "c2ed2eb8463821486e4f2072b3123eb2f1d5bcfd8a2e0f1259e9f8290296125b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c2ed2eb8463821486e4f2072b3123eb2f1d5bcfd8a2e0f1259e9f8290296125b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c2ed2eb8463821486e4f2072b3123eb2f1d5bcfd8a2e0f1259e9f8290296125b", kill_on_drop: false }` [INFO] [stdout] c2ed2eb8463821486e4f2072b3123eb2f1d5bcfd8a2e0f1259e9f8290296125b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9826887377df868d8b7f0ff24fab4e32ced86040d6e70ef6696a5adde2890be4 [INFO] running `Command { std: "docker" "start" "-a" "9826887377df868d8b7f0ff24fab4e32ced86040d6e70ef6696a5adde2890be4", kill_on_drop: false }` [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking lexical-util v0.8.5 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking arrow-schema v52.2.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling polling v2.8.0 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Compiling rustix v0.37.27 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling async-io v1.13.0 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Checking waker-fn v1.2.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking fastrand v1.9.0 [INFO] [stderr] Checking lexical-parse-integer v0.8.6 [INFO] [stderr] Checking lexical-write-integer v0.8.5 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Checking lexical-write-float v0.8.5 [INFO] [stderr] Checking async-lock v2.8.0 [INFO] [stderr] Checking lexical-parse-float v0.8.5 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking raw-cpuid v10.7.0 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Compiling moka v0.11.3 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking scheduled-thread-pool v0.2.7 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking lexical-core v0.8.5 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Checking triomphe v0.1.13 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking tagptr v0.2.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking prost v0.12.6 [INFO] [stderr] Checking rand_xorshift v0.3.0 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking roaring v0.10.6 [INFO] [stderr] Checking mock_instant v0.3.2 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking unarray v0.1.4 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking atoi v2.0.0 [INFO] [stderr] Checking quanta v0.11.1 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking rusty-fork v0.3.0 [INFO] [stderr] Compiling snafu-derive v0.7.5 [INFO] [stderr] Compiling deepsize_derive v0.1.2 [INFO] [stderr] Checking proptest v1.5.0 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking deepsize v0.2.0 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking arrow-buffer v52.2.0 [INFO] [stderr] Checking arrow-data v52.2.0 [INFO] [stderr] Checking snafu v0.7.5 [INFO] [stderr] Checking arrow-array v52.2.0 [INFO] [stderr] Checking object_store v0.10.2 [INFO] [stderr] Checking arrow-select v52.2.0 [INFO] [stderr] Checking arrow-cast v52.2.0 [INFO] [stderr] Checking lance-arrow v0.16.1 [INFO] [stderr] Checking lance-testing v0.16.1 [INFO] [stderr] Checking lance-core v0.16.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:41:28 [INFO] [stdout] | [INFO] [stdout] 36 | fn new(record: Arc) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | size_accessor: Arc::new(size_accessor), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:73:29 [INFO] [stdout] | [INFO] [stdout] 73 | .map(|metadata| metadata.record.clone().downcast::().unwrap()) [INFO] [stdout] | -------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datatypes/field.rs:550:12 [INFO] [stdout] | [INFO] [stdout] 511 | let self_type = self.data_type(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 512 | let other_type = other.data_type(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 550 | Ok(self.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datatypes/field.rs:720:12 [INFO] [stdout] | [INFO] [stdout] 711 | let children = match field.data_type() { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 720 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 721 | | id: -1, [INFO] [stdout] 722 | | parent_id: -1, [INFO] [stdout] 723 | | name: field.name().clone(), [INFO] [stdout] ... | [INFO] [stdout] 736 | | dictionary: None, [INFO] [stdout] 737 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datatypes/schema.rs:188:12 [INFO] [stdout] | [INFO] [stdout] 169 | let mut candidates: Vec = vec![]; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 189 | | fields: candidates, [INFO] [stdout] 190 | | metadata: self.metadata.clone(), [INFO] [stdout] 191 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datatypes/schema.rs:255:12 [INFO] [stdout] | [INFO] [stdout] 248 | let mut candidates: Vec = vec![]; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 255 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 256 | | fields: candidates, [INFO] [stdout] 257 | | metadata: self.metadata.clone(), [INFO] [stdout] 258 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datatypes/schema.rs:304:12 [INFO] [stdout] | [INFO] [stdout] 290 | projection: S, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 291 | ) -> Result { [INFO] [stdout] 292 | let projection = projection.try_into()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 293 | let mut new_fields = vec![]; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 304 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 305 | | fields: new_fields, [INFO] [stdout] 306 | | metadata: self.metadata.clone(), [INFO] [stdout] 307 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datatypes/schema.rs:328:12 [INFO] [stdout] | [INFO] [stdout] 311 | pub fn exclude + Debug>(&self, schema: T) -> Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 312 | let other = schema.try_into().map_err(|_| Error::Schema { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 316 | let mut fields = vec![]; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 328 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 329 | | fields, [INFO] [stdout] 330 | | metadata: self.metadata.clone(), [INFO] [stdout] 331 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:115:21 [INFO] [stdout] | [INFO] [stdout] 109 | message: impl Into, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | source: message.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:123:21 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn invalid_input(message: impl Into, location: Location) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | source: message.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:131:21 [INFO] [stdout] | [INFO] [stdout] 128 | pub fn io(message: impl Into, location: Location) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | source: message.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:188:21 [INFO] [stdout] | [INFO] [stdout] 186 | fn from(e: std::io::Error) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | Self::IO { [INFO] [stdout] 188 | source: box_error(e), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:198:21 [INFO] [stdout] | [INFO] [stdout] 196 | fn from(e: object_store::Error) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 197 | Self::IO { [INFO] [stdout] 198 | source: box_error(e), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:208:21 [INFO] [stdout] | [INFO] [stdout] 206 | fn from(e: prost::DecodeError) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | Self::IO { [INFO] [stdout] 208 | source: box_error(e), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:228:21 [INFO] [stdout] | [INFO] [stdout] 226 | fn from(e: tokio::task::JoinError) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | Self::IO { [INFO] [stdout] 228 | source: box_error(e), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:238:21 [INFO] [stdout] | [INFO] [stdout] 236 | fn from(e: object_store::path::Error) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 237 | Self::IO { [INFO] [stdout] 238 | source: box_error(e), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:333:21 [INFO] [stdout] | [INFO] [stdout] 330 | fn from(err: Error) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 333 | source: Box::new(err), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:365:14 [INFO] [stdout] | [INFO] [stdout] 364 | fn from(result: Result) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 365 | Self(result.map_err(CloneableError)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/mask.rs:51:25 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn from_allowed(allow_list: RowIdTreeMap) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | Self { [INFO] [stdout] 51 | allow_list: Some(allow_list), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/mask.rs:52:25 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn from_allowed(allow_list: RowIdTreeMap) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | block_list: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/mask.rs:59:25 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn from_block(block_list: RowIdTreeMap) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | Self { [INFO] [stdout] 59 | allow_list: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/mask.rs:60:25 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn from_block(block_list: RowIdTreeMap) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | block_list: Some(block_list), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/mask.rs:183:12 [INFO] [stdout] | [INFO] [stdout] 170 | let offsets = OffsetBuffer::from_lengths(lengths); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | let values = Buffer::from(value_bytes); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | let nulls = NullBuffer::from(validity); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | Ok(BinaryArray::try_new(offsets, values, Some(nulls))?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/mask.rs:201:12 [INFO] [stdout] | [INFO] [stdout] 188 | let block_list = if array.is_null(0) { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 195 | let allow_list = if array.is_null(1) { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 201 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 202 | | block_list, [INFO] [stdout] 203 | | allow_list, [INFO] [stdout] 204 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/mask.rs:517:12 [INFO] [stdout] | [INFO] [stdout] 502 | pub fn deserialize_from(mut reader: R) -> Result { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 503 | let num_entries = reader.read_u32::()?; [INFO] [stdout] 504 | let mut inner = BTreeMap::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 517 | Ok(Self { inner }) [INFO] [stdout] | ^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/mask.rs:649:25 [INFO] [stdout] | [INFO] [stdout] 648 | fn from_iter>(iter: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 649 | Self::from_iter(iter.into_iter().copied()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/mask.rs:677:21 [INFO] [stdout] | [INFO] [stdout] 676 | fn extend>(&mut self, iter: T) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 677 | self.extend(iter.into_iter().copied()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/testing.rs:132:30 [INFO] [stdout] | [INFO] [stdout] 130 | bytes: PutPayload, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | opts: PutOptions, [INFO] [stdout] 132 | ) -> OSResult { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 133 | | self.before_method("put", location)?; [INFO] [stdout] 134 | | self.target.put_opts(location, bytes, opts).await [INFO] [stdout] 135 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/testing.rs:175:44 [INFO] [stdout] | [INFO] [stdout] 175 | .and_then(|meta| future::ready(self.transform_meta("list", meta))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/tracing.rs:46:19 [INFO] [stdout] | [INFO] [stdout] 39 | fn stream_in_current_span(self) -> InstrumentedStream [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | span: Span::current(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 30 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lance-core` (lib) due to 31 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:41:28 [INFO] [stdout] | [INFO] [stdout] 36 | fn new(record: Arc) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | size_accessor: Arc::new(size_accessor), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:73:29 [INFO] [stdout] | [INFO] [stdout] 73 | .map(|metadata| metadata.record.clone().downcast::().unwrap()) [INFO] [stdout] | -------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datatypes/field.rs:550:12 [INFO] [stdout] | [INFO] [stdout] 511 | let self_type = self.data_type(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 512 | let other_type = other.data_type(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 550 | Ok(self.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datatypes/field.rs:720:12 [INFO] [stdout] | [INFO] [stdout] 711 | let children = match field.data_type() { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 720 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 721 | | id: -1, [INFO] [stdout] 722 | | parent_id: -1, [INFO] [stdout] 723 | | name: field.name().clone(), [INFO] [stdout] ... | [INFO] [stdout] 736 | | dictionary: None, [INFO] [stdout] 737 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datatypes/schema.rs:188:12 [INFO] [stdout] | [INFO] [stdout] 169 | let mut candidates: Vec = vec![]; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 189 | | fields: candidates, [INFO] [stdout] 190 | | metadata: self.metadata.clone(), [INFO] [stdout] 191 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datatypes/schema.rs:255:12 [INFO] [stdout] | [INFO] [stdout] 248 | let mut candidates: Vec = vec![]; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 255 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 256 | | fields: candidates, [INFO] [stdout] 257 | | metadata: self.metadata.clone(), [INFO] [stdout] 258 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datatypes/schema.rs:304:12 [INFO] [stdout] | [INFO] [stdout] 290 | projection: S, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 291 | ) -> Result { [INFO] [stdout] 292 | let projection = projection.try_into()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 293 | let mut new_fields = vec![]; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 304 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 305 | | fields: new_fields, [INFO] [stdout] 306 | | metadata: self.metadata.clone(), [INFO] [stdout] 307 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datatypes/schema.rs:328:12 [INFO] [stdout] | [INFO] [stdout] 311 | pub fn exclude + Debug>(&self, schema: T) -> Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 312 | let other = schema.try_into().map_err(|_| Error::Schema { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 316 | let mut fields = vec![]; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 328 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 329 | | fields, [INFO] [stdout] 330 | | metadata: self.metadata.clone(), [INFO] [stdout] 331 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:115:21 [INFO] [stdout] | [INFO] [stdout] 109 | message: impl Into, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | source: message.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:123:21 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn invalid_input(message: impl Into, location: Location) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | source: message.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:131:21 [INFO] [stdout] | [INFO] [stdout] 128 | pub fn io(message: impl Into, location: Location) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | source: message.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:188:21 [INFO] [stdout] | [INFO] [stdout] 186 | fn from(e: std::io::Error) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | Self::IO { [INFO] [stdout] 188 | source: box_error(e), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:198:21 [INFO] [stdout] | [INFO] [stdout] 196 | fn from(e: object_store::Error) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 197 | Self::IO { [INFO] [stdout] 198 | source: box_error(e), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:208:21 [INFO] [stdout] | [INFO] [stdout] 206 | fn from(e: prost::DecodeError) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | Self::IO { [INFO] [stdout] 208 | source: box_error(e), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:228:21 [INFO] [stdout] | [INFO] [stdout] 226 | fn from(e: tokio::task::JoinError) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | Self::IO { [INFO] [stdout] 228 | source: box_error(e), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:238:21 [INFO] [stdout] | [INFO] [stdout] 236 | fn from(e: object_store::path::Error) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 237 | Self::IO { [INFO] [stdout] 238 | source: box_error(e), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:333:21 [INFO] [stdout] | [INFO] [stdout] 330 | fn from(err: Error) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 333 | source: Box::new(err), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:365:14 [INFO] [stdout] | [INFO] [stdout] 364 | fn from(result: Result) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 365 | Self(result.map_err(CloneableError)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:385:15 [INFO] [stdout] | [INFO] [stdout] 378 | let f: Box Result<()>> = Box::new(|| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 385 | match f().unwrap_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/futures.rs:225:9 [INFO] [stdout] | [INFO] [stdout] 223 | let noop_waker = futures::task::noop_waker(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 224 | let mut context = std::task::Context::from_waker(&noop_waker); [INFO] [stdout] 225 | fut.poll_unpin(&mut context).is_pending() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/mask.rs:51:25 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn from_allowed(allow_list: RowIdTreeMap) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | Self { [INFO] [stdout] 51 | allow_list: Some(allow_list), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/mask.rs:52:25 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn from_allowed(allow_list: RowIdTreeMap) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | block_list: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/mask.rs:59:25 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn from_block(block_list: RowIdTreeMap) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | Self { [INFO] [stdout] 59 | allow_list: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/mask.rs:60:25 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn from_block(block_list: RowIdTreeMap) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | block_list: Some(block_list), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/mask.rs:183:12 [INFO] [stdout] | [INFO] [stdout] 170 | let offsets = OffsetBuffer::from_lengths(lengths); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | let values = Buffer::from(value_bytes); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | let nulls = NullBuffer::from(validity); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | Ok(BinaryArray::try_new(offsets, values, Some(nulls))?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/mask.rs:201:12 [INFO] [stdout] | [INFO] [stdout] 188 | let block_list = if array.is_null(0) { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 195 | let allow_list = if array.is_null(1) { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 201 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 202 | | block_list, [INFO] [stdout] 203 | | allow_list, [INFO] [stdout] 204 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/mask.rs:517:12 [INFO] [stdout] | [INFO] [stdout] 502 | pub fn deserialize_from(mut reader: R) -> Result { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 503 | let num_entries = reader.read_u32::()?; [INFO] [stdout] 504 | let mut inner = BTreeMap::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 517 | Ok(Self { inner }) [INFO] [stdout] | ^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/mask.rs:649:25 [INFO] [stdout] | [INFO] [stdout] 648 | fn from_iter>(iter: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 649 | Self::from_iter(iter.into_iter().copied()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/mask.rs:677:21 [INFO] [stdout] | [INFO] [stdout] 676 | fn extend>(&mut self, iter: T) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 677 | self.extend(iter.into_iter().copied()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/testing.rs:132:30 [INFO] [stdout] | [INFO] [stdout] 130 | bytes: PutPayload, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | opts: PutOptions, [INFO] [stdout] 132 | ) -> OSResult { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 133 | | self.before_method("put", location)?; [INFO] [stdout] 134 | | self.target.put_opts(location, bytes, opts).await [INFO] [stdout] 135 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/testing.rs:175:44 [INFO] [stdout] | [INFO] [stdout] 175 | .and_then(|meta| future::ready(self.transform_meta("list", meta))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/tracing.rs:46:19 [INFO] [stdout] | [INFO] [stdout] 39 | fn stream_in_current_span(self) -> InstrumentedStream [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | span: Span::current(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 32 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lance-core` (lib test) due to 33 previous errors [INFO] running `Command { std: "docker" "inspect" "9826887377df868d8b7f0ff24fab4e32ced86040d6e70ef6696a5adde2890be4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9826887377df868d8b7f0ff24fab4e32ced86040d6e70ef6696a5adde2890be4", kill_on_drop: false }` [INFO] [stdout] 9826887377df868d8b7f0ff24fab4e32ced86040d6e70ef6696a5adde2890be4