[INFO] fetching crate lair_keystore 0.5.0... [INFO] checking lair_keystore-0.5.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate lair_keystore 0.5.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate lair_keystore 0.5.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate lair_keystore 0.5.0 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate lair_keystore 0.5.0 [INFO] tweaked toml for crates.io crate lair_keystore 0.5.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate lair_keystore 0.5.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 12ce6289f9ee23d1c34a9d04b073bd82d705320d3128cffd98500b8842911355 [INFO] running `Command { std: "docker" "start" "-a" "12ce6289f9ee23d1c34a9d04b073bd82d705320d3128cffd98500b8842911355", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "12ce6289f9ee23d1c34a9d04b073bd82d705320d3128cffd98500b8842911355", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "12ce6289f9ee23d1c34a9d04b073bd82d705320d3128cffd98500b8842911355", kill_on_drop: false }` [INFO] [stdout] 12ce6289f9ee23d1c34a9d04b073bd82d705320d3128cffd98500b8842911355 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] db0c57d29d10be66d758621f7c641bdb6f7dd0490174082a10a3282613cfc8b8 [INFO] running `Command { std: "docker" "start" "-a" "db0c57d29d10be66d758621f7c641bdb6f7dd0490174082a10a3282613cfc8b8", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Compiling zerocopy v0.7.34 [INFO] [stderr] Compiling allocator-api2 v0.2.18 [INFO] [stderr] Compiling memchr v2.7.2 [INFO] [stderr] Compiling cc v1.1.13 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling tinyvec_macros v0.1.1 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Compiling unicode-bidi v0.3.15 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Compiling tinyvec v1.6.0 [INFO] [stderr] Compiling percent-encoding v2.3.1 [INFO] [stderr] Compiling bitflags v2.6.0 [INFO] [stderr] Compiling linux-raw-sys v0.4.14 [INFO] [stderr] Compiling rle-decode-fast v1.0.3 [INFO] [stderr] Compiling crc32fast v1.4.2 [INFO] [stderr] Compiling log v0.4.21 [INFO] [stderr] Compiling dary_heap v0.3.6 [INFO] [stderr] Compiling base64 v0.22.1 [INFO] [stderr] Compiling adler32 v1.2.0 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling form_urlencoded v1.2.1 [INFO] [stderr] Compiling minisign-verify v0.2.1 [INFO] [stderr] Compiling pin-project-lite v0.2.14 [INFO] [stderr] Compiling futures-sink v0.3.30 [INFO] [stderr] Compiling winnow v0.6.11 [INFO] [stderr] Compiling smallvec v1.13.2 [INFO] [stderr] Compiling ryu v1.0.18 [INFO] [stderr] Compiling core2 v0.4.0 [INFO] [stderr] Compiling filetime v0.2.23 [INFO] [stderr] Compiling itoa v1.0.11 [INFO] [stderr] Compiling futures-core v0.3.30 [INFO] [stderr] Compiling scopeguard v1.2.0 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling futures-channel v0.3.30 [INFO] [stderr] Compiling getrandom v0.2.15 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling unicode-normalization v0.1.23 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling pin-utils v0.1.0 [INFO] [stderr] Compiling byteorder v1.5.0 [INFO] [stderr] Compiling hashbrown v0.12.3 [INFO] [stderr] Compiling futures-task v0.3.30 [INFO] [stderr] Compiling futures-io v0.3.30 [INFO] [stderr] Compiling powerfmt v0.2.0 [INFO] [stderr] Compiling parking_lot v0.12.3 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Compiling deranged v0.3.11 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling openssl-src v300.3.1+3.3.1 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling mio v0.8.11 [INFO] [stderr] Compiling signal-hook-registry v1.4.2 [INFO] [stderr] Compiling libflate_lz77 v2.1.0 [INFO] [stderr] Compiling idna v0.5.0 [INFO] [stderr] Compiling indexmap v2.2.6 [INFO] [stderr] Compiling socket2 v0.5.7 [INFO] [stderr] Compiling num_cpus v1.16.0 [INFO] [stderr] Compiling rmp v0.8.14 [INFO] [stderr] Compiling libflate v2.1.0 [INFO] [stderr] Compiling bytes v1.6.0 [INFO] [stderr] Compiling ppv-lite86 v0.2.17 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling base64 v0.13.1 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Compiling spin v0.5.2 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking either v1.12.0 [INFO] [stderr] Compiling untrusted v0.7.1 [INFO] [stderr] Compiling time v0.3.36 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling pem v1.1.1 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling tracing-core v0.1.32 [INFO] [stderr] Compiling minimal-lexical v0.2.1 [INFO] [stderr] Compiling zeroize v1.8.1 [INFO] [stderr] Compiling unsafe-libyaml v0.2.11 [INFO] [stderr] Compiling itertools v0.12.1 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Compiling libsqlite3-sys v0.30.1 [INFO] [stderr] Compiling lru v0.12.3 [INFO] [stderr] Compiling xattr v1.3.1 [INFO] [stderr] Compiling dunce v1.0.4 [INFO] [stderr] Compiling unicode-segmentation v1.11.0 [INFO] [stderr] Compiling tar v0.4.41 [INFO] [stderr] Compiling diff v0.1.13 [INFO] [stderr] Compiling unicode_categories v0.1.1 [INFO] [stderr] Compiling yasna v0.5.2 [INFO] [stderr] Compiling nanoid v0.4.0 [INFO] [stderr] Compiling yansi v0.5.1 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling pretty_assertions v1.4.0 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking hashlink v0.9.1 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking rtoolbox v0.0.2 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking fallible-iterator v0.3.0 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Compiling sqlformat v0.2.3 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking rpassword v7.3.1 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.3.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking sysinfo v0.30.12 [INFO] [stderr] Compiling tokio v1.38.0 [INFO] [stderr] Compiling rcgen v0.10.0 [INFO] [stderr] Checking structopt v0.3.26 [INFO] [stderr] Compiling futures-util v0.3.30 [INFO] [stderr] Compiling tracing v0.1.40 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking serde_spanned v0.6.6 [INFO] [stderr] Checking serde_bytes v0.11.14 [INFO] [stderr] Checking toml_datetime v0.6.6 [INFO] [stderr] Checking rmp-serde v1.3.0 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking rmpv v1.3.0 [INFO] [stderr] Checking toml_edit v0.22.14 [INFO] [stderr] Checking one_err v0.0.8 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Compiling ureq v2.9.7 [INFO] [stderr] Checking toml v0.8.14 [INFO] [stderr] Compiling libsodium-sys-stable v1.20.9 [INFO] [stderr] Compiling lair_keystore_api v0.5.0 [INFO] [stderr] Checking sodoken v0.0.11 [INFO] [stderr] Checking hc_seed_bundle v0.2.4 [INFO] [stderr] Checking rusqlite v0.32.1 [INFO] [stderr] Compiling lair_keystore v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:99:29 [INFO] [stdout] | [INFO] [stdout] 94 | let srv_hnd = self.srv_hnd.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | async move { [INFO] [stdout] 96 | let srv_hnd = srv_hnd.ok_or_else(|| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | srv_hnd.store().await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store_sqlite.rs:42:22 [INFO] [stdout] | [INFO] [stdout] 20 | sqlite_file_path: P, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | let inner = X(sqlite_file_path, db_salt.clone()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | LairStoreFactory(Arc::new(inner)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store_sqlite.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 31 | unlock_secret: sodoken::BufReadSized<32>, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | let db_salt = self.1.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | / async move { [INFO] [stdout] 36 | | SqlPool::new(sqlite_file_path, unlock_secret, db_salt).await [INFO] [stdout] 37 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store_sqlite.rs:36:72 [INFO] [stdout] | [INFO] [stdout] 31 | unlock_secret: sodoken::BufReadSized<32>, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | let db_salt = self.1.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | async move { [INFO] [stdout] 36 | SqlPool::new(sqlite_file_path, unlock_secret, db_salt).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store_sqlite.rs:252:12 [INFO] [stdout] | [INFO] [stdout] 143 | db_key: sodoken::BufReadSized<32>, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | db_salt: BinDataSized<16>, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | let ctx_secret = >::new_mem_locked()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | let ctx_secret = ctx_secret.to_read_sized(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | let dbk_secret = >::new_mem_locked()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | let dbk_secret = dbk_secret.to_read_sized(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | let key_pragma = secure_write_key_pragma(dbk_secret)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 170 | [INFO] [stdout] 171 | let mut write_con = match create_configured_db_connection( [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | Ok(con) => con, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | Err(err) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 223 | let mut read_cons: [Option; READ_CON_COUNT] = [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 244 | let inner = Self(Arc::new(Mutex::new(SqlPoolInner { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 252 | Ok(LairStore(Arc::new(inner))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store_sqlite.rs:348:9 [INFO] [stdout] | [INFO] [stdout] 347 | let read = self.read(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 348 | / async move { [INFO] [stdout] 349 | | let mut read = read.await; [INFO] [stdout] 350 | | read.transaction(|txn| { [INFO] [stdout] 351 | | let mut s = txn [INFO] [stdout] ... | [INFO] [stdout] 385 | | .await [INFO] [stdout] 386 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store_sqlite.rs:385:14 [INFO] [stdout] | [INFO] [stdout] 347 | let read = self.read(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 348 | async move { [INFO] [stdout] 349 | let mut read = read.await; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 385 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store_sqlite.rs:359:28 [INFO] [stdout] | [INFO] [stdout] 359 | Ok(data.into_boxed_slice()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store_sqlite.rs:395:9 [INFO] [stdout] | [INFO] [stdout] 392 | entry: LairEntry, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 393 | ) -> BoxFuture<'static, LairResult<()>> { [INFO] [stdout] 394 | let this = self.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 395 | / async move { [INFO] [stdout] 396 | | let seed_info = match &*entry { [INFO] [stdout] 397 | | LairEntryInner::Seed { seed_info, .. } => { [INFO] [stdout] 398 | | Some(seed_info.clone()) [INFO] [stdout] ... | [INFO] [stdout] 434 | | } [INFO] [stdout] 435 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store_sqlite.rs:413:25 [INFO] [stdout] | [INFO] [stdout] 392 | entry: LairEntry, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 405 | let bytes = entry.encode()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 406 | let mut write = this.write().await; [INFO] [stdout] 407 | if let Some(seed_info) = seed_info { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 413 | / txn.execute( [INFO] [stdout] 414 | | sql::INSERT_SEED, [INFO] [stdout] 415 | | params![ [INFO] [stdout] 416 | | entry.tag(), [INFO] [stdout] ... | [INFO] [stdout] 421 | | ) [INFO] [stdout] 422 | | .map(|_| ()) [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store_sqlite.rs:429:25 [INFO] [stdout] | [INFO] [stdout] 392 | entry: LairEntry, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 405 | let bytes = entry.encode()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 429 | / txn.execute(sql::INSERT, params![entry.tag(), bytes]) [INFO] [stdout] 430 | | .map(|_| ()) [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store_sqlite.rs:444:9 [INFO] [stdout] | [INFO] [stdout] 441 | tag: Arc, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 442 | ) -> BoxFuture<'static, LairResult> { [INFO] [stdout] 443 | let read = self.read(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 444 | / async move { [INFO] [stdout] 445 | | let mut read = read.await; [INFO] [stdout] 446 | | let data = read [INFO] [stdout] 447 | | .transaction(move |txn| { [INFO] [stdout] ... | [INFO] [stdout] 455 | | Ok(Arc::new(e)) [INFO] [stdout] 456 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store_sqlite.rs:455:16 [INFO] [stdout] | [INFO] [stdout] 441 | tag: Arc, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 442 | ) -> BoxFuture<'static, LairResult> { [INFO] [stdout] 443 | let read = self.read(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 444 | async move { [INFO] [stdout] 445 | let mut read = read.await; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 454 | let e = LairEntryInner::decode(&data)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 455 | Ok(Arc::new(e)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store_sqlite.rs:448:21 [INFO] [stdout] | [INFO] [stdout] 441 | tag: Arc, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 448 | / txn.query_row(sql::SELECT_BY_TAG, params![tag], |row| { [INFO] [stdout] 449 | | row.get::<_, Vec>(0) [INFO] [stdout] 450 | | }) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store_sqlite.rs:465:9 [INFO] [stdout] | [INFO] [stdout] 462 | ed25519_pub_key: Ed25519PubKey, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 463 | ) -> BoxFuture<'static, LairResult> { [INFO] [stdout] 464 | let read = self.read(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 465 | / async move { [INFO] [stdout] 466 | | let mut read = read.await; [INFO] [stdout] 467 | | let data = read [INFO] [stdout] 468 | | .transaction(move |txn| { [INFO] [stdout] ... | [INFO] [stdout] 478 | | Ok(Arc::new(e)) [INFO] [stdout] 479 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store_sqlite.rs:478:16 [INFO] [stdout] | [INFO] [stdout] 462 | ed25519_pub_key: Ed25519PubKey, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 463 | ) -> BoxFuture<'static, LairResult> { [INFO] [stdout] 464 | let read = self.read(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 465 | async move { [INFO] [stdout] 466 | let mut read = read.await; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 477 | let e = LairEntryInner::decode(&data)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 478 | Ok(Arc::new(e)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store_sqlite.rs:469:21 [INFO] [stdout] | [INFO] [stdout] 462 | ed25519_pub_key: Ed25519PubKey, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 469 | / txn.query_row( [INFO] [stdout] 470 | | sql::SELECT_BY_SIGN_PK, [INFO] [stdout] 471 | | params![&ed25519_pub_key[..]], [INFO] [stdout] 472 | | |row| row.get::<_, Vec>(0), [INFO] [stdout] 473 | | ) [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store_sqlite.rs:488:9 [INFO] [stdout] | [INFO] [stdout] 485 | x25519_pub_key: X25519PubKey, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 486 | ) -> BoxFuture<'static, LairResult> { [INFO] [stdout] 487 | let read = self.read(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 488 | / async move { [INFO] [stdout] 489 | | let mut read = read.await; [INFO] [stdout] 490 | | let data = read [INFO] [stdout] 491 | | .transaction(move |txn| { [INFO] [stdout] ... | [INFO] [stdout] 501 | | Ok(Arc::new(e)) [INFO] [stdout] 502 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store_sqlite.rs:501:16 [INFO] [stdout] | [INFO] [stdout] 485 | x25519_pub_key: X25519PubKey, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 486 | ) -> BoxFuture<'static, LairResult> { [INFO] [stdout] 487 | let read = self.read(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 488 | async move { [INFO] [stdout] 489 | let mut read = read.await; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 500 | let e = LairEntryInner::decode(&data)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 501 | Ok(Arc::new(e)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store_sqlite.rs:492:21 [INFO] [stdout] | [INFO] [stdout] 485 | x25519_pub_key: X25519PubKey, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 492 | / txn.query_row( [INFO] [stdout] 493 | | "SELECT data FROM lair_keystore WHERE x25519_pub_key = ?1;", [INFO] [stdout] 494 | | params![&x25519_pub_key[..]], [INFO] [stdout] 495 | | |row| row.get::<_, Vec>(0), [INFO] [stdout] 496 | | ) [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store_sqlite.rs:530:8 [INFO] [stdout] | [INFO] [stdout] 513 | key: sodoken::BufReadSized<32>, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 516 | let key_pragma: BufWriteSized = [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 530 | Ok(key_pragma.to_read()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:99:29 [INFO] [stdout] | [INFO] [stdout] 94 | let srv_hnd = self.srv_hnd.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | async move { [INFO] [stdout] 96 | let srv_hnd = srv_hnd.ok_or_else(|| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | srv_hnd.store().await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store_sqlite.rs:42:22 [INFO] [stdout] | [INFO] [stdout] 20 | sqlite_file_path: P, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | let inner = X(sqlite_file_path, db_salt.clone()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | LairStoreFactory(Arc::new(inner)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store_sqlite.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 31 | unlock_secret: sodoken::BufReadSized<32>, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | let db_salt = self.1.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | / async move { [INFO] [stdout] 36 | | SqlPool::new(sqlite_file_path, unlock_secret, db_salt).await [INFO] [stdout] 37 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 21 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store_sqlite.rs:36:72 [INFO] [stdout] | [INFO] [stdout] 31 | unlock_secret: sodoken::BufReadSized<32>, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | let db_salt = self.1.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | async move { [INFO] [stdout] 36 | SqlPool::new(sqlite_file_path, unlock_secret, db_salt).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store_sqlite.rs:252:12 [INFO] [stdout] | [INFO] [stdout] 143 | db_key: sodoken::BufReadSized<32>, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | db_salt: BinDataSized<16>, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | let ctx_secret = >::new_mem_locked()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | let ctx_secret = ctx_secret.to_read_sized(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | let dbk_secret = >::new_mem_locked()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | let dbk_secret = dbk_secret.to_read_sized(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | let key_pragma = secure_write_key_pragma(dbk_secret)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 170 | [INFO] [stdout] 171 | let mut write_con = match create_configured_db_connection( [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | Ok(con) => con, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | Err(err) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 223 | let mut read_cons: [Option; READ_CON_COUNT] = [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 244 | let inner = Self(Arc::new(Mutex::new(SqlPoolInner { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 252 | Ok(LairStore(Arc::new(inner))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store_sqlite.rs:348:9 [INFO] [stdout] | [INFO] [stdout] 347 | let read = self.read(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 348 | / async move { [INFO] [stdout] 349 | | let mut read = read.await; [INFO] [stdout] 350 | | read.transaction(|txn| { [INFO] [stdout] 351 | | let mut s = txn [INFO] [stdout] ... | [INFO] [stdout] 385 | | .await [INFO] [stdout] 386 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store_sqlite.rs:385:14 [INFO] [stdout] | [INFO] [stdout] 347 | let read = self.read(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 348 | async move { [INFO] [stdout] 349 | let mut read = read.await; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 385 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store_sqlite.rs:359:28 [INFO] [stdout] | [INFO] [stdout] 359 | Ok(data.into_boxed_slice()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store_sqlite.rs:395:9 [INFO] [stdout] | [INFO] [stdout] 392 | entry: LairEntry, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 393 | ) -> BoxFuture<'static, LairResult<()>> { [INFO] [stdout] 394 | let this = self.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 395 | / async move { [INFO] [stdout] 396 | | let seed_info = match &*entry { [INFO] [stdout] 397 | | LairEntryInner::Seed { seed_info, .. } => { [INFO] [stdout] 398 | | Some(seed_info.clone()) [INFO] [stdout] ... | [INFO] [stdout] 434 | | } [INFO] [stdout] 435 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store_sqlite.rs:413:25 [INFO] [stdout] | [INFO] [stdout] 392 | entry: LairEntry, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 405 | let bytes = entry.encode()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 406 | let mut write = this.write().await; [INFO] [stdout] 407 | if let Some(seed_info) = seed_info { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 413 | / txn.execute( [INFO] [stdout] 414 | | sql::INSERT_SEED, [INFO] [stdout] 415 | | params![ [INFO] [stdout] 416 | | entry.tag(), [INFO] [stdout] ... | [INFO] [stdout] 421 | | ) [INFO] [stdout] 422 | | .map(|_| ()) [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store_sqlite.rs:429:25 [INFO] [stdout] | [INFO] [stdout] 392 | entry: LairEntry, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 405 | let bytes = entry.encode()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 429 | / txn.execute(sql::INSERT, params![entry.tag(), bytes]) [INFO] [stdout] 430 | | .map(|_| ()) [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store_sqlite.rs:444:9 [INFO] [stdout] | [INFO] [stdout] 441 | tag: Arc, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 442 | ) -> BoxFuture<'static, LairResult> { [INFO] [stdout] 443 | let read = self.read(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 444 | / async move { [INFO] [stdout] 445 | | let mut read = read.await; [INFO] [stdout] 446 | | let data = read [INFO] [stdout] 447 | | .transaction(move |txn| { [INFO] [stdout] ... | [INFO] [stdout] 455 | | Ok(Arc::new(e)) [INFO] [stdout] 456 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store_sqlite.rs:455:16 [INFO] [stdout] | [INFO] [stdout] 441 | tag: Arc, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 442 | ) -> BoxFuture<'static, LairResult> { [INFO] [stdout] 443 | let read = self.read(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 444 | async move { [INFO] [stdout] 445 | let mut read = read.await; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 454 | let e = LairEntryInner::decode(&data)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 455 | Ok(Arc::new(e)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store_sqlite.rs:448:21 [INFO] [stdout] | [INFO] [stdout] 441 | tag: Arc, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 448 | / txn.query_row(sql::SELECT_BY_TAG, params![tag], |row| { [INFO] [stdout] 449 | | row.get::<_, Vec>(0) [INFO] [stdout] 450 | | }) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store_sqlite.rs:465:9 [INFO] [stdout] | [INFO] [stdout] 462 | ed25519_pub_key: Ed25519PubKey, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 463 | ) -> BoxFuture<'static, LairResult> { [INFO] [stdout] 464 | let read = self.read(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 465 | / async move { [INFO] [stdout] 466 | | let mut read = read.await; [INFO] [stdout] 467 | | let data = read [INFO] [stdout] 468 | | .transaction(move |txn| { [INFO] [stdout] ... | [INFO] [stdout] 478 | | Ok(Arc::new(e)) [INFO] [stdout] 479 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store_sqlite.rs:478:16 [INFO] [stdout] | [INFO] [stdout] 462 | ed25519_pub_key: Ed25519PubKey, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 463 | ) -> BoxFuture<'static, LairResult> { [INFO] [stdout] 464 | let read = self.read(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 465 | async move { [INFO] [stdout] 466 | let mut read = read.await; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 477 | let e = LairEntryInner::decode(&data)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 478 | Ok(Arc::new(e)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store_sqlite.rs:469:21 [INFO] [stdout] | [INFO] [stdout] 462 | ed25519_pub_key: Ed25519PubKey, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 469 | / txn.query_row( [INFO] [stdout] 470 | | sql::SELECT_BY_SIGN_PK, [INFO] [stdout] 471 | | params![&ed25519_pub_key[..]], [INFO] [stdout] 472 | | |row| row.get::<_, Vec>(0), [INFO] [stdout] 473 | | ) [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store_sqlite.rs:488:9 [INFO] [stdout] | [INFO] [stdout] 485 | x25519_pub_key: X25519PubKey, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 486 | ) -> BoxFuture<'static, LairResult> { [INFO] [stdout] 487 | let read = self.read(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 488 | / async move { [INFO] [stdout] 489 | | let mut read = read.await; [INFO] [stdout] 490 | | let data = read [INFO] [stdout] 491 | | .transaction(move |txn| { [INFO] [stdout] ... | [INFO] [stdout] 501 | | Ok(Arc::new(e)) [INFO] [stdout] 502 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store_sqlite.rs:501:16 [INFO] [stdout] | [INFO] [stdout] 485 | x25519_pub_key: X25519PubKey, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 486 | ) -> BoxFuture<'static, LairResult> { [INFO] [stdout] 487 | let read = self.read(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 488 | async move { [INFO] [stdout] 489 | let mut read = read.await; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 500 | let e = LairEntryInner::decode(&data)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 501 | Ok(Arc::new(e)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store_sqlite.rs:492:21 [INFO] [stdout] | [INFO] [stdout] 485 | x25519_pub_key: X25519PubKey, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 492 | / txn.query_row( [INFO] [stdout] 493 | | "SELECT data FROM lair_keystore WHERE x25519_pub_key = ?1;", [INFO] [stdout] 494 | | params![&x25519_pub_key[..]], [INFO] [stdout] 495 | | |row| row.get::<_, Vec>(0), [INFO] [stdout] 496 | | ) [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store_sqlite.rs:530:8 [INFO] [stdout] | [INFO] [stdout] 513 | key: sodoken::BufReadSized<32>, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 516 | let key_pragma: BufWriteSized = [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 530 | Ok(key_pragma.to_read()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 21 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lair_keystore` (lib) due to 22 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `lair_keystore` (lib test) due to 22 previous errors [INFO] running `Command { std: "docker" "inspect" "db0c57d29d10be66d758621f7c641bdb6f7dd0490174082a10a3282613cfc8b8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "db0c57d29d10be66d758621f7c641bdb6f7dd0490174082a10a3282613cfc8b8", kill_on_drop: false }` [INFO] [stdout] db0c57d29d10be66d758621f7c641bdb6f7dd0490174082a10a3282613cfc8b8