[INFO] fetching crate lagoon 0.1.3... [INFO] checking lagoon-0.1.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate lagoon 0.1.3 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate lagoon 0.1.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate lagoon 0.1.3 [INFO] finished tweaking crates.io crate lagoon 0.1.3 [INFO] tweaked toml for crates.io crate lagoon 0.1.3 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate lagoon 0.1.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bf0e1fab7a10dbee30f6d1322431fee1e70fccbd2d2f855f34bb482a659e6aac [INFO] running `Command { std: "docker" "start" "-a" "bf0e1fab7a10dbee30f6d1322431fee1e70fccbd2d2f855f34bb482a659e6aac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bf0e1fab7a10dbee30f6d1322431fee1e70fccbd2d2f855f34bb482a659e6aac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bf0e1fab7a10dbee30f6d1322431fee1e70fccbd2d2f855f34bb482a659e6aac", kill_on_drop: false }` [INFO] [stdout] bf0e1fab7a10dbee30f6d1322431fee1e70fccbd2d2f855f34bb482a659e6aac [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 825f6dbc87133bae381a6ca6b02d15153054d3bb47f1d488b3ef67a080ea0b06 [INFO] running `Command { std: "docker" "start" "-a" "825f6dbc87133bae381a6ca6b02d15153054d3bb47f1d488b3ef67a080ea0b06", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling libc v0.2.96 [INFO] [stderr] Compiling proc-macro2 v1.0.27 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Compiling ucd-trie v0.1.3 [INFO] [stderr] Compiling syn v1.0.73 [INFO] [stderr] Compiling serde v1.0.126 [INFO] [stderr] Compiling pest v2.1.3 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling memoffset v0.6.4 [INFO] [stderr] Compiling futures-core v0.3.15 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Compiling futures-macro v0.3.15 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling crossbeam-epoch v0.9.5 [INFO] [stderr] Compiling proc-macro-nested v0.1.7 [INFO] [stderr] Compiling futures-task v0.3.15 [INFO] [stderr] Compiling futures-channel v0.3.15 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Compiling futures-util v0.3.15 [INFO] [stderr] Compiling semver-parser v0.10.2 [INFO] [stderr] Checking futures-sink v0.3.15 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Compiling rayon-core v1.9.1 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Checking slab v0.4.3 [INFO] [stderr] Checking futures-io v0.3.15 [INFO] [stderr] Compiling semver v0.11.0 [INFO] [stderr] Compiling serde_json v1.0.64 [INFO] [stderr] Checking pin-project-lite v0.2.7 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling rustc_version v0.3.3 [INFO] [stderr] Checking crossbeam-deque v0.8.0 [INFO] [stderr] Compiling rayon v1.5.1 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Compiling serde_derive v1.0.126 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking plotters-backend v0.3.0 [INFO] [stderr] Compiling cast v0.2.6 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Checking plotters-svg v0.3.0 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking lock_api v0.4.4 [INFO] [stderr] Checking half v1.7.1 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking spin v0.9.2 [INFO] [stderr] Checking crossbeam-channel v0.3.9 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking plotters v0.3.1 [INFO] [stderr] Checking itertools v0.10.1 [INFO] [stderr] Checking criterion-plot v0.4.3 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking uvth v4.0.1 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Checking bstr v0.2.16 [INFO] [stderr] Checking serde_cbor v0.11.1 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking lagoon v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:137:29 [INFO] [stdout] | [INFO] [stdout] 137 | GLOBAL.call_once(|| builder.finish().expect("Failed to initialise global thread pool")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:161:9 [INFO] [stdout] | [INFO] [stdout] 160 | pub fn run(&self, f: F) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | self.tx.send(Job { f: Box::new(f) }).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:235:12 [INFO] [stdout] | [INFO] [stdout] 233 | let (tx, rx) = unbounded(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 234 | [INFO] [stdout] 235 | Ok(ThreadPool { [INFO] [stdout] | ____________^ [INFO] [stdout] 236 | | tx, [INFO] [stdout] 237 | | handles: (0..thread_count) [INFO] [stdout] 238 | | .map(|_| { [INFO] [stdout] ... | [INFO] [stdout] 258 | | .collect::>()?, [INFO] [stdout] 259 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:249:21 [INFO] [stdout] | [INFO] [stdout] 239 | let rx = rx.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 249 | / builder.spawn(move || { [INFO] [stdout] 250 | | while let Ok(job) = rx.recv() { [INFO] [stdout] 251 | | let job = std::panic::AssertUnwindSafe(job); [INFO] [stdout] 252 | | let _ = std::panic::catch_unwind(move || { [INFO] [stdout] ... | [INFO] [stdout] 255 | | } [INFO] [stdout] 256 | | }).map_err(Error::Io) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lagoon` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "825f6dbc87133bae381a6ca6b02d15153054d3bb47f1d488b3ef67a080ea0b06", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "825f6dbc87133bae381a6ca6b02d15153054d3bb47f1d488b3ef67a080ea0b06", kill_on_drop: false }` [INFO] [stdout] 825f6dbc87133bae381a6ca6b02d15153054d3bb47f1d488b3ef67a080ea0b06