[INFO] fetching crate lace_stats 0.4.0... [INFO] checking lace_stats-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate lace_stats 0.4.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate lace_stats 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate lace_stats 0.4.0 [INFO] finished tweaking crates.io crate lace_stats 0.4.0 [INFO] tweaked toml for crates.io crate lace_stats 0.4.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate lace_stats 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6fc5ba721f442e1b48c79db96bea80d27a33e7d19a7abe4b47be635217d74057 [INFO] running `Command { std: "docker" "start" "-a" "6fc5ba721f442e1b48c79db96bea80d27a33e7d19a7abe4b47be635217d74057", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6fc5ba721f442e1b48c79db96bea80d27a33e7d19a7abe4b47be635217d74057", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6fc5ba721f442e1b48c79db96bea80d27a33e7d19a7abe4b47be635217d74057", kill_on_drop: false }` [INFO] [stdout] 6fc5ba721f442e1b48c79db96bea80d27a33e7d19a7abe4b47be635217d74057 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a8de75c154578a7e7e345077e0f449c005efb63a55ca0576fbf2ad2d8b741f03 [INFO] running `Command { std: "docker" "start" "-a" "a8de75c154578a7e7e345077e0f449c005efb63a55ca0576fbf2ad2d8b741f03", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.76 [INFO] [stderr] Compiling serde v1.0.195 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling libc v0.2.152 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Compiling num-bigint v0.4.4 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Compiling matrixmultiply v0.3.8 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Checking bytemuck v1.14.0 [INFO] [stderr] Compiling num-iter v0.1.43 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Compiling peroxide v0.32.1 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking safe_arch v0.7.1 [INFO] [stderr] Checking puruspe v0.2.0 [INFO] [stderr] Compiling rustix v0.38.30 [INFO] [stderr] Compiling serde_json v1.0.111 [INFO] [stderr] Compiling ahash v0.8.7 [INFO] [stderr] Checking order-stat v0.1.3 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking crossbeam-channel v0.5.11 [INFO] [stderr] Checking plotters-backend v0.3.5 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking ciborium-io v0.2.1 [INFO] [stderr] Checking special v0.10.3 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking itertools v0.12.0 [INFO] [stderr] Checking wide v0.7.13 [INFO] [stderr] Checking clap_builder v4.4.18 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking plotters-svg v0.3.5 [INFO] [stderr] Checking ciborium-ll v0.2.1 [INFO] [stderr] Checking hashbrown v0.13.2 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking thread-tree v0.3.3 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking plotters v0.3.5 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking rayon v1.8.1 [INFO] [stderr] Checking lru v0.9.0 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking is-terminal v0.4.10 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking clap v4.4.18 [INFO] [stderr] Compiling serde_derive v1.0.195 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Compiling nalgebra-macros v0.2.1 [INFO] [stderr] Compiling peroxide-ad v0.3.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking num-complex v0.4.4 [INFO] [stderr] Checking ciborium v0.2.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking simba v0.8.1 [INFO] [stderr] Checking num v0.4.1 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Checking rand_distr v0.4.3 [INFO] [stderr] Checking lace_utils v0.3.0 [INFO] [stderr] Checking lace_data v0.3.0 [INFO] [stderr] Checking nalgebra v0.32.3 [INFO] [stderr] Checking rv v0.16.3 [INFO] [stderr] Checking lace_consts v0.2.1 [INFO] [stderr] Checking lace_stats v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct `FlatImproper` is never constructed [INFO] [stdout] --> src/dist.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | struct FlatImproper; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/integrate.rs:28:57 [INFO] [stdout] | [INFO] [stdout] 28 | let loglikes: Vec = (0..n_iters).map(|_| ln_f(&draw(rng))).collect(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mh.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 31 | x_start: T, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | loglike: F, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | prior_draw: D, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | let x = x_start; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | let fx = loglike(&x); [INFO] [stdout] 43 | / (0..n_iters) [INFO] [stdout] 44 | | .fold((x, fx), |(x, fx), _| { [INFO] [stdout] 45 | | let y = prior_draw(rng); [INFO] [stdout] 46 | | let fy = loglike(&y); [INFO] [stdout] ... | [INFO] [stdout] 55 | | } [INFO] [stdout] 56 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mh.rs:87:5 [INFO] [stdout] | [INFO] [stdout] 73 | x_start: T, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | ln_f: Fx, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | q_draw: Dq, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | q_ln_f: Fq, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | let x = x_start; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | let fx = ln_f(&x) - q_ln_f(&x); [INFO] [stdout] 87 | / (0..n_iters) [INFO] [stdout] 88 | | .fold((x, fx), |(x, fx), _| { [INFO] [stdout] 89 | | let y = q_draw(rng); [INFO] [stdout] 90 | | let fy = ln_f(&y) - q_ln_f(&y); [INFO] [stdout] ... | [INFO] [stdout] 99 | | } [INFO] [stdout] 100 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mh.rs:127:5 [INFO] [stdout] | [INFO] [stdout] 114 | x_start: T, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | score_fn: F, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | walk_fn: Q, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | let x = x_start; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | / (0..n_iters) [INFO] [stdout] 128 | | .fold((x, score_x), |(x, fx), _| { [INFO] [stdout] 129 | | let y = walk_fn(&x, rng); [INFO] [stdout] 130 | | let fy = score_fn(&y); [INFO] [stdout] ... | [INFO] [stdout] 139 | | } [INFO] [stdout] 140 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lace_stats` (lib) due to 5 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: struct `FlatImproper` is never constructed [INFO] [stdout] --> src/dist.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | struct FlatImproper; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/integrate.rs:28:57 [INFO] [stdout] | [INFO] [stdout] 28 | let loglikes: Vec = (0..n_iters).map(|_| ln_f(&draw(rng))).collect(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mh.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 31 | x_start: T, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | loglike: F, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | prior_draw: D, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | let x = x_start; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | let fx = loglike(&x); [INFO] [stdout] 43 | / (0..n_iters) [INFO] [stdout] 44 | | .fold((x, fx), |(x, fx), _| { [INFO] [stdout] 45 | | let y = prior_draw(rng); [INFO] [stdout] 46 | | let fy = loglike(&y); [INFO] [stdout] ... | [INFO] [stdout] 55 | | } [INFO] [stdout] 56 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mh.rs:87:5 [INFO] [stdout] | [INFO] [stdout] 73 | x_start: T, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | ln_f: Fx, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | q_draw: Dq, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | q_ln_f: Fq, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | let x = x_start; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | let fx = ln_f(&x) - q_ln_f(&x); [INFO] [stdout] 87 | / (0..n_iters) [INFO] [stdout] 88 | | .fold((x, fx), |(x, fx), _| { [INFO] [stdout] 89 | | let y = q_draw(rng); [INFO] [stdout] 90 | | let fy = ln_f(&y) - q_ln_f(&y); [INFO] [stdout] ... | [INFO] [stdout] 99 | | } [INFO] [stdout] 100 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mh.rs:127:5 [INFO] [stdout] | [INFO] [stdout] 114 | x_start: T, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | score_fn: F, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | walk_fn: Q, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | let x = x_start; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | / (0..n_iters) [INFO] [stdout] 128 | | .fold((x, score_x), |(x, fx), _| { [INFO] [stdout] 129 | | let y = walk_fn(&x, rng); [INFO] [stdout] 130 | | let fy = score_fn(&y); [INFO] [stdout] ... | [INFO] [stdout] 139 | | } [INFO] [stdout] 140 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lace_stats` (lib test) due to 5 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "a8de75c154578a7e7e345077e0f449c005efb63a55ca0576fbf2ad2d8b741f03", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a8de75c154578a7e7e345077e0f449c005efb63a55ca0576fbf2ad2d8b741f03", kill_on_drop: false }` [INFO] [stdout] a8de75c154578a7e7e345077e0f449c005efb63a55ca0576fbf2ad2d8b741f03