[INFO] fetching crate lace_codebook 0.7.0... [INFO] checking lace_codebook-0.7.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate lace_codebook 0.7.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate lace_codebook 0.7.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate lace_codebook 0.7.0 [INFO] finished tweaking crates.io crate lace_codebook 0.7.0 [INFO] tweaked toml for crates.io crate lace_codebook 0.7.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate lace_codebook 0.7.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `polars` dependency) [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dcfccc11756ad1c48c5f99dec6b42870ee3bfc6d9f3d3315ec48ed34e514d613 [INFO] running `Command { std: "docker" "start" "-a" "dcfccc11756ad1c48c5f99dec6b42870ee3bfc6d9f3d3315ec48ed34e514d613", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dcfccc11756ad1c48c5f99dec6b42870ee3bfc6d9f3d3315ec48ed34e514d613", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dcfccc11756ad1c48c5f99dec6b42870ee3bfc6d9f3d3315ec48ed34e514d613", kill_on_drop: false }` [INFO] [stdout] dcfccc11756ad1c48c5f99dec6b42870ee3bfc6d9f3d3315ec48ed34e514d613 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0160506afe882e74cc874fd49e15a946ad59e4ebf2da74cf6d5ac2eeb5e1dd4f [INFO] running `Command { std: "docker" "start" "-a" "0160506afe882e74cc874fd49e15a946ad59e4ebf2da74cf6d5ac2eeb5e1dd4f", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `polars` dependency) [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling proc-macro2 v1.0.76 [INFO] [stderr] Compiling libc v0.2.152 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling ahash v0.8.7 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling serde v1.0.195 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Compiling target-features v0.1.5 [INFO] [stderr] Checking allocator-api2 v0.2.16 [INFO] [stderr] Compiling polars-utils v0.36.2 [INFO] [stderr] Checking simdutf8 v0.1.4 [INFO] [stderr] Compiling polars-arrow v0.36.2 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Checking streaming-iterator v0.1.9 [INFO] [stderr] Checking strength_reduce v0.2.4 [INFO] [stderr] Checking ethnum v1.5.0 [INFO] [stderr] Checking atoi_simd v0.15.6 [INFO] [stderr] Checking dyn-clone v1.0.16 [INFO] [stderr] Checking fast-float v0.2.0 [INFO] [stderr] Checking foreign_vec v0.1.0 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling smartstring v1.0.1 [INFO] [stderr] Compiling num-bigint v0.4.4 [INFO] [stderr] Compiling matrixmultiply v0.3.8 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Compiling num-iter v0.1.43 [INFO] [stderr] Compiling polars-compute v0.36.2 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Compiling polars-core v0.36.2 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking crossbeam-channel v0.5.11 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Compiling peroxide v0.32.1 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking xxhash-rust v0.8.8 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking puruspe v0.2.0 [INFO] [stderr] Checking thread-tree v0.3.3 [INFO] [stderr] Checking order-stat v0.1.3 [INFO] [stderr] Checking special v0.10.3 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling polars-ops v0.36.2 [INFO] [stderr] Compiling polars v0.36.2 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Compiling rustix v0.38.30 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking itertools v0.12.0 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Checking unsafe-libyaml v0.2.10 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Compiling indoc v2.0.4 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking memmap2 v0.7.1 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking hashbrown v0.13.2 [INFO] [stderr] Checking rayon v1.8.1 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking argminmax v0.6.1 [INFO] [stderr] Checking lru v0.9.0 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Compiling serde_derive v1.0.195 [INFO] [stderr] Compiling bytemuck_derive v1.5.0 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking tempfile v3.9.0 [INFO] [stderr] Checking bytemuck v1.14.0 [INFO] [stderr] Checking indexmap v2.1.0 [INFO] [stderr] Checking polars-error v0.36.2 [INFO] [stderr] Checking safe_arch v0.7.1 [INFO] [stderr] Checking wide v0.7.13 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Compiling multiversion-macros v0.7.3 [INFO] [stderr] Compiling peroxide-ad v0.3.0 [INFO] [stderr] Compiling nalgebra-macros v0.2.1 [INFO] [stderr] Checking multiversion v0.7.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking num-complex v0.4.4 [INFO] [stderr] Checking serde_yaml v0.9.30 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking simba v0.8.1 [INFO] [stderr] Checking num v0.4.1 [INFO] [stderr] Checking rand_distr v0.4.3 [INFO] [stderr] Checking lace_utils v0.3.0 [INFO] [stderr] Checking lace_data v0.3.0 [INFO] [stderr] Checking polars-row v0.36.2 [INFO] [stderr] Checking nalgebra v0.32.3 [INFO] [stderr] Checking polars-io v0.36.2 [INFO] [stderr] Checking rv v0.16.3 [INFO] [stderr] Checking lace_consts v0.2.1 [INFO] [stderr] Checking lace_stats v0.4.0 [INFO] [stderr] Checking lace_codebook v0.7.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codebook.rs:215:18 [INFO] [stdout] | [INFO] [stdout] 203 | pub fn new(metadata: Vec) -> Result { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 215 | .map(|_| ColMetadataList { [INFO] [stdout] | __________________^ [INFO] [stdout] 216 | | metadata, [INFO] [stdout] 217 | | index_lookup, [INFO] [stdout] 218 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codebook.rs:344:9 [INFO] [stdout] | [INFO] [stdout] 343 | fn try_from(mds: Vec) -> Result { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 344 | ColMetadataList::new(mds).map_err(ColMetadataListError::Duplicate) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codebook.rs:408:33 [INFO] [stdout] | [INFO] [stdout] 404 | pub fn new(table_name: String, col_metadata: ColMetadataList) -> Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 408 | view_prior_process: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codebook.rs:409:34 [INFO] [stdout] | [INFO] [stdout] 404 | pub fn new(table_name: String, col_metadata: ColMetadataList) -> Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 409 | state_prior_process: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codebook.rs:458:57 [INFO] [stdout] | [INFO] [stdout] 458 | .map(|(id, colmd)| (id, colmd.name.clone(), colmd.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:270:8 [INFO] [stdout] | [INFO] [stdout] 264 | let (hyper, prior) = if no_hypers { [INFO] [stdout] | ----- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 270 | Ok(ColType::Continuous { hyper, prior }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:285:8 [INFO] [stdout] | [INFO] [stdout] 279 | let (hyper, prior) = if no_hypers { [INFO] [stdout] | ----- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 285 | Ok(ColType::Count { hyper, prior }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:294:8 [INFO] [stdout] | [INFO] [stdout] 292 | let (hyper, prior) = hyper_and_prior_for_categorical(no_hypers, k); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 293 | [INFO] [stdout] 294 | Ok(ColType::Categorical { [INFO] [stdout] | ________^ [INFO] [stdout] 295 | | k, [INFO] [stdout] 296 | | hyper, [INFO] [stdout] 297 | | prior, [INFO] [stdout] 298 | | value_map: ValueMap::U8(k), [INFO] [stdout] 299 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:322:8 [INFO] [stdout] | [INFO] [stdout] 320 | let (hyper, prior) = hyper_and_prior_for_categorical(no_hypers, 2); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 321 | [INFO] [stdout] 322 | Ok(ColType::Categorical { [INFO] [stdout] | ________^ [INFO] [stdout] 323 | | k: 2, [INFO] [stdout] 324 | | hyper, [INFO] [stdout] 325 | | prior, [INFO] [stdout] 326 | | value_map: ValueMap::Bool, [INFO] [stdout] 327 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:408:8 [INFO] [stdout] | [INFO] [stdout] 384 | let coltype = match dtype { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 408 | Ok(ColMetadata { [INFO] [stdout] | ________^ [INFO] [stdout] 409 | | name, [INFO] [stdout] 410 | | coltype, [INFO] [stdout] 411 | | notes: None, [INFO] [stdout] 412 | | missing_not_at_random: false, [INFO] [stdout] 413 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:462:8 [INFO] [stdout] | [INFO] [stdout] 432 | state_prior_process: Option, [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 433 | view_prior_process: Option, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 436 | let (col_metadata, row_names) = { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 437 | let mut row_names_opt: Option = None; [INFO] [stdout] 438 | let mut col_metadata = Vec::with_capacity(df.shape().1); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 451 | let colmd = series_to_colmd(srs, cat_cutoff, no_hypers)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 457 | let col_metadata = ColMetadataList::try_from(col_metadata)?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 462 | Ok(Codebook { [INFO] [stdout] | ________^ [INFO] [stdout] 463 | | table_name: "my_table".into(), [INFO] [stdout] 464 | | state_prior_process, [INFO] [stdout] 465 | | view_prior_process, [INFO] [stdout] ... | [INFO] [stdout] 468 | | comments: None, [INFO] [stdout] 469 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value_map.rs:275:15 [INFO] [stdout] | [INFO] [stdout] 273 | extension: ValueMapExtension, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 274 | ) -> Result<(), ValueMapExtensionError> { [INFO] [stdout] 275 | match (self, extension) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value_map.rs:387:9 [INFO] [stdout] | [INFO] [stdout] 386 | fn from(mut value_map: CategoryMap) -> Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 387 | value_map.to_cat.drain(..).enumerate().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value_map.rs:415:12 [INFO] [stdout] | [INFO] [stdout] 397 | fn try_from(mut map: BTreeMap) -> Result { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 401 | let mut to_cat = vec![T::default(); k]; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 402 | let mut to_ix = HashMap::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 415 | Ok(Self { to_ix, to_cat }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lace_codebook` (lib) due to 15 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codebook.rs:215:18 [INFO] [stdout] | [INFO] [stdout] 203 | pub fn new(metadata: Vec) -> Result { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 215 | .map(|_| ColMetadataList { [INFO] [stdout] | __________________^ [INFO] [stdout] 216 | | metadata, [INFO] [stdout] 217 | | index_lookup, [INFO] [stdout] 218 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codebook.rs:344:9 [INFO] [stdout] | [INFO] [stdout] 343 | fn try_from(mds: Vec) -> Result { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 344 | ColMetadataList::new(mds).map_err(ColMetadataListError::Duplicate) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codebook.rs:408:33 [INFO] [stdout] | [INFO] [stdout] 404 | pub fn new(table_name: String, col_metadata: ColMetadataList) -> Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 408 | view_prior_process: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codebook.rs:409:34 [INFO] [stdout] | [INFO] [stdout] 404 | pub fn new(table_name: String, col_metadata: ColMetadataList) -> Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 409 | state_prior_process: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codebook.rs:458:57 [INFO] [stdout] | [INFO] [stdout] 458 | .map(|(id, colmd)| (id, colmd.name.clone(), colmd.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:270:8 [INFO] [stdout] | [INFO] [stdout] 264 | let (hyper, prior) = if no_hypers { [INFO] [stdout] | ----- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 270 | Ok(ColType::Continuous { hyper, prior }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:285:8 [INFO] [stdout] | [INFO] [stdout] 279 | let (hyper, prior) = if no_hypers { [INFO] [stdout] | ----- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 285 | Ok(ColType::Count { hyper, prior }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:294:8 [INFO] [stdout] | [INFO] [stdout] 292 | let (hyper, prior) = hyper_and_prior_for_categorical(no_hypers, k); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 293 | [INFO] [stdout] 294 | Ok(ColType::Categorical { [INFO] [stdout] | ________^ [INFO] [stdout] 295 | | k, [INFO] [stdout] 296 | | hyper, [INFO] [stdout] 297 | | prior, [INFO] [stdout] 298 | | value_map: ValueMap::U8(k), [INFO] [stdout] 299 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:322:8 [INFO] [stdout] | [INFO] [stdout] 320 | let (hyper, prior) = hyper_and_prior_for_categorical(no_hypers, 2); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 321 | [INFO] [stdout] 322 | Ok(ColType::Categorical { [INFO] [stdout] | ________^ [INFO] [stdout] 323 | | k: 2, [INFO] [stdout] 324 | | hyper, [INFO] [stdout] 325 | | prior, [INFO] [stdout] 326 | | value_map: ValueMap::Bool, [INFO] [stdout] 327 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:408:8 [INFO] [stdout] | [INFO] [stdout] 384 | let coltype = match dtype { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 408 | Ok(ColMetadata { [INFO] [stdout] | ________^ [INFO] [stdout] 409 | | name, [INFO] [stdout] 410 | | coltype, [INFO] [stdout] 411 | | notes: None, [INFO] [stdout] 412 | | missing_not_at_random: false, [INFO] [stdout] 413 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:462:8 [INFO] [stdout] | [INFO] [stdout] 432 | state_prior_process: Option, [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 433 | view_prior_process: Option, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 436 | let (col_metadata, row_names) = { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 437 | let mut row_names_opt: Option = None; [INFO] [stdout] 438 | let mut col_metadata = Vec::with_capacity(df.shape().1); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 451 | let colmd = series_to_colmd(srs, cat_cutoff, no_hypers)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 457 | let col_metadata = ColMetadataList::try_from(col_metadata)?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 462 | Ok(Codebook { [INFO] [stdout] | ________^ [INFO] [stdout] 463 | | table_name: "my_table".into(), [INFO] [stdout] 464 | | state_prior_process, [INFO] [stdout] 465 | | view_prior_process, [INFO] [stdout] ... | [INFO] [stdout] 468 | | comments: None, [INFO] [stdout] 469 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:676:19 [INFO] [stdout] | [INFO] [stdout] 672 | let srs = Series::new( [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 676 | match series_to_colmd(&srs, None, false) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value_map.rs:275:15 [INFO] [stdout] | [INFO] [stdout] 273 | extension: ValueMapExtension, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 274 | ) -> Result<(), ValueMapExtensionError> { [INFO] [stdout] 275 | match (self, extension) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value_map.rs:387:9 [INFO] [stdout] | [INFO] [stdout] 386 | fn from(mut value_map: CategoryMap) -> Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 387 | value_map.to_cat.drain(..).enumerate().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value_map.rs:415:12 [INFO] [stdout] | [INFO] [stdout] 397 | fn try_from(mut map: BTreeMap) -> Result { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 401 | let mut to_cat = vec![T::default(); k]; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 402 | let mut to_ix = HashMap::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 415 | Ok(Self { to_ix, to_cat }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lace_codebook` (lib test) due to 16 previous errors [INFO] running `Command { std: "docker" "inspect" "0160506afe882e74cc874fd49e15a946ad59e4ebf2da74cf6d5ac2eeb5e1dd4f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0160506afe882e74cc874fd49e15a946ad59e4ebf2da74cf6d5ac2eeb5e1dd4f", kill_on_drop: false }` [INFO] [stdout] 0160506afe882e74cc874fd49e15a946ad59e4ebf2da74cf6d5ac2eeb5e1dd4f