[INFO] fetching crate kyoto 0.0.1... [INFO] checking kyoto-0.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate kyoto 0.0.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate kyoto 0.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate kyoto 0.0.1 [INFO] finished tweaking crates.io crate kyoto 0.0.1 [INFO] tweaked toml for crates.io crate kyoto 0.0.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate kyoto 0.0.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 09c5d95b9fa485aeca0d7ff06626687ac8f4bc2f53ba1343b1d95fa2530e82b1 [INFO] running `Command { std: "docker" "start" "-a" "09c5d95b9fa485aeca0d7ff06626687ac8f4bc2f53ba1343b1d95fa2530e82b1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "09c5d95b9fa485aeca0d7ff06626687ac8f4bc2f53ba1343b1d95fa2530e82b1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "09c5d95b9fa485aeca0d7ff06626687ac8f4bc2f53ba1343b1d95fa2530e82b1", kill_on_drop: false }` [INFO] [stdout] 09c5d95b9fa485aeca0d7ff06626687ac8f4bc2f53ba1343b1d95fa2530e82b1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 33e00f70571fd751ab57b3d5043289fcbdbaaed4ac22f3d69c5991eac8c93da3 [INFO] running `Command { std: "docker" "start" "-a" "33e00f70571fd751ab57b3d5043289fcbdbaaed4ac22f3d69c5991eac8c93da3", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling libc v0.2.82 [INFO] [stderr] Compiling syn v1.0.58 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling log v0.4.13 [INFO] [stderr] Compiling serde v1.0.119 [INFO] [stderr] Checking pin-project-lite v0.2.4 [INFO] [stderr] Checking regex-syntax v0.6.22 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Checking tracing-core v0.1.17 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling pin-project-internal v0.4.27 [INFO] [stderr] Checking instant v0.1.9 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling serde_json v1.0.61 [INFO] [stderr] Checking byteorder v1.4.2 [INFO] [stderr] Compiling heck v0.3.2 [INFO] [stderr] Checking lock_api v0.4.2 [INFO] [stderr] Compiling tokio v1.0.2 [INFO] [stderr] Compiling anyhow v1.0.38 [INFO] [stderr] Compiling httparse v1.3.4 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Checking sharded-slab v0.1.1 [INFO] [stderr] Checking thread_local v1.1.0 [INFO] [stderr] Checking once_cell v1.5.2 [INFO] [stderr] Checking tracing-log v0.1.1 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling quote v1.0.8 [INFO] [stderr] Checking parking_lot_core v0.8.2 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking signal-hook-registry v1.3.0 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking mio v0.7.7 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking parking_lot v0.11.1 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Checking regex v1.4.3 [INFO] [stderr] Checking tracing-serde v0.1.2 [INFO] [stderr] Checking matchers v0.0.1 [INFO] [stderr] Compiling tracing-attributes v0.1.11 [INFO] [stderr] Compiling tokio-macros v1.0.0 [INFO] [stderr] Compiling structopt-derive v0.4.14 [INFO] [stderr] Checking tracing v0.1.22 [INFO] [stderr] Checking tracing-subscriber v0.2.15 [INFO] [stderr] Checking pin-project v0.4.27 [INFO] [stderr] Checking tracing-futures v0.2.4 [INFO] [stderr] Checking structopt v0.3.21 [INFO] [stderr] Checking kyoto v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `BufMut` [INFO] [stdout] --> src/data/server_state/machine_info.rs:1:24 [INFO] [stdout] | [INFO] [stdout] 1 | use bytes::{ BytesMut, BufMut }; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `BufMut` [INFO] [stdout] --> src/data/warehouse/data_info.rs:1:24 [INFO] [stdout] | [INFO] [stdout] 1 | use bytes::{ BytesMut, BufMut }; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `BufMut` [INFO] [stdout] --> src/data/server_state/machine_info.rs:1:24 [INFO] [stdout] | [INFO] [stdout] 1 | use bytes::{ BytesMut, BufMut }; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `BufMut` [INFO] [stdout] --> src/data/warehouse/data_info.rs:1:24 [INFO] [stdout] | [INFO] [stdout] 1 | use bytes::{ BytesMut, BufMut }; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `error_type` [INFO] [stdout] --> src/network/network_handler.rs:61:30 [INFO] [stdout] | [INFO] [stdout] 61 | Response::Error{ error_type, message } => { [INFO] [stdout] | ^^^^^^^^^^ help: try ignoring the field: `error_type: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `error_type` [INFO] [stdout] --> src/network/network_handler.rs:61:30 [INFO] [stdout] | [INFO] [stdout] 61 | Response::Error{ error_type, message } => { [INFO] [stdout] | ^^^^^^^^^^ help: try ignoring the field: `error_type: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/data/warehouse/data_info.rs:13:33 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn generate_info(&self, mut info: BytesMut) -> BytesMut { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/data/warehouse/data_info.rs:13:33 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn generate_info(&self, mut info: BytesMut) -> BytesMut { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `total_keys` is never read [INFO] [stdout] --> src/data/warehouse/data_info.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct DataInfo { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 5 | total_keys: u32, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DataInfo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `total_keys` is never read [INFO] [stdout] --> src/data/warehouse/data_info.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct DataInfo { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 5 | total_keys: u32, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DataInfo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/warehouse/db.rs:22:22 [INFO] [stdout] | [INFO] [stdout] 20 | let hashmap_mutex: HashMap = HashMap::new(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Db { [INFO] [stdout] 22 | hashmap: Mutex::new(hashmap_mutex), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/warehouse/db.rs:22:22 [INFO] [stdout] | [INFO] [stdout] 20 | let hashmap_mutex: HashMap = HashMap::new(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Db { [INFO] [stdout] 22 | hashmap: Mutex::new(hashmap_mutex), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/serialization/response_encoder.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn generate_response(val: Bytes) -> crate::Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 15 | let mut response = BytesMut::with_capacity(resp_bin.len() + val.len() + 5); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 18 | Ok(response.freeze()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/serialization/response_encoder.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn generate_response(val: Bytes) -> crate::Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 15 | let mut response = BytesMut::with_capacity(resp_bin.len() + val.len() + 5); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 18 | Ok(response.freeze()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kyoto` (lib test) due to 3 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `kyoto` (lib) due to 3 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "33e00f70571fd751ab57b3d5043289fcbdbaaed4ac22f3d69c5991eac8c93da3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "33e00f70571fd751ab57b3d5043289fcbdbaaed4ac22f3d69c5991eac8c93da3", kill_on_drop: false }` [INFO] [stdout] 33e00f70571fd751ab57b3d5043289fcbdbaaed4ac22f3d69c5991eac8c93da3