[INFO] fetching crate kyanite 0.5.1... [INFO] checking kyanite-0.5.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate kyanite 0.5.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate kyanite 0.5.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate kyanite 0.5.1 [INFO] finished tweaking crates.io crate kyanite 0.5.1 [INFO] tweaked toml for crates.io crate kyanite 0.5.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate kyanite 0.5.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d4655d18bd5678619b9dd6be1f0105a640fb9b3c35419e2a0bbf60def2aa7b2f [INFO] running `Command { std: "docker" "start" "-a" "d4655d18bd5678619b9dd6be1f0105a640fb9b3c35419e2a0bbf60def2aa7b2f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d4655d18bd5678619b9dd6be1f0105a640fb9b3c35419e2a0bbf60def2aa7b2f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d4655d18bd5678619b9dd6be1f0105a640fb9b3c35419e2a0bbf60def2aa7b2f", kill_on_drop: false }` [INFO] [stdout] d4655d18bd5678619b9dd6be1f0105a640fb9b3c35419e2a0bbf60def2aa7b2f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b9c660386725439d658950b7630ba9c2ddd8a2e6d6c04f7b629e9266c77c9662 [INFO] running `Command { std: "docker" "start" "-a" "b9c660386725439d658950b7630ba9c2ddd8a2e6d6c04f7b629e9266c77c9662", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.94 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling indexmap v1.8.0 [INFO] [stderr] Compiling serde_derive v1.0.137 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Compiling serde v1.0.137 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Checking tinyvec v1.5.1 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling encoding_rs v0.8.30 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Compiling serde_json v1.0.81 [INFO] [stderr] Checking miniz_oxide v0.5.1 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking xml-rs v0.8.4 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking deunicode v0.4.3 [INFO] [stderr] Checking mio v0.8.2 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking native-tls v0.2.8 [INFO] [stderr] Checking ipnet v2.5.0 [INFO] [stderr] Checking mime v0.3.16 [INFO] [stderr] Checking clap_lex v0.2.0 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking fern v0.6.1 [INFO] [stderr] Checking slug v0.1.4 [INFO] [stderr] Checking flate2 v1.0.23 [INFO] [stderr] Checking clap v3.1.18 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Compiling tracing-attributes v0.1.20 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Compiling async-trait v0.1.53 [INFO] [stderr] Checking tokio v1.18.2 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking tracing v0.1.34 [INFO] [stderr] Checking tokio-util v0.7.1 [INFO] [stderr] Checking tokio-native-tls v0.3.0 [INFO] [stderr] Checking h2 v0.3.13 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde-xml-rs v0.5.1 [INFO] [stderr] Checking hyper v0.14.18 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.10 [INFO] [stderr] Checking kyanite v0.5.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `site_base` is never used [INFO] [stdout] --> src/collector.rs:21:8 [INFO] [stdout] | [INFO] [stdout] 17 | pub trait KyaniteCollector { [INFO] [stdout] | ---------------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 21 | fn site_base(&self) -> &'static str; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `image` is never read [INFO] [stdout] --> src/item.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct KyaniteItemMD5 { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 11 | pub url: String, [INFO] [stdout] 12 | pub image: String, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `KyaniteItemMD5` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | Ok(()) [INFO] [stdout] | ^^---- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collector.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 57 | let collectors = vec![ [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 68 | | stats, [INFO] [stdout] 69 | | params, [INFO] [stdout] 70 | | manifest, [INFO] [stdout] 71 | | collectors, [INFO] [stdout] 72 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kyanite` (bin "kyanite") due to 3 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `site_base` is never used [INFO] [stdout] --> src/collector.rs:21:8 [INFO] [stdout] | [INFO] [stdout] 17 | pub trait KyaniteCollector { [INFO] [stdout] | ---------------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 21 | fn site_base(&self) -> &'static str; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `image` is never read [INFO] [stdout] --> src/item.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct KyaniteItemMD5 { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 11 | pub url: String, [INFO] [stdout] 12 | pub image: String, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `KyaniteItemMD5` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | Ok(()) [INFO] [stdout] | ^^---- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collector.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 57 | let collectors = vec![ [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 68 | | stats, [INFO] [stdout] 69 | | params, [INFO] [stdout] 70 | | manifest, [INFO] [stdout] 71 | | collectors, [INFO] [stdout] 72 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kyanite` (bin "kyanite" test) due to 3 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b9c660386725439d658950b7630ba9c2ddd8a2e6d6c04f7b629e9266c77c9662", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b9c660386725439d658950b7630ba9c2ddd8a2e6d6c04f7b629e9266c77c9662", kill_on_drop: false }` [INFO] [stdout] b9c660386725439d658950b7630ba9c2ddd8a2e6d6c04f7b629e9266c77c9662