[INFO] fetching crate kvsd 0.1.3... [INFO] checking kvsd-0.1.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate kvsd 0.1.3 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate kvsd 0.1.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-5-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate kvsd 0.1.3 [INFO] finished tweaking crates.io crate kvsd 0.1.3 [INFO] tweaked toml for crates.io crate kvsd 0.1.3 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate kvsd 0.1.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e979dce930d24266dee12e8a8a1fb105816bc97e8880ea7258c52efbb1ad3a40 [INFO] running `Command { std: "docker" "start" "-a" "e979dce930d24266dee12e8a8a1fb105816bc97e8880ea7258c52efbb1ad3a40", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e979dce930d24266dee12e8a8a1fb105816bc97e8880ea7258c52efbb1ad3a40", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e979dce930d24266dee12e8a8a1fb105816bc97e8880ea7258c52efbb1ad3a40", kill_on_drop: false }` [INFO] [stdout] e979dce930d24266dee12e8a8a1fb105816bc97e8880ea7258c52efbb1ad3a40 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2fda658be67cf5eb1547b10f5774f6c8858405fdf8ba9d02ae29587677589493 [INFO] running `Command { std: "docker" "start" "-a" "2fda658be67cf5eb1547b10f5774f6c8858405fdf8ba9d02ae29587677589493", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Compiling proc-macro2 v1.0.76 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling serde v1.0.195 [INFO] [stderr] Compiling crossbeam-utils v0.8.18 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking rustls-pki-types v1.3.1 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Compiling rustls v0.22.2 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Compiling serde_json v1.0.111 [INFO] [stderr] Compiling rayon-core v1.12.0 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Compiling async-trait v0.1.77 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking anstream v0.6.12 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Checking gimli v0.28.1 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking clap_builder v4.5.1 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking crossbeam-epoch v0.9.17 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking thread_local v1.1.7 [INFO] [stderr] Checking half v2.4.0 [INFO] [stderr] Checking crossbeam-deque v0.8.4 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Compiling rustix v0.38.28 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Checking plotters-backend v0.3.5 [INFO] [stderr] Checking smallvec v1.11.2 [INFO] [stderr] Checking rustls-pemfile v2.1.0 [INFO] [stderr] Checking plotters-svg v0.3.5 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking object v0.32.2 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking chrono v0.4.34 [INFO] [stderr] Checking atoi v0.3.3 [INFO] [stderr] Checking plotters v0.3.5 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking rayon v1.8.0 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking getrandom v0.2.11 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking clap v4.5.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tempfile v3.9.0 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling backtrace v0.3.69 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Compiling serde_derive v1.0.195 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling pin-project-internal v1.1.3 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking tokio v1.35.1 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking pin-project v1.1.3 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking tracing-futures v0.2.5 [INFO] [stderr] Checking rustls-webpki v0.102.2 [INFO] [stderr] Checking tokio-stream v0.1.14 [INFO] [stderr] Checking tokio-test v0.4.3 [INFO] [stderr] Checking tokio-rustls v0.25.0 [INFO] [stderr] Checking serde_yaml v0.8.26 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking kvsd v0.1.3 (/opt/rustwide/workdir) [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/core/principal/mod.rs:7:10 [INFO] [stdout] | [INFO] [stdout] 7 | User(User), [INFO] [stdout] | ---- ^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Principal` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 7 | User(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/tcp.rs:507:30 [INFO] [stdout] | [INFO] [stdout] 504 | fn new(listener: TcpListener, max_connections: u32) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 507 | max_connections: Arc::new(Semaphore::new(max_connections as usize)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/tcp.rs:42:21 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn new(stream: T) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | Self { [INFO] [stdout] 42 | client: Client::new(stream), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/tcp.rs:120:25 [INFO] [stdout] | [INFO] [stdout] 118 | fn new(stream: T) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | Self { [INFO] [stdout] 120 | connection: Connection::new(stream, Some(1024 * 4)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/tcp.rs:140:67 [INFO] [stdout] | [INFO] [stdout] 140 | async fn set(&mut self, key: Key, value: Value) -> Result<()> { [INFO] [stdout] | _______________________________________------------________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | | let set = Set::new(key, value); [INFO] [stdout] 142 | | self.connection.write_message(set).await?; [INFO] [stdout] 143 | | match self.connection.read_message().await? { [INFO] [stdout] ... | [INFO] [stdout] 151 | | } [INFO] [stdout] 152 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/table/entry.rs:184:25 [INFO] [stdout] | [INFO] [stdout] 183 | pub(super) fn take_key_value(self) -> (String, Box<[u8]>) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | (self.body.key, self.body.value.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/table/table.rs:129:9 [INFO] [stdout] | [INFO] [stdout] 126 | sender: Option>>>, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | value: Result>, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | ) -> Result<()> { [INFO] [stdout] 129 | / sender [INFO] [stdout] 130 | | .expect("response already sent") [INFO] [stdout] 131 | | .send(value) [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/table/table.rs:132:26 [INFO] [stdout] | [INFO] [stdout] 132 | .map_err(|_| ErrorKind::Internal("send to resp channel".to_owned()).into()) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/uow.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 35 | pub(crate) fn send_response(&mut self, response: Result) -> Result<()> { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | / self.response_sender [INFO] [stdout] 37 | | .take() [INFO] [stdout] 38 | | .expect("response already sent") [INFO] [stdout] 39 | | .send(response) [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/uow.rs:40:26 [INFO] [stdout] | [INFO] [stdout] 40 | .map_err(|_| ErrorKind::Internal("send response".to_owned()).into()) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/uow.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 46 | principal: Arc, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | provider: impl credential::Provider + Send + 'static, [INFO] [stdout] | ---------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | ) -> (UnitOfWork, oneshot::Receiver>>) { [INFO] [stdout] 49 | let (tx, rx) = oneshot::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | ( [INFO] [stdout] 51 | / UnitOfWork::Authenticate(Work { [INFO] [stdout] 52 | | principal, [INFO] [stdout] 53 | | request: Box::new(provider), [INFO] [stdout] 54 | | response_sender: Some(tx), [INFO] [stdout] 55 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/uow.rs:65:13 [INFO] [stdout] | [INFO] [stdout] 61 | principal: Arc, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | ) -> (UnitOfWork, oneshot::Receiver>) { [INFO] [stdout] 63 | let (tx, rx) = oneshot::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | ( [INFO] [stdout] 65 | / UnitOfWork::Ping(Work { [INFO] [stdout] 66 | | principal, [INFO] [stdout] 67 | | request: (), [INFO] [stdout] 68 | | response_sender: Some(tx), [INFO] [stdout] 69 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/uow.rs:80:13 [INFO] [stdout] | [INFO] [stdout] 75 | principal: Arc, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | set: Set, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | ) -> (UnitOfWork, oneshot::Receiver>>) { [INFO] [stdout] 78 | let (tx, rx) = oneshot::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | ( [INFO] [stdout] 80 | / UnitOfWork::Set(Work { [INFO] [stdout] 81 | | principal, [INFO] [stdout] 82 | | request: set, [INFO] [stdout] 83 | | response_sender: Some(tx), [INFO] [stdout] 84 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/uow.rs:95:13 [INFO] [stdout] | [INFO] [stdout] 90 | principal: Arc, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | let (tx, rx) = oneshot::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | ( [INFO] [stdout] 95 | / UnitOfWork::Get(Work { [INFO] [stdout] 96 | | principal, [INFO] [stdout] 97 | | request: get, [INFO] [stdout] 98 | | response_sender: Some(tx), [INFO] [stdout] 99 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/uow.rs:110:13 [INFO] [stdout] | [INFO] [stdout] 105 | principal: Arc, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | let (tx, rx) = oneshot::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | ( [INFO] [stdout] 110 | / UnitOfWork::Delete(Work { [INFO] [stdout] 111 | | principal, [INFO] [stdout] 112 | | request: delete, [INFO] [stdout] 113 | | response_sender: Some(tx), [INFO] [stdout] 114 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/middleware/authenticator.rs:43:62 [INFO] [stdout] | [INFO] [stdout] 43 | async fn apply(&mut self, uow: UnitOfWork) -> Result<()> { [INFO] [stdout] | _______________________________---------------________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | | // TODO: need derive impl that can provide principal [INFO] [stdout] 45 | | match uow { [INFO] [stdout] 46 | | UnitOfWork::Authenticate(auth) => { [INFO] [stdout] ... | [INFO] [stdout] 71 | | } [INFO] [stdout] 72 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/middleware/authorizer.rs:22:62 [INFO] [stdout] | [INFO] [stdout] 22 | async fn apply(&mut self, uow: UnitOfWork) -> Result<()> { [INFO] [stdout] | _______________________________---------------________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | | self.next.apply(uow).await [INFO] [stdout] 24 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/middleware/logger.rs:22:62 [INFO] [stdout] | [INFO] [stdout] 22 | async fn apply(&mut self, uow: UnitOfWork) -> Result<()> { [INFO] [stdout] | _______________________________---------------________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | | let start = tokio::time::Instant::now(); [INFO] [stdout] 24 | | let log = format!("{:?}", uow); [INFO] [stdout] ... | [INFO] [stdout] 30 | | result [INFO] [stdout] 31 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/middleware/dispatcher.rs:36:28 [INFO] [stdout] | [INFO] [stdout] 36 | .ok_or_else(|| ErrorKind::TableNotFound(format!("{}/{}", namespace, table)).into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/middleware/dispatcher.rs:42:66 [INFO] [stdout] | [INFO] [stdout] 42 | async fn apply(&mut self, mut uow: UnitOfWork) -> Result<()> { [INFO] [stdout] | ___________________________________---------------________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | | match uow { [INFO] [stdout] 44 | | // TODO: delegate system handler. [INFO] [stdout] 45 | | UnitOfWork::Ping(ping) => { [INFO] [stdout] ... | [INFO] [stdout] 72 | | } [INFO] [stdout] 73 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error/mod.rs:55:29 [INFO] [stdout] | [INFO] [stdout] 54 | fn from(err: self::internal::Error) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | KvsdError::Internal(Box::new(err)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error/internal.rs:67:21 [INFO] [stdout] | [INFO] [stdout] 66 | fn from(err: io::Error) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | Error::from(ErrorKind::Io(err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error/internal.rs:79:21 [INFO] [stdout] | [INFO] [stdout] 78 | fn from(err: KvsdError) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | Error::from(ErrorKind::Kvsd(err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error/internal.rs:114:21 [INFO] [stdout] | [INFO] [stdout] 113 | fn from(err: SendError) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | Error::from(ErrorKind::Internal(err.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error/internal.rs:126:21 [INFO] [stdout] | [INFO] [stdout] 125 | fn from(err: serde_yaml::Error) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | Error::from(ErrorKind::Yaml(err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/mod.rs:92:15 [INFO] [stdout] | [INFO] [stdout] 91 | pub(crate) fn new_unchecked(v: impl Into>) -> Self { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | Value(v.into()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/mod.rs:123:12 [INFO] [stdout] | [INFO] [stdout] 122 | fn try_from(kv: (K, V)) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | Ok(KeyValue { [INFO] [stdout] | ____________^ [INFO] [stdout] 124 | | key: Key::new(kv.0)?, [INFO] [stdout] 125 | | value: Value::new(Box::<[u8]>::from(kv.1.as_ref()))?, [INFO] [stdout] 126 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/connection/mod.rs:24:21 [INFO] [stdout] | [INFO] [stdout] 22 | pub(crate) fn new(stream: T, buffer_size: Option) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | Self { [INFO] [stdout] 24 | stream: BufWriter::new(stream), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/connection/mod.rs:25:21 [INFO] [stdout] | [INFO] [stdout] 22 | pub(crate) fn new(stream: T, buffer_size: Option) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | buffer: BytesMut::with_capacity(buffer_size.unwrap_or(4 * 1024)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/message/success.rs:16:23 [INFO] [stdout] | [INFO] [stdout] 15 | pub(crate) fn with_value(value: Value) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | Self { value: Some(value) } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/message/success.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 20 | let value = parse.next_bytes_or_null()?.and_then(|v| Value::new(v).ok()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | Ok(Self { value }) [INFO] [stdout] | ^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/message/success.rs:20:62 [INFO] [stdout] | [INFO] [stdout] 20 | let value = parse.next_bytes_or_null()?.and_then(|v| Value::new(v).ok()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/message/set.rs:20:12 [INFO] [stdout] | [INFO] [stdout] 18 | let value = Value::new(parse.next_bytes()?)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | [INFO] [stdout] 20 | Ok(Set::new(key, value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 32 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kvsd` (lib) due to 33 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "2fda658be67cf5eb1547b10f5774f6c8858405fdf8ba9d02ae29587677589493", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2fda658be67cf5eb1547b10f5774f6c8858405fdf8ba9d02ae29587677589493", kill_on_drop: false }` [INFO] [stdout] 2fda658be67cf5eb1547b10f5774f6c8858405fdf8ba9d02ae29587677589493