[INFO] fetching crate kvbench 0.2.1... [INFO] checking kvbench-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate kvbench 0.2.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate kvbench 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate kvbench 0.2.1 [INFO] finished tweaking crates.io crate kvbench 0.2.1 [INFO] tweaked toml for crates.io crate kvbench 0.2.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate kvbench 0.2.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4fa65e2341d09148845a0263d83b85c6acbafc1f4e112a618652173bd6656f92 [INFO] running `Command { std: "docker" "start" "-a" "4fa65e2341d09148845a0263d83b85c6acbafc1f4e112a618652173bd6656f92", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4fa65e2341d09148845a0263d83b85c6acbafc1f4e112a618652173bd6656f92", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4fa65e2341d09148845a0263d83b85c6acbafc1f4e112a618652173bd6656f92", kill_on_drop: false }` [INFO] [stdout] 4fa65e2341d09148845a0263d83b85c6acbafc1f4e112a618652173bd6656f92 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 619bc4d52d20b677bd8f42468de10ba6a654b21f2360b5c4d762053546feb6dc [INFO] running `Command { std: "docker" "start" "-a" "619bc4d52d20b677bd8f42468de10ba6a654b21f2360b5c4d762053546feb6dc", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling serde v1.0.207 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Compiling proc-macro2-diagnostics v0.10.1 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Compiling yansi v1.0.1 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling uncased v0.9.10 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Compiling figment v0.10.19 [INFO] [stderr] Checking inlinable_string v0.1.15 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking raw-cpuid v11.0.2 [INFO] [stderr] Checking inventory v0.3.15 [INFO] [stderr] Checking rustix v0.38.34 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking quanta v0.12.3 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking core_affinity v0.8.1 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking hdrhistogram v7.5.4 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking env_filter v0.1.1 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Checking zipf v7.0.1 [INFO] [stderr] Checking ctrlc v3.4.5 [INFO] [stderr] Compiling serde_derive v1.0.207 [INFO] [stderr] Compiling pear_codegen v0.2.9 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Checking pear v0.2.9 [INFO] [stderr] Checking clap v4.5.15 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking kvbench v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bench.rs:953:27 [INFO] [stdout] | [INFO] [stdout] 953 | .map(|_| Arc::new(Measurement::new(benchmark.repeat))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bench.rs:992:27 [INFO] [stdout] | [INFO] [stdout] 992 | .map(|_| Arc::new(Measurement::new(benchmark.repeat))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:139:21 [INFO] [stdout] | [INFO] [stdout] 138 | fn new(stream: TcpStream) -> RcTcpStream { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | RcTcpStream(Rc::new(stream)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:165:14 [INFO] [stdout] | [INFO] [stdout] 164 | fn new(stream: RcTcpStream) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | Self(BufReader::new(stream)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:191:14 [INFO] [stdout] | [INFO] [stdout] 190 | fn new(stream: RcTcpStream) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | Self(RefCell::new(BufWriter::new(stream))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stores/null.rs:71:18 [INFO] [stdout] | [INFO] [stdout] 70 | fn handle(&self, responder: Rc) -> Box { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | Box::new(NullMapAsyncHandle(Vec::new(), responder.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stores/remote.rs:52:18 [INFO] [stdout] | [INFO] [stdout] 51 | fn handle(&self, responder: Rc) -> Box { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | Box::new(RemoteMapHandle { [INFO] [stdout] | __________________^ [INFO] [stdout] 53 | | client: KVClient::new(&self.host, &self.port).unwrap(), [INFO] [stdout] 54 | | responder, [INFO] [stdout] 55 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread.rs:49:18 [INFO] [stdout] | [INFO] [stdout] 47 | fn spawn(&self, f: Box) -> Box { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let handle = std::thread::spawn(f); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | Box::new(DefaultJoinHandle(handle)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kvbench` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bench.rs:953:27 [INFO] [stdout] | [INFO] [stdout] 953 | .map(|_| Arc::new(Measurement::new(benchmark.repeat))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bench.rs:992:27 [INFO] [stdout] | [INFO] [stdout] 992 | .map(|_| Arc::new(Measurement::new(benchmark.repeat))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:139:21 [INFO] [stdout] | [INFO] [stdout] 138 | fn new(stream: TcpStream) -> RcTcpStream { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | RcTcpStream(Rc::new(stream)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:165:14 [INFO] [stdout] | [INFO] [stdout] 164 | fn new(stream: RcTcpStream) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | Self(BufReader::new(stream)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:191:14 [INFO] [stdout] | [INFO] [stdout] 190 | fn new(stream: RcTcpStream) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | Self(RefCell::new(BufWriter::new(stream))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stores/null.rs:71:18 [INFO] [stdout] | [INFO] [stdout] 70 | fn handle(&self, responder: Rc) -> Box { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | Box::new(NullMapAsyncHandle(Vec::new(), responder.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stores/remote.rs:52:18 [INFO] [stdout] | [INFO] [stdout] 51 | fn handle(&self, responder: Rc) -> Box { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | Box::new(RemoteMapHandle { [INFO] [stdout] | __________________^ [INFO] [stdout] 53 | | client: KVClient::new(&self.host, &self.port).unwrap(), [INFO] [stdout] 54 | | responder, [INFO] [stdout] 55 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread.rs:49:18 [INFO] [stdout] | [INFO] [stdout] 47 | fn spawn(&self, f: Box) -> Box { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let handle = std::thread::spawn(f); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | Box::new(DefaultJoinHandle(handle)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workload.rs:491:68 [INFO] [stdout] | [INFO] [stdout] 491 | let mut freq: Vec<(Box<[u8]>, u64)> = dist.iter().map(|e| (e.0.clone(), *e.1)).collect(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workload.rs:505:68 [INFO] [stdout] | [INFO] [stdout] 505 | let mut freq: Vec<(Box<[u8]>, u64)> = dist.iter().map(|e| (e.0.clone(), *e.1)).collect(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kvbench` (lib test) due to 11 previous errors [INFO] running `Command { std: "docker" "inspect" "619bc4d52d20b677bd8f42468de10ba6a654b21f2360b5c4d762053546feb6dc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "619bc4d52d20b677bd8f42468de10ba6a654b21f2360b5c4d762053546feb6dc", kill_on_drop: false }` [INFO] [stdout] 619bc4d52d20b677bd8f42468de10ba6a654b21f2360b5c4d762053546feb6dc