[INFO] fetching crate kv-par-merge-sort 0.1.0... [INFO] checking kv-par-merge-sort-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate kv-par-merge-sort 0.1.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate kv-par-merge-sort 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate kv-par-merge-sort 0.1.0 [INFO] finished tweaking crates.io crate kv-par-merge-sort 0.1.0 [INFO] tweaked toml for crates.io crate kv-par-merge-sort 0.1.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate kv-par-merge-sort 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 506d87bfbe0dfb91dff86260f146a00839d9290281ebcb350a5058c9eb2fb47f [INFO] running `Command { std: "docker" "start" "-a" "506d87bfbe0dfb91dff86260f146a00839d9290281ebcb350a5058c9eb2fb47f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "506d87bfbe0dfb91dff86260f146a00839d9290281ebcb350a5058c9eb2fb47f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "506d87bfbe0dfb91dff86260f146a00839d9290281ebcb350a5058c9eb2fb47f", kill_on_drop: false }` [INFO] [stdout] 506d87bfbe0dfb91dff86260f146a00839d9290281ebcb350a5058c9eb2fb47f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2b4cb1a8352e42bdf9777adc54039d4a79d6b6242fe968f46c851d37695ee6aa [INFO] running `Command { std: "docker" "start" "-a" "2b4cb1a8352e42bdf9777adc54039d4a79d6b6242fe968f46c851d37695ee6aa", kill_on_drop: false }` [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling proc-macro2 v1.0.39 [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling unicode-ident v1.0.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.8 [INFO] [stderr] Compiling syn v1.0.95 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling crossbeam-queue v0.3.5 [INFO] [stderr] Checking once_cell v1.12.0 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Checking fastrand v1.7.0 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling crossbeam-epoch v0.9.8 [INFO] [stderr] Compiling indexmap v1.8.2 [INFO] [stderr] Checking tracing-core v0.1.26 [INFO] [stderr] Checking sharded-slab v0.1.4 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking regex-syntax v0.6.26 [INFO] [stderr] Checking thread_local v1.1.4 [INFO] [stderr] Checking smallvec v1.8.0 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking os_str_bytes v6.1.0 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking json v0.12.4 [INFO] [stderr] Checking bytemuck v1.9.1 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking tracing-log v0.1.3 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking clap_lex v0.2.0 [INFO] [stderr] Checking crossbeam-channel v0.5.4 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Checking tracing-subscriber v0.3.11 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking getrandom v0.2.6 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking tempfile v3.3.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking crossbeam v0.8.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking regex v1.5.6 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling tracing-attributes v0.1.21 [INFO] [stderr] Compiling clap_derive v3.1.18 [INFO] [stderr] Checking tracing v0.1.34 [INFO] [stderr] Checking tracing-chrome v0.6.0 [INFO] [stderr] Checking kv-par-merge-sort v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chunk.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 42 | mut key_file: File, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | mut value_file: File, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 49 | | key_file, [INFO] [stdout] 50 | | value_file, [INFO] [stdout] 51 | | num_entries, [INFO] [stdout] 52 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merge.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 14 | chunks: Vec, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | tempfile_in(tmp_dir_path)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merge.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 14 | chunks: Vec, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | tempfile_in(tmp_dir_path)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merge.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 30 | chunks: Vec, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | merged_key_file: File, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | merged_value_file: File, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | let span = tracing::info_span!("merge_persisted_chunks"); [INFO] [stdout] | ---- --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let _guard = span.enter(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | let mut readers: Vec<_> = chunks [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | let mut key_writer = BufWriter::with_capacity(ONE_MIB, merged_key_file); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | let mut value_writer = BufWriter::with_capacity(ONE_MIB, merged_value_file); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | key_writer.into_inner()?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merge.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 30 | chunks: Vec, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | merged_key_file: File, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | merged_value_file: File, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | let span = tracing::info_span!("merge_persisted_chunks"); [INFO] [stdout] | ---- --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let _guard = span.enter(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | let mut readers: Vec<_> = chunks [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | let mut key_writer = BufWriter::with_capacity(ONE_MIB, merged_key_file); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | let mut value_writer = BufWriter::with_capacity(ONE_MIB, merged_value_file); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | value_writer.into_inner()?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merge.rs:50:17 [INFO] [stdout] | [INFO] [stdout] 48 | .map(|chunk| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | ( [INFO] [stdout] 50 | BufReader::with_capacity(ONE_MIB, chunk.key_file), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merge.rs:51:17 [INFO] [stdout] | [INFO] [stdout] 48 | .map(|chunk| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | BufReader::with_capacity(ONE_MIB, chunk.value_file), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pipeline.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn finish(self) -> Result<(), io::Error> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | self.merge_initiator_thread_handle.join().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pipeline.rs:164:9 [INFO] [stdout] | [INFO] [stdout] 148 | let sort_span = tracing::info_span!("sort_chunk"); [INFO] [stdout] | --------- --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | let persist_span = tracing::info_span!("persist_sorted_chunk"); [INFO] [stdout] | ------------ ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | let _gaurd = persist_span.enter(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | let mut key_writer = BufWriter::with_capacity(ONE_MIB, tempfile_in(tmp_dir_path)?); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 157 | let mut value_writer = BufWriter::with_capacity(ONE_MIB, tempfile_in(tmp_dir_path)?); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 164 | key_writer.into_inner()?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pipeline.rs:165:9 [INFO] [stdout] | [INFO] [stdout] 148 | let sort_span = tracing::info_span!("sort_chunk"); [INFO] [stdout] | --------- --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | let persist_span = tracing::info_span!("persist_sorted_chunk"); [INFO] [stdout] | ------------ ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | let _gaurd = persist_span.enter(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | let mut key_writer = BufWriter::with_capacity(ONE_MIB, tempfile_in(tmp_dir_path)?); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 157 | let mut value_writer = BufWriter::with_capacity(ONE_MIB, tempfile_in(tmp_dir_path)?); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | value_writer.into_inner()?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kv-par-merge-sort` (lib) due to 11 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "2b4cb1a8352e42bdf9777adc54039d4a79d6b6242fe968f46c851d37695ee6aa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2b4cb1a8352e42bdf9777adc54039d4a79d6b6242fe968f46c851d37695ee6aa", kill_on_drop: false }` [INFO] [stdout] 2b4cb1a8352e42bdf9777adc54039d4a79d6b6242fe968f46c851d37695ee6aa