[INFO] fetching crate krates 0.17.1... [INFO] checking krates-0.17.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate krates 0.17.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate krates 0.17.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-3-tc2/source/.cargo/config.toml [INFO] started tweaking crates.io crate krates 0.17.1 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate krates 0.17.1 [INFO] tweaked toml for crates.io crate krates 0.17.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate krates 0.17.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 43c0f1c454b73c63946ba3cc2b18ece87be001a8dc8735e29ebbd0b9575bc042 [INFO] running `Command { std: "docker" "start" "-a" "43c0f1c454b73c63946ba3cc2b18ece87be001a8dc8735e29ebbd0b9575bc042", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "43c0f1c454b73c63946ba3cc2b18ece87be001a8dc8735e29ebbd0b9575bc042", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "43c0f1c454b73c63946ba3cc2b18ece87be001a8dc8735e29ebbd0b9575bc042", kill_on_drop: false }` [INFO] [stdout] 43c0f1c454b73c63946ba3cc2b18ece87be001a8dc8735e29ebbd0b9575bc042 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a3a081fe7dc44c0613027bdaf43b0849fb5457e197a476eafc4c7362b6c99826 [INFO] running `Command { std: "docker" "start" "-a" "a3a081fe7dc44c0613027bdaf43b0849fb5457e197a476eafc4c7362b6c99826", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Compiling serde_json v1.0.122 [INFO] [stderr] Compiling camino v1.1.7 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking indexmap v2.3.0 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking toml-span v0.3.0 [INFO] [stderr] Checking cfg-expr v0.16.0 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking clap_builder v4.5.13 [INFO] [stderr] Checking similar v2.6.0 [INFO] [stderr] Checking petgraph v0.6.5 [INFO] [stderr] Checking similar-asserts v1.5.0 [INFO] [stderr] Checking insta v1.39.0 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking clap v4.5.13 [INFO] [stderr] Checking smol_str v0.2.2 [INFO] [stderr] Checking tame-index v0.13.1 [INFO] [stderr] Checking krates v0.17.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:792:25 [INFO] [stdout] | [INFO] [stdout] 782 | name: impl Into, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 783 | req: semver::VersionReq, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 792 | .filter_map(move |(index, node)| { [INFO] [stdout] | _________________________^ [INFO] [stdout] 793 | | if let Node::Krate { krate, id, .. } = &node.weight { [INFO] [stdout] 794 | | if krate.name() == name && req.matches(krate.version()) { [INFO] [stdout] 795 | | return Some(KrateMatch { [INFO] [stdout] ... | [INFO] [stdout] 803 | | None [INFO] [stdout] 804 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:905:22 [INFO] [stdout] | [INFO] [stdout] 905 | .then(|| cfg_expr::Expression::parse(&inner).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cm.rs:648:8 [INFO] [stdout] | [INFO] [stdout] 621 | deserializer: D, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 648 | Ok(Some( [INFO] [stdout] | ________^ [INFO] [stdout] 649 | | Version::parse(&buf).map_err(serde::de::Error::custom)?, [INFO] [stdout] 650 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cm/dependency.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 34 | pub(super) fn parse_dependency_kind<'de, D>(d: D) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | Deserialize::deserialize(d).map(|x: Option<_>| x.unwrap_or_default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:1668:12 [INFO] [stdout] | [INFO] [stdout] 601 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 602 | md: crate::Metadata, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 603 | mut on_filter: F, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 612 | let mut packages: Vec<_> = md [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 621 | let index = self.crates_io_index.map(|index| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 682 | let exclude = self.exclude; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 736 | let mut nodes: Vec<_> = resolved [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1377 | let mut graph = petgraph::Graph::, E>::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1668 | Ok(Krates { [INFO] [stdout] | ____________^ [INFO] [stdout] 1669 | | graph, [INFO] [stdout] 1670 | | workspace_members, [INFO] [stdout] 1671 | | workspace_root: md.workspace_root, [INFO] [stdout] 1672 | | krates_end, [INFO] [stdout] 1673 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:758:38 [INFO] [stdout] | [INFO] [stdout] 758 | ... cfg: dk.target.map(MdTarget::from), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder/index.rs:28:20 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn new(build: BuildIndexCache, krates: BTreeSet) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | Self { [INFO] [stdout] 28 | cache: build(krates), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `krates` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:792:25 [INFO] [stdout] | [INFO] [stdout] 782 | name: impl Into, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 783 | req: semver::VersionReq, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 792 | .filter_map(move |(index, node)| { [INFO] [stdout] | _________________________^ [INFO] [stdout] 793 | | if let Node::Krate { krate, id, .. } = &node.weight { [INFO] [stdout] 794 | | if krate.name() == name && req.matches(krate.version()) { [INFO] [stdout] 795 | | return Some(KrateMatch { [INFO] [stdout] ... | [INFO] [stdout] 803 | | None [INFO] [stdout] 804 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:905:22 [INFO] [stdout] | [INFO] [stdout] 905 | .then(|| cfg_expr::Expression::parse(&inner).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cm.rs:648:8 [INFO] [stdout] | [INFO] [stdout] 621 | deserializer: D, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 648 | Ok(Some( [INFO] [stdout] | ________^ [INFO] [stdout] 649 | | Version::parse(&buf).map_err(serde::de::Error::custom)?, [INFO] [stdout] 650 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cm/dependency.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 34 | pub(super) fn parse_dependency_kind<'de, D>(d: D) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | Deserialize::deserialize(d).map(|x: Option<_>| x.unwrap_or_default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:1668:12 [INFO] [stdout] | [INFO] [stdout] 601 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 602 | md: crate::Metadata, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 603 | mut on_filter: F, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 612 | let mut packages: Vec<_> = md [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 621 | let index = self.crates_io_index.map(|index| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 682 | let exclude = self.exclude; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 736 | let mut nodes: Vec<_> = resolved [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1377 | let mut graph = petgraph::Graph::, E>::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1668 | Ok(Krates { [INFO] [stdout] | ____________^ [INFO] [stdout] 1669 | | graph, [INFO] [stdout] 1670 | | workspace_members, [INFO] [stdout] 1671 | | workspace_root: md.workspace_root, [INFO] [stdout] 1672 | | krates_end, [INFO] [stdout] 1673 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:758:38 [INFO] [stdout] | [INFO] [stdout] 758 | ... cfg: dk.target.map(MdTarget::from), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder/index.rs:28:20 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn new(build: BuildIndexCache, krates: BTreeSet) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | Self { [INFO] [stdout] 28 | cache: build(krates), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `krates` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "a3a081fe7dc44c0613027bdaf43b0849fb5457e197a476eafc4c7362b6c99826", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a3a081fe7dc44c0613027bdaf43b0849fb5457e197a476eafc4c7362b6c99826", kill_on_drop: false }` [INFO] [stdout] a3a081fe7dc44c0613027bdaf43b0849fb5457e197a476eafc4c7362b6c99826