[INFO] fetching crate krate_info 0.1.1... [INFO] checking krate_info-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate krate_info 0.1.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate krate_info 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate krate_info 0.1.1 [INFO] finished tweaking crates.io crate krate_info 0.1.1 [INFO] tweaked toml for crates.io crate krate_info 0.1.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate krate_info 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5465ea429c2ed64df2d99c41116fe0c04d40aaed05fa7c97f404e2bd173b4741 [INFO] running `Command { std: "docker" "start" "-a" "5465ea429c2ed64df2d99c41116fe0c04d40aaed05fa7c97f404e2bd173b4741", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5465ea429c2ed64df2d99c41116fe0c04d40aaed05fa7c97f404e2bd173b4741", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5465ea429c2ed64df2d99c41116fe0c04d40aaed05fa7c97f404e2bd173b4741", kill_on_drop: false }` [INFO] [stdout] 5465ea429c2ed64df2d99c41116fe0c04d40aaed05fa7c97f404e2bd173b4741 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4f17c667e030e6901ab8c8125702d8071d3195a9417edb37ad7d95b762136acc [INFO] running `Command { std: "docker" "start" "-a" "4f17c667e030e6901ab8c8125702d8071d3195a9417edb37ad7d95b762136acc", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.67 [INFO] [stderr] Compiling libc v0.2.148 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Compiling pkg-config v0.3.27 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling futures-task v0.3.28 [INFO] [stderr] Compiling futures-channel v0.3.28 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Checking futures-io v0.3.28 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Checking memchr v2.6.3 [INFO] [stderr] Checking tracing-core v0.1.31 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling openssl v0.10.57 [INFO] [stderr] Checking http v0.2.9 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Compiling syn v2.0.37 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking socket2 v0.5.4 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Checking percent-encoding v2.3.0 [INFO] [stderr] Checking tokio v1.32.0 [INFO] [stderr] Checking try-lock v0.2.4 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Checking form_urlencoded v1.2.0 [INFO] [stderr] Checking socket2 v0.4.9 [INFO] [stderr] Compiling num-traits v0.2.16 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking unicode-bidi v0.3.13 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Compiling serde_json v1.0.107 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking encoding_rs v0.8.33 [INFO] [stderr] Compiling openssl-sys v0.9.93 [INFO] [stderr] Checking base64 v0.21.4 [INFO] [stderr] Checking idna v0.4.0 [INFO] [stderr] Checking ipnet v2.8.0 [INFO] [stderr] Compiling semver v1.0.18 [INFO] [stderr] Checking url v2.4.1 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Checking serde_path_to_error v0.1.14 [INFO] [stderr] Compiling futures-macro v0.3.28 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Checking tokio-util v0.7.8 [INFO] [stderr] Checking h2 v0.3.21 [INFO] [stderr] Checking futures-executor v0.3.28 [INFO] [stderr] Checking futures v0.3.28 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking hyper v0.14.27 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.20 [INFO] [stderr] Checking crates_io_api v0.8.1 [INFO] [stderr] Checking krate_info v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `Level`, `error`, `info`, and `log_enabled` [INFO] [stdout] --> src/krates.rs:2:18 [INFO] [stdout] | [INFO] [stdout] 2 | use log::{debug, error, info, log_enabled, Level}; [INFO] [stdout] | ^^^^^ ^^^^ ^^^^^^^^^^^ ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `HashMap` and `error::Error` [INFO] [stdout] --> src/krates.rs:5:19 [INFO] [stdout] | [INFO] [stdout] 5 | collections::{HashMap, HashSet}, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 6 | error::Error, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashSet` [INFO] [stdout] --> src/lib.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | use std::collections::HashSet; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Level`, `error`, `info`, and `log_enabled` [INFO] [stdout] --> src/krates.rs:2:18 [INFO] [stdout] | [INFO] [stdout] 2 | use log::{debug, error, info, log_enabled, Level}; [INFO] [stdout] | ^^^^^ ^^^^ ^^^^^^^^^^^ ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `HashMap` and `error::Error` [INFO] [stdout] --> src/krates.rs:5:19 [INFO] [stdout] | [INFO] [stdout] 5 | collections::{HashMap, HashSet}, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 6 | error::Error, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/krates.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 60 | Err(e) => return Err(KrateError::NoMetadataError(e)), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Ok(Krate::new(name, Version::parse(&version.num).unwrap())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/krates.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 60 | Err(e) => return Err(KrateError::NoMetadataError(e)), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Ok(Krate::new(name, Version::parse(&version.num).unwrap())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/krates.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | k.fill_information_from_crates_api(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 69 | let _ = k.fill_information_from_crates_api(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/krates.rs:78:13 [INFO] [stdout] | [INFO] [stdout] 78 | self.fill_information_from_crates_api(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 78 | let _ = self.fill_information_from_crates_api(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/krates.rs:91:15 [INFO] [stdout] | [INFO] [stdout] 85 | let client = SyncClient::new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | match client.crate_owners(&self.name) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/krates.rs:103:13 [INFO] [stdout] | [INFO] [stdout] 103 | self.fill_information_from_crates_api(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 103 | let _ = self.fill_information_from_crates_api(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/krates.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | k.fill_information_from_crates_api(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 69 | let _ = k.fill_information_from_crates_api(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/krates.rs:78:13 [INFO] [stdout] | [INFO] [stdout] 78 | self.fill_information_from_crates_api(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 78 | let _ = self.fill_information_from_crates_api(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/krates.rs:126:36 [INFO] [stdout] | [INFO] [stdout] 126 | let tarball_path = dest_dir.clone().join(format!("{:#}.tar.gz", self.name)); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 126 - let tarball_path = dest_dir.clone().join(format!("{:#}.tar.gz", self.name)); [INFO] [stdout] 126 + let tarball_path = dest_dir.join(format!("{:#}.tar.gz", self.name)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/krates.rs:91:15 [INFO] [stdout] | [INFO] [stdout] 85 | let client = SyncClient::new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | match client.crate_owners(&self.name) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/krates.rs:103:13 [INFO] [stdout] | [INFO] [stdout] 103 | self.fill_information_from_crates_api(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 103 | let _ = self.fill_information_from_crates_api(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/krates.rs:126:36 [INFO] [stdout] | [INFO] [stdout] 126 | let tarball_path = dest_dir.clone().join(format!("{:#}.tar.gz", self.name)); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 126 - let tarball_path = dest_dir.clone().join(format!("{:#}.tar.gz", self.name)); [INFO] [stdout] 126 + let tarball_path = dest_dir.join(format!("{:#}.tar.gz", self.name)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `krate_info` (lib) due to 3 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `krate_info` (lib test) due to 3 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "4f17c667e030e6901ab8c8125702d8071d3195a9417edb37ad7d95b762136acc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4f17c667e030e6901ab8c8125702d8071d3195a9417edb37ad7d95b762136acc", kill_on_drop: false }` [INFO] [stdout] 4f17c667e030e6901ab8c8125702d8071d3195a9417edb37ad7d95b762136acc