[INFO] fetching crate koibumi-node-sync 0.0.1... [INFO] checking koibumi-node-sync-0.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate koibumi-node-sync 0.0.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate koibumi-node-sync 0.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate koibumi-node-sync 0.0.1 [INFO] finished tweaking crates.io crate koibumi-node-sync 0.0.1 [INFO] tweaked toml for crates.io crate koibumi-node-sync 0.0.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 70 packages to latest compatible versions [INFO] [stderr] Adding fallible-iterator v0.2.0 (latest: v0.3.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding hashlink v0.8.4 (latest: v0.9.1) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding libsqlite3-sys v0.26.0 (latest: v0.30.1) [INFO] [stderr] Adding rusqlite v0.29.0 (latest: v0.32.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a20ac00d316b75b3537394fdd687a24fa3e4fc143ec4495bb331ea8d00024a23 [INFO] running `Command { std: "docker" "start" "-a" "a20ac00d316b75b3537394fdd687a24fa3e4fc143ec4495bb331ea8d00024a23", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a20ac00d316b75b3537394fdd687a24fa3e4fc143ec4495bb331ea8d00024a23", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a20ac00d316b75b3537394fdd687a24fa3e4fc143ec4495bb331ea8d00024a23", kill_on_drop: false }` [INFO] [stdout] a20ac00d316b75b3537394fdd687a24fa3e4fc143ec4495bb331ea8d00024a23 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cdecc6642cd188f568f69b1fe4f2173e9760d9ea00cbb92d742faa4d41ec6f4f [INFO] running `Command { std: "docker" "start" "-a" "cdecc6642cd188f568f69b1fe4f2173e9760d9ea00cbb92d742faa4d41ec6f4f", kill_on_drop: false }` [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking block-padding v0.3.3 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling secp256k1-sys v0.10.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling libsqlite3-sys v0.26.0 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking koibumi-net v0.0.1 [INFO] [stderr] Checking koibumi-base32 v0.0.3 [INFO] [stderr] Checking ripemd v0.1.3 [INFO] [stderr] Checking sha3 v0.10.8 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking cbc v0.1.2 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking koibumi-socks-sync v0.0.1 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking hashlink v0.8.4 [INFO] [stderr] Checking rusqlite v0.29.0 [INFO] [stderr] Checking rand_distr v0.4.3 [INFO] [stderr] Checking koibumi-base58 v0.0.2 [INFO] [stderr] Checking koibumi-secp256k1 v0.0.0 [INFO] [stderr] Checking koibumi-core v0.0.9 [INFO] [stderr] Checking koibumi-node-sync v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/connection_loop.rs:548:17 [INFO] [stdout] | [INFO] [stdout] 548 | Ok(void) => match void {}, [INFO] [stdout] | ^^^^^^^^ matches no values because `Void` is uninhabited [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/connection_loop.rs:548:17 [INFO] [stdout] | [INFO] [stdout] 548 | Ok(void) => match void {}, [INFO] [stdout] | ^^^^^^^^ matches no values because `Void` is uninhabited [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection_loop.rs:306:23 [INFO] [stdout] | [INFO] [stdout] 305 | pub fn stop(self) -> thread::JoinHandle<()> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 306 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 307 | | let bm_event_sender = self.ctx.bm_event_sender().clone(); [INFO] [stdout] 308 | | [INFO] [stdout] 309 | | if let Some(sender) = self.server_shutdown_sender { [INFO] [stdout] ... | [INFO] [stdout] 351 | | } [INFO] [stdout] 352 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection_loop.rs:388:19 [INFO] [stdout] | [INFO] [stdout] 384 | fn spawn_and_log_error(f: F, level: Level) -> thread::JoinHandle<()> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 388 | thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 389 | | if let Err(e) = f() { [INFO] [stdout] 390 | | log!(level, "{}", e) [INFO] [stdout] 391 | | } [INFO] [stdout] 392 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection_loop.rs:646:37 [INFO] [stdout] | [INFO] [stdout] 645 | fn from(err: socks::ConnectError) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 646 | ConnectOutgoingError::Error(Error::from(err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/inv_manager.rs:303:9 [INFO] [stdout] | [INFO] [stdout] 287 | let stmt = self [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 294 | let mut stmt = stmt.unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 295 | let m = stmt.query_row(rusqlite::params![k.as_ref()], |row| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 303 | message::Object::sized_read_from_exact(&m).ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection_loop.rs:306:23 [INFO] [stdout] | [INFO] [stdout] 305 | pub fn stop(self) -> thread::JoinHandle<()> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 306 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 307 | | let bm_event_sender = self.ctx.bm_event_sender().clone(); [INFO] [stdout] 308 | | [INFO] [stdout] 309 | | if let Some(sender) = self.server_shutdown_sender { [INFO] [stdout] ... | [INFO] [stdout] 351 | | } [INFO] [stdout] 352 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection_loop.rs:388:19 [INFO] [stdout] | [INFO] [stdout] 384 | fn spawn_and_log_error(f: F, level: Level) -> thread::JoinHandle<()> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 388 | thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 389 | | if let Err(e) = f() { [INFO] [stdout] 390 | | log!(level, "{}", e) [INFO] [stdout] 391 | | } [INFO] [stdout] 392 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection_loop.rs:646:37 [INFO] [stdout] | [INFO] [stdout] 645 | fn from(err: socks::ConnectError) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 646 | ConnectOutgoingError::Error(Error::from(err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/inv_manager.rs:303:9 [INFO] [stdout] | [INFO] [stdout] 287 | let stmt = self [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 294 | let mut stmt = stmt.unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 295 | let m = stmt.query_row(rusqlite::params![k.as_ref()], |row| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 303 | message::Object::sized_read_from_exact(&m).ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `koibumi-node-sync` (lib) due to 5 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `koibumi-node-sync` (lib test) due to 5 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "cdecc6642cd188f568f69b1fe4f2173e9760d9ea00cbb92d742faa4d41ec6f4f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cdecc6642cd188f568f69b1fe4f2173e9760d9ea00cbb92d742faa4d41ec6f4f", kill_on_drop: false }` [INFO] [stdout] cdecc6642cd188f568f69b1fe4f2173e9760d9ea00cbb92d742faa4d41ec6f4f