[INFO] fetching crate kodept 0.2.3... [INFO] checking kodept-0.2.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate kodept 0.2.3 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate kodept 0.2.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate kodept 0.2.3 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate kodept 0.2.3 [INFO] tweaked toml for crates.io crate kodept 0.2.3 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate kodept 0.2.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7f9943b68ee2411e7ada560f1ee7b48b09f8bc47f012600a6aba4c265ebfc446 [INFO] running `Command { std: "docker" "start" "-a" "7f9943b68ee2411e7ada560f1ee7b48b09f8bc47f012600a6aba4c265ebfc446", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7f9943b68ee2411e7ada560f1ee7b48b09f8bc47f012600a6aba4c265ebfc446", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7f9943b68ee2411e7ada560f1ee7b48b09f8bc47f012600a6aba4c265ebfc446", kill_on_drop: false }` [INFO] [stdout] 7f9943b68ee2411e7ada560f1ee7b48b09f8bc47f012600a6aba4c265ebfc446 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4f3c4234d231e05267c7a4f103d47a21007d3cdbf8b6c9358135157b11ff9aa5 [INFO] running `Command { std: "docker" "start" "-a" "4f3c4234d231e05267c7a4f103d47a21007d3cdbf8b6c9358135157b11ff9aa5", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-segmentation v1.11.0 [INFO] [stderr] Compiling unicode-xid v0.2.4 [INFO] [stderr] Checking fixedbitset v0.4.2 [INFO] [stderr] Compiling slotmap v1.0.7 [INFO] [stderr] Checking indexmap v2.3.0 [INFO] [stderr] Compiling ref-cast v1.0.23 [INFO] [stderr] Checking pathdiff v0.2.1 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking qcell v0.5.4 [INFO] [stderr] Compiling peg-runtime v0.8.3 [INFO] [stderr] Checking constcat v0.5.0 [INFO] [stderr] Checking nonempty-collections v0.2.7 [INFO] [stderr] Checking owning_ref v0.3.3 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking snowflake v1.3.0 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking replace_with v0.1.7 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Compiling peg-macros v0.8.4 [INFO] [stderr] Checking id_tree v1.8.0 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking codespan-reporting v0.11.1 [INFO] [stderr] Checking clap_builder v4.5.13 [INFO] [stderr] Compiling convert_case v0.6.0 [INFO] [stderr] Checking insta v1.39.0 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Checking codespan v0.11.1 [INFO] [stderr] Checking petgraph v0.6.5 [INFO] [stderr] Checking parking_lot v0.4.8 [INFO] [stderr] Checking chashmap v2.2.2 [INFO] [stderr] Checking peg v0.8.4 [INFO] [stderr] Checking slotgraph v0.1.0 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Compiling derive_more-impl v1.0.0-beta.7 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling ref-cast-impl v1.0.23 [INFO] [stderr] Compiling extend v1.2.0 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking clap v4.5.13 [INFO] [stderr] Checking kodept-inference v0.2.3 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking derive_more v1.0.0-beta.7 [INFO] [stderr] Checking kodept-core v0.2.8 [INFO] [stderr] Checking kodept-ast v0.4.1 [INFO] [stderr] Checking kodept-parse v0.3.0 [INFO] [stderr] Checking kodept-macros v0.1.6 [INFO] [stderr] Checking kodept-interpret v0.1.2 [INFO] [stderr] Checking kodept v0.2.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loader.rs:103:26 [INFO] [stdout] | [INFO] [stdout] 94 | .filter_map_ok(|it| { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | let file = match File::open(it.path()) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | Ok(f) => f, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | Some((file, it.path())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loader.rs:139:22 [INFO] [stdout] | [INFO] [stdout] 138 | pub fn from_text(text: impl IntoIterator) -> Self { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | Self::Memory(text.into_iter().collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/macro_context.rs:37:19 [INFO] [stdout] | [INFO] [stdout] 31 | rlt_accessor: RLTAccessor, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | ast: SyntaxTree, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | tree: Rc::new(ast), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read_code_source.rs:38:20 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn with_filename(&self, f: impl Fn(&Self) -> T) -> FileRelative { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | FileRelative { [INFO] [stdout] 38 | value: f(self), [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/steps/mod.rs:59:15 [INFO] [stdout] | [INFO] [stdout] 51 | let head = if pack.node.ro(pack.token).try_as_ref().is_some() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | let tail = self.tail.apply(pack); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | [INFO] [stdout] 59 | match (head, tail) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/steps/mod.rs:98:31 [INFO] [stdout] | [INFO] [stdout] 77 | let mut token = PermTkn::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | let mut changes = ChangeSet::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | match context.modify_tree(|tree| tree.apply_changes(changes, &token)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kodept` (lib test) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loader.rs:103:26 [INFO] [stdout] | [INFO] [stdout] 94 | .filter_map_ok(|it| { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | let file = match File::open(it.path()) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | Ok(f) => f, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | Some((file, it.path())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loader.rs:139:22 [INFO] [stdout] | [INFO] [stdout] 138 | pub fn from_text(text: impl IntoIterator) -> Self { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | Self::Memory(text.into_iter().collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/macro_context.rs:37:19 [INFO] [stdout] | [INFO] [stdout] 31 | rlt_accessor: RLTAccessor, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | ast: SyntaxTree, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | tree: Rc::new(ast), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read_code_source.rs:38:20 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn with_filename(&self, f: impl Fn(&Self) -> T) -> FileRelative { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | FileRelative { [INFO] [stdout] 38 | value: f(self), [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/steps/mod.rs:59:15 [INFO] [stdout] | [INFO] [stdout] 51 | let head = if pack.node.ro(pack.token).try_as_ref().is_some() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | let tail = self.tail.apply(pack); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | [INFO] [stdout] 59 | match (head, tail) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/steps/mod.rs:98:31 [INFO] [stdout] | [INFO] [stdout] 77 | let mut token = PermTkn::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | let mut changes = ChangeSet::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | match context.modify_tree(|tree| tree.apply_changes(changes, &token)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kodept` (lib) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "4f3c4234d231e05267c7a4f103d47a21007d3cdbf8b6c9358135157b11ff9aa5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4f3c4234d231e05267c7a4f103d47a21007d3cdbf8b6c9358135157b11ff9aa5", kill_on_drop: false }` [INFO] [stdout] 4f3c4234d231e05267c7a4f103d47a21007d3cdbf8b6c9358135157b11ff9aa5