[INFO] fetching crate knyst 0.5.0... [INFO] checking knyst-0.5.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate knyst 0.5.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate knyst 0.5.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate knyst 0.5.0 [INFO] removed 0 missing examples [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate knyst 0.5.0 [INFO] tweaked toml for crates.io crate knyst 0.5.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate knyst 0.5.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 96f3ceba7ee2a48d61ab78629b4c297c33f492070f626b0836ec68fd1422babb [INFO] running `Command { std: "docker" "start" "-a" "96f3ceba7ee2a48d61ab78629b4c297c33f492070f626b0836ec68fd1422babb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "96f3ceba7ee2a48d61ab78629b4c297c33f492070f626b0836ec68fd1422babb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "96f3ceba7ee2a48d61ab78629b4c297c33f492070f626b0836ec68fd1422babb", kill_on_drop: false }` [INFO] [stdout] 96f3ceba7ee2a48d61ab78629b4c297c33f492070f626b0836ec68fd1422babb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] de4a678cf3eab7109fadfe7243fd76f6d3e25560ec93717bd92c9dcc976fe2d1 [INFO] running `Command { std: "docker" "start" "-a" "de4a678cf3eab7109fadfe7243fd76f6d3e25560ec93717bd92c9dcc976fe2d1", kill_on_drop: false }` [INFO] [stderr] Compiling pkg-config v0.3.27 [INFO] [stderr] Compiling serde v1.0.189 [INFO] [stderr] Compiling target-lexicon v0.12.12 [INFO] [stderr] Compiling hashbrown v0.14.2 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Compiling winnow v0.5.17 [INFO] [stderr] Compiling libc v0.2.149 [INFO] [stderr] Compiling smallvec v1.11.1 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling version-compare v0.1.1 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking bytemuck v1.14.0 [INFO] [stderr] Checking encoding_rs v0.8.33 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Compiling serde_json v1.0.107 [INFO] [stderr] Checking symphonia-core v0.5.3 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling indexmap v2.0.2 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling cfg-expr v0.15.5 [INFO] [stderr] Compiling rustix v0.38.20 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Compiling rayon-core v1.12.0 [INFO] [stderr] Compiling alsa-sys v0.3.1 [INFO] [stderr] Compiling jack-sys v0.5.1 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Compiling slotmap v1.0.6 [INFO] [stderr] Checking libloading v0.7.4 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Checking linux-raw-sys v0.4.10 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Compiling jack v0.11.4 [INFO] [stderr] Checking plotters-backend v0.3.5 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Compiling cpal v0.15.2 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking ciborium-io v0.2.1 [INFO] [stderr] Compiling thiserror v1.0.50 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking plotters-svg v0.3.5 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking symphonia-metadata v0.5.3 [INFO] [stderr] Checking symphonia-codec-pcm v0.5.3 [INFO] [stderr] Checking clap_builder v4.4.7 [INFO] [stderr] Checking symphonia-codec-adpcm v0.5.3 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking nix v0.24.3 [INFO] [stderr] Checking ciborium-ll v0.2.1 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking symphonia-utils-xiph v0.5.3 [INFO] [stderr] Checking symphonia-format-wav v0.5.3 [INFO] [stderr] Checking symphonia-bundle-mp3 v0.5.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Compiling trybuild v1.0.85 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Checking symphonia-format-ogg v0.5.3 [INFO] [stderr] Checking symphonia-format-mkv v0.5.3 [INFO] [stderr] Checking symphonia-bundle-flac v0.5.3 [INFO] [stderr] Checking symphonia-codec-vorbis v0.5.3 [INFO] [stderr] Checking alsa v0.7.1 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling rfd v0.12.1 [INFO] [stderr] Checking dasp_sample v0.11.0 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking dirs v2.0.2 [INFO] [stderr] Checking plotters v0.3.5 [INFO] [stderr] Checking rayon v1.8.0 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking rpassword v2.1.0 [INFO] [stderr] Checking crossbeam-channel v0.5.8 [INFO] [stderr] Checking rtrb v0.3.0 [INFO] [stderr] Checking itertools v0.12.0 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking fastapprox v0.3.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking symphonia v0.5.3 [INFO] [stderr] Checking dissimilar v1.0.7 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking termcolor v1.3.0 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking raw-window-handle v0.5.2 [INFO] [stderr] Checking numtoa v0.1.0 [INFO] [stderr] Checking hound v3.5.1 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking assert_no_alloc v1.1.2 [INFO] [stderr] Checking downcast-rs v1.2.0 [INFO] [stderr] Checking termion v2.0.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking dialog v0.3.0 [INFO] [stderr] Compiling serde_spanned v0.6.4 [INFO] [stderr] Compiling toml_datetime v0.6.5 [INFO] [stderr] Checking clap v4.4.7 [INFO] [stderr] Compiling toml_edit v0.20.4 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Compiling serde_derive v1.0.189 [INFO] [stderr] Compiling thiserror-impl v1.0.50 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Compiling knyst_macro v0.5.0 [INFO] [stderr] Compiling toml v0.8.4 [INFO] [stderr] Checking tokio v1.33.0 [INFO] [stderr] Compiling system-deps v6.1.2 [INFO] [stderr] Checking knyst v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition name: `loom` [INFO] [stdout] --> src/graph.rs:38:7 [INFO] [stdout] | [INFO] [stdout] 38 | #[cfg(loom)] [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(loom)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(loom)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `loom` [INFO] [stdout] --> src/graph.rs:61:11 [INFO] [stdout] | [INFO] [stdout] 61 | #[cfg(not(loom))] [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(loom)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(loom)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling glib-sys v0.18.1 [INFO] [stderr] Compiling gobject-sys v0.18.0 [INFO] [stderr] Compiling atk-sys v0.18.0 [INFO] [stderr] Compiling gdk-sys v0.18.0 [INFO] [stderr] Compiling gio-sys v0.18.1 [INFO] [stderr] Compiling cairo-sys-rs v0.18.2 [INFO] [stderr] Compiling pango-sys v0.18.0 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.18.0 [INFO] [stderr] Compiling gtk-sys v0.18.0 [INFO] [stdout] warning: struct `NaiveSine` is never constructed [INFO] [stdout] --> src/graph.rs:4233:8 [INFO] [stdout] | [INFO] [stdout] 4233 | struct NaiveSine { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `update_freq` is never used [INFO] [stdout] --> src/graph.rs:4239:12 [INFO] [stdout] | [INFO] [stdout] 4238 | impl NaiveSine { [INFO] [stdout] | -------------- method in this implementation [INFO] [stdout] 4239 | pub fn update_freq(&mut self, freq: Sample, sample_rate: Sample) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `process` is never used [INFO] [stdout] --> src/graph.rs:4247:8 [INFO] [stdout] | [INFO] [stdout] 4245 | impl NaiveSine { [INFO] [stdout] | -------------- method in this implementation [INFO] [stdout] 4246 | #[process] [INFO] [stdout] 4247 | fn process( [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/scheduling.rs:249:30 [INFO] [stdout] | [INFO] [stdout] 249 | pub struct MusicalTimeMapRef(Arc>); [INFO] [stdout] | ----------------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/audio_backend.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 36 | graph: Graph, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | resources: Resources, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | run_graph_settings: RunGraphSettings, [INFO] [stdout] 39 | error_handler: Box, [INFO] [stdout] | ---------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | ) -> Result { [INFO] [stdout] 41 | let controller = self.start_processing_return_controller( [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | Ok(controller.start_on_new_thread()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/audio_backend.rs:130:16 [INFO] [stdout] | [INFO] [stdout] 124 | pub fn new>(name: S) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | // Create client [INFO] [stdout] 126 | let (client, _status) = [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | Ok(Self { [INFO] [stdout] | ________________^ [INFO] [stdout] 131 | | client: Some(JackClient::Passive(client)), [INFO] [stdout] 132 | | sample_rate, [INFO] [stdout] 133 | | block_size, [INFO] [stdout] 134 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/audio_backend.rs:384:16 [INFO] [stdout] | [INFO] [stdout] 369 | let device = if options.device == "default" { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 384 | Ok(Self { [INFO] [stdout] | ________________^ [INFO] [stdout] 385 | | stream: None, [INFO] [stdout] 386 | | sample_rate: config.sample_rate().0 as usize, [INFO] [stdout] 387 | | config, [INFO] [stdout] 388 | | device, [INFO] [stdout] 389 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller.rs:219:5 [INFO] [stdout] | [INFO] [stdout] 215 | init: impl FnOnce(), [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 219 | knyst_commands() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller.rs:740:23 [INFO] [stdout] | [INFO] [stdout] 735 | callback: impl FnMut(Beats, &mut MultiThreadedKnystCommands) -> Option + Send + 'static, [INFO] [stdout] | ---------------------------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 738 | let free_flag = Arc::new(AtomicBool::new(false)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 739 | Self { [INFO] [stdout] 740 | callback: Box::new(callback), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller.rs:804:28 [INFO] [stdout] | [INFO] [stdout] 793 | top_level_graph: Graph, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 794 | error_handler: impl FnMut(KnystError) + Send + 'static, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 795 | resources_sender: rtrb::Producer, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 796 | resources_receiver: rtrb::Consumer, [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 797 | ) -> Self { [INFO] [stdout] 798 | let (sender, receiver) = unbounded(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 804 | error_handler: Box::new(error_handler), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph.rs:723:10 [INFO] [stdout] | [INFO] [stdout] 718 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 723 | (None, Box::new(self)) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph.rs:723:16 [INFO] [stdout] | [INFO] [stdout] 718 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 723 | (None, Box::new(self)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph.rs:726:29 [INFO] [stdout] | [INFO] [stdout] 725 | fn into_gen_or_graph_enum(self) -> GenOrGraphEnum { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 726 | GenOrGraphEnum::Gen(Box::new(self)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph.rs:775:10 [INFO] [stdout] | [INFO] [stdout] 747 | mut self, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 768 | let gen = self [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 775 | (Some(self), gen) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph.rs:835:21 [INFO] [stdout] | [INFO] [stdout] 832 | process: impl (FnMut(GenContext, &mut Resources) -> GenState) + 'static + Send, [INFO] [stdout] | ------------------------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 835 | process_fn: Box::new(process), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph.rs:836:11 [INFO] [stdout] | [INFO] [stdout] 832 | process: impl (FnMut(GenContext, &mut Resources) -> GenState) + 'static + Send, [INFO] [stdout] | ------------------------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 836 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph.rs:1177:40 [INFO] [stdout] | [INFO] [stdout] 1152 | let inputs_buffers_ptr = Arc::new(OwnedRawBuffer { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1156 | let nodes = Arc::new(UnsafeCell::new(SlotMap::with_capacity_and_key(num_nodes))); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1177 | node_keys_pending_removal: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph.rs:1179:30 [INFO] [stdout] | [INFO] [stdout] 1152 | let inputs_buffers_ptr = Arc::new(OwnedRawBuffer { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1156 | let nodes = Arc::new(UnsafeCell::new(SlotMap::with_capacity_and_key(num_nodes))); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1179 | graphs_per_node: SecondaryMap::with_capacity(num_nodes), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph.rs:1191:37 [INFO] [stdout] | [INFO] [stdout] 1152 | let inputs_buffers_ptr = Arc::new(OwnedRawBuffer { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1156 | let nodes = Arc::new(UnsafeCell::new(SlotMap::with_capacity_and_key(num_nodes))); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1191 | graph_gen_communicator: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph.rs:1284:9 [INFO] [stdout] | [INFO] [stdout] 1283 | pub fn push(&mut self, to_node: impl Into) -> NodeId { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1284 | self.push_to_graph(to_node, self.id).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph.rs:1289:9 [INFO] [stdout] | [INFO] [stdout] 1288 | pub fn push_at_time(&mut self, to_node: impl Into, start_time: Time) -> NodeId { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1289 | self.push_to_graph_at_time(to_node, self.id, start_time) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph.rs:1327:9 [INFO] [stdout] | [INFO] [stdout] 1324 | to_node: impl Into, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1327 | self.push_with_existing_address_to_graph(to_node, node_address, self.id) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph.rs:1339:9 [INFO] [stdout] | [INFO] [stdout] 1335 | to_node: impl Into, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1339 | self.push_with_existing_address_to_graph_at_time(to_node, node_address, self.id, start_time) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph/connection.rs:874:41 [INFO] [stdout] | [INFO] [stdout] 874 | .map(|(index, con, output)| (index, con, output).into()) [INFO] [stdout] | -------------------- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph/connection.rs:885:41 [INFO] [stdout] | [INFO] [stdout] 885 | .map(|(label, con, output)| (label, con, output).into()) [INFO] [stdout] | -------------------- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph/node.rs:41:17 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn new(name: &'static str, gen: Box) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | vec![0.0 as Sample; gen.num_inputs()].into_boxed_slice(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph/run_graph.rs:60:15 [INFO] [stdout] | [INFO] [stdout] 47 | resources: Resources, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | match graph.split_and_create_top_level_node(NodeId::new(u64::MAX)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modal_interface.rs:395:44 [INFO] [stdout] | [INFO] [stdout] 395 | if ACTIVE_KNYST_SPHERE.with(|aks| *aks.borrow_mut()) == sphere_id { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modal_interface.rs:439:64 [INFO] [stdout] | [INFO] [stdout] 439 | if let Some(kc) = ACTIVE_KNYST_SPHERE_COMMANDS.with(|aksc| aksc.borrow().clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modal_interface.rs:446:68 [INFO] [stdout] | [INFO] [stdout] 446 | if let Some(kc) = ACTIVE_KNYST_SPHERE_COMMANDS.with(|aksc| aksc.borrow().clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sphere.rs:102:12 [INFO] [stdout] | [INFO] [stdout] 69 | error_handler: impl FnMut(KnystError) + Send + 'static, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | ) -> Result<(SphereId, Controller), SphereError> { [INFO] [stdout] 71 | let resources = Resources::new(settings.resources_settings); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | let graph: Graph = Graph::new(graph_settings); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | let controller = backend.start_processing_return_controller( [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | let s = Self { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | Ok((sphere_id, controller)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 27 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `knyst` (lib) due to 28 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "de4a678cf3eab7109fadfe7243fd76f6d3e25560ec93717bd92c9dcc976fe2d1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "de4a678cf3eab7109fadfe7243fd76f6d3e25560ec93717bd92c9dcc976fe2d1", kill_on_drop: false }` [INFO] [stdout] de4a678cf3eab7109fadfe7243fd76f6d3e25560ec93717bd92c9dcc976fe2d1