[INFO] fetching crate klu-rs 0.4.0... [INFO] checking klu-rs-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate klu-rs 0.4.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate klu-rs 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate klu-rs 0.4.0 [INFO] finished tweaking crates.io crate klu-rs 0.4.0 [INFO] tweaked toml for crates.io crate klu-rs 0.4.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 53 packages to latest compatible versions [INFO] [stderr] Adding bit-set v0.5.3 (latest: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 678bd0a5b3ba1d881997e176ea08207cbfa58ee0dfdae1f77f68d7996bce97fa [INFO] running `Command { std: "docker" "start" "-a" "678bd0a5b3ba1d881997e176ea08207cbfa58ee0dfdae1f77f68d7996bce97fa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "678bd0a5b3ba1d881997e176ea08207cbfa58ee0dfdae1f77f68d7996bce97fa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "678bd0a5b3ba1d881997e176ea08207cbfa58ee0dfdae1f77f68d7996bce97fa", kill_on_drop: false }` [INFO] [stdout] 678bd0a5b3ba1d881997e176ea08207cbfa58ee0dfdae1f77f68d7996bce97fa [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a32a6f58a32ef9accc126c6bb16108900cae2c4ceb2de44742b0d5258bd96ce1 [INFO] running `Command { std: "docker" "start" "-a" "a32a6f58a32ef9accc126c6bb16108900cae2c4ceb2de44742b0d5258bd96ce1", kill_on_drop: false }` [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling klu_sys v0.2.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking rand_xorshift v0.3.0 [INFO] [stderr] Checking unarray v0.1.4 [INFO] [stderr] Checking rusty-fork v0.3.0 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking proptest v1.5.0 [INFO] [stderr] Checking klu-rs v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:102:14 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn new_with_alloc(spec: Rc>, mut alloc: Vec) -> Option { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | Some(Self { [INFO] [stdout] | ______________^ [INFO] [stdout] 103 | | spec, [INFO] [stdout] 104 | | data: Some(data.into()), [INFO] [stdout] 105 | | klu_numeric: None, [INFO] [stdout] 106 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/lib.rs:305:17 [INFO] [stdout] | [INFO] [stdout] 305 | Box::from_raw(data.as_ptr()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 305 | let _ = Box::from_raw(data.as_ptr()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `klu-rs` (lib) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:102:14 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn new_with_alloc(spec: Rc>, mut alloc: Vec) -> Option { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | Some(Self { [INFO] [stdout] | ______________^ [INFO] [stdout] 103 | | spec, [INFO] [stdout] 104 | | data: Some(data.into()), [INFO] [stdout] 105 | | klu_numeric: None, [INFO] [stdout] 106 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/lib.rs:305:17 [INFO] [stdout] | [INFO] [stdout] 305 | Box::from_raw(data.as_ptr()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 305 | let _ = Box::from_raw(data.as_ptr()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 58 | fn linear_system(elem: S) -> impl Strategy> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | / (5i32..100i32) [INFO] [stdout] 60 | | .prop_flat_map(move |size| { [INFO] [stdout] 61 | | let matrix = matrix(elem.clone(), size); [INFO] [stdout] 62 | | let rhs = vec![elem.clone(); size as usize]; [INFO] [stdout] 63 | | (rhs, matrix) [INFO] [stdout] 64 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 76 | elem: S, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | let matrix_shape = matrix_shape(size); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | (matrix_shape, num_matrix).prop_flat_map(move |(shape, num_matrix)| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:82:46 [INFO] [stdout] | [INFO] [stdout] 76 | elem: S, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | let matrix_shape = matrix_shape(size); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | (matrix_shape, num_matrix).prop_flat_map(move |(shape, num_matrix)| { [INFO] [stdout] | ______________________________________________^ [INFO] [stdout] 83 | | let data_len: usize = shape.iter().map(|row_entries| row_entries.len()).sum(); [INFO] [stdout] 84 | | ( [INFO] [stdout] 85 | | Just(shape), [INFO] [stdout] ... | [INFO] [stdout] 88 | | ) [INFO] [stdout] 89 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `klu-rs` (lib test) due to 5 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "a32a6f58a32ef9accc126c6bb16108900cae2c4ceb2de44742b0d5258bd96ce1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a32a6f58a32ef9accc126c6bb16108900cae2c4ceb2de44742b0d5258bd96ce1", kill_on_drop: false }` [INFO] [stdout] a32a6f58a32ef9accc126c6bb16108900cae2c4ceb2de44742b0d5258bd96ce1