[INFO] fetching crate kiss_xml 1.0.0... [INFO] checking kiss_xml-1.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate kiss_xml 1.0.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate kiss_xml 1.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate kiss_xml 1.0.0 [INFO] finished tweaking crates.io crate kiss_xml 1.0.0 [INFO] tweaked toml for crates.io crate kiss_xml 1.0.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 50 packages to latest compatible versions [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4d2fcc6773ffad23bc3747889ad930dbf3d778eac21590c5250ebaf4335a3e02 [INFO] running `Command { std: "docker" "start" "-a" "4d2fcc6773ffad23bc3747889ad930dbf3d778eac21590c5250ebaf4335a3e02", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4d2fcc6773ffad23bc3747889ad930dbf3d778eac21590c5250ebaf4335a3e02", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4d2fcc6773ffad23bc3747889ad930dbf3d778eac21590c5250ebaf4335a3e02", kill_on_drop: false }` [INFO] [stdout] 4d2fcc6773ffad23bc3747889ad930dbf3d778eac21590c5250ebaf4335a3e02 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5569668023ca94aecd44dfe69e097c3197fb03c749e18647a39b8472c612b0e3 [INFO] running `Command { std: "docker" "start" "-a" "5569668023ca94aecd44dfe69e097c3197fb03c749e18647a39b8472c612b0e3", kill_on_drop: false }` [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking dyn-clone v1.0.17 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking kiss_xml v1.0.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:583:5 [INFO] [stdout] | [INFO] [stdout] 381 | pub fn parse_str(xml_string: impl Into) -> Result { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 451 | let mut parse_stack = parsing::ParseTree::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 452 | let root_slice = &buffer[tag_span.0 .. tag_span.1]; [INFO] [stdout] 453 | let root_element: dom::Element = parse_new_element(strip_tag(root_slice).as_str(), &buffer, &tag_span, None)?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 583 | Ok(dom::Document::new_with_decl_dtd( [INFO] [stdout] | ________^ [INFO] [stdout] 584 | | parse_stack.to_dom()?, [INFO] [stdout] 585 | | decl, [INFO] [stdout] 586 | | Some(&dtds) [INFO] [stdout] 587 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:820:41 [INFO] [stdout] | [INFO] [stdout] 820 | let matcher = singleton.get_or_init(|| Regex::new(r#"^\s*$"#).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dom.rs:522:25 [INFO] [stdout] | [INFO] [stdout] 521 | ...th_attributes+Clone, TEXT2: Into+Clone>(name: &str, attributes: HashMap) -> Result [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dom.rs:522:55 [INFO] [stdout] | [INFO] [stdout] 521 | ...1: Into+Clone, TEXT2: Into+Clone>(name: &str, attributes: HashMap) -> Result { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 522 | ...attributes), None, None, None) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dom.rs:526:90 [INFO] [stdout] | [INFO] [stdout] 525 | pub fn new_with_text(name: &str, text: impl Into) -> Result { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 526 | Self::new(name, Some(text.into()), Option::>::None, None, None, None) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dom.rs:547:38 [INFO] [stdout] | [INFO] [stdout] 546 | ...t+Clone, TEXT2: Into+Clone>(name: &str, attributes: HashMap, text: impl Into) -> Res... [INFO] [stdout] | --------------------------------- ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 547 | ...()), Some(attributes), None, None, None) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dom.rs:547:68 [INFO] [stdout] | [INFO] [stdout] 546 | ...ng>+Clone, TEXT2: Into+Clone>(name: &str, attributes: HashMap, text: impl Into) -> Result [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dom.rs:574:25 [INFO] [stdout] | [INFO] [stdout] 573 | ...tes_and_children+Clone, TEXT2: Into+Clone>(name: &str, attributes: HashMap, children: Vec>) -... [INFO] [stdout] | --------------------------------- ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 574 | ...e, Some(attributes), None, None, Some(children)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dom.rs:574:55 [INFO] [stdout] | [INFO] [stdout] 573 | ...Into+Clone, TEXT2: Into+Clone>(name: &str, attributes: HashMap, children: Vec>) -> Result<... [INFO] [stdout] | --------------------------------- ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 574 | ...e, None, Some(children)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dom.rs:599:77 [INFO] [stdout] | [INFO] [stdout] 598 | pub fn new_with_children(name: &str, children: Vec>) -> Result { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 599 | Self::new(name, None, Option::>::None, None, None, Some(children)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dom.rs:950:3 [INFO] [stdout] | [INFO] [stdout] 948 | pub fn elements_by_name(&self, name: impl Into) -> impl Iterator{ [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 949 | let n: String = name.into(); [INFO] [stdout] 950 | self.child_elements().filter(move |c| c.name == n) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dom.rs:958:3 [INFO] [stdout] | [INFO] [stdout] 956 | pub fn elements_by_name_mut(&mut self, name: impl Into) -> impl Iterator{ [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 957 | let n: String = name.into(); [INFO] [stdout] 958 | self.child_elements_mut().filter(move |c| c.name == n) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dom.rs:985:7 [INFO] [stdout] | [INFO] [stdout] 985 | || Regex::new(r#"^[_a-zA-Z]\S*$"#).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dom.rs:999:7 [INFO] [stdout] | [INFO] [stdout] 999 | || Regex::new(r#"^[_a-zA-Z]\S*$"#).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dom.rs:1048:4 [INFO] [stdout] | [INFO] [stdout] 1045 | pub fn search<'a, P>(&'a self, predicate: P) -> Box> + '_> where P: FnMut(&&Box) -> bool... [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1048 | self.children_recursive().filter(predicate) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dom.rs:1083:4 [INFO] [stdout] | [INFO] [stdout] 1080 | pub fn search_elements<'a, P>(&'a self, predicate: P) -> Box + '_> where P: FnMut(&&Element) -> bool ... [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1083 | / self.search(|n| n.is_element()) [INFO] [stdout] 1084 | | .map(|n| n.as_element().expect("logic error")) [INFO] [stdout] 1085 | | .filter(predicate) [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dom.rs:1126:4 [INFO] [stdout] | [INFO] [stdout] 1123 | pub fn search_text<'a, P>(&'a self, predicate: P) -> Box + '_> where P: Fn(&&Text) -> bool + 'a { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1126 | / self.search(|n| n.is_text()) [INFO] [stdout] 1127 | | .map(|n| n.as_text().expect("logic error")) [INFO] [stdout] 1128 | | .filter(predicate) [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dom.rs:1136:4 [INFO] [stdout] | [INFO] [stdout] 1133 | pub fn search_comments<'a, P>(&'a self, predicate: P) -> Box + '_> where P: Fn(&&Comment) -> bool + 'a { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1136 | / self.search(|n| n.is_comment()) [INFO] [stdout] 1137 | | .map(|n| n.as_comment().expect("logic error")) [INFO] [stdout] 1138 | | .filter(predicate) [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dom.rs:1365:6 [INFO] [stdout] | [INFO] [stdout] 1364 | let removed = self.child_nodes.remove(elems[index]); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1365 | Ok(removed.as_element().expect("logic error").clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dom.rs:1659:46 [INFO] [stdout] | [INFO] [stdout] 1659 | let wsp_matcher = singleton.get_or_init(|| Regex::new(r#"^\s+$"#).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 20 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kiss_xml` (lib) due to 21 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "5569668023ca94aecd44dfe69e097c3197fb03c749e18647a39b8472c612b0e3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5569668023ca94aecd44dfe69e097c3197fb03c749e18647a39b8472c612b0e3", kill_on_drop: false }` [INFO] [stdout] 5569668023ca94aecd44dfe69e097c3197fb03c749e18647a39b8472c612b0e3