[INFO] fetching crate kiss2d 0.1.6... [INFO] checking kiss2d-0.1.6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate kiss2d 0.1.6 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate kiss2d 0.1.6 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate kiss2d 0.1.6 [INFO] finished tweaking crates.io crate kiss2d 0.1.6 [INFO] tweaked toml for crates.io crate kiss2d 0.1.6 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 36 packages to latest compatible versions [INFO] [stderr] Adding approx v0.3.2 (latest: v0.5.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding gdi32-sys v0.1.2 (latest: v0.2.0) [INFO] [stderr] Adding lazy_static v0.2.11 (latest: v1.5.0) [INFO] [stderr] Adding libredox v0.0.2 (latest: v0.1.3) [INFO] [stderr] Adding minifb v0.11.2 (latest: v0.27.0) [INFO] [stderr] Adding ordered-float v1.1.1 (latest: v4.2.2) [INFO] [stderr] Adding redox_syscall v0.4.1 (latest: v0.5.3) [INFO] [stderr] Adding rusttype v0.7.9 (latest: v0.9.3) [INFO] [stderr] Adding rusttype v0.8.3 (latest: v0.9.3) [INFO] [stderr] Adding sdl2 v0.35.2 (latest: v0.37.0) [INFO] [stderr] Adding sdl2-sys v0.35.2 (latest: v0.37.0) [INFO] [stderr] Adding time v0.1.45 (latest: v0.3.36) [INFO] [stderr] Adding user32-sys v0.1.3 (latest: v0.2.0) [INFO] [stderr] Adding version-compare v0.1.1 (latest: v0.2.0) [INFO] [stderr] Adding wasi v0.10.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding winapi v0.2.8 (latest: v0.3.9) [INFO] [stderr] Adding x11-dl v2.14.0 (latest: v2.21.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3e19abb1cb031fb82904ee183ffac1cf064ad730b0b626d597d791b036866d4e [INFO] running `Command { std: "docker" "start" "-a" "3e19abb1cb031fb82904ee183ffac1cf064ad730b0b626d597d791b036866d4e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3e19abb1cb031fb82904ee183ffac1cf064ad730b0b626d597d791b036866d4e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3e19abb1cb031fb82904ee183ffac1cf064ad730b0b626d597d791b036866d4e", kill_on_drop: false }` [INFO] [stdout] 3e19abb1cb031fb82904ee183ffac1cf064ad730b0b626d597d791b036866d4e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c77b2c3af49c0542faee0d55ce62482d06f1e0ac746458f81a35b7396924832c [INFO] running `Command { std: "docker" "start" "-a" "c77b2c3af49c0542faee0d55ce62482d06f1e0ac746458f81a35b7396924832c", kill_on_drop: false }` [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking lazy_static v0.2.11 [INFO] [stderr] Compiling x11-dl v2.14.0 [INFO] [stderr] Compiling minifb v0.11.2 [INFO] [stderr] Checking approx v0.3.2 [INFO] [stderr] Checking ordered-float v1.1.1 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking stb_truetype v0.3.1 [INFO] [stderr] Checking rusttype v0.8.3 [INFO] [stderr] Checking rusttype v0.7.9 [INFO] [stderr] Checking kiss2d v0.1.6 (/opt/rustwide/workdir) [INFO] [stdout] warning: identifier contains a non normalized (NFKC) character: 'ϕ' [INFO] [stdout] --> src/vg/raster_fixed.rs:13:7 [INFO] [stdout] | [INFO] [stdout] 13 | const ϕ: int1ϕ = 9; [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: this character is included in the Not_NFKC Unicode general security profile [INFO] [stdout] = note: `#[warn(uncommon_codepoints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: identifier contains a non normalized (NFKC) character: 'ϕ' [INFO] [stdout] --> src/vg/raster_fixed.rs:13:10 [INFO] [stdout] | [INFO] [stdout] 13 | const ϕ: int1ϕ = 9; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this character is included in the Not_NFKC Unicode general security profile [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: identifier contains a non normalized (NFKC) character: 'ϕ' [INFO] [stdout] --> src/vg/raster_fixed.rs:32:6 [INFO] [stdout] | [INFO] [stdout] 32 | type int2ϕ = i32; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this character is included in the Not_NFKC Unicode general security profile [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: identifier contains a non normalized (NFKC) character: 'ϕ' [INFO] [stdout] --> src/vg/raster_fixed.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | let ayϕ = (ay * (fxOne as f32)) as int1ϕ; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: this character is included in the Not_NFKC Unicode general security profile [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: identifier contains a non normalized (NFKC) character: 'ϕ' [INFO] [stdout] --> src/vg/raster_fixed.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 72 | let byϕ = (by * (fxOne as f32)) as int1ϕ; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: this character is included in the Not_NFKC Unicode general security profile [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: identifier contains a non normalized (NFKC) character: 'ϕ' [INFO] [stdout] --> src/vg/raster_fixed.rs:13:7 [INFO] [stdout] | [INFO] [stdout] 13 | const ϕ: int1ϕ = 9; [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: this character is included in the Not_NFKC Unicode general security profile [INFO] [stdout] = note: `#[warn(uncommon_codepoints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: identifier contains a non normalized (NFKC) character: 'ϕ' [INFO] [stdout] --> src/vg/raster_fixed.rs:13:10 [INFO] [stdout] | [INFO] [stdout] 13 | const ϕ: int1ϕ = 9; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this character is included in the Not_NFKC Unicode general security profile [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: identifier contains a non normalized (NFKC) character: 'ϕ' [INFO] [stdout] --> src/vg/raster_fixed.rs:32:6 [INFO] [stdout] | [INFO] [stdout] 32 | type int2ϕ = i32; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this character is included in the Not_NFKC Unicode general security profile [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: identifier contains a non normalized (NFKC) character: 'ϕ' [INFO] [stdout] --> src/vg/raster_fixed.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | let ayϕ = (ay * (fxOne as f32)) as int1ϕ; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: this character is included in the Not_NFKC Unicode general security profile [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: identifier contains a non normalized (NFKC) character: 'ϕ' [INFO] [stdout] --> src/vg/raster_fixed.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 72 | let byϕ = (by * (fxOne as f32)) as int1ϕ; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: this character is included in the Not_NFKC Unicode general security profile [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `int1ϕ` should have an upper camel case name [INFO] [stdout] --> src/vg/raster_fixed.rs:21:6 [INFO] [stdout] | [INFO] [stdout] 21 | type int1ϕ = i32; [INFO] [stdout] | ^^^^^ help: convert the identifier to upper camel case (notice the capitalization): `Int1ϕ` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `int2ϕ` should have an upper camel case name [INFO] [stdout] --> src/vg/raster_fixed.rs:32:6 [INFO] [stdout] | [INFO] [stdout] 32 | type int2ϕ = i32; [INFO] [stdout] | ^^^^^ help: convert the identifier to upper camel case (notice the capitalization): `Int2ϕ` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/vg/raster_fixed.rs:37:47 [INFO] [stdout] | [INFO] [stdout] 37 | #[inline(always)] fn floor(x: int1ϕ) -> i32 { (x >> ϕ) } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 37 - #[inline(always)] fn floor(x: int1ϕ) -> i32 { (x >> ϕ) } [INFO] [stdout] 37 + #[inline(always)] fn floor(x: int1ϕ) -> i32 { x >> ϕ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/vg/raster_fixed.rs:38:47 [INFO] [stdout] | [INFO] [stdout] 38 | #[inline(always)] fn ceil(x: int1ϕ) -> i32 { ((x + fxOneMinusIota) >> ϕ) } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 38 - #[inline(always)] fn ceil(x: int1ϕ) -> i32 { ((x + fxOneMinusIota) >> ϕ) } [INFO] [stdout] 38 + #[inline(always)] fn ceil(x: int1ϕ) -> i32 { (x + fxOneMinusIota) >> ϕ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `exceeding_bitshifts` has been renamed to `arithmetic_overflow` [INFO] [stdout] --> src/vg/raster_fixed.rs:251:33 [INFO] [stdout] | [INFO] [stdout] 251 | #[allow(exceeding_bitshifts)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: use the new name: `arithmetic_overflow` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Point` [INFO] [stdout] --> src/vg/vector.rs:2:37 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::image::{RGBA, Rectangle, Point}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `int1ϕ` should have an upper camel case name [INFO] [stdout] --> src/vg/raster_fixed.rs:21:6 [INFO] [stdout] | [INFO] [stdout] 21 | type int1ϕ = i32; [INFO] [stdout] | ^^^^^ help: convert the identifier to upper camel case (notice the capitalization): `Int1ϕ` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `int2ϕ` should have an upper camel case name [INFO] [stdout] --> src/vg/raster_fixed.rs:32:6 [INFO] [stdout] | [INFO] [stdout] 32 | type int2ϕ = i32; [INFO] [stdout] | ^^^^^ help: convert the identifier to upper camel case (notice the capitalization): `Int2ϕ` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/vg/raster_fixed.rs:37:47 [INFO] [stdout] | [INFO] [stdout] 37 | #[inline(always)] fn floor(x: int1ϕ) -> i32 { (x >> ϕ) } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 37 - #[inline(always)] fn floor(x: int1ϕ) -> i32 { (x >> ϕ) } [INFO] [stdout] 37 + #[inline(always)] fn floor(x: int1ϕ) -> i32 { x >> ϕ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/vg/raster_fixed.rs:38:47 [INFO] [stdout] | [INFO] [stdout] 38 | #[inline(always)] fn ceil(x: int1ϕ) -> i32 { ((x + fxOneMinusIota) >> ϕ) } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 38 - #[inline(always)] fn ceil(x: int1ϕ) -> i32 { ((x + fxOneMinusIota) >> ϕ) } [INFO] [stdout] 38 + #[inline(always)] fn ceil(x: int1ϕ) -> i32 { (x + fxOneMinusIota) >> ϕ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `exceeding_bitshifts` has been renamed to `arithmetic_overflow` [INFO] [stdout] --> src/vg/raster_fixed.rs:251:33 [INFO] [stdout] | [INFO] [stdout] 251 | #[allow(exceeding_bitshifts)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: use the new name: `arithmetic_overflow` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Point` [INFO] [stdout] --> src/vg/vector.rs:2:37 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::image::{RGBA, Rectangle, Point}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `non_ascii_idents` has been stable since 1.53.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:1:43 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(int_to_from_bytes, decl_macro, non_ascii_idents)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `int_to_from_bytes` has been stable since 1.32.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(int_to_from_bytes, decl_macro, non_ascii_idents)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `non_ascii_idents` has been stable since 1.53.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:1:43 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(int_to_from_bytes, decl_macro, non_ascii_idents)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `int_to_from_bytes` has been stable since 1.32.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(int_to_from_bytes, decl_macro, non_ascii_idents)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `h` [INFO] [stdout] --> src/image.rs:57:17 [INFO] [stdout] | [INFO] [stdout] 57 | let (w, h) = (r.dx(), r.dy()); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_h` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `h` [INFO] [stdout] --> src/image.rs:57:17 [INFO] [stdout] | [INFO] [stdout] 57 | let (w, h) = (r.dx(), r.dy()); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_h` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/vg/mod.rs:50:18 [INFO] [stdout] | [INFO] [stdout] 50 | struct SimdAlign([f32; 4]); [INFO] [stdout] | --------- ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `SimdAlign` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `PorterDuff` is never used [INFO] [stdout] --> src/vg/mod.rs:146:6 [INFO] [stdout] | [INFO] [stdout] 146 | enum PorterDuff { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `PD` is never used [INFO] [stdout] --> src/vg/mod.rs:161:6 [INFO] [stdout] | [INFO] [stdout] 161 | enum PD { [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `int2ϕ` is never used [INFO] [stdout] --> src/vg/raster_fixed.rs:32:6 [INFO] [stdout] | [INFO] [stdout] 32 | type int2ϕ = i32; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 43 | let window = Window::new(title, width, height, Default::default())?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | [INFO] [stdout] 45 | Ok(Self { buffer, window, size: (width, height) }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:70:29 [INFO] [stdout] | [INFO] [stdout] 68 | pub fn keys(&self, f: F) { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | self.window.get_keys() [INFO] [stdout] 70 | .map(|mut keys| keys.drain(..).for_each(f)); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wu.rs:9:61 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn clipped_aaline(start: (isize, isize), end: (isize, isize), size: (isize, isize), plot: F) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 9 | clipped(start.0, start.1, end.0, end.1, size.0, size.1, |x1, y1, x2, y2| { [INFO] [stdout] | _____________________________________________________________^ [INFO] [stdout] 10 | | aaline(x1, y1, x2, y2, plot) [INFO] [stdout] 11 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `ϕ` should have an upper case name [INFO] [stdout] --> src/vg/raster_fixed.rs:13:7 [INFO] [stdout] | [INFO] [stdout] 13 | const ϕ: int1ϕ = 9; [INFO] [stdout] | ^ help: convert the identifier to upper case: `Φ` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `fxOne` should have an upper case name [INFO] [stdout] --> src/vg/raster_fixed.rs:15:7 [INFO] [stdout] | [INFO] [stdout] 15 | const fxOne: int1ϕ = 1 << ϕ; [INFO] [stdout] | ^^^^^ help: convert the identifier to upper case: `FX_ONE` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `fxOneAndAHalf` should have an upper case name [INFO] [stdout] --> src/vg/raster_fixed.rs:16:7 [INFO] [stdout] | [INFO] [stdout] 16 | const fxOneAndAHalf: int1ϕ = 1<<ϕ + 1<<(ϕ-1); [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper case: `FX_ONE_AND_AHALF` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `fxOneMinusIota` should have an upper case name [INFO] [stdout] --> src/vg/raster_fixed.rs:17:7 [INFO] [stdout] | [INFO] [stdout] 17 | const fxOneMinusIota: int1ϕ = 1<<ϕ - 1; // Used for rounding up. [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to upper case: `FX_ONE_MINUS_IOTA` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `D` should have a snake case name [INFO] [stdout] --> src/vg/raster_fixed.rs:134:29 [INFO] [stdout] | [INFO] [stdout] 134 | let mut D = one_minus_x0f_squared; // D ranges up to ±1<<(2*ϕ). [INFO] [stdout] | ^ help: convert the identifier to snake case: `d` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `D` should have a snake case name [INFO] [stdout] --> src/vg/raster_fixed.rs:147:33 [INFO] [stdout] | [INFO] [stdout] 147 | let mut D = two_over_s<<ϕ - one_minus_x0f_squared - x1f_squared; // D ranges up to ±1<<(2*ϕ+2). [INFO] [stdout] | ^ help: convert the identifier to snake case: `d` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `D` should have a snake case name [INFO] [stdout] --> src/vg/raster_fixed.rs:191:33 [INFO] [stdout] | [INFO] [stdout] 191 | let mut D = (fxOneAndAHalf-x0f)<<(ϕ+1) - one_minus_x0f_squared; // D ranges up to ±1<<(2*ϕ+2). [INFO] [stdout] | ^ help: convert the identifier to snake case: `d` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `D` should have a snake case name [INFO] [stdout] --> src/vg/raster_fixed.rs:252:33 [INFO] [stdout] | [INFO] [stdout] 252 | let mut D = x1f<<1 + (1<<(ϕ+2) - fxOneAndAHalf<<1); // D ranges up to ±1<<(1*ϕ+2). [INFO] [stdout] | ^ help: convert the identifier to snake case: `d` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `D` should have a snake case name [INFO] [stdout] --> src/vg/raster_fixed.rs:263:29 [INFO] [stdout] | [INFO] [stdout] 263 | let mut D = x1f_squared; // D ranges up to ±1<<(2*ϕ). [INFO] [stdout] | ^ help: convert the identifier to snake case: `d` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 27 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kiss2d` (lib) due to 4 previous errors; 27 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/vg/mod.rs:50:18 [INFO] [stdout] | [INFO] [stdout] 50 | struct SimdAlign([f32; 4]); [INFO] [stdout] | --------- ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `SimdAlign` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `PorterDuff` is never used [INFO] [stdout] --> src/vg/mod.rs:146:6 [INFO] [stdout] | [INFO] [stdout] 146 | enum PorterDuff { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `PD` is never used [INFO] [stdout] --> src/vg/mod.rs:161:6 [INFO] [stdout] | [INFO] [stdout] 161 | enum PD { [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `int2ϕ` is never used [INFO] [stdout] --> src/vg/raster_fixed.rs:32:6 [INFO] [stdout] | [INFO] [stdout] 32 | type int2ϕ = i32; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 43 | let window = Window::new(title, width, height, Default::default())?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | [INFO] [stdout] 45 | Ok(Self { buffer, window, size: (width, height) }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:70:29 [INFO] [stdout] | [INFO] [stdout] 68 | pub fn keys(&self, f: F) { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | self.window.get_keys() [INFO] [stdout] 70 | .map(|mut keys| keys.drain(..).for_each(f)); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wu.rs:9:61 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn clipped_aaline(start: (isize, isize), end: (isize, isize), size: (isize, isize), plot: F) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 9 | clipped(start.0, start.1, end.0, end.1, size.0, size.1, |x1, y1, x2, y2| { [INFO] [stdout] | _____________________________________________________________^ [INFO] [stdout] 10 | | aaline(x1, y1, x2, y2, plot) [INFO] [stdout] 11 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `ϕ` should have an upper case name [INFO] [stdout] --> src/vg/raster_fixed.rs:13:7 [INFO] [stdout] | [INFO] [stdout] 13 | const ϕ: int1ϕ = 9; [INFO] [stdout] | ^ help: convert the identifier to upper case: `Φ` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `fxOne` should have an upper case name [INFO] [stdout] --> src/vg/raster_fixed.rs:15:7 [INFO] [stdout] | [INFO] [stdout] 15 | const fxOne: int1ϕ = 1 << ϕ; [INFO] [stdout] | ^^^^^ help: convert the identifier to upper case: `FX_ONE` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `fxOneAndAHalf` should have an upper case name [INFO] [stdout] --> src/vg/raster_fixed.rs:16:7 [INFO] [stdout] | [INFO] [stdout] 16 | const fxOneAndAHalf: int1ϕ = 1<<ϕ + 1<<(ϕ-1); [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper case: `FX_ONE_AND_AHALF` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `fxOneMinusIota` should have an upper case name [INFO] [stdout] --> src/vg/raster_fixed.rs:17:7 [INFO] [stdout] | [INFO] [stdout] 17 | const fxOneMinusIota: int1ϕ = 1<<ϕ - 1; // Used for rounding up. [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to upper case: `FX_ONE_MINUS_IOTA` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `D` should have a snake case name [INFO] [stdout] --> src/vg/raster_fixed.rs:134:29 [INFO] [stdout] | [INFO] [stdout] 134 | let mut D = one_minus_x0f_squared; // D ranges up to ±1<<(2*ϕ). [INFO] [stdout] | ^ help: convert the identifier to snake case: `d` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `D` should have a snake case name [INFO] [stdout] --> src/vg/raster_fixed.rs:147:33 [INFO] [stdout] | [INFO] [stdout] 147 | let mut D = two_over_s<<ϕ - one_minus_x0f_squared - x1f_squared; // D ranges up to ±1<<(2*ϕ+2). [INFO] [stdout] | ^ help: convert the identifier to snake case: `d` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `D` should have a snake case name [INFO] [stdout] --> src/vg/raster_fixed.rs:191:33 [INFO] [stdout] | [INFO] [stdout] 191 | let mut D = (fxOneAndAHalf-x0f)<<(ϕ+1) - one_minus_x0f_squared; // D ranges up to ±1<<(2*ϕ+2). [INFO] [stdout] | ^ help: convert the identifier to snake case: `d` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `D` should have a snake case name [INFO] [stdout] --> src/vg/raster_fixed.rs:252:33 [INFO] [stdout] | [INFO] [stdout] 252 | let mut D = x1f<<1 + (1<<(ϕ+2) - fxOneAndAHalf<<1); // D ranges up to ±1<<(1*ϕ+2). [INFO] [stdout] | ^ help: convert the identifier to snake case: `d` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `D` should have a snake case name [INFO] [stdout] --> src/vg/raster_fixed.rs:263:29 [INFO] [stdout] | [INFO] [stdout] 263 | let mut D = x1f_squared; // D ranges up to ±1<<(2*ϕ). [INFO] [stdout] | ^ help: convert the identifier to snake case: `d` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 27 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kiss2d` (lib test) due to 4 previous errors; 27 warnings emitted [INFO] running `Command { std: "docker" "inspect" "c77b2c3af49c0542faee0d55ce62482d06f1e0ac746458f81a35b7396924832c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c77b2c3af49c0542faee0d55ce62482d06f1e0ac746458f81a35b7396924832c", kill_on_drop: false }` [INFO] [stdout] c77b2c3af49c0542faee0d55ce62482d06f1e0ac746458f81a35b7396924832c