[INFO] fetching crate kiro-editor 0.4.3... [INFO] checking kiro-editor-0.4.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate kiro-editor 0.4.3 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate kiro-editor 0.4.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate kiro-editor 0.4.3 [INFO] finished tweaking crates.io crate kiro-editor 0.4.3 [INFO] tweaked toml for crates.io crate kiro-editor 0.4.3 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate kiro-editor 0.4.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] db3f057114b85890ef4eba634c5ee1ef13d6c5b595ba353f65e7f6fb21c03f0e [INFO] running `Command { std: "docker" "start" "-a" "db3f057114b85890ef4eba634c5ee1ef13d6c5b595ba353f65e7f6fb21c03f0e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "db3f057114b85890ef4eba634c5ee1ef13d6c5b595ba353f65e7f6fb21c03f0e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "db3f057114b85890ef4eba634c5ee1ef13d6c5b595ba353f65e7f6fb21c03f0e", kill_on_drop: false }` [INFO] [stdout] db3f057114b85890ef4eba634c5ee1ef13d6c5b595ba353f65e7f6fb21c03f0e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4204012bfd4ad65a35b1573c79ea9baafaab2065d4f77232ded6ba345c061ac0 [INFO] running `Command { std: "docker" "start" "-a" "4204012bfd4ad65a35b1573c79ea9baafaab2065d4f77232ded6ba345c061ac0", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.86 [INFO] [stderr] Compiling cc v1.0.67 [INFO] [stderr] Compiling fs_extra v1.2.0 [INFO] [stderr] Compiling signal-hook v0.3.6 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Compiling cargo-husky v1.5.0 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Compiling jemalloc-sys v0.3.2 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking signal-hook-registry v1.3.0 [INFO] [stderr] Checking termios v0.3.3 [INFO] [stderr] Checking term_size v0.3.2 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking term v0.7.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking jemallocator v0.3.2 [INFO] [stderr] Checking kiro-editor v0.4.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/editor.rs:49:12 [INFO] [stdout] | [INFO] [stdout] 43 | mut input: I, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | output: W, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | let screen = Screen::new(window_size, &mut input, output)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let status_bar = StatusBar::from_buffer(&buf, (1, 1)); [INFO] [stdout] 49 | Ok(Editor { [INFO] [stdout] | ____________^ [INFO] [stdout] 50 | | input, [INFO] [stdout] 51 | | quitting: false, [INFO] [stdout] 52 | | hl: Highlighting::default(), [INFO] [stdout] ... | [INFO] [stdout] 56 | | status_bar, [INFO] [stdout] 57 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/editor.rs:86:12 [INFO] [stdout] | [INFO] [stdout] 74 | mut input: I, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | output: W, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | let screen = Screen::new(window_size, &mut input, output)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | Ok(Editor { [INFO] [stdout] | ____________^ [INFO] [stdout] 87 | | input, [INFO] [stdout] 88 | | quitting: false, [INFO] [stdout] 89 | | hl, [INFO] [stdout] ... | [INFO] [stdout] 93 | | status_bar, [INFO] [stdout] 94 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 40 | Ok(StdinRawMode { stdin, orig }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/screen.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 69 | fn get_window_size(input: I, mut output: W) -> Result<(usize, usize)> [INFO] [stdout] | -------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | Err(Error::UnknownWindowSize) // Give up [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/screen.rs:168:12 [INFO] [stdout] | [INFO] [stdout] 148 | pub fn new(size: Option<(usize, usize)>, input: I, mut output: W) -> Result [INFO] [stdout] | -------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 169 | | output, [INFO] [stdout] 170 | | rx: 0, [INFO] [stdout] 171 | | num_cols: w, [INFO] [stdout] ... | [INFO] [stdout] 184 | | coloff: 0, [INFO] [stdout] 185 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signal.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 14 | let flag = Arc::new(AtomicBool::new(false)); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | let signal_id = signal_hook::flag::register(SIGWINCH, Arc::clone(&flag))?; [INFO] [stdout] 16 | Ok(Self { flag, signal_id }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kiro-editor` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/editor.rs:49:12 [INFO] [stdout] | [INFO] [stdout] 43 | mut input: I, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | output: W, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | let screen = Screen::new(window_size, &mut input, output)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let status_bar = StatusBar::from_buffer(&buf, (1, 1)); [INFO] [stdout] 49 | Ok(Editor { [INFO] [stdout] | ____________^ [INFO] [stdout] 50 | | input, [INFO] [stdout] 51 | | quitting: false, [INFO] [stdout] 52 | | hl: Highlighting::default(), [INFO] [stdout] ... | [INFO] [stdout] 56 | | status_bar, [INFO] [stdout] 57 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/editor.rs:86:12 [INFO] [stdout] | [INFO] [stdout] 74 | mut input: I, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | output: W, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | let screen = Screen::new(window_size, &mut input, output)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | Ok(Editor { [INFO] [stdout] | ____________^ [INFO] [stdout] 87 | | input, [INFO] [stdout] 88 | | quitting: false, [INFO] [stdout] 89 | | hl, [INFO] [stdout] ... | [INFO] [stdout] 93 | | status_bar, [INFO] [stdout] 94 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 40 | Ok(StdinRawMode { stdin, orig }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kiro-editor` (lib test) due to 7 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/screen.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 69 | fn get_window_size(input: I, mut output: W) -> Result<(usize, usize)> [INFO] [stdout] | -------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | Err(Error::UnknownWindowSize) // Give up [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/screen.rs:168:12 [INFO] [stdout] | [INFO] [stdout] 148 | pub fn new(size: Option<(usize, usize)>, input: I, mut output: W) -> Result [INFO] [stdout] | -------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 169 | | output, [INFO] [stdout] 170 | | rx: 0, [INFO] [stdout] 171 | | num_cols: w, [INFO] [stdout] ... | [INFO] [stdout] 184 | | coloff: 0, [INFO] [stdout] 185 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signal.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 14 | let flag = Arc::new(AtomicBool::new(false)); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | let signal_id = signal_hook::flag::register(SIGWINCH, Arc::clone(&flag))?; [INFO] [stdout] 16 | Ok(Self { flag, signal_id }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "4204012bfd4ad65a35b1573c79ea9baafaab2065d4f77232ded6ba345c061ac0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4204012bfd4ad65a35b1573c79ea9baafaab2065d4f77232ded6ba345c061ac0", kill_on_drop: false }` [INFO] [stdout] 4204012bfd4ad65a35b1573c79ea9baafaab2065d4f77232ded6ba345c061ac0