[INFO] fetching crate kiri 0.3.0... [INFO] checking kiri-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate kiri 0.3.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate kiri 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate kiri 0.3.0 [INFO] finished tweaking crates.io crate kiri 0.3.0 [INFO] tweaked toml for crates.io crate kiri 0.3.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 24 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding memoffset v0.6.5 (latest: v0.9.1) [INFO] [stderr] Adding nix v0.23.2 (latest: v0.29.0) [INFO] [stderr] Adding radium v0.7.0 (latest: v1.1.0) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding wyz v0.5.1 (latest: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3186c61b7cb7e75a35785dc5f6d53c8d38b333472bd66b3bd210fc9df8112fc0 [INFO] running `Command { std: "docker" "start" "-a" "3186c61b7cb7e75a35785dc5f6d53c8d38b333472bd66b3bd210fc9df8112fc0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3186c61b7cb7e75a35785dc5f6d53c8d38b333472bd66b3bd210fc9df8112fc0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3186c61b7cb7e75a35785dc5f6d53c8d38b333472bd66b3bd210fc9df8112fc0", kill_on_drop: false }` [INFO] [stdout] 3186c61b7cb7e75a35785dc5f6d53c8d38b333472bd66b3bd210fc9df8112fc0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c92c5633011a8f038b49d9f4d3f759caced096123b76068eddde76f313a8111d [INFO] running `Command { std: "docker" "start" "-a" "c92c5633011a8f038b49d9f4d3f759caced096123b76068eddde76f313a8111d", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling radium v0.7.0 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Checking funty v2.0.0 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking wyz v0.5.1 [INFO] [stderr] Checking bitvec v1.0.1 [INFO] [stderr] Checking nix v0.23.2 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking evdev v0.12.2 [INFO] [stderr] Checking evdev-keys v0.2.0 [INFO] [stderr] Checking kiri v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:70:15 [INFO] [stdout] | [INFO] [stdout] 64 | fn run(self) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | let keyboards = get_keyboard_devices().collect::>(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | match self.layers.to_key_recorder() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read_keys.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn order_insensitive(self) -> impl Iterator { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | / [ [INFO] [stdout] 26 | | self.clone(), [INFO] [stdout] 27 | | Self { [INFO] [stdout] 28 | | input: [self.input[1], self.input[0]], [INFO] [stdout] 29 | | ..self [INFO] [stdout] 30 | | }, [INFO] [stdout] 31 | | ] [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read_keys.rs:478:29 [INFO] [stdout] | [INFO] [stdout] 477 | fn add_layer(self, tail: T) -> Self::LayerAdded { [INFO] [stdout] | ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 478 | RemapLayers(self.0, self.1.add_layer(tail)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read_keys.rs:515:21 [INFO] [stdout] | [INFO] [stdout] 513 | fn add_layer(self, tail: T) -> Self::LayerAdded { [INFO] [stdout] | ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 514 | KeyConfig { [INFO] [stdout] 515 | layers: self.layers.add_layer(tail), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write_keys.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 12 | let mut key_set = evdev::AttributeSet::::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 16 | Ok(KeyWriter { [INFO] [stdout] | ____________^ [INFO] [stdout] 17 | | device: VirtualDeviceBuilder::new()? [INFO] [stdout] 18 | | .name(b"kiri virtual keyboard") [INFO] [stdout] 19 | | .with_keys(&key_set) [INFO] [stdout] ... | [INFO] [stdout] 22 | | .unwrap(), [INFO] [stdout] 23 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:70:15 [INFO] [stdout] | [INFO] [stdout] 64 | fn run(self) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | let keyboards = get_keyboard_devices().collect::>(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | match self.layers.to_key_recorder() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read_keys.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn order_insensitive(self) -> impl Iterator { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | / [ [INFO] [stdout] 26 | | self.clone(), [INFO] [stdout] 27 | | Self { [INFO] [stdout] 28 | | input: [self.input[1], self.input[0]], [INFO] [stdout] 29 | | ..self [INFO] [stdout] 30 | | }, [INFO] [stdout] 31 | | ] [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read_keys.rs:478:29 [INFO] [stdout] | [INFO] [stdout] 477 | fn add_layer(self, tail: T) -> Self::LayerAdded { [INFO] [stdout] | ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 478 | RemapLayers(self.0, self.1.add_layer(tail)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read_keys.rs:515:21 [INFO] [stdout] | [INFO] [stdout] 513 | fn add_layer(self, tail: T) -> Self::LayerAdded { [INFO] [stdout] | ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 514 | KeyConfig { [INFO] [stdout] 515 | layers: self.layers.add_layer(tail), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write_keys.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 12 | let mut key_set = evdev::AttributeSet::::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 16 | Ok(KeyWriter { [INFO] [stdout] | ____________^ [INFO] [stdout] 17 | | device: VirtualDeviceBuilder::new()? [INFO] [stdout] 18 | | .name(b"kiri virtual keyboard") [INFO] [stdout] 19 | | .with_keys(&key_set) [INFO] [stdout] ... | [INFO] [stdout] 22 | | .unwrap(), [INFO] [stdout] 23 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kiri` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kiri` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "c92c5633011a8f038b49d9f4d3f759caced096123b76068eddde76f313a8111d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c92c5633011a8f038b49d9f4d3f759caced096123b76068eddde76f313a8111d", kill_on_drop: false }` [INFO] [stdout] c92c5633011a8f038b49d9f4d3f759caced096123b76068eddde76f313a8111d