[INFO] fetching crate kioto-serial 0.1.0... [INFO] checking kioto-serial-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate kioto-serial 0.1.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate kioto-serial 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate kioto-serial 0.1.0 [INFO] finished tweaking crates.io crate kioto-serial 0.1.0 [INFO] tweaked toml for crates.io crate kioto-serial 0.1.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 50 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding nix v0.26.4 (latest: v0.29.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bbf269fcdb71d5c78b7a1e13b17df7bcb46454dd47a1c1b3d04812a523fb4aa2 [INFO] running `Command { std: "docker" "start" "-a" "bbf269fcdb71d5c78b7a1e13b17df7bcb46454dd47a1c1b3d04812a523fb4aa2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bbf269fcdb71d5c78b7a1e13b17df7bcb46454dd47a1c1b3d04812a523fb4aa2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bbf269fcdb71d5c78b7a1e13b17df7bcb46454dd47a1c1b3d04812a523fb4aa2", kill_on_drop: false }` [INFO] [stdout] bbf269fcdb71d5c78b7a1e13b17df7bcb46454dd47a1c1b3d04812a523fb4aa2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c60b4eb0c80f3a87f16a4a8161e904a44c24de5d84d080cdf00b11c7d33ddc6c [INFO] running `Command { std: "docker" "start" "-a" "c60b4eb0c80f3a87f16a4a8161e904a44c24de5d84d080cdf00b11c7d33ddc6c", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Compiling libudev-sys v0.1.4 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking libudev v0.3.0 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking unescaper v0.1.5 [INFO] [stderr] Checking serialport v4.5.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking kioto-serial v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/lib.rs:213:9 [INFO] [stdout] | [INFO] [stdout] 213 | Ok(_never) => { [INFO] [stdout] | ^^^^^^^^^^ matches no values because `NeverOk` is uninhabited [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:168:9 [INFO] [stdout] | [INFO] [stdout] 160 | mut port: Box, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | rx: tokio::io::ReadHalf, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | ) -> Result { [INFO] [stdout] 163 | let mut rx = tokio_util::io::ReaderStream::new(rx); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | Err(Error::SenderClosed) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:202:8 [INFO] [stdout] | [INFO] [stdout] 177 | mut port: Box, [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | let write_port = port.try_clone()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | [INFO] [stdout] 186 | let (for_rw_threads, duplex) = tokio::io::duplex(max_buf_size); [INFO] [stdout] | -------------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | let (read_half, write_half) = tokio::io::split(for_rw_threads); [INFO] [stdout] | --------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 188 | let (read_thread_result_tx, read_thread_result_rx) = tokio::sync::oneshot::channel(); [INFO] [stdout] | --------------------- --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | let (write_thread_result_tx, write_thread_result_rx) = tokio::sync::oneshot::channel(); [INFO] [stdout] | ---------------------- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 201 | let (reader_duplex, writer_duplex) = tokio::io::split(duplex); [INFO] [stdout] | ------------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | Ok(SerialStream { [INFO] [stdout] | ________^ [INFO] [stdout] 203 | | read_err: Box::pin(read_thread_result_rx.map(flatten)), [INFO] [stdout] 204 | | write_err: Box::pin(write_thread_result_rx.map(flatten)), [INFO] [stdout] 205 | | reader_duplex, [INFO] [stdout] 206 | | writer_duplex, [INFO] [stdout] 207 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/lib.rs:213:9 [INFO] [stdout] | [INFO] [stdout] 213 | Ok(_never) => { [INFO] [stdout] | ^^^^^^^^^^ matches no values because `NeverOk` is uninhabited [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:168:9 [INFO] [stdout] | [INFO] [stdout] 160 | mut port: Box, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | rx: tokio::io::ReadHalf, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | ) -> Result { [INFO] [stdout] 163 | let mut rx = tokio_util::io::ReaderStream::new(rx); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | Err(Error::SenderClosed) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:202:8 [INFO] [stdout] | [INFO] [stdout] 177 | mut port: Box, [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | let write_port = port.try_clone()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | [INFO] [stdout] 186 | let (for_rw_threads, duplex) = tokio::io::duplex(max_buf_size); [INFO] [stdout] | -------------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | let (read_half, write_half) = tokio::io::split(for_rw_threads); [INFO] [stdout] | --------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 188 | let (read_thread_result_tx, read_thread_result_rx) = tokio::sync::oneshot::channel(); [INFO] [stdout] | --------------------- --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | let (write_thread_result_tx, write_thread_result_rx) = tokio::sync::oneshot::channel(); [INFO] [stdout] | ---------------------- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 201 | let (reader_duplex, writer_duplex) = tokio::io::split(duplex); [INFO] [stdout] | ------------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | Ok(SerialStream { [INFO] [stdout] | ________^ [INFO] [stdout] 203 | | read_err: Box::pin(read_thread_result_rx.map(flatten)), [INFO] [stdout] 204 | | write_err: Box::pin(write_thread_result_rx.map(flatten)), [INFO] [stdout] 205 | | reader_duplex, [INFO] [stdout] 206 | | writer_duplex, [INFO] [stdout] 207 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kioto-serial` (lib) due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kioto-serial` (lib test) due to 3 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "c60b4eb0c80f3a87f16a4a8161e904a44c24de5d84d080cdf00b11c7d33ddc6c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c60b4eb0c80f3a87f16a4a8161e904a44c24de5d84d080cdf00b11c7d33ddc6c", kill_on_drop: false }` [INFO] [stdout] c60b4eb0c80f3a87f16a4a8161e904a44c24de5d84d080cdf00b11c7d33ddc6c