[INFO] fetching crate kinesis-firehose-producer 0.1.2... [INFO] checking kinesis-firehose-producer-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate kinesis-firehose-producer 0.1.2 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate kinesis-firehose-producer 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate kinesis-firehose-producer 0.1.2 [INFO] finished tweaking crates.io crate kinesis-firehose-producer 0.1.2 [INFO] tweaked toml for crates.io crate kinesis-firehose-producer 0.1.2 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate kinesis-firehose-producer 0.1.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `rusoto_core` dependency) [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `rusoto_firehose` dependency) [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ca996c98ec33d9cbf6cf4722be76a91c94dc157b7da528b07985a012f6397acc [INFO] running `Command { std: "docker" "start" "-a" "ca996c98ec33d9cbf6cf4722be76a91c94dc157b7da528b07985a012f6397acc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ca996c98ec33d9cbf6cf4722be76a91c94dc157b7da528b07985a012f6397acc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ca996c98ec33d9cbf6cf4722be76a91c94dc157b7da528b07985a012f6397acc", kill_on_drop: false }` [INFO] [stdout] ca996c98ec33d9cbf6cf4722be76a91c94dc157b7da528b07985a012f6397acc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ad8191221f9f849a95627826958e31df365fd9e3469cbe65ebcba2fb90ccddc7 [INFO] running `Command { std: "docker" "start" "-a" "ad8191221f9f849a95627826958e31df365fd9e3469cbe65ebcba2fb90ccddc7", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `rusoto_core` dependency) [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `rusoto_firehose` dependency) [INFO] [stderr] Compiling proc-macro2 v1.0.27 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling libc v0.2.97 [INFO] [stderr] Compiling syn v1.0.73 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Checking once_cell v1.8.0 [INFO] [stderr] Checking pin-project-lite v0.2.7 [INFO] [stderr] Compiling cc v1.0.68 [INFO] [stderr] Compiling futures-core v0.3.15 [INFO] [stderr] Compiling futures-task v0.3.15 [INFO] [stderr] Compiling futures-macro v0.3.15 [INFO] [stderr] Compiling futures-channel v0.3.15 [INFO] [stderr] Compiling typenum v1.13.0 [INFO] [stderr] Compiling futures-util v0.3.15 [INFO] [stderr] Checking futures-sink v0.3.15 [INFO] [stderr] Compiling tokio v1.7.1 [INFO] [stderr] Checking slab v0.4.3 [INFO] [stderr] Checking futures-io v0.3.15 [INFO] [stderr] Compiling serde_derive v1.0.126 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling serde v1.0.126 [INFO] [stderr] Compiling httparse v1.4.1 [INFO] [stderr] Checking http v0.2.4 [INFO] [stderr] Checking tracing-core v0.1.18 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Checking try-lock v0.2.3 [INFO] [stderr] Compiling const_fn v0.4.8 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Compiling generic-array v0.14.4 [INFO] [stderr] Compiling standback v0.2.17 [INFO] [stderr] Checking httpdate v1.0.1 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling async-trait v0.1.50 [INFO] [stderr] Checking tower-service v0.3.1 [INFO] [stderr] Compiling time v0.2.27 [INFO] [stderr] Checking subtle v2.4.0 [INFO] [stderr] Checking tracing v0.1.26 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking openssl-probe v0.1.4 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking opaque-debug v0.3.0 [INFO] [stderr] Checking shlex v0.1.1 [INFO] [stderr] Checking zeroize v1.3.0 [INFO] [stderr] Checking cpufeatures v0.1.5 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking md5 v0.7.0 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling unicode-segmentation v1.7.1 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking xml-rs v0.8.3 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking mio v0.7.13 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking socket2 v0.4.0 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Compiling rusoto_core v0.46.0 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Compiling anyhow v1.0.41 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking crypto-mac v0.10.0 [INFO] [stderr] Checking hmac v0.10.1 [INFO] [stderr] Checking sha2 v0.9.5 [INFO] [stderr] Checking http-body v0.4.2 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking env_logger v0.8.4 [INFO] [stderr] Compiling tokio-macros v1.2.0 [INFO] [stderr] Compiling time-macros-impl v0.1.2 [INFO] [stderr] Compiling fehler-macros v1.0.0 [INFO] [stderr] Compiling thiserror-impl v1.0.25 [INFO] [stderr] Compiling structopt-derive v0.4.14 [INFO] [stderr] Compiling test-env-log v0.2.7 [INFO] [stderr] Checking sct v0.6.1 [INFO] [stderr] Checking webpki v0.21.4 [INFO] [stderr] Checking ct-logs v0.8.0 [INFO] [stderr] Checking rustls v0.19.1 [INFO] [stderr] Checking time-macros v0.1.1 [INFO] [stderr] Checking thiserror v1.0.25 [INFO] [stderr] Checking fehler v1.0.0 [INFO] [stderr] Checking structopt v0.3.21 [INFO] [stderr] Checking rustls-native-certs v0.5.0 [INFO] [stderr] Checking futures-executor v0.3.15 [INFO] [stderr] Checking futures v0.3.15 [INFO] [stderr] Checking hyper v0.14.9 [INFO] [stderr] Checking tokio-rustls v0.22.0 [INFO] [stderr] Checking hyper-rustls v0.22.1 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking serde_json v1.0.64 [INFO] [stderr] Checking rusoto_credential v0.46.0 [INFO] [stderr] Checking rusoto_signature v0.46.0 [INFO] [stderr] Checking rusoto_firehose v0.46.0 [INFO] [stderr] Checking kinesis-firehose-producer v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/put_record_batcher.rs:129:73 [INFO] [stdout] | [INFO] [stdout] 128 | req: PutRecordBatchInput, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | ) -> Result> { [INFO] [stdout] | _________________________________________________________________________^ [INFO] [stdout] 130 | | self.put_record_batch(req).await [INFO] [stdout] 131 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_producer.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 123 | pub fn with_client(client: C, stream_name: String) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | / Self { [INFO] [stdout] 125 | | buf: Buffer::new(), [INFO] [stdout] 126 | | client, [INFO] [stdout] 127 | | stream_name, [INFO] [stdout] 128 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_producer_pool.rs:91:64 [INFO] [stdout] | [INFO] [stdout] 91 | .then(|n| Self::create_member(stream_name.clone(), err_tx.clone(), n, &make_producer)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kinesis-firehose-producer` (lib) due to 5 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync_producer.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn with_client(client: C, stream_name: String) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | / Self { [INFO] [stdout] 61 | | async_producer: async_producer::Producer::with_client(client, stream_name)?, [INFO] [stdout] 62 | | runtime: make_runtime()?, [INFO] [stdout] 63 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/put_record_batcher.rs:73:73 [INFO] [stdout] | [INFO] [stdout] 72 | req: PutRecordBatchInput, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | ) -> Result> { [INFO] [stdout] | _________________________________________________________________________^ [INFO] [stdout] 74 | | let records = req.records; [INFO] [stdout] 75 | | [INFO] [stdout] 76 | | let buf = self.buf.lock().expect("poisoned mutex"); [INFO] [stdout] ... | [INFO] [stdout] 120 | | Ok(resp) [INFO] [stdout] 121 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/put_record_batcher.rs:129:73 [INFO] [stdout] | [INFO] [stdout] 128 | req: PutRecordBatchInput, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | ) -> Result> { [INFO] [stdout] | _________________________________________________________________________^ [INFO] [stdout] 130 | | self.put_record_batch(req).await [INFO] [stdout] 131 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_producer.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 123 | pub fn with_client(client: C, stream_name: String) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | / Self { [INFO] [stdout] 125 | | buf: Buffer::new(), [INFO] [stdout] 126 | | client, [INFO] [stdout] 127 | | stream_name, [INFO] [stdout] 128 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_producer_pool.rs:91:64 [INFO] [stdout] | [INFO] [stdout] 91 | .then(|n| Self::create_member(stream_name.clone(), err_tx.clone(), n, &make_producer)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync_producer.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn with_client(client: C, stream_name: String) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | / Self { [INFO] [stdout] 61 | | async_producer: async_producer::Producer::with_client(client, stream_name)?, [INFO] [stdout] 62 | | runtime: make_runtime()?, [INFO] [stdout] 63 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kinesis-firehose-producer` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "ad8191221f9f849a95627826958e31df365fd9e3469cbe65ebcba2fb90ccddc7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ad8191221f9f849a95627826958e31df365fd9e3469cbe65ebcba2fb90ccddc7", kill_on_drop: false }` [INFO] [stdout] ad8191221f9f849a95627826958e31df365fd9e3469cbe65ebcba2fb90ccddc7