[INFO] fetching crate kinesis 0.0.1... [INFO] checking kinesis-0.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate kinesis 0.0.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate kinesis 0.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate kinesis 0.0.1 [INFO] finished tweaking crates.io crate kinesis 0.0.1 [INFO] tweaked toml for crates.io crate kinesis 0.0.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 17 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] aeb099331932679e526457a15d03a15bd19e82219a9f71214a6ac70b40ef5c47 [INFO] running `Command { std: "docker" "start" "-a" "aeb099331932679e526457a15d03a15bd19e82219a9f71214a6ac70b40ef5c47", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "aeb099331932679e526457a15d03a15bd19e82219a9f71214a6ac70b40ef5c47", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aeb099331932679e526457a15d03a15bd19e82219a9f71214a6ac70b40ef5c47", kill_on_drop: false }` [INFO] [stdout] aeb099331932679e526457a15d03a15bd19e82219a9f71214a6ac70b40ef5c47 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b90d64369df70d95839129464690f380ae0d3fbbbc04ae1adf92f96f2fc7ac89 [INFO] running `Command { std: "docker" "start" "-a" "b90d64369df70d95839129464690f380ae0d3fbbbc04ae1adf92f96f2fc7ac89", kill_on_drop: false }` [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.93 [INFO] [stderr] Compiling log v0.4.22 [INFO] [stderr] Compiling bumpalo v3.16.0 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling wasm-bindgen v0.2.93 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling wasm-bindgen-backend v0.2.93 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.93 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.93 [INFO] [stderr] Checking js-sys v0.3.70 [INFO] [stderr] Checking console_error_panic_hook v0.1.7 [INFO] [stderr] Checking web-sys v0.3.70 [INFO] [stderr] Checking kinesis v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `render_position::RenderPosition` [INFO] [stdout] --> src/component/controller_v2.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | render_position::RenderPosition, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `controller_v2::*` [INFO] [stdout] --> src/component/mod.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | pub use controller_v2::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `console` [INFO] [stdout] --> src/dom/dynamic.rs:3:15 [INFO] [stdout] | [INFO] [stdout] 3 | use web_sys::{console, Document}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `web_sys::Element` [INFO] [stdout] --> src/dom/render_position.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use web_sys::Element; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused macro definition: `generate_match` [INFO] [stdout] --> src/dom/render_position.rs:30:14 [INFO] [stdout] | [INFO] [stdout] 30 | macro_rules! generate_match { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_macros)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `render_position::RenderPosition` [INFO] [stdout] --> src/dom/mod.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | render_position::RenderPosition, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `TextContent` [INFO] [stdout] --> src/counter.rs:5:85 [INFO] [stdout] | [INFO] [stdout] 5 | dom::{dynamic::Dynamic, renderable::Renderable, text::Text, DomNode, EventType, TextContent}, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `render_position::RenderPosition` [INFO] [stdout] --> src/component/controller_v2.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | render_position::RenderPosition, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `controller_v2::*` [INFO] [stdout] --> src/component/mod.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | pub use controller_v2::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `console` [INFO] [stdout] --> src/dom/dynamic.rs:3:15 [INFO] [stdout] | [INFO] [stdout] 3 | use web_sys::{console, Document}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `web_sys::Element` [INFO] [stdout] --> src/dom/render_position.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use web_sys::Element; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused macro definition: `generate_match` [INFO] [stdout] --> src/dom/render_position.rs:30:14 [INFO] [stdout] | [INFO] [stdout] 30 | macro_rules! generate_match { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_macros)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `render_position::RenderPosition` [INFO] [stdout] --> src/dom/mod.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | render_position::RenderPosition, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `TextContent` [INFO] [stdout] --> src/counter.rs:5:85 [INFO] [stdout] | [INFO] [stdout] 5 | dom::{dynamic::Dynamic, renderable::Renderable, text::Text, DomNode, EventType, TextContent}, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `document` [INFO] [stdout] --> src/dom/dynamic.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | document: &Document, [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_document` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `get_event_closure` [INFO] [stdout] --> src/dom/dynamic.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | get_event_closure: &mut dyn FnMut(EventType) -> Function, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_get_event_closure` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `component` [INFO] [stdout] --> src/dom/renderable.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | component: &dyn Component, [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_component` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `get_event_closure` [INFO] [stdout] --> src/dom/text.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | get_event_closure: &mut dyn FnMut(EventType) -> Function, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_get_event_closure` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `component` [INFO] [stdout] --> src/dom/mod.rs:137:9 [INFO] [stdout] | [INFO] [stdout] 137 | component: &dyn Component, [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_component` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/dom/mod.rs:163:13 [INFO] [stdout] | [INFO] [stdout] 163 | let mut dynamic_content = Vec::::new(); [INFO] [stdout] | ----^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `id` [INFO] [stdout] --> src/simple.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | id: Identifier, [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `event_type` [INFO] [stdout] --> src/simple.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | event_type: EventType, [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_event_type` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `event` [INFO] [stdout] --> src/simple.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | event: Event, [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_event` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `sibling` is never used [INFO] [stdout] --> src/component/identifier.rs:9:12 [INFO] [stdout] | [INFO] [stdout] 4 | impl Identifier { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 9 | pub fn sibling(&self) -> Self { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `TextContent` is never used [INFO] [stdout] --> src/dom/mod.rs:47:10 [INFO] [stdout] | [INFO] [stdout] 47 | pub enum TextContent { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `NodeContent` is never used [INFO] [stdout] --> src/dom/mod.rs:65:10 [INFO] [stdout] | [INFO] [stdout] 65 | pub enum NodeContent { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `DomContent` is never used [INFO] [stdout] --> src/dom/mod.rs:73:10 [INFO] [stdout] | [INFO] [stdout] 73 | pub enum DomContent { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `RenderPosition` is never used [INFO] [stdout] --> src/dom/render_position.rs:8:10 [INFO] [stdout] | [INFO] [stdout] 8 | pub enum RenderPosition { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RenderPosition` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `render` and `get_element` are never used [INFO] [stdout] --> src/dom/render_position.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 47 | impl RenderPosition { [INFO] [stdout] | ------------------- methods in this implementation [INFO] [stdout] 48 | pub fn render(&self, element: &RenderedNode) -> Result<(), JsValue> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 111 | pub fn get_element(&self) -> Option { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `cache_node` is never read [INFO] [stdout] --> src/dom/renderable.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 38 | pub struct DomNodeBuildResult { [INFO] [stdout] | ------------------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 43 | pub cache_node: bool, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/counter.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 13 | impl Counter { [INFO] [stdout] | ------------ associated function in this implementation [INFO] [stdout] 14 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/component/controller_v2.rs:45:24 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn new(component: C, document: &Document) -> Self [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | component: Rc::new(RefCell::new(component)) as Rc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/component/controller_v2.rs:46:23 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn new(component: C, document: &Document) -> Self [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | document: document.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/component/controller_v2.rs:48:32 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn new(component: C, document: &Document) -> Self [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | rendered_elements: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/component/controller_v2.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 62 | let controller_ref = controller_ref.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | [INFO] [stdout] 64 | / Closure::::new(Box::new(move |event: Event| { [INFO] [stdout] 65 | | // Gain a mutable reference to the controller [INFO] [stdout] 66 | | let mut controller = controller_ref.0.borrow_mut(); [INFO] [stdout] 67 | | let changed = controller.component.borrow_mut().handle_event( [INFO] [stdout] ... | [INFO] [stdout] 77 | | }) as Box) [INFO] [stdout] 78 | | .into_js_value() [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/component/controller_v2.rs:128:79 [INFO] [stdout] | [INFO] [stdout] 128 | .map(|(i, renderable)| (root_identifier.child(i), renderable, parent.clone())) [INFO] [stdout] | --------------- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/component/controller_v2.rs:159:33 [INFO] [stdout] | [INFO] [stdout] 155 | queue.extend(children.into_iter().enumerate().map(|(i, renderable)| { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | / if result.in_place { [INFO] [stdout] 160 | | parent.clone() [INFO] [stdout] 161 | | } else { [INFO] [stdout] 162 | | result.element.clone() [INFO] [stdout] 163 | | }, [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/component/controller_v2.rs:227:14 [INFO] [stdout] | [INFO] [stdout] 223 | pub fn new(component: C, document: &Document) -> Self [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | Self(Rc::new(RefCell::new(Controller::new(component, document)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dom/mod.rs:200:12 [INFO] [stdout] | [INFO] [stdout] 135 | self: Box, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | element: Option, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | let element = element [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 200 | Ok(Some(DomNodeBuildResult { [INFO] [stdout] | ____________^ [INFO] [stdout] 201 | | element: Some(RenderedNode::Element(element)), [INFO] [stdout] 202 | | cache_node: true, [INFO] [stdout] 203 | | children: Some(self.children), [INFO] [stdout] 204 | | dynamic_content, [INFO] [stdout] 205 | | in_place: false, [INFO] [stdout] 206 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dom/dynamic.rs:44:12 [INFO] [stdout] | [INFO] [stdout] 35 | self: Box, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | element: Option, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | let children = component.render(RenderType::Partial(self.render_type)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | [INFO] [stdout] 44 | Ok(Some(DomNodeBuildResult { [INFO] [stdout] | ____________^ [INFO] [stdout] 45 | | element, [INFO] [stdout] 46 | | cache_node: false, [INFO] [stdout] 47 | | children, [INFO] [stdout] ... | [INFO] [stdout] 52 | | in_place: true, [INFO] [stdout] 53 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/dom/render_position.rs:56:17 [INFO] [stdout] | [INFO] [stdout] 56 | parent.append_child(element); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 56 | let _ = parent.append_child(element); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/dom/render_position.rs:59:17 [INFO] [stdout] | [INFO] [stdout] 59 | parent.append_child(element); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 59 | let _ = parent.append_child(element); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/dom/render_position.rs:62:17 [INFO] [stdout] | [INFO] [stdout] 62 | parent.prepend_with_node_1(element); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 62 | let _ = parent.prepend_with_node_1(element); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/dom/render_position.rs:66:21 [INFO] [stdout] | [INFO] [stdout] 66 | parent.insert_before(&sibling, Some(element)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 66 | let _ = parent.insert_before(&sibling, Some(element)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/dom/render_position.rs:69:21 [INFO] [stdout] | [INFO] [stdout] 69 | parent.append_child(element); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 69 | let _ = parent.append_child(element); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/dom/render_position.rs:73:17 [INFO] [stdout] | [INFO] [stdout] 73 | sibling.before_with_node_1(element); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 73 | let _ = sibling.before_with_node_1(element); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/dom/render_position.rs:76:17 [INFO] [stdout] | [INFO] [stdout] 76 | / sibling [INFO] [stdout] 77 | | .parent_element() [INFO] [stdout] 78 | | .expect("to be able to get a parent element") [INFO] [stdout] 79 | | .insert_before(sibling, Some(element)); [INFO] [stdout] | |__________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 76 | let _ = sibling [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/dom/render_position.rs:82:17 [INFO] [stdout] | [INFO] [stdout] 82 | parent.after_with_node_1(element); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 82 | let _ = parent.after_with_node_1(element); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/dom/render_position.rs:90:21 [INFO] [stdout] | [INFO] [stdout] 90 | parent.insert_before(&sibling, Some(element)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 90 | let _ = parent.insert_before(&sibling, Some(element)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/dom/render_position.rs:93:21 [INFO] [stdout] | [INFO] [stdout] 93 | parent.append_child(element); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 93 | let _ = parent.append_child(element); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/dom/render_position.rs:97:17 [INFO] [stdout] | [INFO] [stdout] 97 | old_element.replace_with_with_node_1(element); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 97 | let _ = old_element.replace_with_with_node_1(element); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/dom/render_position.rs:100:17 [INFO] [stdout] | [INFO] [stdout] 100 | / old_element [INFO] [stdout] 101 | | .parent_node() [INFO] [stdout] 102 | | .expect("to be able to get a parent node") [INFO] [stdout] 103 | | .replace_child(old_element, element); [INFO] [stdout] | |________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 100 | let _ = old_element [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dom/renderable.rs:80:12 [INFO] [stdout] | [INFO] [stdout] 72 | self: Box, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | element: Option, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | let children = self.into_iter().collect::>(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | [INFO] [stdout] 80 | Ok(if !children.is_empty() { [INFO] [stdout] | ____________^ [INFO] [stdout] 81 | | Some(DomNodeBuildResult { [INFO] [stdout] 82 | | element, [INFO] [stdout] 83 | | cache_node: false, [INFO] [stdout] ... | [INFO] [stdout] 89 | | None [INFO] [stdout] 90 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dom/text.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 25 | self: Box, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | element: Option, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | let node = document.create_text_node(&self.0); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | Ok(Some(DomNodeBuildResult { [INFO] [stdout] | ____________^ [INFO] [stdout] 41 | | element: Some(RenderedNode::Node(node.into())), [INFO] [stdout] 42 | | cache_node: false, [INFO] [stdout] 43 | | children: None, [INFO] [stdout] 44 | | dynamic_content: Vec::new(), [INFO] [stdout] 45 | | in_place: false, [INFO] [stdout] 46 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/hash_map_list.rs:83:14 [INFO] [stdout] | [INFO] [stdout] 70 | let key = self.0.keys().next()?.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | let value = list.pop()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | Some((key, value)) [INFO] [stdout] | ^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 36 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kinesis` (lib) due to 13 previous errors; 36 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `document` [INFO] [stdout] --> src/dom/dynamic.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | document: &Document, [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_document` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `get_event_closure` [INFO] [stdout] --> src/dom/dynamic.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | get_event_closure: &mut dyn FnMut(EventType) -> Function, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_get_event_closure` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `component` [INFO] [stdout] --> src/dom/renderable.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | component: &dyn Component, [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_component` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `get_event_closure` [INFO] [stdout] --> src/dom/text.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | get_event_closure: &mut dyn FnMut(EventType) -> Function, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_get_event_closure` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `component` [INFO] [stdout] --> src/dom/mod.rs:137:9 [INFO] [stdout] | [INFO] [stdout] 137 | component: &dyn Component, [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_component` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/dom/mod.rs:163:13 [INFO] [stdout] | [INFO] [stdout] 163 | let mut dynamic_content = Vec::::new(); [INFO] [stdout] | ----^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `id` [INFO] [stdout] --> src/simple.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | id: Identifier, [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `event_type` [INFO] [stdout] --> src/simple.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | event_type: EventType, [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_event_type` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `event` [INFO] [stdout] --> src/simple.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | event: Event, [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_event` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `sibling` is never used [INFO] [stdout] --> src/component/identifier.rs:9:12 [INFO] [stdout] | [INFO] [stdout] 4 | impl Identifier { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 9 | pub fn sibling(&self) -> Self { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `TextContent` is never used [INFO] [stdout] --> src/dom/mod.rs:47:10 [INFO] [stdout] | [INFO] [stdout] 47 | pub enum TextContent { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `NodeContent` is never used [INFO] [stdout] --> src/dom/mod.rs:65:10 [INFO] [stdout] | [INFO] [stdout] 65 | pub enum NodeContent { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `DomContent` is never used [INFO] [stdout] --> src/dom/mod.rs:73:10 [INFO] [stdout] | [INFO] [stdout] 73 | pub enum DomContent { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `RenderPosition` is never used [INFO] [stdout] --> src/dom/render_position.rs:8:10 [INFO] [stdout] | [INFO] [stdout] 8 | pub enum RenderPosition { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RenderPosition` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `render` and `get_element` are never used [INFO] [stdout] --> src/dom/render_position.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 47 | impl RenderPosition { [INFO] [stdout] | ------------------- methods in this implementation [INFO] [stdout] 48 | pub fn render(&self, element: &RenderedNode) -> Result<(), JsValue> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 111 | pub fn get_element(&self) -> Option { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `cache_node` is never read [INFO] [stdout] --> src/dom/renderable.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 38 | pub struct DomNodeBuildResult { [INFO] [stdout] | ------------------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 43 | pub cache_node: bool, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/counter.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 13 | impl Counter { [INFO] [stdout] | ------------ associated function in this implementation [INFO] [stdout] 14 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/component/controller_v2.rs:45:24 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn new(component: C, document: &Document) -> Self [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | component: Rc::new(RefCell::new(component)) as Rc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/component/controller_v2.rs:46:23 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn new(component: C, document: &Document) -> Self [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | document: document.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/component/controller_v2.rs:48:32 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn new(component: C, document: &Document) -> Self [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | rendered_elements: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/component/controller_v2.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 62 | let controller_ref = controller_ref.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | [INFO] [stdout] 64 | / Closure::::new(Box::new(move |event: Event| { [INFO] [stdout] 65 | | // Gain a mutable reference to the controller [INFO] [stdout] 66 | | let mut controller = controller_ref.0.borrow_mut(); [INFO] [stdout] 67 | | let changed = controller.component.borrow_mut().handle_event( [INFO] [stdout] ... | [INFO] [stdout] 77 | | }) as Box) [INFO] [stdout] 78 | | .into_js_value() [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/component/controller_v2.rs:128:79 [INFO] [stdout] | [INFO] [stdout] 128 | .map(|(i, renderable)| (root_identifier.child(i), renderable, parent.clone())) [INFO] [stdout] | --------------- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/component/controller_v2.rs:159:33 [INFO] [stdout] | [INFO] [stdout] 155 | queue.extend(children.into_iter().enumerate().map(|(i, renderable)| { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | / if result.in_place { [INFO] [stdout] 160 | | parent.clone() [INFO] [stdout] 161 | | } else { [INFO] [stdout] 162 | | result.element.clone() [INFO] [stdout] 163 | | }, [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/component/controller_v2.rs:227:14 [INFO] [stdout] | [INFO] [stdout] 223 | pub fn new(component: C, document: &Document) -> Self [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | Self(Rc::new(RefCell::new(Controller::new(component, document)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dom/mod.rs:200:12 [INFO] [stdout] | [INFO] [stdout] 135 | self: Box, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | element: Option, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | let element = element [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 200 | Ok(Some(DomNodeBuildResult { [INFO] [stdout] | ____________^ [INFO] [stdout] 201 | | element: Some(RenderedNode::Element(element)), [INFO] [stdout] 202 | | cache_node: true, [INFO] [stdout] 203 | | children: Some(self.children), [INFO] [stdout] 204 | | dynamic_content, [INFO] [stdout] 205 | | in_place: false, [INFO] [stdout] 206 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dom/dynamic.rs:44:12 [INFO] [stdout] | [INFO] [stdout] 35 | self: Box, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | element: Option, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | let children = component.render(RenderType::Partial(self.render_type)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | [INFO] [stdout] 44 | Ok(Some(DomNodeBuildResult { [INFO] [stdout] | ____________^ [INFO] [stdout] 45 | | element, [INFO] [stdout] 46 | | cache_node: false, [INFO] [stdout] 47 | | children, [INFO] [stdout] ... | [INFO] [stdout] 52 | | in_place: true, [INFO] [stdout] 53 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/dom/render_position.rs:56:17 [INFO] [stdout] | [INFO] [stdout] 56 | parent.append_child(element); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 56 | let _ = parent.append_child(element); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/dom/render_position.rs:59:17 [INFO] [stdout] | [INFO] [stdout] 59 | parent.append_child(element); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 59 | let _ = parent.append_child(element); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/dom/render_position.rs:62:17 [INFO] [stdout] | [INFO] [stdout] 62 | parent.prepend_with_node_1(element); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 62 | let _ = parent.prepend_with_node_1(element); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/dom/render_position.rs:66:21 [INFO] [stdout] | [INFO] [stdout] 66 | parent.insert_before(&sibling, Some(element)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 66 | let _ = parent.insert_before(&sibling, Some(element)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/dom/render_position.rs:69:21 [INFO] [stdout] | [INFO] [stdout] 69 | parent.append_child(element); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 69 | let _ = parent.append_child(element); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/dom/render_position.rs:73:17 [INFO] [stdout] | [INFO] [stdout] 73 | sibling.before_with_node_1(element); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 73 | let _ = sibling.before_with_node_1(element); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/dom/render_position.rs:76:17 [INFO] [stdout] | [INFO] [stdout] 76 | / sibling [INFO] [stdout] 77 | | .parent_element() [INFO] [stdout] 78 | | .expect("to be able to get a parent element") [INFO] [stdout] 79 | | .insert_before(sibling, Some(element)); [INFO] [stdout] | |__________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 76 | let _ = sibling [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/dom/render_position.rs:82:17 [INFO] [stdout] | [INFO] [stdout] 82 | parent.after_with_node_1(element); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 82 | let _ = parent.after_with_node_1(element); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/dom/render_position.rs:90:21 [INFO] [stdout] | [INFO] [stdout] 90 | parent.insert_before(&sibling, Some(element)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 90 | let _ = parent.insert_before(&sibling, Some(element)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/dom/render_position.rs:93:21 [INFO] [stdout] | [INFO] [stdout] 93 | parent.append_child(element); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 93 | let _ = parent.append_child(element); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/dom/render_position.rs:97:17 [INFO] [stdout] | [INFO] [stdout] 97 | old_element.replace_with_with_node_1(element); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 97 | let _ = old_element.replace_with_with_node_1(element); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/dom/render_position.rs:100:17 [INFO] [stdout] | [INFO] [stdout] 100 | / old_element [INFO] [stdout] 101 | | .parent_node() [INFO] [stdout] 102 | | .expect("to be able to get a parent node") [INFO] [stdout] 103 | | .replace_child(old_element, element); [INFO] [stdout] | |________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 100 | let _ = old_element [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dom/renderable.rs:80:12 [INFO] [stdout] | [INFO] [stdout] 72 | self: Box, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | element: Option, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | let children = self.into_iter().collect::>(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | [INFO] [stdout] 80 | Ok(if !children.is_empty() { [INFO] [stdout] | ____________^ [INFO] [stdout] 81 | | Some(DomNodeBuildResult { [INFO] [stdout] 82 | | element, [INFO] [stdout] 83 | | cache_node: false, [INFO] [stdout] ... | [INFO] [stdout] 89 | | None [INFO] [stdout] 90 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dom/text.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 25 | self: Box, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | element: Option, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | let node = document.create_text_node(&self.0); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | Ok(Some(DomNodeBuildResult { [INFO] [stdout] | ____________^ [INFO] [stdout] 41 | | element: Some(RenderedNode::Node(node.into())), [INFO] [stdout] 42 | | cache_node: false, [INFO] [stdout] 43 | | children: None, [INFO] [stdout] 44 | | dynamic_content: Vec::new(), [INFO] [stdout] 45 | | in_place: false, [INFO] [stdout] 46 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/hash_map_list.rs:83:14 [INFO] [stdout] | [INFO] [stdout] 70 | let key = self.0.keys().next()?.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | let value = list.pop()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | Some((key, value)) [INFO] [stdout] | ^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 36 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kinesis` (lib test) due to 13 previous errors; 36 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b90d64369df70d95839129464690f380ae0d3fbbbc04ae1adf92f96f2fc7ac89", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b90d64369df70d95839129464690f380ae0d3fbbbc04ae1adf92f96f2fc7ac89", kill_on_drop: false }` [INFO] [stdout] b90d64369df70d95839129464690f380ae0d3fbbbc04ae1adf92f96f2fc7ac89