[INFO] fetching crate kindness 0.4.0... [INFO] checking kindness-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate kindness 0.4.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate kindness 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate kindness 0.4.0 [INFO] finished tweaking crates.io crate kindness 0.4.0 [INFO] tweaked toml for crates.io crate kindness 0.4.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 113 packages to latest compatible versions [INFO] [stderr] Adding anes v0.1.6 (latest: v0.2.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clap v3.2.25 (latest: v4.5.16) [INFO] [stderr] Adding clap_lex v0.2.4 (latest: v0.7.2) [INFO] [stderr] Adding criterion v0.4.0 (latest: v0.5.1) [INFO] [stderr] Adding encode_unicode v0.3.6 (latest: v1.0.0) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding os_str_bytes v6.6.1 (latest: v7.0.0) [INFO] [stderr] Adding pulldown-cmark v0.9.6 (latest: v0.12.0) [INFO] [stderr] Adding toml v0.7.8 (latest: v0.8.19) [INFO] [stderr] Adding toml_edit v0.19.15 (latest: v0.22.20) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding winnow v0.5.40 (latest: v0.6.18) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5466410d6fa8ab23dbe148905208a15688149bd49d63f9b0e61b94aa482fd6c1 [INFO] running `Command { std: "docker" "start" "-a" "5466410d6fa8ab23dbe148905208a15688149bd49d63f9b0e61b94aa482fd6c1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5466410d6fa8ab23dbe148905208a15688149bd49d63f9b0e61b94aa482fd6c1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5466410d6fa8ab23dbe148905208a15688149bd49d63f9b0e61b94aa482fd6c1", kill_on_drop: false }` [INFO] [stdout] 5466410d6fa8ab23dbe148905208a15688149bd49d63f9b0e61b94aa482fd6c1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 529e4d23955c0d9f81ff5fc433ce1b1d3e6bb800248ed203d6add030109ba39c [INFO] running `Command { std: "docker" "start" "-a" "529e4d23955c0d9f81ff5fc433ce1b1d3e6bb800248ed203d6add030109ba39c", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Compiling pulldown-cmark v0.9.6 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking winnow v0.5.40 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking similar v2.6.0 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking insta v1.39.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking kindness v0.4.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking toml_edit v0.19.15 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.4.0 [INFO] [stderr] Checking toml v0.7.8 [INFO] [stderr] Checking version-sync v0.9.5 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:313:21 [INFO] [stdout] | [INFO] [stdout] 279 | fn choose_unique(mut self, rng: &mut R) -> unique::iterators::Unique [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 286 | let mut map: HashMap = Default::default(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 313 | Unique::new(map.into_keys()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:348:45 [INFO] [stdout] | [INFO] [stdout] 323 | mut self, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 324 | rng: &mut R, [INFO] [stdout] 325 | mut f: F, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 328 | let mut map: HashMap = Default::default(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 348 | unique::iterators::UniqueByKey::new(map.into_values()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unique.rs:89:13 [INFO] [stdout] | [INFO] [stdout] 85 | fn last(self) -> Option [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | self.map.map(|x| x.0).last() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kindness` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "529e4d23955c0d9f81ff5fc433ce1b1d3e6bb800248ed203d6add030109ba39c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "529e4d23955c0d9f81ff5fc433ce1b1d3e6bb800248ed203d6add030109ba39c", kill_on_drop: false }` [INFO] [stdout] 529e4d23955c0d9f81ff5fc433ce1b1d3e6bb800248ed203d6add030109ba39c