[INFO] fetching crate kik_sync_service 0.7.3... [INFO] checking kik_sync_service-0.7.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate kik_sync_service 0.7.3 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate kik_sync_service 0.7.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate kik_sync_service 0.7.3 [INFO] finished tweaking crates.io crate kik_sync_service 0.7.3 [INFO] tweaked toml for crates.io crate kik_sync_service 0.7.3 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b93a9e7ab1cf382a022dfb40a27e079aa3872b88d9bf3d0f42f813a9069934f5 [INFO] running `Command { std: "docker" "start" "-a" "b93a9e7ab1cf382a022dfb40a27e079aa3872b88d9bf3d0f42f813a9069934f5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b93a9e7ab1cf382a022dfb40a27e079aa3872b88d9bf3d0f42f813a9069934f5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b93a9e7ab1cf382a022dfb40a27e079aa3872b88d9bf3d0f42f813a9069934f5", kill_on_drop: false }` [INFO] [stdout] b93a9e7ab1cf382a022dfb40a27e079aa3872b88d9bf3d0f42f813a9069934f5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 88ea9d77b28c00fb3304d32364e0267abb00cf8f6acffef147655673674c2c8b [INFO] running `Command { std: "docker" "start" "-a" "88ea9d77b28c00fb3304d32364e0267abb00cf8f6acffef147655673674c2c8b", kill_on_drop: false }` [INFO] [stderr] Checking kik_sync_service v0.7.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/kik_channel.rs:272:21 [INFO] [stdout] | [INFO] [stdout] 272 | std::mem::drop(&lock); [INFO] [stdout] | ^^^^^^^^^^^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&MutexGuard<'_, std::sync::mpsc::Receiver>` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 272 - std::mem::drop(&lock); [INFO] [stdout] 272 + let _ = &lock; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/kik_channel.rs:286:9 [INFO] [stdout] | [INFO] [stdout] 286 | std::mem::drop(&self.rx_inserter); [INFO] [stdout] | ^^^^^^^^^^^^^^^-----------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&Arc>>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 286 - std::mem::drop(&self.rx_inserter); [INFO] [stdout] 286 + let _ = &self.rx_inserter; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/kik_channel.rs:287:9 [INFO] [stdout] | [INFO] [stdout] 287 | std::mem::drop(&self.feeder); [INFO] [stdout] | ^^^^^^^^^^^^^^^------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&FeederRecycler` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 287 - std::mem::drop(&self.feeder); [INFO] [stdout] 287 + let _ = &self.feeder; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/kik_channel.rs:288:9 [INFO] [stdout] | [INFO] [stdout] 288 | std::mem::drop(&self.tx_deliverer); [INFO] [stdout] | ^^^^^^^^^^^^^^^------------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&SyncSender` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 288 - std::mem::drop(&self.tx_deliverer); [INFO] [stdout] 288 + let _ = &self.tx_deliverer; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/kik_channel.rs:289:9 [INFO] [stdout] | [INFO] [stdout] 289 | std::mem::drop(&self.thread_vec); [INFO] [stdout] | ^^^^^^^^^^^^^^^----------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&Vec>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 289 - std::mem::drop(&self.thread_vec); [INFO] [stdout] 289 + let _ = &self.thread_vec; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/kik_worker.rs:95:45 [INFO] [stdout] | [INFO] [stdout] 95 | ... std::mem::drop(self); [INFO] [stdout] | ^^^^^^^^^^^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&Worker` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 95 - std::mem::drop(self); [INFO] [stdout] 95 + let _ = self; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/kik_worker.rs:108:21 [INFO] [stdout] | [INFO] [stdout] 108 | std::mem::drop(self); [INFO] [stdout] | ^^^^^^^^^^^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&Worker` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 108 - std::mem::drop(self); [INFO] [stdout] 108 + let _ = self; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/kik_worker.rs:155:9 [INFO] [stdout] | [INFO] [stdout] 155 | std::mem::drop(&self.tx_deliverer); [INFO] [stdout] | ^^^^^^^^^^^^^^^------------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&SyncSender` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 155 - std::mem::drop(&self.tx_deliverer); [INFO] [stdout] 155 + let _ = &self.tx_deliverer; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/kik_worker.rs:156:9 [INFO] [stdout] | [INFO] [stdout] 156 | std::mem::drop(&self.rx_inserter); [INFO] [stdout] | ^^^^^^^^^^^^^^^-----------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&std::sync::Weak>>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 156 - std::mem::drop(&self.rx_inserter); [INFO] [stdout] 156 + let _ = &self.rx_inserter; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kik_feeder.rs:70:24 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn new(id: usize, package_number: usize, tx_inserter: SyncSender, rx_deliverer: Receiver)->Self{ [INFO] [stdout] | -------------------------- ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | input_vec: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kik_feeder.rs:168:15 [INFO] [stdout] | [INFO] [stdout] 167 | let new_data: T; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | match self.input_vec.pop(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/kik_feeder.rs:244:9 [INFO] [stdout] | [INFO] [stdout] 244 | std::mem::drop(&self.input_vec); [INFO] [stdout] | ^^^^^^^^^^^^^^^---------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&Vec` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 244 - std::mem::drop(&self.input_vec); [INFO] [stdout] 244 + let _ = &self.input_vec; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/kik_feeder.rs:245:9 [INFO] [stdout] | [INFO] [stdout] 245 | std::mem::drop(&self.rx_deliverer); [INFO] [stdout] | ^^^^^^^^^^^^^^^------------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&std::sync::mpsc::Receiver` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 245 - std::mem::drop(&self.rx_deliverer); [INFO] [stdout] 245 + let _ = &self.rx_deliverer; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/kik_feeder.rs:246:9 [INFO] [stdout] | [INFO] [stdout] 246 | std::mem::drop(&self.tx_inserter); [INFO] [stdout] | ^^^^^^^^^^^^^^^-----------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&SyncSender` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 246 - std::mem::drop(&self.tx_inserter); [INFO] [stdout] 246 + let _ = &self.tx_inserter; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kik_sync_service` (lib test) due to 3 previous errors; 12 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/kik_channel.rs:272:21 [INFO] [stdout] | [INFO] [stdout] 272 | std::mem::drop(&lock); [INFO] [stdout] | ^^^^^^^^^^^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&MutexGuard<'_, std::sync::mpsc::Receiver>` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 272 - std::mem::drop(&lock); [INFO] [stdout] 272 + let _ = &lock; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/kik_channel.rs:286:9 [INFO] [stdout] | [INFO] [stdout] 286 | std::mem::drop(&self.rx_inserter); [INFO] [stdout] | ^^^^^^^^^^^^^^^-----------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&Arc>>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 286 - std::mem::drop(&self.rx_inserter); [INFO] [stdout] 286 + let _ = &self.rx_inserter; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/kik_channel.rs:287:9 [INFO] [stdout] | [INFO] [stdout] 287 | std::mem::drop(&self.feeder); [INFO] [stdout] | ^^^^^^^^^^^^^^^------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&FeederRecycler` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 287 - std::mem::drop(&self.feeder); [INFO] [stdout] 287 + let _ = &self.feeder; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/kik_channel.rs:288:9 [INFO] [stdout] | [INFO] [stdout] 288 | std::mem::drop(&self.tx_deliverer); [INFO] [stdout] | ^^^^^^^^^^^^^^^------------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&SyncSender` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 288 - std::mem::drop(&self.tx_deliverer); [INFO] [stdout] 288 + let _ = &self.tx_deliverer; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/kik_channel.rs:289:9 [INFO] [stdout] | [INFO] [stdout] 289 | std::mem::drop(&self.thread_vec); [INFO] [stdout] | ^^^^^^^^^^^^^^^----------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&Vec>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 289 - std::mem::drop(&self.thread_vec); [INFO] [stdout] 289 + let _ = &self.thread_vec; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/kik_worker.rs:95:45 [INFO] [stdout] | [INFO] [stdout] 95 | ... std::mem::drop(self); [INFO] [stdout] | ^^^^^^^^^^^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&Worker` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 95 - std::mem::drop(self); [INFO] [stdout] 95 + let _ = self; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/kik_worker.rs:108:21 [INFO] [stdout] | [INFO] [stdout] 108 | std::mem::drop(self); [INFO] [stdout] | ^^^^^^^^^^^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&Worker` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 108 - std::mem::drop(self); [INFO] [stdout] 108 + let _ = self; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/kik_worker.rs:155:9 [INFO] [stdout] | [INFO] [stdout] 155 | std::mem::drop(&self.tx_deliverer); [INFO] [stdout] | ^^^^^^^^^^^^^^^------------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&SyncSender` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 155 - std::mem::drop(&self.tx_deliverer); [INFO] [stdout] 155 + let _ = &self.tx_deliverer; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/kik_worker.rs:156:9 [INFO] [stdout] | [INFO] [stdout] 156 | std::mem::drop(&self.rx_inserter); [INFO] [stdout] | ^^^^^^^^^^^^^^^-----------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&std::sync::Weak>>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 156 - std::mem::drop(&self.rx_inserter); [INFO] [stdout] 156 + let _ = &self.rx_inserter; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kik_feeder.rs:70:24 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn new(id: usize, package_number: usize, tx_inserter: SyncSender, rx_deliverer: Receiver)->Self{ [INFO] [stdout] | -------------------------- ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | input_vec: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kik_feeder.rs:168:15 [INFO] [stdout] | [INFO] [stdout] 167 | let new_data: T; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | match self.input_vec.pop(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/kik_feeder.rs:244:9 [INFO] [stdout] | [INFO] [stdout] 244 | std::mem::drop(&self.input_vec); [INFO] [stdout] | ^^^^^^^^^^^^^^^---------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&Vec` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 244 - std::mem::drop(&self.input_vec); [INFO] [stdout] 244 + let _ = &self.input_vec; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/kik_feeder.rs:245:9 [INFO] [stdout] | [INFO] [stdout] 245 | std::mem::drop(&self.rx_deliverer); [INFO] [stdout] | ^^^^^^^^^^^^^^^------------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&std::sync::mpsc::Receiver` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 245 - std::mem::drop(&self.rx_deliverer); [INFO] [stdout] 245 + let _ = &self.rx_deliverer; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/kik_feeder.rs:246:9 [INFO] [stdout] | [INFO] [stdout] 246 | std::mem::drop(&self.tx_inserter); [INFO] [stdout] | ^^^^^^^^^^^^^^^-----------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&SyncSender` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 246 - std::mem::drop(&self.tx_inserter); [INFO] [stdout] 246 + let _ = &self.tx_inserter; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kik_sync_service` (lib) due to 3 previous errors; 12 warnings emitted [INFO] running `Command { std: "docker" "inspect" "88ea9d77b28c00fb3304d32364e0267abb00cf8f6acffef147655673674c2c8b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "88ea9d77b28c00fb3304d32364e0267abb00cf8f6acffef147655673674c2c8b", kill_on_drop: false }` [INFO] [stdout] 88ea9d77b28c00fb3304d32364e0267abb00cf8f6acffef147655673674c2c8b