[INFO] fetching crate kiibohd-hid-io 0.1.6... [INFO] checking kiibohd-hid-io-0.1.6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate kiibohd-hid-io 0.1.6 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate kiibohd-hid-io 0.1.6 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate kiibohd-hid-io 0.1.6 [INFO] finished tweaking crates.io crate kiibohd-hid-io 0.1.6 [INFO] tweaked toml for crates.io crate kiibohd-hid-io 0.1.6 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 40 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding enum-primitive-derive v0.2.2 (latest: v0.3.0) [INFO] [stderr] Adding hash32 v0.2.1 (latest: v0.3.1) [INFO] [stderr] Adding heapless v0.7.17 (latest: v0.8.0) [INFO] [stderr] Adding num_enum v0.5.11 (latest: v0.7.3) [INFO] [stderr] Adding num_enum_derive v0.5.11 (latest: v0.7.3) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 16a5f0d25dc20c4a53b659397b470a22b2eb1bd77b9033178b5b6ddef029a4cb [INFO] running `Command { std: "docker" "start" "-a" "16a5f0d25dc20c4a53b659397b470a22b2eb1bd77b9033178b5b6ddef029a4cb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "16a5f0d25dc20c4a53b659397b470a22b2eb1bd77b9033178b5b6ddef029a4cb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "16a5f0d25dc20c4a53b659397b470a22b2eb1bd77b9033178b5b6ddef029a4cb", kill_on_drop: false }` [INFO] [stdout] 16a5f0d25dc20c4a53b659397b470a22b2eb1bd77b9033178b5b6ddef029a4cb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9bc901e8dcbd6a1e78054fe21801a6e69909664f65b698d8cff5ca5732165dcd [INFO] running `Command { std: "docker" "start" "-a" "9bc901e8dcbd6a1e78054fe21801a6e69909664f65b698d8cff5ca5732165dcd", kill_on_drop: false }` [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling proc-macro-hack v0.5.20+deprecated [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Compiling kll-macros v0.1.2 [INFO] [stderr] Checking kll-hid v0.1.2 [INFO] [stderr] Checking hash32 v0.2.1 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Compiling heapless v0.7.17 [INFO] [stderr] Compiling pkg-version-impl v0.1.1 [INFO] [stderr] Checking pkg-version v1.0.0 [INFO] [stderr] Compiling num_enum_derive v0.5.11 [INFO] [stderr] Compiling enum-primitive-derive v0.2.2 [INFO] [stderr] Checking kll-core v0.1.8 [INFO] [stderr] Checking num_enum v0.5.11 [INFO] [stderr] Checking hid-io-protocol v0.1.6 [INFO] [stderr] Checking kiibohd-hid-io v0.1.6 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:107:12 [INFO] [stdout] | [INFO] [stdout] 83 | interface: KINTF, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | let ids = match Vec::from_slice(ids) { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | Ok(ids) => ids, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | let tx_bytebuf = buffer::Buffer::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | let rx_bytebuf = buffer::Buffer::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | let rx_packetbuf = HidIoPacketBuffer::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | let serial_buf = Vec::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | let term_out_buffer = String::new(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | let hostinfo = HidIoHostInfo { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | Ok(CommandInterface { [INFO] [stdout] | ____________^ [INFO] [stdout] 108 | | ids, [INFO] [stdout] 109 | | rx_bytebuf, [INFO] [stdout] 110 | | rx_packetbuf, [INFO] [stdout] ... | [INFO] [stdout] 115 | | interface, [INFO] [stdout] 116 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:373:12 [INFO] [stdout] | [INFO] [stdout] 299 | let mut string = String::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 373 | Ok(Ack { [INFO] [stdout] | ____________^ [INFO] [stdout] 374 | | property, [INFO] [stdout] 375 | | os, [INFO] [stdout] 376 | | number, [INFO] [stdout] 377 | | string, [INFO] [stdout] 378 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:417:12 [INFO] [stdout] | [INFO] [stdout] 416 | fn h0002_test_cmd(&mut self, data: h0002::Cmd) -> Result, h0002::Nak> { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 417 | Ok(h0002::Ack { data: data.data }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kiibohd-hid-io` (lib test) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:107:12 [INFO] [stdout] | [INFO] [stdout] 83 | interface: KINTF, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | let ids = match Vec::from_slice(ids) { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | Ok(ids) => ids, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | let tx_bytebuf = buffer::Buffer::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | let rx_bytebuf = buffer::Buffer::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | let rx_packetbuf = HidIoPacketBuffer::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | let serial_buf = Vec::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | let term_out_buffer = String::new(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | let hostinfo = HidIoHostInfo { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | Ok(CommandInterface { [INFO] [stdout] | ____________^ [INFO] [stdout] 108 | | ids, [INFO] [stdout] 109 | | rx_bytebuf, [INFO] [stdout] 110 | | rx_packetbuf, [INFO] [stdout] ... | [INFO] [stdout] 115 | | interface, [INFO] [stdout] 116 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:373:12 [INFO] [stdout] | [INFO] [stdout] 299 | let mut string = String::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 373 | Ok(Ack { [INFO] [stdout] | ____________^ [INFO] [stdout] 374 | | property, [INFO] [stdout] 375 | | os, [INFO] [stdout] 376 | | number, [INFO] [stdout] 377 | | string, [INFO] [stdout] 378 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:417:12 [INFO] [stdout] | [INFO] [stdout] 416 | fn h0002_test_cmd(&mut self, data: h0002::Cmd) -> Result, h0002::Nak> { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 417 | Ok(h0002::Ack { data: data.data }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kiibohd-hid-io` (lib) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "9bc901e8dcbd6a1e78054fe21801a6e69909664f65b698d8cff5ca5732165dcd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9bc901e8dcbd6a1e78054fe21801a6e69909664f65b698d8cff5ca5732165dcd", kill_on_drop: false }` [INFO] [stdout] 9bc901e8dcbd6a1e78054fe21801a6e69909664f65b698d8cff5ca5732165dcd