[INFO] fetching crate kick 0.1.2... [INFO] checking kick-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate kick 0.1.2 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate kick 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate kick 0.1.2 [INFO] finished tweaking crates.io crate kick 0.1.2 [INFO] tweaked toml for crates.io crate kick 0.1.2 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 12c6477e5f2e59742e945c786bd387d091c9a1e65261855ed4072eac070e76d7 [INFO] running `Command { std: "docker" "start" "-a" "12c6477e5f2e59742e945c786bd387d091c9a1e65261855ed4072eac070e76d7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "12c6477e5f2e59742e945c786bd387d091c9a1e65261855ed4072eac070e76d7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "12c6477e5f2e59742e945c786bd387d091c9a1e65261855ed4072eac070e76d7", kill_on_drop: false }` [INFO] [stdout] 12c6477e5f2e59742e945c786bd387d091c9a1e65261855ed4072eac070e76d7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 497b8f682dad0afd99c06bd0d5987fc45a5c900a7e189afd5960d96e57357080 [INFO] running `Command { std: "docker" "start" "-a" "497b8f682dad0afd99c06bd0d5987fc45a5c900a7e189afd5960d96e57357080", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking kick v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/tests/mod.rs:108:19 [INFO] [stdout] | [INFO] [stdout] 108 | fn test_cell_1() {; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/stream/slot.rs:54:44 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn push(&mut self, t: T) -> Option<(Box>)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 54 - pub fn push(&mut self, t: T) -> Option<(Box>)> { [INFO] [stdout] 54 + pub fn push(&mut self, t: T) -> Option>> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/stream/slot.rs:54:44 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn push(&mut self, t: T) -> Option<(Box>)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 54 - pub fn push(&mut self, t: T) -> Option<(Box>)> { [INFO] [stdout] 54 + pub fn push(&mut self, t: T) -> Option>> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/moment.rs:20:55 [INFO] [stdout] | [INFO] [stdout] 20 | pub type MomentBox<'a, T, Tr: Transaction<'a> + 'a> = StateBox + 'a; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 20 | pub type MomentBox<'a, T, Tr: Transaction<'a> + 'a> = dyn StateBox + 'a; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/stream/slot.rs:13:64 [INFO] [stdout] | [INFO] [stdout] 13 | pub type SlotFn<'a, 'b: 'a, T: 'a, Tr: Transaction<'b> + 'b> = Fn(T) -> Option>> + 'a; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 13 | pub type SlotFn<'a, 'b: 'a, T: 'a, Tr: Transaction<'b> + 'b> = dyn Fn(T) -> Option>> + 'a; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/stream/slot.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | FnMut(T) -> Option>> + 'a; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 15 | dyn FnMut(T) -> Option>> + 'a; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/moment.rs:20:55 [INFO] [stdout] | [INFO] [stdout] 20 | pub type MomentBox<'a, T, Tr: Transaction<'a> + 'a> = StateBox + 'a; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 20 | pub type MomentBox<'a, T, Tr: Transaction<'a> + 'a> = dyn StateBox + 'a; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/stream/slot.rs:13:64 [INFO] [stdout] | [INFO] [stdout] 13 | pub type SlotFn<'a, 'b: 'a, T: 'a, Tr: Transaction<'b> + 'b> = Fn(T) -> Option>> + 'a; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 13 | pub type SlotFn<'a, 'b: 'a, T: 'a, Tr: Transaction<'b> + 'b> = dyn Fn(T) -> Option>> + 'a; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/stream/slot.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | FnMut(T) -> Option>> + 'a; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 15 | dyn FnMut(T) -> Option>> + 'a; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/moment.rs:17:56 [INFO] [stdout] | [INFO] [stdout] 17 | pub type MomentOnce<'a, T, Tr: Transaction<'a> + 'a> = StateOnce + 'a; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 17 | pub type MomentOnce<'a, T, Tr: Transaction<'a> + 'a> = dyn StateOnce + 'a; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/moment.rs:23:55 [INFO] [stdout] | [INFO] [stdout] 23 | pub type MomentMut<'a, T, Tr: Transaction<'a> + 'a> = StateMut + 'a; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 23 | pub type MomentMut<'a, T, Tr: Transaction<'a> + 'a> = dyn StateMut + 'a; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/moment.rs:26:52 [INFO] [stdout] | [INFO] [stdout] 26 | pub type Moment<'a, T, Tr: Transaction<'a> + 'a> = State + 'a; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 26 | pub type Moment<'a, T, Tr: Transaction<'a> + 'a> = dyn State + 'a; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/moment.rs:17:56 [INFO] [stdout] | [INFO] [stdout] 17 | pub type MomentOnce<'a, T, Tr: Transaction<'a> + 'a> = StateOnce + 'a; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 17 | pub type MomentOnce<'a, T, Tr: Transaction<'a> + 'a> = dyn StateOnce + 'a; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/moment.rs:23:55 [INFO] [stdout] | [INFO] [stdout] 23 | pub type MomentMut<'a, T, Tr: Transaction<'a> + 'a> = StateMut + 'a; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 23 | pub type MomentMut<'a, T, Tr: Transaction<'a> + 'a> = dyn StateMut + 'a; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/moment.rs:26:52 [INFO] [stdout] | [INFO] [stdout] 26 | pub type Moment<'a, T, Tr: Transaction<'a> + 'a> = State + 'a; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 26 | pub type Moment<'a, T, Tr: Transaction<'a> + 'a> = dyn State + 'a; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/state/refs.rs:18:17 [INFO] [stdout] | [INFO] [stdout] 18 | fn run_once(mut self, state: &mut S) -> Self::Output { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `s` [INFO] [stdout] --> src/tests/mod.rs:56:18 [INFO] [stdout] | [INFO] [stdout] 56 | st(move |s: &mut _| x * 2) => x; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_s` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `s` [INFO] [stdout] --> src/tests/mod.rs:57:18 [INFO] [stdout] | [INFO] [stdout] 57 | st(move |s: &mut _| x + 6).map(|x| x * 3).map(|x| st(move |s: &mut _| x / 2)).join() [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_s` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `s` [INFO] [stdout] --> src/tests/mod.rs:57:68 [INFO] [stdout] | [INFO] [stdout] 57 | st(move |s: &mut _| x + 6).map(|x| x * 3).map(|x| st(move |s: &mut _| x / 2)).join() [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_s` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `s` [INFO] [stdout] --> src/tests/mod.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 64 | st(|s: &mut _| 1) [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_s` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `s` [INFO] [stdout] --> src/tests/mod.rs:184:33 [INFO] [stdout] | [INFO] [stdout] 184 | let m = m.bind(|x| st(move |s: &mut _| x + 6)); // (10) [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_s` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `s` [INFO] [stdout] --> src/tests/mod.rs:186:32 [INFO] [stdout] | [INFO] [stdout] 186 | let m = m.map(|x| st(move |s: &mut _| x / 2)); // ((15)) [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_s` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/state/refs.rs:18:17 [INFO] [stdout] | [INFO] [stdout] 18 | fn run_once(mut self, state: &mut S) -> Self::Output { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/stream/slot.rs:61:23 [INFO] [stdout] | [INFO] [stdout] 61 | Slot::Mut(mut f) => f(t).map(move |r| (Some(Slot::Mut(f)), r)), [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state/mod.rs:263:9 [INFO] [stdout] | [INFO] [stdout] 260 | fn run_once(self, state: &mut S) -> Self::Output { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 261 | let StateBind(m, f, _) = self; [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 262 | let t = m.run_once(state); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 263 | f(t).run_once(state) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state/mod.rs:273:9 [INFO] [stdout] | [INFO] [stdout] 272 | let t = self.0.run_mut(state); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 273 | self.1(t).run_once(state) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state/mod.rs:283:9 [INFO] [stdout] | [INFO] [stdout] 282 | let t = self.0.run(state); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 283 | self.1(t).run_once(state) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state/mod.rs:299:9 [INFO] [stdout] | [INFO] [stdout] 296 | fn run_once(self, state: &mut S) -> Self::Output { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 297 | let StateChain(m, f, _) = self; [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 298 | m.run_once(state); [INFO] [stdout] 299 | f().run_once(state) [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bounds on generic parameters in type aliases are not enforced [INFO] [stdout] --> src/moment.rs:17:32 [INFO] [stdout] | [INFO] [stdout] 17 | pub type MomentOnce<'a, T, Tr: Transaction<'a> + 'a> = StateOnce + 'a; [INFO] [stdout] | --^^^^^^^^^^^^^^^---^^ [INFO] [stdout] | | | [INFO] [stdout] | | will not be checked at usage sites of the type alias [INFO] [stdout] | help: remove this bound [INFO] [stdout] | [INFO] [stdout] = note: this is a known limitation of the type checker that may be lifted in a future edition. [INFO] [stdout] see issue #112792 for more information [INFO] [stdout] = help: add `#![feature(lazy_type_alias)]` to the crate attributes to enable the desired semantics [INFO] [stdout] = note: `#[warn(type_alias_bounds)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bounds on generic parameters in type aliases are not enforced [INFO] [stdout] --> src/moment.rs:20:31 [INFO] [stdout] | [INFO] [stdout] 20 | pub type MomentBox<'a, T, Tr: Transaction<'a> + 'a> = StateBox + 'a; [INFO] [stdout] | --^^^^^^^^^^^^^^^---^^ [INFO] [stdout] | | | [INFO] [stdout] | | will not be checked at usage sites of the type alias [INFO] [stdout] | help: remove this bound [INFO] [stdout] | [INFO] [stdout] = note: this is a known limitation of the type checker that may be lifted in a future edition. [INFO] [stdout] see issue #112792 for more information [INFO] [stdout] = help: add `#![feature(lazy_type_alias)]` to the crate attributes to enable the desired semantics [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bounds on generic parameters in type aliases are not enforced [INFO] [stdout] --> src/moment.rs:23:31 [INFO] [stdout] | [INFO] [stdout] 23 | pub type MomentMut<'a, T, Tr: Transaction<'a> + 'a> = StateMut + 'a; [INFO] [stdout] | --^^^^^^^^^^^^^^^---^^ [INFO] [stdout] | | | [INFO] [stdout] | | will not be checked at usage sites of the type alias [INFO] [stdout] | help: remove this bound [INFO] [stdout] | [INFO] [stdout] = note: this is a known limitation of the type checker that may be lifted in a future edition. [INFO] [stdout] see issue #112792 for more information [INFO] [stdout] = help: add `#![feature(lazy_type_alias)]` to the crate attributes to enable the desired semantics [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bounds on generic parameters in type aliases are not enforced [INFO] [stdout] --> src/moment.rs:26:28 [INFO] [stdout] | [INFO] [stdout] 26 | pub type Moment<'a, T, Tr: Transaction<'a> + 'a> = State + 'a; [INFO] [stdout] | --^^^^^^^^^^^^^^^---^^ [INFO] [stdout] | | | [INFO] [stdout] | | will not be checked at usage sites of the type alias [INFO] [stdout] | help: remove this bound [INFO] [stdout] | [INFO] [stdout] = note: this is a known limitation of the type checker that may be lifted in a future edition. [INFO] [stdout] see issue #112792 for more information [INFO] [stdout] = help: add `#![feature(lazy_type_alias)]` to the crate attributes to enable the desired semantics [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/moment.rs:47:22 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn with_context(context: C) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | BasicTransaction { [INFO] [stdout] 47 | updates: VecDeque::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/moment.rs:98:14 [INFO] [stdout] | [INFO] [stdout] 95 | pub fn delay<'a, M: 'a, Tr: Transaction<'a> + 'a>(m: M) -> Box> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | Box::new(st(|tr: &mut Tr| { [INFO] [stdout] | ______________^ [INFO] [stdout] 99 | | tr.delay(m); [INFO] [stdout] 100 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/moment.rs:105:5 [INFO] [stdout] | [INFO] [stdout] 104 | pub fn sync<'a, T, M>(m: M) -> T where M: StateOnce, Output = T> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | BasicTransaction::new().sync(m) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/moment.rs:110:6 [INFO] [stdout] | [INFO] [stdout] 108 | pub fn sync_with_context<'a, T, M, C>(m: M, c: C) -> (T, C) where M: StateOnce, Output = T> { [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | let mut tr = BasicTransaction::with_context(c); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | (tr.sync(m), tr.destroy()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/moment.rs:110:18 [INFO] [stdout] | [INFO] [stdout] 108 | pub fn sync_with_context<'a, T, M, C>(m: M, c: C) -> (T, C) where M: StateOnce, Output = T> { [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | let mut tr = BasicTransaction::with_context(c); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | (tr.sync(m), tr.destroy()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cell/mod.rs:29:14 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn new(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | Cell(Rc::new(RefCell::new(value)), PhantomData) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cell/mod.rs:32:20 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn modify(&self, f: F) -> CellModify<'a, T, F> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | CellModify(self.clone(), f) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cell/mod.rs:40:17 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn set(&self, value: T) -> CellSet<'a, T> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | CellSet(self.clone(), value) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/stream/slot.rs:61:23 [INFO] [stdout] | [INFO] [stdout] 61 | Slot::Mut(mut f) => f(t).map(move |r| (Some(Slot::Mut(f)), r)), [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::mem::replace` that must be used [INFO] [stdout] --> src/cell/mod.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | ::std::mem::replace(&mut *self.0.borrow_mut(), value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 51 | let _ = ::std::mem::replace(&mut *self.0.borrow_mut(), value); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_macro_1` is never used [INFO] [stdout] --> src/tests/mod.rs:24:4 [INFO] [stdout] | [INFO] [stdout] 24 | fn test_macro_1() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state/mod.rs:263:9 [INFO] [stdout] | [INFO] [stdout] 260 | fn run_once(self, state: &mut S) -> Self::Output { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 261 | let StateBind(m, f, _) = self; [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 262 | let t = m.run_once(state); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 263 | f(t).run_once(state) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state/mod.rs:273:9 [INFO] [stdout] | [INFO] [stdout] 272 | let t = self.0.run_mut(state); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 273 | self.1(t).run_once(state) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state/mod.rs:283:9 [INFO] [stdout] | [INFO] [stdout] 282 | let t = self.0.run(state); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 283 | self.1(t).run_once(state) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state/mod.rs:299:9 [INFO] [stdout] | [INFO] [stdout] 296 | fn run_once(self, state: &mut S) -> Self::Output { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 297 | let StateChain(m, f, _) = self; [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 298 | m.run_once(state); [INFO] [stdout] 299 | f().run_once(state) [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bounds on generic parameters in type aliases are not enforced [INFO] [stdout] --> src/moment.rs:17:32 [INFO] [stdout] | [INFO] [stdout] 17 | pub type MomentOnce<'a, T, Tr: Transaction<'a> + 'a> = StateOnce + 'a; [INFO] [stdout] | --^^^^^^^^^^^^^^^---^^ [INFO] [stdout] | | | [INFO] [stdout] | | will not be checked at usage sites of the type alias [INFO] [stdout] | help: remove this bound [INFO] [stdout] | [INFO] [stdout] = note: this is a known limitation of the type checker that may be lifted in a future edition. [INFO] [stdout] see issue #112792 for more information [INFO] [stdout] = help: add `#![feature(lazy_type_alias)]` to the crate attributes to enable the desired semantics [INFO] [stdout] = note: `#[warn(type_alias_bounds)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bounds on generic parameters in type aliases are not enforced [INFO] [stdout] --> src/moment.rs:20:31 [INFO] [stdout] | [INFO] [stdout] 20 | pub type MomentBox<'a, T, Tr: Transaction<'a> + 'a> = StateBox + 'a; [INFO] [stdout] | --^^^^^^^^^^^^^^^---^^ [INFO] [stdout] | | | [INFO] [stdout] | | will not be checked at usage sites of the type alias [INFO] [stdout] | help: remove this bound [INFO] [stdout] | [INFO] [stdout] = note: this is a known limitation of the type checker that may be lifted in a future edition. [INFO] [stdout] see issue #112792 for more information [INFO] [stdout] = help: add `#![feature(lazy_type_alias)]` to the crate attributes to enable the desired semantics [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cell/mod.rs:54:34 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn swap_now +'a>(&self, value: T, _: &mut Tr) -> T { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | ::std::mem::replace(&mut *self.0.borrow_mut(), value) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signal/variable.rs:56:20 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn new(start: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let (ev, push) = Event::new(); [INFO] [stdout] | -- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | Variable { [INFO] [stdout] 56 | value: Rc::new(Cell::new(start)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signal/variable.rs:104:18 [INFO] [stdout] | [INFO] [stdout] 99 | fn hold(start: T, signal: &S) -> Box> [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | let var = Self::new(start); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | let var2 = var.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | Box::new(signal.listen(Box::new(move |val| Some(var.set(val)))).map(move |_| var2)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bounds on generic parameters in type aliases are not enforced [INFO] [stdout] --> src/moment.rs:23:31 [INFO] [stdout] | [INFO] [stdout] 23 | pub type MomentMut<'a, T, Tr: Transaction<'a> + 'a> = StateMut + 'a; [INFO] [stdout] | --^^^^^^^^^^^^^^^---^^ [INFO] [stdout] | | | [INFO] [stdout] | | will not be checked at usage sites of the type alias [INFO] [stdout] | help: remove this bound [INFO] [stdout] | [INFO] [stdout] = note: this is a known limitation of the type checker that may be lifted in a future edition. [INFO] [stdout] see issue #112792 for more information [INFO] [stdout] = help: add `#![feature(lazy_type_alias)]` to the crate attributes to enable the desired semantics [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signal/variable.rs:104:57 [INFO] [stdout] | [INFO] [stdout] 102 | let var = Self::new(start); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | let var2 = var.clone(); [INFO] [stdout] 104 | Box::new(signal.listen(Box::new(move |val| Some(var.set(val)))).map(move |_| var2)) [INFO] [stdout] | --- ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bounds on generic parameters in type aliases are not enforced [INFO] [stdout] --> src/moment.rs:26:28 [INFO] [stdout] | [INFO] [stdout] 26 | pub type Moment<'a, T, Tr: Transaction<'a> + 'a> = State + 'a; [INFO] [stdout] | --^^^^^^^^^^^^^^^---^^ [INFO] [stdout] | | | [INFO] [stdout] | | will not be checked at usage sites of the type alias [INFO] [stdout] | help: remove this bound [INFO] [stdout] | [INFO] [stdout] = note: this is a known limitation of the type checker that may be lifted in a future edition. [INFO] [stdout] see issue #112792 for more information [INFO] [stdout] = help: add `#![feature(lazy_type_alias)]` to the crate attributes to enable the desired semantics [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/mod.rs:22:28 [INFO] [stdout] | [INFO] [stdout] 21 | fn map(self, f: F) -> SignalMapped where Self: Sized, F: Fn(Self::Output) -> Y { [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | SignalMapped(self, Rc::new(f), PhantomData) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/moment.rs:47:22 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn with_context(context: C) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | BasicTransaction { [INFO] [stdout] 47 | updates: VecDeque::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/mod.rs:39:23 [INFO] [stdout] | [INFO] [stdout] 36 | fn listen(&self, s: S) -> M::Listen where S: Into> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let mut s = s.into(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | let f = self.1.clone(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | self.0.listen(Box::new(move |value: T| s.push((*f)(value)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/moment.rs:98:14 [INFO] [stdout] | [INFO] [stdout] 95 | pub fn delay<'a, M: 'a, Tr: Transaction<'a> + 'a>(m: M) -> Box> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | Box::new(st(|tr: &mut Tr| { [INFO] [stdout] | ______________^ [INFO] [stdout] 99 | | tr.delay(m); [INFO] [stdout] 100 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/moment.rs:105:5 [INFO] [stdout] | [INFO] [stdout] 104 | pub fn sync<'a, T, M>(m: M) -> T where M: StateOnce, Output = T> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | BasicTransaction::new().sync(m) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/mod.rs:39:55 [INFO] [stdout] | [INFO] [stdout] 37 | let mut s = s.into(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | let f = self.1.clone(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | self.0.listen(Box::new(move |value: T| s.push((*f)(value)))) [INFO] [stdout] | -------- ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/moment.rs:110:6 [INFO] [stdout] | [INFO] [stdout] 108 | pub fn sync_with_context<'a, T, M, C>(m: M, c: C) -> (T, C) where M: StateOnce, Output = T> { [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | let mut tr = BasicTransaction::with_context(c); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | (tr.sync(m), tr.destroy()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bounds on generic parameters in type aliases are not enforced [INFO] [stdout] --> src/stream/slot.rs:13:25 [INFO] [stdout] | [INFO] [stdout] 13 | pub type SlotFn<'a, 'b: 'a, T: 'a, Tr: Transaction<'b> + 'b> = Fn(T) -> Option>> + 'a; [INFO] [stdout] | ^^ ^^ ^^^^^^^^^^^^^^^ ^^ will not be checked at usage sites of the type alias [INFO] [stdout] | [INFO] [stdout] = note: this is a known limitation of the type checker that may be lifted in a future edition. [INFO] [stdout] see issue #112792 for more information [INFO] [stdout] = help: add `#![feature(lazy_type_alias)]` to the crate attributes to enable the desired semantics [INFO] [stdout] help: remove these bounds [INFO] [stdout] | [INFO] [stdout] 13 - pub type SlotFn<'a, 'b: 'a, T: 'a, Tr: Transaction<'b> + 'b> = Fn(T) -> Option>> + 'a; [INFO] [stdout] 13 + pub type SlotFn<'a, 'b, T, Tr> = Fn(T) -> Option>> + 'a; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/moment.rs:110:18 [INFO] [stdout] | [INFO] [stdout] 108 | pub fn sync_with_context<'a, T, M, C>(m: M, c: C) -> (T, C) where M: StateOnce, Output = T> { [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | let mut tr = BasicTransaction::with_context(c); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | (tr.sync(m), tr.destroy()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bounds on generic parameters in type aliases are not enforced [INFO] [stdout] --> src/stream/slot.rs:14:28 [INFO] [stdout] | [INFO] [stdout] 14 | pub type SlotFnMut<'a, 'b: 'a, T: 'a, Tr: Transaction<'b> + 'b> = [INFO] [stdout] | ^^ ^^ ^^^^^^^^^^^^^^^ ^^ will not be checked at usage sites of the type alias [INFO] [stdout] | [INFO] [stdout] = note: this is a known limitation of the type checker that may be lifted in a future edition. [INFO] [stdout] see issue #112792 for more information [INFO] [stdout] = help: add `#![feature(lazy_type_alias)]` to the crate attributes to enable the desired semantics [INFO] [stdout] help: remove these bounds [INFO] [stdout] | [INFO] [stdout] 14 - pub type SlotFnMut<'a, 'b: 'a, T: 'a, Tr: Transaction<'b> + 'b> = [INFO] [stdout] 14 + pub type SlotFnMut<'a, 'b, T, Tr> = [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cell/mod.rs:29:14 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn new(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | Cell(Rc::new(RefCell::new(value)), PhantomData) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/slot.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn push(&mut self, t: T) -> Option<(Box>)> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | let slot = ::std::mem::replace(self, Slot::Nothing); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | / match slot { [INFO] [stdout] 57 | | Slot::Nothing => None, [INFO] [stdout] 58 | | Slot::Ref(f) => f(t).map(move |r| (Some(Slot::Ref(f)), r)), [INFO] [stdout] 59 | | Slot::SRef(f) => f(t).map(move |r| (Some(Slot::SRef(f)), r)), [INFO] [stdout] ... | [INFO] [stdout] 65 | | Slot::Once(f) => f(t).map(|r| (None, (r))), [INFO] [stdout] 66 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cell/mod.rs:32:20 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn modify(&self, f: F) -> CellModify<'a, T, F> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | CellModify(self.clone(), f) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/slot.rs:58:48 [INFO] [stdout] | [INFO] [stdout] 58 | Slot::Ref(f) => f(t).map(move |r| (Some(Slot::Ref(f)), r)), [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cell/mod.rs:40:17 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn set(&self, value: T) -> CellSet<'a, T> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | CellSet(self.clone(), value) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/slot.rs:59:49 [INFO] [stdout] | [INFO] [stdout] 59 | Slot::SRef(f) => f(t).map(move |r| (Some(Slot::SRef(f)), r)), [INFO] [stdout] | - - ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/slot.rs:60:75 [INFO] [stdout] | [INFO] [stdout] 60 | Slot::WRef(f) => f.upgrade().and_then(|f| f(t)).map(move |r| (Some(Slot::WRef(f)), r)), [INFO] [stdout] | - - ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/slot.rs:61:52 [INFO] [stdout] | [INFO] [stdout] 61 | Slot::Mut(mut f) => f(t).map(move |r| (Some(Slot::Mut(f)), r)), [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/slot.rs:62:54 [INFO] [stdout] | [INFO] [stdout] 62 | Slot::Boxed(mut f) => f(t).map(move |r| (Some(Slot::Boxed(f)), r)), [INFO] [stdout] | - - ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::mem::replace` that must be used [INFO] [stdout] --> src/stream/slot.rs:69:17 [INFO] [stdout] | [INFO] [stdout] 69 | ::std::mem::replace(self, slot); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 69 | let _ = ::std::mem::replace(self, slot); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/slot.rs:119:17 [INFO] [stdout] | [INFO] [stdout] 116 | pub fn box_slot<'a, 'b: 'a, T: 'a, F: 'a, Tr: Transaction<'b> + 'b>(f: F) -> Slot<'a, 'b, T, Tr> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | Slot::Boxed(Box::new(f)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/event.rs:51:69 [INFO] [stdout] | [INFO] [stdout] 51 | ... .filter_map(|slot| slot.push(value.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/event.rs:70:10 [INFO] [stdout] | [INFO] [stdout] 66 | let ev: Self = Event { listeners: Default::default() }; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | let l = ev.listeners.clone(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | / Rc::new(move |value: T| { [INFO] [stdout] 71 | | let l = l.clone(); [INFO] [stdout] 72 | | Some(Box::new(st({ [INFO] [stdout] 73 | | move |s: &mut Tr| push_process(l, value, s) [INFO] [stdout] 74 | | }))) [INFO] [stdout] 75 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/event.rs:72:18 [INFO] [stdout] | [INFO] [stdout] 67 | let l = ev.listeners.clone(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | Rc::new(move |value: T| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | let l = l.clone(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | Some(Box::new(st({ [INFO] [stdout] | __________________^ [INFO] [stdout] 73 | | move |s: &mut Tr| push_process(l, value, s) [INFO] [stdout] 74 | | }))) [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/event.rs:115:18 [INFO] [stdout] | [INFO] [stdout] 111 | fn listen(&self, f: F) -> Self::Listen [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | let slot = f.into(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | Box::new(self.listeners.modify(move |vd: &mut VecDeque<_>| vd.push_back(slot))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 30 previous errors; 17 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::mem::replace` that must be used [INFO] [stdout] --> src/cell/mod.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | ::std::mem::replace(&mut *self.0.borrow_mut(), value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 51 | let _ = ::std::mem::replace(&mut *self.0.borrow_mut(), value); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cell/mod.rs:54:34 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn swap_now +'a>(&self, value: T, _: &mut Tr) -> T { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | ::std::mem::replace(&mut *self.0.borrow_mut(), value) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signal/variable.rs:56:20 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn new(start: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let (ev, push) = Event::new(); [INFO] [stdout] | -- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | Variable { [INFO] [stdout] 56 | value: Rc::new(Cell::new(start)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signal/variable.rs:104:18 [INFO] [stdout] | [INFO] [stdout] 99 | fn hold(start: T, signal: &S) -> Box> [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | let var = Self::new(start); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | let var2 = var.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | Box::new(signal.listen(Box::new(move |val| Some(var.set(val)))).map(move |_| var2)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signal/variable.rs:104:57 [INFO] [stdout] | [INFO] [stdout] 102 | let var = Self::new(start); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | let var2 = var.clone(); [INFO] [stdout] 104 | Box::new(signal.listen(Box::new(move |val| Some(var.set(val)))).map(move |_| var2)) [INFO] [stdout] | --- ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/mod.rs:22:28 [INFO] [stdout] | [INFO] [stdout] 21 | fn map(self, f: F) -> SignalMapped where Self: Sized, F: Fn(Self::Output) -> Y { [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | SignalMapped(self, Rc::new(f), PhantomData) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/mod.rs:39:23 [INFO] [stdout] | [INFO] [stdout] 36 | fn listen(&self, s: S) -> M::Listen where S: Into> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let mut s = s.into(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | let f = self.1.clone(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | self.0.listen(Box::new(move |value: T| s.push((*f)(value)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/mod.rs:39:55 [INFO] [stdout] | [INFO] [stdout] 37 | let mut s = s.into(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | let f = self.1.clone(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | self.0.listen(Box::new(move |value: T| s.push((*f)(value)))) [INFO] [stdout] | -------- ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bounds on generic parameters in type aliases are not enforced [INFO] [stdout] --> src/stream/slot.rs:13:25 [INFO] [stdout] | [INFO] [stdout] 13 | pub type SlotFn<'a, 'b: 'a, T: 'a, Tr: Transaction<'b> + 'b> = Fn(T) -> Option>> + 'a; [INFO] [stdout] | ^^ ^^ ^^^^^^^^^^^^^^^ ^^ will not be checked at usage sites of the type alias [INFO] [stdout] | [INFO] [stdout] = note: this is a known limitation of the type checker that may be lifted in a future edition. [INFO] [stdout] see issue #112792 for more information [INFO] [stdout] = help: add `#![feature(lazy_type_alias)]` to the crate attributes to enable the desired semantics [INFO] [stdout] help: remove these bounds [INFO] [stdout] | [INFO] [stdout] 13 - pub type SlotFn<'a, 'b: 'a, T: 'a, Tr: Transaction<'b> + 'b> = Fn(T) -> Option>> + 'a; [INFO] [stdout] 13 + pub type SlotFn<'a, 'b, T, Tr> = Fn(T) -> Option>> + 'a; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bounds on generic parameters in type aliases are not enforced [INFO] [stdout] --> src/stream/slot.rs:14:28 [INFO] [stdout] | [INFO] [stdout] 14 | pub type SlotFnMut<'a, 'b: 'a, T: 'a, Tr: Transaction<'b> + 'b> = [INFO] [stdout] | ^^ ^^ ^^^^^^^^^^^^^^^ ^^ will not be checked at usage sites of the type alias [INFO] [stdout] | [INFO] [stdout] = note: this is a known limitation of the type checker that may be lifted in a future edition. [INFO] [stdout] see issue #112792 for more information [INFO] [stdout] = help: add `#![feature(lazy_type_alias)]` to the crate attributes to enable the desired semantics [INFO] [stdout] help: remove these bounds [INFO] [stdout] | [INFO] [stdout] 14 - pub type SlotFnMut<'a, 'b: 'a, T: 'a, Tr: Transaction<'b> + 'b> = [INFO] [stdout] 14 + pub type SlotFnMut<'a, 'b, T, Tr> = [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/slot.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn push(&mut self, t: T) -> Option<(Box>)> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | let slot = ::std::mem::replace(self, Slot::Nothing); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | / match slot { [INFO] [stdout] 57 | | Slot::Nothing => None, [INFO] [stdout] 58 | | Slot::Ref(f) => f(t).map(move |r| (Some(Slot::Ref(f)), r)), [INFO] [stdout] 59 | | Slot::SRef(f) => f(t).map(move |r| (Some(Slot::SRef(f)), r)), [INFO] [stdout] ... | [INFO] [stdout] 65 | | Slot::Once(f) => f(t).map(|r| (None, (r))), [INFO] [stdout] 66 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/slot.rs:58:48 [INFO] [stdout] | [INFO] [stdout] 58 | Slot::Ref(f) => f(t).map(move |r| (Some(Slot::Ref(f)), r)), [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/slot.rs:59:49 [INFO] [stdout] | [INFO] [stdout] 59 | Slot::SRef(f) => f(t).map(move |r| (Some(Slot::SRef(f)), r)), [INFO] [stdout] | - - ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/slot.rs:60:75 [INFO] [stdout] | [INFO] [stdout] 60 | Slot::WRef(f) => f.upgrade().and_then(|f| f(t)).map(move |r| (Some(Slot::WRef(f)), r)), [INFO] [stdout] | - - ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/slot.rs:61:52 [INFO] [stdout] | [INFO] [stdout] 61 | Slot::Mut(mut f) => f(t).map(move |r| (Some(Slot::Mut(f)), r)), [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/slot.rs:62:54 [INFO] [stdout] | [INFO] [stdout] 62 | Slot::Boxed(mut f) => f(t).map(move |r| (Some(Slot::Boxed(f)), r)), [INFO] [stdout] | - - ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::mem::replace` that must be used [INFO] [stdout] --> src/stream/slot.rs:69:17 [INFO] [stdout] | [INFO] [stdout] 69 | ::std::mem::replace(self, slot); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 69 | let _ = ::std::mem::replace(self, slot); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/slot.rs:119:17 [INFO] [stdout] | [INFO] [stdout] 116 | pub fn box_slot<'a, 'b: 'a, T: 'a, F: 'a, Tr: Transaction<'b> + 'b>(f: F) -> Slot<'a, 'b, T, Tr> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | Slot::Boxed(Box::new(f)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/event.rs:51:69 [INFO] [stdout] | [INFO] [stdout] 51 | ... .filter_map(|slot| slot.push(value.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/event.rs:70:10 [INFO] [stdout] | [INFO] [stdout] 66 | let ev: Self = Event { listeners: Default::default() }; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | let l = ev.listeners.clone(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | / Rc::new(move |value: T| { [INFO] [stdout] 71 | | let l = l.clone(); [INFO] [stdout] 72 | | Some(Box::new(st({ [INFO] [stdout] 73 | | move |s: &mut Tr| push_process(l, value, s) [INFO] [stdout] 74 | | }))) [INFO] [stdout] 75 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/event.rs:72:18 [INFO] [stdout] | [INFO] [stdout] 67 | let l = ev.listeners.clone(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | Rc::new(move |value: T| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | let l = l.clone(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | Some(Box::new(st({ [INFO] [stdout] | __________________^ [INFO] [stdout] 73 | | move |s: &mut Tr| push_process(l, value, s) [INFO] [stdout] 74 | | }))) [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/event.rs:115:18 [INFO] [stdout] | [INFO] [stdout] 111 | fn listen(&self, f: F) -> Self::Listen [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | let slot = f.into(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | Box::new(self.listeners.modify(move |vd: &mut VecDeque<_>| vd.push_back(slot))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 30 previous errors; 25 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kick` (lib) due to 31 previous errors; 17 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `kick` (lib test) due to 31 previous errors; 25 warnings emitted [INFO] running `Command { std: "docker" "inspect" "497b8f682dad0afd99c06bd0d5987fc45a5c900a7e189afd5960d96e57357080", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "497b8f682dad0afd99c06bd0d5987fc45a5c900a7e189afd5960d96e57357080", kill_on_drop: false }` [INFO] [stdout] 497b8f682dad0afd99c06bd0d5987fc45a5c900a7e189afd5960d96e57357080