[INFO] fetching crate khronos-egl 6.0.0... [INFO] checking khronos-egl-6.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate khronos-egl 6.0.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate khronos-egl 6.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate khronos-egl 6.0.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate khronos-egl 6.0.0 [INFO] tweaked toml for crates.io crate khronos-egl 6.0.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate khronos-egl 6.0.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 43733cacd46c03d307e7c850479e7e0982317fe1632afc36567d53703f018e20 [INFO] running `Command { std: "docker" "start" "-a" "43733cacd46c03d307e7c850479e7e0982317fe1632afc36567d53703f018e20", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "43733cacd46c03d307e7c850479e7e0982317fe1632afc36567d53703f018e20", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "43733cacd46c03d307e7c850479e7e0982317fe1632afc36567d53703f018e20", kill_on_drop: false }` [INFO] [stdout] 43733cacd46c03d307e7c850479e7e0982317fe1632afc36567d53703f018e20 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 37c764bd4327b458655096873132e6ece8066f319476f8f4695a6127faf148c1 [INFO] running `Command { std: "docker" "start" "-a" "37c764bd4327b458655096873132e6ece8066f319476f8f4695a6127faf148c1", kill_on_drop: false }` [INFO] [stderr] Compiling xml-rs v0.8.3 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling libc v0.2.86 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling pkg-config v0.3.19 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling khronos_api v3.1.0 [INFO] [stderr] Compiling nix v0.18.0 [INFO] [stderr] Checking once_cell v1.6.0 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Checking downcast-rs v1.2.0 [INFO] [stderr] Checking scoped-tls v1.0.0 [INFO] [stderr] Checking libloading v0.6.7 [INFO] [stderr] Compiling khronos-egl v6.0.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking dlib v0.4.2 [INFO] [stderr] Compiling wayland-sys v0.28.3 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Compiling wayland-scanner v0.28.3 [INFO] [stderr] Compiling gl v0.14.0 [INFO] [stdout] warning: unexpected `cfg` condition name: `android` [INFO] [stdout] --> src/lib.rs:318:12 [INFO] [stdout] | [INFO] [stdout] 318 | #[cfg(not(android))] [INFO] [stdout] | ^^^^^^^ help: found config with similar value: `target_os = "android"` [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(android)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(android)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `android` [INFO] [stdout] --> src/lib.rs:321:12 [INFO] [stdout] | [INFO] [stdout] 321 | #[cfg(not(android))] [INFO] [stdout] | ^^^^^^^ help: found config with similar value: `target_os = "android"` [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(android)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(android)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `android` [INFO] [stdout] --> src/lib.rs:325:8 [INFO] [stdout] | [INFO] [stdout] 325 | #[cfg(android)] [INFO] [stdout] | ^^^^^^^ help: found config with similar value: `target_os = "android"` [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(android)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(android)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `android` [INFO] [stdout] --> src/lib.rs:329:8 [INFO] [stdout] | [INFO] [stdout] 329 | #[cfg(android)] [INFO] [stdout] | ^^^^^^^ help: found config with similar value: `target_os = "android"` [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(android)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(android)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `android` [INFO] [stdout] --> src/lib.rs:332:8 [INFO] [stdout] | [INFO] [stdout] 332 | #[cfg(android)] [INFO] [stdout] | ^^^^^^^ help: found config with similar value: `target_os = "android"` [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(android)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(android)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `android` [INFO] [stdout] --> src/lib.rs:335:8 [INFO] [stdout] | [INFO] [stdout] 335 | #[cfg(android)] [INFO] [stdout] | ^^^^^^^ help: found config with similar value: `target_os = "android"` [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(android)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(android)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:177:9 [INFO] [stdout] | [INFO] [stdout] 175 | pub fn cast_into>(self) -> Instance { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | Instance { [INFO] [stdout] 177 | api: self.api.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:184:9 [INFO] [stdout] | [INFO] [stdout] 183 | pub fn try_cast_into>(self) -> Result, Instance> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | match self.api.try_into() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function pointers are not nullable, so checking them for null will always return false [INFO] [stdout] --> src/lib.rs:1044:9 [INFO] [stdout] | [INFO] [stdout] 1044 | if !(addr as *const ()).is_null() { [INFO] [stdout] | ^----^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | expression has type `extern "system" fn()` [INFO] [stdout] | [INFO] [stdout] = help: wrap the function pointer inside an `Option` and use `Option::is_none` to check for null pointer value [INFO] [stdout] = note: `#[warn(useless_ptr_null_checks)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `khronos-egl` (lib) due to 3 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "37c764bd4327b458655096873132e6ece8066f319476f8f4695a6127faf148c1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "37c764bd4327b458655096873132e6ece8066f319476f8f4695a6127faf148c1", kill_on_drop: false }` [INFO] [stdout] 37c764bd4327b458655096873132e6ece8066f319476f8f4695a6127faf148c1